@hopla/claude-setup 1.4.4 → 1.4.5

package/cli.js

@@ -72,17 +72,38 @@ function removeFile(dest, label) {
 async function uninstall() {
     log(`\n${BOLD}@hopla/claude-setup${RESET} — Uninstall\n`);
 
-    const commandFiles = fs.readdirSync(path.join(FILES_DIR, "commands"));
-    const filesToRemove = [
-        { dest: path.join(CLAUDE_DIR, "CLAUDE.md"), label: "~/.claude/CLAUDE.md" },
-        ...commandFiles.map((file) => ({
+    const srcEntries = fs.readdirSync(path.join(FILES_DIR, "commands"));
+    const srcFiles = srcEntries.filter((f) =>
+        fs.statSync(path.join(FILES_DIR, "commands", f)).isFile()
+    );
+    const srcDirs = srcEntries.filter((f) =>
+        fs.statSync(path.join(FILES_DIR, "commands", f)).isDirectory()
+    );
+
+    const itemsToRemove = [
+        { dest: path.join(CLAUDE_DIR, "CLAUDE.md"), label: "~/.claude/CLAUDE.md", isDir: false },
+        ...srcFiles.map((file) => ({
             dest: path.join(COMMANDS_DIR, file),
             label: `~/.claude/commands/${file}`,
+            isDir: false,
+        })),
+        ...srcDirs.map((dir) => ({
+            dest: path.join(COMMANDS_DIR, dir),
+            label: `~/.claude/commands/${dir}/`,
+            isDir: true,
         })),
     ];
 
-    log(`The following files will be removed:`);
-    for (const { label } of filesToRemove) {
+    // Also remove skills and hooks installed by hopla
+    if (fs.existsSync(SKILLS_DIR)) {
+        itemsToRemove.push({ dest: SKILLS_DIR, label: "~/.claude/skills/", isDir: true });
+    }
+    if (fs.existsSync(HOOKS_DIR)) {
+        itemsToRemove.push({ dest: HOOKS_DIR, label: "~/.claude/hooks/", isDir: true });
+    }
+
+    log(`The following will be removed:`);
+    for (const { label } of itemsToRemove) {
         log(`  ${RED}✕${RESET}  ${label}`);
     }
 
@@ -93,40 +114,34 @@ async function uninstall() {
     }
 
     log("");
-    for (const { dest, label } of filesToRemove) {
-        removeFile(dest, label);
+    for (const { dest, label, isDir } of itemsToRemove) {
+        if (fs.existsSync(dest)) {
+            fs.rmSync(dest, { recursive: isDir });
+            log(`  ${RED}✕${RESET}  Removed: ${label}`);
+        } else {
+            log(`  ${YELLOW}↷${RESET}  Not found: ${label}`);
+        }
     }
 
     log(`\n${GREEN}${BOLD}Done!${RESET} Files removed.\n`);
 }
 
-const LEGACY_FILES = [
-    "code-review-fix.md",
-    "code-review.md",
-    "commit.md",
-    "create-prd.md",
-    "execute.md",
-    "execution-report.md",
-    "plan-feature.md",
-    "prime.md",
-    "system-review.md",
-    "hopla-lang.md",
-    "hopla-commit.md",
-];
-
-function removeLegacyFiles() {
+function removeStaleCommands(currentCommandFiles) {
+    if (!fs.existsSync(COMMANDS_DIR)) return;
+    const currentSet = new Set(currentCommandFiles);
     const removed = [];
-    for (const file of LEGACY_FILES) {
-        const dest = path.join(COMMANDS_DIR, file);
-        if (fs.existsSync(dest)) {
-            fs.rmSync(dest);
+    for (const file of fs.readdirSync(COMMANDS_DIR)) {
+        const filePath = path.join(COMMANDS_DIR, file);
+        if (!fs.statSync(filePath).isFile()) continue;
+        if (file.startsWith("hopla-") && !currentSet.has(file)) {
+            fs.rmSync(filePath);
             removed.push(file);
         }
     }
     if (removed.length > 0) {
-        log(`${CYAN}Cleaning up legacy commands...${RESET}`);
+        log(`${CYAN}Removing stale commands from previous versions...${RESET}`);
         for (const file of removed) {
-            log(`  ${YELLOW}↷${RESET}  Removed legacy: ~/.claude/commands/${file}`);
+            log(`  ${YELLOW}↷${RESET}  Removed: ~/.claude/commands/${file}`);
         }
         log("");
     }
@@ -142,25 +157,6 @@ const PLANNING_COMMANDS = [
     "hopla-git-pr.md",
 ];
 
-function removeExecutionCommands() {
-    const planningSet = new Set(PLANNING_COMMANDS);
-    const removed = [];
-    if (!fs.existsSync(COMMANDS_DIR)) return;
-    for (const file of fs.readdirSync(COMMANDS_DIR)) {
-        if (file.startsWith("hopla-") && !planningSet.has(file)) {
-            fs.rmSync(path.join(COMMANDS_DIR, file));
-            removed.push(file);
-        }
-    }
-    if (removed.length > 0) {
-        log(`${CYAN}Removing execution commands (planning mode)...${RESET}`);
-        for (const file of removed) {
-            log(`  ${RED}✕${RESET}  Removed: ~/.claude/commands/${file}`);
-        }
-        log("");
-    }
-}
-
 async function install() {
     const modeLabel = PLANNING ? "Planning Mode (Robert)" : "Full Install";
     log(`\n${BOLD}@hopla/claude-setup${RESET} — Agentic Coding System ${CYAN}[${modeLabel}]${RESET}\n`);
@@ -169,20 +165,7 @@ async function install() {
     fs.mkdirSync(CLAUDE_DIR, { recursive: true });
     fs.mkdirSync(COMMANDS_DIR, { recursive: true });
 
-    // Remove old non-prefixed commands from previous versions
-    removeLegacyFiles();
-
-    // In planning mode, remove any execution commands left from a previous full install
-    if (PLANNING) removeExecutionCommands();
-
-    log(`${CYAN}Installing global rules...${RESET}`);
-    await installFile(
-        path.join(FILES_DIR, "CLAUDE.md"),
-        path.join(CLAUDE_DIR, "CLAUDE.md"),
-        "~/.claude/CLAUDE.md"
-    );
-
-    log(`\n${CYAN}Installing commands...${RESET}`);
+    // Determine which command files will be installed
     const allCommandEntries = fs.readdirSync(path.join(FILES_DIR, "commands"));
     const allCommandFiles = allCommandEntries.filter((f) => {
         const stat = fs.statSync(path.join(FILES_DIR, "commands", f));
@@ -195,6 +178,18 @@ async function install() {
     const commandFiles = PLANNING
         ? allCommandFiles.filter((f) => PLANNING_COMMANDS.includes(f))
         : allCommandFiles;
+
+    // Remove stale hopla-* commands not in the current version
+    removeStaleCommands(commandFiles);
+
+    log(`${CYAN}Installing global rules...${RESET}`);
+    await installFile(
+        path.join(FILES_DIR, "CLAUDE.md"),
+        path.join(CLAUDE_DIR, "CLAUDE.md"),
+        "~/.claude/CLAUDE.md"
+    );
+
+    log(`\n${CYAN}Installing commands...${RESET}`);
     for (const file of commandFiles.sort()) {
         await installFile(
             path.join(FILES_DIR, "commands", file),

package/files/commands/hopla-prime.md

@@ -53,6 +53,6 @@ Pending plans:
 - add-user-authentication.md ← ready to execute with /hopla-execute
 ```
 
-End with a sentence like: "Listo para continuar — ¿por dónde empezamos?" or "All caught up — what are we working on today?" depending on the language the user writes in.
+End with a sentence like: "All caught up — what are we working on today?" (adapt to the user's language).
 
 Do NOT use headers in the prose summary. Write it as natural, friendly prose, then the pending plans list if applicable.

package/files/commands/hopla-review-plan.md

@@ -41,9 +41,8 @@ Do NOT reproduce the full plan. Instead, present a structured summary in the use
 
 ## Step 3: Ask for Approval
 
-After the summary, ask:
-> "¿Todo claro? Puedes aprobar para ejecutar, pedir cambios, o hacer preguntas sobre alguna tarea."
-> (or in English if the conversation is in English)
+After the summary, ask (in the user's language):
+> "All clear? You can approve to execute, request changes, or ask questions about any task."
 
 **Review loop:**
 - If the user has questions → answer them based on the plan content

package/files/commands/hopla-system-review.md

@@ -10,6 +10,22 @@ Perform a meta-level analysis of how well the implementation followed the plan.
 - **$1** — Path to the structured plan file
 - **$2** — Path to the execution report file
 
+## Step 0: Check for Existing Review
+
+Before doing anything else, check if a system review already exists for this plan:
+
+```bash
+ls .agents/system-reviews/
+```
+
+Look for a file that matches the feature name derived from **$1** (the plan filename). If a matching review exists:
+- Skip Steps 1–6
+- Go directly to **Step 7** to archive the plan
+
+If no matching review exists, continue with Step 1.
+
+---
+
 ## Step 1: Load All Context
 
 Read these four artifacts in order:
@@ -137,3 +153,15 @@ After the analysis, use this to prioritize actions:
 | Same manual step done 3+ times | Create a new command |
 | Plan was ambiguous in the same spot twice | Update plan-feature command |
 | First time seeing this issue | Note it, don't over-engineer yet |
+
+## Step 7: Archive the Plan
+
+Move the completed plan to the archive folder:
+
+```bash
+mkdir -p .agents/plans/done
+mv "$1" .agents/plans/done/
+```
+
+Then notify the user:
+> "✅ System review saved to `.agents/system-reviews/[feature]-review.md`. Plan archived to `.agents/plans/done/[plan-name].md` — the active plans folder is now clean."

package/files/skills/hopla-code-review/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: hopla-code-review
-description: Performs a technical code review on recently changed files. Use when the user says "review the code", "revisar el código", "code review", "analiza los cambios", "check my code", "revisa mi código", "look for issues", or asks for feedback on their implementation.
+description: Performs a technical code review on recently changed files. Use when the user says "review the code", "code review", "check my code", "look for issues", or asks for feedback on their implementation.
 ---
 
 Perform a technical code review focused on finding real bugs and issues.

package/files/skills/hopla-git/SKILL.md

@@ -7,13 +7,13 @@ Detect the user's intent and execute the appropriate git workflow.
 
 ## Intent Detection
 
-**If the user wants to commit** (keywords: "commit", "comitea", "guarda los cambios", "save changes", "crear commit", "hacer commit"):
+**If the user wants to commit** (keywords: "commit", "save changes", "create commit"):
 - Read and follow the instructions in `commit.md` (located in the same directory as this skill)
 
-**If the user wants to create a PR or push** (keywords: "PR", "pull request", "crea un PR", "abre un PR", "push", "merge request"):
+**If the user wants to create a PR or push** (keywords: "PR", "pull request", "push", "merge request"):
 - Read and follow the instructions in `pr.md` (located in the same directory as this skill)
 
-**If unclear**, ask the user one short question: "¿Commit o Pull Request?" / "Commit or Pull Request?"
+**If unclear**, ask the user one short question: "Commit or Pull Request?"
 
 ## File References
 

package/files/skills/hopla-prime/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: hopla-prime
-description: Orients Claude in a project at the start of a session. Use when the user says "orient yourself", "get oriented", "prime yourself", "ponte al día", "qué es este proyecto", "what is this project", "load context", or asks Claude to familiarize itself with the codebase before starting work.
+description: Orients Claude in a project at the start of a session. Use when the user says "orient yourself", "get oriented", "prime yourself", "what is this project", "load context", or asks Claude to familiarize itself with the codebase before starting work.
 ---
 
 Get oriented in this project before doing any work.
@@ -54,6 +54,6 @@ Pending plans:
 - add-user-authentication.md ← ready to execute with /hopla-execute
 ```
 
-End with a sentence like: "Listo para continuar — ¿por dónde empezamos?" or "All caught up — what are we working on today?" depending on the language the user writes in.
+End with a sentence like: "All caught up — what are we working on today?" (adapt to the user's language).
 
 Do NOT use headers in the prose summary. Write it as natural, friendly prose, then the pending plans list if applicable.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hopla/claude-setup",
-  "version": "1.4.4",
+  "version": "1.4.5",
   "description": "Hopla team agentic coding system for Claude Code",
   "type": "module",
   "bin": {