@hoox-sh/pynets 0.2.0 → 0.3.0

package/src/runtime/compile/emit_call.ts

@@ -13,6 +13,18 @@ const LOW = "low_arr[__bar_idx]";
 const CLOSE = "close_arr[__bar_idx]";
 const VOL = "vol_arr[__bar_idx]";
 const OPEN = "open_arr[__bar_idx]";
+// Interpret's bare `ta.vwap` sources hlc3 = (h+l+c)/3, falling back to close
+// when any component is na — mirror that exactly on the compile side.
+const HLC3 =
+  "((high_arr[__bar_idx] != null && low_arr[__bar_idx] != null && close_arr[__bar_idx] != null)" +
+  " ? (high_arr[__bar_idx] + low_arr[__bar_idx] + close_arr[__bar_idx]) / 3" +
+  " : close_arr[__bar_idx])";
+// Interpret `hlc3(env)` for the ta.cci period-only form: falls back through
+// close → high → low when any component is na (interpret.ts hlc3).
+const TP =
+  "((high_arr[__bar_idx] != null && low_arr[__bar_idx] != null && close_arr[__bar_idx] != null)" +
+  " ? (high_arr[__bar_idx] + low_arr[__bar_idx] + close_arr[__bar_idx]) / 3" +
+  " : (close_arr[__bar_idx] ?? high_arr[__bar_idx] ?? low_arr[__bar_idx]))";
 
 const NS = new Set([
   "ta",
@@ -87,13 +99,19 @@ const TA_METHODS = new Set([
   "cum",
   "range",
   "accdist",
+  "ad",
   "pvt",
+  "vpt",
   "wad",
   "nvi",
   "pvi",
   "wvad",
+  "cmf",
+  "klinger",
   "iii",
   "obv",
+  "ao",
+  "aroon",
   "highestbars",
   "lowestbars",
   "dev",
@@ -106,6 +124,40 @@ const TA_METHODS = new Set([
   "bbw",
   "max",
   "min",
+  "uo",
+  "rci",
+  "dpo",
+  "kst",
+  "stochrsi",
+  "donchian",
+  "ichimoku",
+  "bb_pct",
+  "emv",
+  "fractal",
+  "atr_stop",
+  "zigzag",
+]);
+
+/**
+ * Bare `ta.<attr>` auto-call whitelist. Mirrors interpret's evalTaAttr
+ * (interpret.ts) exactly: only these attributes auto-invoke a zero-arg TA
+ * kernel on a bare attribute load; anything else is na on both backends.
+ * `aroon` is deliberately absent — interpret's evalTaAttr does not handle it.
+ */
+export const TA_BARE_ATTRS = new Set([
+  "accdist",
+  "ad",
+  "obv",
+  "tr",
+  "vwap",
+  "pvt",
+  "vpt",
+  "nvi",
+  "pvi",
+  "wad",
+  "wvad",
+  "cmf",
+  "ao",
 ]);
 
 const SRC_LEN = new Set([
@@ -120,8 +172,6 @@ const SRC_LEN = new Set([
   "sum",
   "dema",
   "tema",
-  "highestbars",
-  "lowestbars",
   "dev",
   "variance",
   "median",
@@ -141,6 +191,8 @@ const PLOT_FUNCS = new Set([
   "hline",
   "bgcolor",
   "barcolor",
+  "plotcandle",
+  "plotbar",
 ]);
 
 const STRATEGY_ACTIONS = new Set([
@@ -160,6 +212,10 @@ const STRATEGY_QUERIES = new Set([
   "strategy_openprofit",
   "strategy_opentrades",
   "strategy_closedtrades",
+  "strategy_leverage",
+  "strategy_margin_liquidation_price",
+  "strategy_position_avg_price",
+  "strategy_initial_capital",
 ]);
 
 const CHART_SERIES_ARR: Record<string, string> = {
@@ -232,7 +288,7 @@ export function emitCall(ctx: EmitCtx, node: Call, visit: VisitFn): string {
   if (PLOT_FUNCS.has(name)) return emitPlot(ctx, name, args);
 
   if (name === "indicator" || name === "study" || name === "library") return "null";
-  if (name === "strategy") return "null";
+  if (name === "strategy") return emitStrategyDecl(ctx, args);
 
   if (name === "na") {
     if (args.pos.length === 0 && args.kw.x == null && args.kw.source == null) return "null";
@@ -275,6 +331,19 @@ export function emitCall(ctx: EmitCtx, node: Call, visit: VisitFn): string {
     }
     return "86400";
   }
+  if (name === "timeframe_change") {
+    // Prev bar time is `time_arr[__bar_idx-1]`; bar 0 has no prev (interpret series.get(1)).
+    return `__h.timeframeChange(${pick(args, 0, ["timeframe", "tf"], "null")}, time, (__bar_idx > 0 ? time_arr[__bar_idx - 1] : null), __bar_idx)`;
+  }
+  if (name === "time_close") {
+    return `__h.timeClose(__bar_idx, time_arr)`;
+  }
+  if (name === "syminfo_prefix") {
+    if (hasArg(args, 0, ["tickerid", "symbol"])) {
+      return `__h.syminfoPrefix(${pick(args, 0, ["tickerid", "symbol"], "null")})`;
+    }
+    return `__h.syminfoPrefix()`;
+  }
   if (name === "ticker_heikinashi" || name === "heikinashi") {
     ctx.needsHeikinashi = true;
     return `"__HEIKINASHI__"`;
@@ -432,6 +501,30 @@ function hasArg(args: CallArgs, index: number, names: string[]): boolean {
   return index >= 0 && index < args.pos.length;
 }
 
+/** True when a keyword argument named one of *names* is present (interpret hasKwarg). */
+function hasAnyKw(args: CallArgs, names: string[]): boolean {
+  return names.some((n) => Object.hasOwn(args.kw, n));
+}
+
+/**
+ * Runtime-safe `_is_period_like` gate (interpret `periodLikeCell`): only whole
+ * numbers pass and are returned as-is; everything else (na, fractional,
+ * series samples) collapses to *fb* — mirroring `periodLikeArg(...) ?? fb`.
+ * Constant args could be decided at emit time, but the runtime form is
+ * equally exact and keeps one code path for constants and series alike.
+ */
+function periodGate(expr: string, fb: string): string {
+  return `((__p) => (Number.isInteger(__p) ? __p : ${fb}))(${expr})`;
+}
+
+/**
+ * Interpret `lenArg` / `lenOrDefault` analog: a null (na) or non-finite slot
+ * collapses to *fb* instead of reaching the kernel raw.
+ */
+function finiteOr(expr: string, fb: string): string {
+  return `((__v) => (__v != null && Number.isFinite(__v) ? __v : ${fb}))(${expr})`;
+}
+
 const DRAW_KINDS = new Set(["label", "line", "box", "table", "polyline", "linefill"]);
 
 const ARRAY_SIGS: Record<string, string[][]> = {
@@ -452,7 +545,7 @@ const ARRAY_SIGS: Record<string, string[][]> = {
   fill: [["id"], ["value"]],
   copy: [["id"]],
   reverse: [["id"]],
-  sort: [["id"], ["order"]],
+  sort: [["id"], ["order"], ["sort_field"]],
   concat: [["id"], ["other", "id2"]],
   slice: [["id"], ["index_from", "from"], ["index_to", "to"]],
   indexof: [["id"], ["value"]],
@@ -476,10 +569,10 @@ const ARRAY_SIGS: Record<string, string[][]> = {
   percentile_linear_interpolation: [["id"], ["percentage", "percent"]],
   percentile_nearest: [["id"], ["percentage", "percent"]],
   percentile_nearest_rank: [["id"], ["percentage", "percent"]],
-  binary_search: [["id"], ["value"]],
-  binary_search_leftmost: [["id"], ["value"]],
-  binary_search_rightmost: [["id"], ["value"]],
-  sort_indices: [["id"], ["order"]],
+  binary_search: [["id"], ["value"], ["sort_field"]],
+  binary_search_leftmost: [["id"], ["value"], ["sort_field"]],
+  binary_search_rightmost: [["id"], ["value"], ["sort_field"]],
+  sort_indices: [["id"], ["order"], ["sort_field"]],
   covariance: [["id"], ["id2", "other"], ["biased"]],
 };
 
@@ -541,7 +634,8 @@ const MATRIX_SIGS: Record<string, string[][]> = {
   concat: [["id"], ["other"]],
   reshape: [["id"], ["rows"], ["columns", "cols"]],
   reverse: [["id"]],
-  sort: [["id"], ["column", "col"], ["order"]],
+  sort: [["id"], ["column", "col"], ["order"], ["sort_field"]],
+  sort_indices: [["id"], ["column", "col"], ["order"], ["sort_field"]],
   eigenvalues: [["id"]],
   eigenvectors: [["id"]],
   pow: [["id"], ["power", "n"]],
@@ -554,6 +648,26 @@ const MATRIX_SIGS: Record<string, string[][]> = {
   remove_col: [["id"], ["column", "index"]],
   remove_column: [["id"], ["column", "index"]],
   submatrix: [["id"], ["from_row"], ["to_row"], ["from_column", "from_col"], ["to_column", "to_col"]],
+  sum_row: [["id"], ["row", "index"]],
+  avg_row: [["id"], ["row", "index"]],
+  min_row: [["id"], ["row", "index"]],
+  max_row: [["id"], ["row", "index"]],
+  mode_row: [["id"], ["row", "index"]],
+  sum_col: [["id"], ["column", "col", "index"]],
+  avg_col: [["id"], ["column", "col", "index"]],
+  min_col: [["id"], ["column", "col", "index"]],
+  max_col: [["id"], ["column", "col", "index"]],
+  mode_col: [["id"], ["column", "col", "index"]],
+  copy_row: [["id"], ["row", "index"]],
+  copy_col: [["id"], ["column", "col", "index"]],
+  fill_row: [["id"], ["row", "index"], ["value"]],
+  fill_col: [["id"], ["column", "col", "index"], ["value"]],
+  fill_diagonal: [["id"], ["value"]],
+  reverse_rows: [["id"]],
+  reverse_cols: [["id"]],
+  stdev: [["id"]],
+  variance: [["id"]],
+  mode_all: [["id"]],
 };
 
 function nsMethod(name: string, prefix: string): string | null {
@@ -562,6 +676,8 @@ function nsMethod(name: string, prefix: string): string | null {
 }
 
 function ctorMethod(method: string): string {
+  // Every Python `array.new*` spelling (newint, new_float, new_chart.point, …)
+  // lowers to the same PineArray constructor as `array.new`.
   return method === "from" || method.startsWith("new") ? "new" : method;
 }
 
@@ -891,6 +1007,26 @@ function isStrategyAction(name: string, method: string): boolean {
   );
 }
 
+/** `strategy(...)` declaration — kwargs only, matching interpret `applyStrategyDecl`. */
+function emitStrategyDecl(ctx: EmitCtx, args: CallArgs): string {
+  ctx.usesStrategy = true;
+  const fields: string[] = [];
+  const add = (names: string[], key: string): void => {
+    if (hasArg(args, -1, names)) fields.push(`${key}: ${pick(args, -1, names, "null")}`);
+  };
+  add(["commission", "commission_value"], "commission");
+  add(["slippage"], "slippage");
+  add(["pyramiding"], "pyramiding");
+  add(["avg_price_model"], "avg_price_model");
+  add(["leverage"], "leverage");
+  add(["margin_long"], "margin_long");
+  add(["margin_short"], "margin_short");
+  add(["default_qty_type"], "default_qty_type");
+  add(["default_qty_value"], "default_qty_value");
+  add(["initial_capital"], "initial_capital");
+  return `__h.strategy.configure({${fields.join(", ")}})`;
+}
+
 function emitStrategyEntry(method: "entry" | "order", args: CallArgs): string {
   const id = pick(args, 0, ["id"], "null");
   const direction = pick(args, 1, ["direction"], "null");
@@ -926,10 +1062,22 @@ function emitStrategy(ctx: EmitCtx, name: string, args: CallArgs): string {
       return "__h.strategy.close_all()";
     case "exit": {
       ctx.usesStrategy = true;
-      const fromEntry = pick(args, 1, ["from_entry"], "null");
-      return hasArg(args, 2, ["qty"])
-        ? `__h.strategy.exit(${fromEntry}, ${pick(args, 2, ["qty"], "null")})`
-        : `__h.strategy.exit(${fromEntry})`;
+      const id = pick(args, 0, ["id"], "null");
+      const fields: string[] = [];
+      const add = (index: number, names: string[], key: string): void => {
+        if (hasArg(args, index, names)) fields.push(`${key}: ${pick(args, index, names, "null")}`);
+      };
+      add(1, ["from_entry"], "from_entry");
+      add(2, ["qty"], "qty");
+      add(3, ["qty_percent"], "qty_percent");
+      add(4, ["profit"], "profit");
+      add(5, ["limit"], "limit");
+      add(6, ["loss"], "loss");
+      add(7, ["stop"], "stop");
+      add(8, ["trail_price"], "trail_price");
+      add(9, ["trail_points"], "trail_points");
+      add(10, ["trail_offset"], "trail_offset");
+      return `__h.strategy.exit(${id}, {${fields.join(", ")}})`;
     }
     case "cancel":
       ctx.usesStrategy = true;
@@ -943,6 +1091,10 @@ function emitStrategy(ctx: EmitCtx, name: string, args: CallArgs): string {
     case "openprofit":
     case "opentrades":
     case "closedtrades":
+    case "leverage":
+    case "margin_liquidation_price":
+    case "position_avg_price":
+    case "initial_capital":
       ctx.usesStrategy = true;
       return `__h.strategy.${method}()`;
     case "risk_allow_entry_in":
@@ -992,7 +1144,7 @@ function packUserFuncArgs(ctx: EmitCtx, name: string, args: CallArgs): string[]
   return packed;
 }
 
-function emitPlot(ctx: EmitCtx, _fname: string, args: CallArgs): string {
+function emitPlot(ctx: EmitCtx, fname: string, args: CallArgs): string {
   let title: string | null = constString(args.kwNodes.title);
   if (title == null) {
     for (const n of args.posNodes) {
@@ -1003,8 +1155,16 @@ function emitPlot(ctx: EmitCtx, _fname: string, args: CallArgs): string {
       }
     }
   }
-  if (title == null || title === "") title = `plot_${ctx.plots.length}`;
-  const series = pick(args, 0, ["series", "source", "price"], "null");
+  if (title == null || title === "") {
+    if (fname === "plotcandle") title = "candles";
+    else if (fname === "plotbar") title = "bars";
+    else title = `plot_${ctx.plots.length}`;
+  }
+  // Python primary column for plotcandle/plotbar is close (arg 3), not open.
+  const ohlc = fname === "plotcandle" || fname === "plotbar";
+  const series = ohlc
+    ? pick(args, 3, ["close"], "null")
+    : pick(args, 0, ["series", "source", "price"], "null");
   const i = ctx.plots.length;
   ctx.plots.push({ title });
   return `plot_${i}[__bar_idx] = __h.naNum(${series})`;
@@ -1084,9 +1244,13 @@ function emitMath(name: string, args: CallArgs): string | null {
     name === "todegrees" ||
     name === "toradians" ||
     name === "iff" ||
-    name === "fixnan";
+    name === "fixnan" ||
+    name === "round_to_mintick";
   if (!isNs && !isBareMath) return null;
 
+  if (bare === "round_to_mintick") {
+    return `__h.roundToMintick(${pick(args, 0, ["number", "x"], "null")})`;
+  }
   if (bare === "iff") {
     const cond = pick(args, 0, ["condition", "cond"], "null");
     const a = pick(args, 1, ["then", "if_true"], "null");
@@ -1176,6 +1340,7 @@ function taCall(method: string, site: string, parts: string[]): string {
 
 function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
   if (!TA_METHODS.has(method)) return "null";
+  if (method === "ad") method = "accdist";
   const site = allocSite(ctx);
   const src = () => pick(args, 0, ["source", "series", "src"], CLOSE);
   const len = (index: number, fb: string, names: string[] = ["length", "len", "period"]) =>
@@ -1187,8 +1352,27 @@ function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
   if (SRC_LEN1.has(method)) {
     return taCall(method, site, [src(), len(1, "1")]);
   }
-  if (method === "highest" || method === "lowest" || method === "max" || method === "min") {
-    const defSrc = method === "lowest" || method === "min" ? LOW : HIGH;
+  if (method === "highest" || method === "lowest") {
+    const defSrc = method === "lowest" ? LOW : HIGH;
+    if (args.pos.length <= 1 && !hasAnyKw(args, ["source", "series"])) {
+      // Python 1-arg period-only form (basic.py:222-246): source defaults to
+      // the context high/low series and the length gates on _is_period_like
+      // → non-period-like → na period 0 (interpret evalExtraTa).
+      return taCall(method, site, [defSrc, periodGate(pick(args, 0, ["length"], "null"), "0")]);
+    }
+    return taCall(method, site, [src(), finiteOr(pick(args, 1, ["length"], "null"), "0")]);
+  }
+  if (method === "highestbars" || method === "lowestbars") {
+    const defSrc = method === "lowestbars" ? LOW : HIGH;
+    if (args.pos.length <= 1 && !hasAnyKw(args, ["source", "series"])) {
+      // Python 1-arg period-only form (basic.py:248-291): context high/low
+      // source, length gated like ta.highest (interpret evalExtraTa).
+      return taCall(method, site, [defSrc, periodGate(pick(args, 0, ["length"], "null"), "0")]);
+    }
+    return taCall(method, site, [src(), finiteOr(pick(args, 1, ["length"], "null"), "0")]);
+  }
+  if (method === "max" || method === "min") {
+    const defSrc = method === "min" ? LOW : HIGH;
     if (args.pos.length >= 2 || Object.hasOwn(args.kw, "source") || Object.hasOwn(args.kw, "series")) {
       return taCall(method, site, [src(), len(1, "14")]);
     }
@@ -1224,10 +1408,24 @@ function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
     return `(() => { const __r = ${call}; return [__r.macd, __r.signal, __r.hist]; })()`;
   }
   if (method === "bb") {
+    if (args.pos.length === 2 && !hasAnyKw(args, ["source", "series"])) {
+      // Python period-first form (basic.py:394-401): (length, mult) with the
+      // series defaulting to the context close. Dispatch gates slot 0 on
+      // _is_period_like per bar (kwarg-first resolution, like interpret
+      // callArg) — a non-period-like slot falls through to the series arm on
+      // the raw slot-0 value, exactly like interpret.
+      const p0Expr = pick(args, 0, ["source", "series", "length"], "null");
+      const multPf = finiteOr(pick(args, 1, ["mult", "multiplier"], "null"), "NaN");
+      const lenFt = finiteOr(pick(args, 1, ["length"], "null"), "0");
+      const multFt = finiteOr(pick(args, 2, ["mult", "multiplier"], "null"), "2");
+      const pf = `(() => { const __r = __h.ta.bb(${site}, close_arr[__bar_idx], __p0, ${multPf}); return [__r.mid, __r.up, __r.lo]; })()`;
+      const ft = `(() => { const __r = __h.ta.bb(${site}, __s0, ${lenFt}, ${multFt}); return [__r.mid, __r.up, __r.lo]; })()`;
+      return `((__p0, __s0) => (Number.isInteger(__p0) ? ${pf} : ${ft}))(${p0Expr}, ${pick(args, 0, ["source", "series"], "null")})`;
+    }
     const call = taCall("bb", site, [
       src(),
-      len(1, "20"),
-      pick(args, 2, ["mult", "multiplier"], "2"),
+      finiteOr(pick(args, 1, ["length"], "null"), "0"),
+      finiteOr(pick(args, 2, ["mult", "multiplier"], "null"), "2"),
     ]);
     return `(() => { const __r = ${call}; return [__r.mid, __r.up, __r.lo]; })()`;
   }
@@ -1245,21 +1443,52 @@ function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
     return `(() => { const __r = ${call}; return [__r.mid, __r.up, __r.lo]; })()`;
   }
   if (method === "stoch") {
-    if (args.pos.length <= 1 && args.kw.high == null) {
-      return taCall("stoch", site, [CLOSE, HIGH, LOW, len(0, "14")]);
+    if (args.kw.high == null && args.pos.length <= 2) {
+      // Python period-only / community forms (oscillators.py:58-78): %K over
+      // the context close/high/low. Both slots gate on _is_period_like; in
+      // the 2-arg (kLength, dPeriod) form dPeriod is ignored (Python quirk).
+      const length =
+        args.pos.length === 2
+          ? `(((__k, __d) => ((Number.isInteger(__k) && Number.isInteger(__d)) ? __k : 0))(${pick(args, 0, ["length"], "null")}, ${pick(args, 1, ["d", "smooth"], "null")}))`
+          : periodGate(pick(args, 0, ["length"], "null"), "0");
+      return taCall("stoch", site, [CLOSE, HIGH, LOW, length]);
     }
     return taCall("stoch", site, [
       src(),
       pick(args, 1, ["high"], HIGH),
       pick(args, 2, ["low"], LOW),
-      len(3, "14"),
+      finiteOr(pick(args, 3, ["length"], "null"), "0"),
     ]);
   }
   if (method === "vwma") {
-    return taCall("vwma", site, [src(), pick(args, 2, ["volume"], VOL), len(1, "14")]);
+    if (args.pos.length <= 1 && !hasAnyKw(args, ["volume"])) {
+      // Python 1-arg period-only form (basic.py:80-88): close + volume from
+      // the chart context; length gates on _is_period_like → na period 0.
+      return taCall("vwma", site, [CLOSE, VOL, periodGate(pick(args, 0, ["length"], "null"), "0")]);
+    }
+    if (args.pos.length >= 3 || hasAnyKw(args, ["volume"])) {
+      // Python 3-arg community form (basic.py:89-100): (source, volume,
+      // length). A period-like middle slot swaps volume back to the context
+      // series (basic.py:93/97) — mirror interpret's per-bar swap.
+      const vol = `((__v) => (Number.isInteger(__v) ? ${VOL} : __v))(${pick(args, 1, ["volume"], "null")})`;
+      return taCall("vwma", site, [src(), vol, finiteOr(pick(args, 2, ["length", "period"], "null"), "0")]);
+    }
+    return taCall("vwma", site, [src(), VOL, finiteOr(pick(args, 1, ["length"], "null"), "0")]);
   }
   if (method === "cci") {
-    return taCall("cci", site, [src(), len(1, "14")]);
+    if (args.pos.length >= 4) {
+      // Python legacy 4-arg form (oscillators.py:178-187): typical price of
+      // the given (high, low, close) series. Slots resolve kwarg-first.
+      const tp = `((__h, __l, __c) => ((__h != null && __l != null && __c != null) ? (__h + __l + __c) / 3 : __c))(${pick(args, 0, ["high"], "null")}, ${pick(args, 1, ["low"], "null")}, ${pick(args, 2, ["close"], "null")})`;
+      return taCall("cci", site, [tp, finiteOr(pick(args, 3, ["length"], "null"), "0")]);
+    }
+    if (args.pos.length <= 1 && !hasAnyKw(args, ["source", "series"])) {
+      // Python 1-arg period-only form (oscillators.py:159-171): typical price
+      // from the context high/low/close; length gates on _is_period_like.
+      return taCall("cci", site, [TP, periodGate(pick(args, 0, ["length"], "null"), "0")]);
+    }
+    // Python 2-arg form (oscillators.py:172-177): CCI over the source alone.
+    return taCall("cci", site, [src(), finiteOr(pick(args, 1, ["length"], "null"), "0")]);
   }
   if (method === "mfi") {
     if (args.pos.length <= 1) {
@@ -1336,10 +1565,27 @@ function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
     ]);
   }
   if (method === "pivothigh" || method === "pivotlow") {
+    if (args.pos.length === 2 && !hasAnyKw(args, ["source", "series"])) {
+      // Python period-first form (basic.py:1007-1039): both slots gate on
+      // _is_period_like and the source defaults to the context high/low
+      // series. A non-period-like slot falls through to the series arm on
+      // the raw slot values (never confirms on a scalar) — mirror interpret.
+      // Slots resolve kwarg-first (leftbars/rightbars), like interpret callArg.
+      const defSrc = method === "pivotlow" ? LOW : HIGH;
+      const lExpr = pick(args, 0, ["leftbars", "left"], "null");
+      const rExpr = pick(args, 1, ["rightbars", "right"], "null");
+      const leftFt = finiteOr(pick(args, 1, ["leftbars", "left"], "null"), "5");
+      const rightFt = finiteOr(pick(args, 2, ["rightbars", "right"], "null"), "5");
+      const pf = taCall(method, site, [defSrc, "__l", "__r"]);
+      const ft = taCall(method, site, ["__s", leftFt, rightFt]);
+      return `((__l, __r, __s) => (((Number.isInteger(__l) && Number.isInteger(__r))) ? ${pf} : ${ft}))(${lExpr}, ${rExpr}, ${pick(args, 0, ["source", "series"], "null")})`;
+    }
+    // Interpret srcArg: source slot names ["source", "series"], missing → na
+    // (a bare ta.pivothigh() never confirms, like interpret).
     return taCall(method, site, [
-      src(),
-      pick(args, 1, ["leftbars", "left"], "5"),
-      pick(args, 2, ["rightbars", "right"], "5"),
+      pick(args, 0, ["source", "series"], "null"),
+      finiteOr(pick(args, 1, ["leftbars", "left"], "null"), "5"),
+      finiteOr(pick(args, 2, ["rightbars", "right"], "null"), "5"),
     ]);
   }
   if (method === "swma") {
@@ -1355,7 +1601,10 @@ function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
     return taCall("willr", site, [HIGH, LOW, CLOSE, len(0, "14")]);
   }
   if (method === "vwap") {
-    return taCall("vwap", site, [src(), pick(args, 1, ["volume"], VOL)]);
+    return taCall("vwap", site, [
+      pick(args, 0, ["source", "series", "src"], HLC3),
+      pick(args, 1, ["volume"], VOL),
+    ]);
   }
   if (method === "sar") {
     return taCall("sar", site, [
@@ -1367,7 +1616,27 @@ function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
     ]);
   }
   if (method === "adx") {
-    return taCall("adx", site, [HIGH, LOW, CLOSE, len(0, "14")]);
+    if (args.pos.length >= 4) {
+      // Python legacy 4-arg form (common.py:718-726): (high, low, close,
+      // length) with explicit series. Slots resolve kwarg-first.
+      return taCall("adx", site, [
+        pick(args, 0, ["source", "series"], "null"),
+        pick(args, 1, ["low"], "null"),
+        pick(args, 2, ["close"], "null"),
+        finiteOr(pick(args, 3, ["length"], "null"), "0"),
+      ]);
+    }
+    if (args.pos.length === 2 && !hasAnyKw(args, ["high", "low", "close"])) {
+      // Python 2-arg form (diLength, adxSmoothing) (common.py:709-717): both
+      // slots gate on _is_period_like (kwarg-first resolution) and the ADX
+      // period is the SECOND slot — diLength is accepted but unused. A
+      // non-period-like slot → default 14.
+      const period = `(((__di, __sm) => ((Number.isInteger(__di) && Number.isInteger(__sm)) ? __sm : 14))(${pick(args, 0, ["diLength", "length"], "null")}, ${pick(args, 1, ["adxSmoothing", "adxlen"], "null")}))`;
+      return taCall("adx", site, [HIGH, LOW, CLOSE, period]);
+    }
+    // Python 1-arg period-only form gates length via _is_period_like
+    // (common.py ~701): non-period-like → ignored → default 14 (as absent).
+    return taCall("adx", site, [HIGH, LOW, CLOSE, periodGate(pick(args, 0, ["length"], "null"), "14")]);
   }
   if (method === "correlation") {
     return taCall("correlation", site, [
@@ -1387,20 +1656,141 @@ function emitTa(ctx: EmitCtx, method: string, args: CallArgs): string {
       pick(args, 3, ["volume"], VOL),
     ]);
   }
-  if (method === "pvt" || method === "obv" || method === "nvi" || method === "pvi") {
-    return taCall(method, site, [
+  // `vpt` is an alias of the pvt kernel on interpret (no ta.vpt engine fn).
+  if (method === "pvt" || method === "vpt" || method === "obv" || method === "nvi" || method === "pvi") {
+    return taCall(method === "vpt" ? "pvt" : method, site, [
       pick(args, 0, ["source", "close"], CLOSE),
       pick(args, 1, ["volume"], VOL),
     ]);
   }
   if (method === "wad") {
-    return taCall("wad", site, [HIGH, LOW, CLOSE]);
+    return taCall("wad", site, [
+      pick(args, 0, ["high"], HIGH),
+      pick(args, 1, ["low"], LOW),
+      pick(args, 2, ["close"], CLOSE),
+      pick(args, 3, ["volume"], VOL),
+    ]);
   }
   if (method === "iii") {
     return taCall("iii", site, [HIGH, LOW, CLOSE, VOL]);
   }
   if (method === "wvad") {
-    return taCall("wvad", site, [OPEN, HIGH, LOW, CLOSE, VOL]);
+    if (args.pos.length >= 4 || Object.hasOwn(args.kw, "high")) {
+      return taCall("wvad", site, [
+        pick(args, 0, ["high"], HIGH),
+        pick(args, 1, ["low"], LOW),
+        pick(args, 2, ["close"], CLOSE),
+        pick(args, 3, ["volume"], VOL),
+        pick(args, 4, ["length", "period"], "20"),
+      ]);
+    }
+    return taCall("wvad", site, [HIGH, LOW, CLOSE, VOL, pick(args, 0, ["length", "period"], "20")]);
+  }
+  if (method === "cmf") {
+    if (args.pos.length >= 5) {
+      return taCall("cmf", site, [
+        pick(args, 1, ["high"], HIGH),
+        pick(args, 2, ["low"], LOW),
+        pick(args, 0, ["close", "source"], CLOSE),
+        pick(args, 3, ["volume"], VOL),
+        pick(args, 4, ["length", "period"], "20"),
+      ]);
+    }
+    return taCall("cmf", site, [HIGH, LOW, CLOSE, VOL, pick(args, 0, ["length", "period"], "20")]);
+  }
+  if (method === "klinger") {
+    return taCall("klinger", site, [
+      pick(args, 2, ["close"], CLOSE),
+      pick(args, 3, ["volume"], VOL),
+      pick(args, 4, ["fast_period", "fast", "fastlen"], "0"),
+      pick(args, 5, ["slow_period", "slow", "slowlen"], "0"),
+    ]);
+  }
+  if (method === "ao") {
+    // SMA(hl2, fast) − SMA(hl2, slow); high/low always come from the bar context.
+    return taCall("ao", site, [
+      HIGH,
+      LOW,
+      pick(args, 0, ["fast", "fastlen"], "5"),
+      pick(args, 1, ["slow", "slowlen"], "34"),
+    ]);
+  }
+  if (method === "aroon") {
+    // Kernel returns {down, up}; interpret exposes the tuple [down, up].
+    const call = taCall("aroon", site, [HIGH, LOW, pick(args, 0, ["length"], "14")]);
+    return `(() => { const __r = ${call}; return [__r.down, __r.up]; })()`;
+  }
+  if (method === "uo") {
+    return taCall("uo", site, [
+      HIGH,
+      LOW,
+      CLOSE,
+      finiteOr(pick(args, 0, ["length"], "null"), "0"),
+      finiteOr(pick(args, 1, ["length"], "null"), "0"),
+      finiteOr(pick(args, 2, ["length"], "null"), "0"),
+    ]);
+  }
+  if (method === "rci") {
+    // srcArg: missing source is na, not close.
+    return taCall("rci", site, [
+      pick(args, 0, ["source", "series"], "null"),
+      finiteOr(pick(args, 1, ["length"], "null"), "0"),
+    ]);
+  }
+  if (method === "dpo") {
+    return taCall("dpo", site, [CLOSE, finiteOr(pick(args, 0, ["length"], "null"), "0")]);
+  }
+  if (method === "kst") {
+    return taCall("kst", site, [
+      CLOSE,
+      finiteOr(pick(args, 0, ["length"], "null"), "0"),
+      finiteOr(pick(args, 1, ["length"], "null"), "0"),
+      finiteOr(pick(args, 2, ["length"], "null"), "0"),
+      finiteOr(pick(args, 3, ["length"], "null"), "0"),
+    ]);
+  }
+  if (method === "stochrsi") {
+    // Engine method is stochRsi; record already branded {stochrsi, signal}.
+    return taCall("stochRsi", site, [
+      CLOSE,
+      finiteOr(pick(args, 0, ["length"], "null"), "0"),
+      finiteOr(pick(args, 1, ["length"], "null"), "0"),
+    ]);
+  }
+  if (method === "donchian") {
+    return taCall("donchian", site, [HIGH, LOW, finiteOr(pick(args, 0, ["length"], "null"), "0")]);
+  }
+  if (method === "ichimoku") {
+    return taCall("ichimoku", site, [
+      HIGH,
+      LOW,
+      finiteOr(pick(args, 0, ["length"], "null"), "0"),
+      finiteOr(pick(args, 1, ["length"], "null"), "0"),
+    ]);
+  }
+  if (method === "bb_pct") {
+    return taCall("bbPct", site, [
+      CLOSE,
+      finiteOr(pick(args, 0, ["length"], "null"), "0"),
+      finiteOr(pick(args, 1, ["std_dev", "mult", "std"], "null"), "2"),
+    ]);
+  }
+  if (method === "emv") {
+    return taCall("emv", site, [HIGH, LOW, VOL, finiteOr(pick(args, 0, ["length"], "null"), "0")]);
+  }
+  if (method === "fractal") {
+    return taCall("fractal", site, [HIGH, LOW, finiteOr(pick(args, 0, ["length"], "null"), "0")]);
+  }
+  if (method === "atr_stop") {
+    // Kernel has no call-site; missing multiplier → 2 (interpret numArg).
+    return `__h.ta.atrStop(${CLOSE}, ${pick(args, 0, ["atr", "atr_value"], "null")}, ${finiteOr(pick(args, 1, ["multiplier", "mult"], "null"), "2")})`;
+  }
+  if (method === "zigzag") {
+    const call = taCall("zigzag", site, [
+      pick(args, 0, ["source", "series"], "null"),
+      finiteOr(pick(args, 1, ["threshold", "percent", "deviation"], "null"), "5"),
+    ]);
+    return `(() => { const __r = ${call}; return [__r.high, __r.low, __r.dir]; })()`;
   }
   return "null";
 }