@hoox-sh/hoox-tui 0.3.2 → 0.4.0

package/src/components/views/setup-wizard.tsx

@@ -60,7 +60,7 @@ async function spawnVersion(
 
 function extractSemver(raw: string): string {
   const m = raw.match(/(\d+\.\d+\.\d+)/);
-  return m ? m[1] : raw;
+  return m?.[1] ?? raw;
 }
 
 async function checkBun(): Promise<PrereqCheck> {
@@ -95,7 +95,7 @@ async function checkGit(): Promise<PrereqCheck> {
       hint: "apt install git",
     };
   const m = raw.match(/(\d+\.\d+)/);
-  const ver = m ? m[1] : "unknown";
+  const ver = m?.[1] ?? "unknown";
   const [major, minor] = ver.split(".").map(Number);
   const ok = (major ?? 0) >= 2 && (minor ?? 0) >= 40;
   return {
@@ -189,7 +189,7 @@ async function checkCfAccountId(): Promise<PrereqCheck> {
     const m = text.match(
       /(?:account_id|accountId)\s*["']?\s*:\s*["']([^"']+)["']/
     );
-    if (m)
+    if (m?.[1])
       return {
         name: "Cloudflare Account",
         status: "pass",
@@ -298,10 +298,9 @@ type ValidationState = null | boolean;
 // ─── Default Form Data ──────────────────────────────────────────────────────
 
 const defaultFormData = (): WizardFormData => ({
+  // Single unified exchange API key pair (venue selected via Active Exchanges)
   apiKeys: {
-    binance: { key: "", secret: "" },
-    bybit: { key: "", secret: "" },
-    mexc: { key: "", secret: "" },
+    exchange: { key: "", secret: "" },
   },
   exchanges: { binance: false, bybit: false, mexc: false },
   ai: { providerUrl: "", apiKey: "", model: "default" },
@@ -447,12 +446,12 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
   }, []);
 
   useEffect(() => {
-    runChecks();
+    void runChecks();
   }, [runChecks]);
 
   // ── Detect Cloudflare account ID from wrangler.jsonc ────────────────────
   useEffect(() => {
-    (async () => {
+    void (async () => {
       try {
         const file = Bun.file("wrangler.jsonc");
         if (await file.exists()) {
@@ -460,7 +459,7 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
           const m = text.match(
             /(?:account_id|accountId)\s*["']?\s*:\s*["']([^"']+)["']/
           );
-          if (m) setCfAccountId(m[1]);
+          if (m?.[1]) setCfAccountId(m[1]);
         }
         const cfgFile = Bun.file(
           `${process.env.HOME ?? "~"}/.hoox/config.json`
@@ -482,7 +481,7 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
 
   // ── Restore wizard session from disk on mount ───────────────────────────
   useEffect(() => {
-    (async () => {
+    void (async () => {
       try {
         const f = Bun.file(WIZARD_SESSION_PATH);
         if (!(await f.exists())) return;
@@ -534,12 +533,18 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
       >;
       for (let i = 0; i < keys.length - 1; i++) {
         const key = keys[i];
-        if (key === "__proto__" || key === "constructor" || key === "prototype")
+        if (
+          key === undefined ||
+          key === "__proto__" ||
+          key === "constructor" ||
+          key === "prototype"
+        )
           return prev;
         obj = obj[key] as Record<string, unknown>;
       }
       const lastKey = keys[keys.length - 1];
       if (
+        lastKey === undefined ||
         lastKey === "__proto__" ||
         lastKey === "constructor" ||
         lastKey === "prototype"
@@ -561,20 +566,17 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
     let allValid = true;
 
     if (step === 1) {
-      for (const exchange of EXCHANGES) {
-        const e = exchange.toLowerCase();
-        const keyPath = `apiKeys.${e}.key`;
-        const secretPath = `apiKeys.${e}.secret`;
-        const key = data.apiKeys[e].key;
-        const secret = data.apiKeys[e].secret;
-        if (key) {
-          results[keyPath] = validateApiKey(key);
-          if (!results[keyPath]) allValid = false;
-        }
-        if (secret) {
-          results[secretPath] = validateApiKey(secret);
-          if (!results[secretPath]) allValid = false;
-        }
+      const keyPath = "apiKeys.exchange.key";
+      const secretPath = "apiKeys.exchange.secret";
+      const key = data.apiKeys.exchange?.key ?? "";
+      const secret = data.apiKeys.exchange?.secret ?? "";
+      if (key) {
+        results[keyPath] = validateApiKey(key);
+        if (!results[keyPath]) allValid = false;
+      }
+      if (secret) {
+        results[secretPath] = validateApiKey(secret);
+        if (!results[secretPath]) allValid = false;
       }
     } else if (step === 3) {
       // AI providers: if a URL is provided it must be valid; key optional but format-checked when set.
@@ -740,7 +742,7 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
     if (key.name === "left") handleBack();
     if (key.name === "escape") handleBack();
     if (key.name === "tab" && key.shift) handleBack();
-    if (key.name === "r" && step === 0) runChecks();
+    if (key.name === "r" && step === 0) void runChecks();
   });
 
   // ── Validation indicator for a field ─────────────────────────────────────
@@ -916,34 +918,33 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
         Exchange API Keys
       </text>
       <text dim fg={Colors.muted}>
-        Secrets are not entered in the TUI. Set them via CLI, then continue.
+        One key pair for all venues. Secrets are not entered in the TUI — set
+        via CLI, then continue. Active venues are chosen in the next step.
       </text>
       <text dim fg={Colors.dim}>
-        hoox config secrets set BINANCE_API_KEY · etc.
+        hoox secrets set trade-worker EXCHANGE_KEY_BINDING
+      </text>
+      <text dim fg={Colors.dim}>
+        hoox secrets set trade-worker EXCHANGE_SECRET_BINDING
       </text>
       <box flexDirection="column" gap={1} paddingTop={1}>
-        {EXCHANGES.map((name) => {
-          const e = name.toLowerCase();
-          return (
-            <box flexDirection="column" gap={0}>
-              <text bold fg={Colors.foreground}>
-                {name}
-              </text>
-              <SecretField
-                label="  API Key"
-                value={data.apiKeys[e].key}
-                path={`apiKeys.${e}.key`}
-                cliHint={`hoox config secrets set ${name.toUpperCase()}_API_KEY`}
-              />
-              <SecretField
-                label="  API Secret"
-                value={data.apiKeys[e].secret}
-                path={`apiKeys.${e}.secret`}
-                cliHint={`hoox config secrets set ${name.toUpperCase()}_API_SECRET`}
-              />
-            </box>
-          );
-        })}
+        <box flexDirection="column" gap={0}>
+          <text bold fg={Colors.foreground}>
+            Unified exchange credentials
+          </text>
+          <SecretField
+            label="  API Key"
+            value={data.apiKeys.exchange?.key ?? ""}
+            path="apiKeys.exchange.key"
+            cliHint="hoox secrets set trade-worker EXCHANGE_KEY_BINDING"
+          />
+          <SecretField
+            label="  API Secret"
+            value={data.apiKeys.exchange?.secret ?? ""}
+            path="apiKeys.exchange.secret"
+            cliHint="hoox secrets set trade-worker EXCHANGE_SECRET_BINDING"
+          />
+        </box>
       </box>
     </box>
   );
@@ -961,7 +962,7 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
         {EXCHANGES.map((name) => (
           <Checkbox
             label={name}
-            checked={data.exchanges[name.toLowerCase()]}
+            checked={data.exchanges[name.toLowerCase()] ?? false}
             path={`exchanges.${name.toLowerCase()}`}
           />
         ))}
@@ -1126,9 +1127,8 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
   /** Step 6: Deploy — Summary view */
   const StepDeploy = () => {
     const activeCount = Object.values(data.exchanges).filter(Boolean).length;
-    const apiKeysConfigured = Object.values(data.apiKeys).filter(
-      (e) => e.key || e.secret
-    ).length;
+    const apiKeysConfigured =
+      data.apiKeys.exchange?.key || data.apiKeys.exchange?.secret ? 1 : 0;
     const notifCount = [
       data.notifications.email.enabled,
       data.notifications.telegram.enabled,
@@ -1185,7 +1185,7 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
                 bold
                 onMouseUp={() => {
                   setDeployLog("");
-                  handleDeploy();
+                  void handleDeploy();
                 }}
               >
                 {"  [ Retry Deploy ]  "}
@@ -1209,7 +1209,7 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
                 {activeCount === 0 ? "none" : ""})
               </text>
               <text fg={Colors.foreground}>
-                API Keys: {apiKeysConfigured}/3 configured
+                API Keys: {apiKeysConfigured ? "configured" : "not set"}
               </text>
               <text fg={Colors.foreground}>
                 AI Provider:{" "}
@@ -1226,10 +1226,12 @@ export function SetupWizard({ dialog }: SetupWizardProps) {
             </box>
             <box paddingTop={2} justifyContent="center">
               <text
-                fg={deploying ? Colors.dim : Colors.accent}
-                bg={deploying ? Colors.border : Colors.card}
+                fg={Colors.accent}
+                bg={Colors.card}
                 bold
-                onMouseUp={deploying ? undefined : handleDeploy}
+                onMouseUp={() => {
+                  void handleDeploy();
+                }}
               >
                 {"  [ Deploy Now ]  "}
               </text>

package/src/components/views/worker-detail.test.tsx

@@ -192,8 +192,8 @@ describe("WorkerDetail", () => {
     // Only logs for worker "w1" should be relevant
     const workerLogs = state.logs.filter((l) => l.workerId === "w1");
     expect(workerLogs).toHaveLength(2);
-    expect(workerLogs[0].level).toBe("info");
-    expect(workerLogs[1].level).toBe("warn");
+    expect(workerLogs[0]?.level).toBe("info");
+    expect(workerLogs[1]?.level).toBe("warn");
 
     // The log for worker "w2" should be filtered out
     const otherLogs = state.logs.filter((l) => l.workerId === "w2");

package/src/components/views/worker-settings.tsx

@@ -298,13 +298,13 @@ export function WorkerSettingsView() {
 
       if (isAgentConfigEmbeddedField(row.field.key)) {
         const cfgResult = await cliBridge.configKvGet(AGENT_CONFIG_KV_KEY);
-        if (!cfgResult.success && cfgResult.data == null) {
-          // Empty/missing agent:config is fine (starts from {}); only hard-fail on I/O errors
-          // when stderr indicates a real failure and data is unusable.
+        if (!cfgResult.success) {
+          setStatus(
+            `Save blocked: could not read ${AGENT_CONFIG_KV_KEY} (${cfgResult.stderr || cfgResult.stdout || "unknown error"})`
+          );
+          return;
         }
-        const current = parseAgentConfigJson(
-          cfgResult.success ? cfgResult.data : null
-        );
+        const current = parseAgentConfigJson(cfgResult.data);
         const next = applyAgentConfigFieldUpdates(current, {
           [row.field.key]: value,
         });

package/src/components/views/workers-overview.tsx

@@ -237,7 +237,7 @@ export function WorkersOverview({ dialog }: WorkersOverviewProps = {}) {
 
     let cancelled = false;
 
-    (async () => {
+    void (async () => {
       try {
         const result = await cliBridge.monitorStatus();
         if (cancelled) return;

package/src/hooks/hooks.test.ts

@@ -4,18 +4,17 @@
  */
 
 /**
- * Hook unit tests — renderer ref, global keyboard registration, polling helpers.
+ * Hook unit tests — renderer ref and polling helpers.
  */
 import { describe, it, expect, beforeEach, afterEach, jest } from "bun:test";
 import {
   setRendererRef,
   getRendererRef,
-  registerGlobalHandler,
   computePollingBackoff,
   createPollingController,
+  formatPollIntervalLabel,
   POLLING_MAX_BACKOFF_MS,
 } from "./index";
-import type { KeyEvent } from "./use-keyboard";
 
 describe("renderer-ref", () => {
   afterEach(() => {
@@ -37,139 +36,6 @@ describe("renderer-ref", () => {
   });
 });
 
-describe("registerGlobalHandler", () => {
-  beforeEach(() => {
-    // Ensure no renderer → attach is a no-op; handlers still register
-    setRendererRef(null);
-  });
-
-  afterEach(() => {
-    setRendererRef(null);
-  });
-
-  it("registers and unregisters without throwing", () => {
-    const calls: string[] = [];
-    const unsub = registerGlobalHandler((key: KeyEvent) => {
-      calls.push(key.name);
-    }, 10);
-    expect(typeof unsub).toBe("function");
-    unsub();
-    expect(calls).toEqual([]);
-  });
-
-  it("multiple handlers can register and all unsubscribe cleanly", () => {
-    const a = registerGlobalHandler(() => {}, 0);
-    const b = registerGlobalHandler(() => {}, 50);
-    const c = registerGlobalHandler(() => {}, 100);
-    a();
-    b();
-    c();
-  });
-
-  it("dispatches keypresses in priority order when renderer is attached", () => {
-    const order: number[] = [];
-    const listeners = new Map<string, Set<(...args: unknown[]) => void>>();
-    const keyInput = {
-      on: (event: string, fn: (...args: unknown[]) => void) => {
-        if (!listeners.has(event)) listeners.set(event, new Set());
-        listeners.get(event)!.add(fn);
-        return () => listeners.get(event)?.delete(fn);
-      },
-      off: (event: string, fn: (...args: unknown[]) => void) => {
-        listeners.get(event)?.delete(fn);
-      },
-    };
-    setRendererRef({
-      keyInput,
-    } as unknown as import("@opentui/core").CliRenderer);
-
-    const unsubHigh = registerGlobalHandler(() => {
-      order.push(0);
-    }, 0);
-    const unsubMid = registerGlobalHandler(() => {
-      order.push(10);
-    }, 10);
-    const unsubLow = registerGlobalHandler(() => {
-      order.push(50);
-    }, 50);
-
-    const handlers = listeners.get("keypress");
-    expect(handlers?.size).toBe(1);
-    for (const h of handlers ?? []) {
-      h({
-        name: "a",
-        ctrl: false,
-        shift: false,
-        alt: false,
-        meta: false,
-        sequence: "a",
-      });
-    }
-    expect(order).toEqual([0, 10, 50]);
-
-    unsubHigh();
-    unsubMid();
-    unsubLow();
-    // Last unsubscribe detaches key input
-    expect(listeners.get("keypress")?.size ?? 0).toBe(0);
-  });
-
-  it("snapshot protects against unsubscribe mid-dispatch", () => {
-    const seen: string[] = [];
-    let unsubB: (() => void) | null = null;
-    const listeners = new Map<string, Set<(...args: unknown[]) => void>>();
-    const keyInput = {
-      on: (event: string, fn: (...args: unknown[]) => void) => {
-        if (!listeners.has(event)) listeners.set(event, new Set());
-        listeners.get(event)!.add(fn);
-        return () => listeners.get(event)?.delete(fn);
-      },
-      off: () => {},
-    };
-    setRendererRef({
-      keyInput,
-    } as unknown as import("@opentui/core").CliRenderer);
-
-    const unsubA = registerGlobalHandler(() => {
-      seen.push("a");
-      unsubB?.();
-    }, 0);
-    unsubB = registerGlobalHandler(() => {
-      seen.push("b");
-    }, 1);
-
-    for (const h of listeners.get("keypress") ?? []) {
-      h({
-        name: "x",
-        ctrl: false,
-        shift: false,
-        alt: false,
-        meta: false,
-        sequence: "x",
-      });
-    }
-    // Snapshot ensures b still runs even though unsub mid-dispatch
-    expect(seen).toEqual(["a", "b"]);
-    unsubA();
-  });
-
-  it("attaches when on() returns non-function (off fallback path)", () => {
-    let offCalled = false;
-    const keyInput = {
-      on: () => undefined,
-      off: () => {
-        offCalled = true;
-      },
-    };
-    setRendererRef({
-      keyInput,
-    } as unknown as import("@opentui/core").CliRenderer);
-    const unsub = registerGlobalHandler(() => {}, 5);
-    unsub();
-    expect(offCalled).toBe(true);
-  });
-});
-
 describe("computePollingBackoff", () => {
   it("caps exponential backoff at 16s", () => {
     const base = 1000;
@@ -192,6 +58,14 @@ describe("computePollingBackoff", () => {
   });
 });
 
+describe("formatPollIntervalLabel", () => {
+  it("formats whole seconds, fractional seconds, and milliseconds", () => {
+    expect(formatPollIntervalLabel(5_000)).toBe("5s auto");
+    expect(formatPollIntervalLabel(1500)).toBe("1.5s auto");
+    expect(formatPollIntervalLabel(500)).toBe("500ms auto");
+  });
+});
+
 describe("createPollingController", () => {
   /** Flush microtasks after advancing fake timers (Bun has no advanceTimersByTimeAsync). */
   async function advance(ms: number): Promise<void> {
@@ -326,41 +200,3 @@ describe("createPollingController", () => {
     expect(calls).toBe(1);
   });
 });
-
-describe("useServiceData", () => {
-  afterEach(async () => {
-    const { __setServiceStoreHookForTests } =
-      await import("./use-service-data");
-    __setServiceStoreHookForTests(null);
-  });
-
-  it("applies the selector via the store hook", async () => {
-    const { useServiceData, __setServiceStoreHookForTests } =
-      await import("./use-service-data");
-    const { useServiceStore } = await import("@hoox-sh/hoox-shared");
-    const snapshot = useServiceStore.getState();
-
-    __setServiceStoreHookForTests((selector) => selector(snapshot));
-
-    const status = useServiceData((s) => s.connectionStatus);
-    expect(status).toBe(snapshot.connectionStatus);
-
-    const workers = useServiceData((s) => s.workers);
-    expect(workers).toBe(snapshot.workers);
-  });
-
-  it("restores real store hook after null reset", async () => {
-    const { useServiceData, __setServiceStoreHookForTests } =
-      await import("./use-service-data");
-    __setServiceStoreHookForTests((() => "injected") as never);
-    expect(useServiceData((() => "x") as never) as unknown).toBe("injected");
-    __setServiceStoreHookForTests(null);
-    // Real hook throws outside React — proves restore happened
-    expect(() => useServiceData((s) => s.connectionStatus)).toThrow();
-  });
-
-  it("is re-exported from hooks index", async () => {
-    const mod = await import("./index");
-    expect(typeof mod.useServiceData).toBe("function");
-  });
-});

package/src/hooks/index.ts

@@ -3,15 +3,13 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-export { useKeyboard, registerGlobalHandler } from "./use-keyboard";
-export type { KeyEvent, UseKeyboardOptions } from "./use-keyboard";
 export {
   usePolling,
   computePollingBackoff,
   createPollingController,
+  formatPollIntervalLabel,
   POLLING_MAX_BACKOFF_MS,
 } from "./use-polling";
 export type { UsePollingOptions } from "./use-polling";
-export { useServiceData } from "./use-service-data";
 export { setRendererRef, getRendererRef } from "./renderer-ref";
 export { isShellOverlayOpen, useViewKeyboard } from "./shell-overlay";

package/src/hooks/renderer-ref.ts

@@ -17,6 +17,7 @@ export function setRendererRef(renderer: CliRenderer | null): void {
   _renderer = renderer;
 }
 
+/** Current CLI renderer, or `null` before `setRendererRef` / after teardown. */
 export function getRendererRef(): CliRenderer | null {
   return _renderer;
 }

package/src/hooks/use-polling.ts

@@ -101,6 +101,18 @@ export function createPollingController(options: {
   };
 }
 
+/** Compact HUD label for the configured poll interval. */
+export function formatPollIntervalLabel(ms: number): string {
+  if (!Number.isFinite(ms) || ms <= 0) return "auto";
+  if (ms >= 1000 && ms % 1000 === 0) return `${ms / 1000}s auto`;
+  if (ms >= 1000) return `${(ms / 1000).toFixed(1)}s auto`;
+  return `${Math.round(ms)}ms auto`;
+}
+
+/**
+ * Poll `callback` on the Settings refresh interval while `enabled`.
+ * Backs off exponentially after thrown failures; resets after success.
+ */
 export function usePolling(options: UsePollingOptions): void {
   const { callback, enabled = true, immediate = true } = options;
   const intervalMs = useConfigStore((s) => s.refreshIntervalMs);