@honeybadger-io/react-native 6.2.0 → 6.2.2

package/CHANGELOG.md

@@ -3,6 +3,23 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [6.2.2](https://github.com/honeybadger-io/honeybadger-js/compare/@honeybadger-io/react-native@6.2.1...@honeybadger-io/react-native@6.2.2) (2023-10-09)
+
+
+### Bug Fixes
+
+* **react-native:** fix sourcemaps for iOS builds with hermes ([#1197](https://github.com/honeybadger-io/honeybadger-js/issues/1197)) ([d516ef0](https://github.com/honeybadger-io/honeybadger-js/commit/d516ef0b75a2e46f4c374d042a6c5a90179e4f53))
+
+
+
+## [6.2.1](https://github.com/honeybadger-io/honeybadger-js/compare/@honeybadger-io/react-native@6.2.0...@honeybadger-io/react-native@6.2.1) (2023-09-12)
+
+**Note:** Version bump only for package @honeybadger-io/react-native
+
+
+
+
+
 ## [6.2.0](https://github.com/honeybadger-io/honeybadger-js/compare/@honeybadger-io/react-native@6.1.1...@honeybadger-io/react-native@6.2.0) (2023-09-07)
 
 

package/README.md

@@ -49,7 +49,7 @@ Error reports can be [customized](https://docs.honeybadger.io/lib/javascript/gui
 ### Limitations
 Some native errors on Android may not be recorded if they cause an immediate crash of the app before the notice makes it to Honeybadger. 
 
-### Source Maps
+## Source Maps
 To generate and upload source maps to Honeybadger, use the following command:
 ```shell
 npx honeybadger-upload-sourcemaps --apiKey <your project API key> --revision <build revision>

package/dist/index.js

@@ -84,7 +84,7 @@ function __generator(thisArg, body) {
 }
 
 var name = "@honeybadger-io/react-native";
-var version = "6.2.0";
+var version = "6.2.2";
 
 var Transport = /** @class */ (function () {
     function Transport() {
@@ -283,7 +283,7 @@ var Honeybadger = /** @class */ (function (_super) {
         _this.__notifier = {
             name: '@honeybadger-io/react-native',
             url: 'https://github.com/honeybadger-io/honeybadger-js/tree/master/packages/react-native',
-            version: '6.2.0'
+            version: '6.2.2'
         };
         _this.__jsHandlerInitialized = false;
         _this.__nativeHandlerInitialized = false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@honeybadger-io/react-native",
-  "version": "6.2.0",
+  "version": "6.2.2",
   "description": "Honeybadger.io for React Native.",
   "author": "Andrey Butov <andreybutov@antair.com> (https://andreybutov.com)",
   "license": "MIT",
@@ -50,5 +50,5 @@
   "dependencies": {
     "@honeybadger-io/core": "^6.3.0"
   },
-  "gitHead": "94e663836936974474628967f5c440ffa668bc9b"
+  "gitHead": "96a0f90cd1cac6cf09f074af70199744d757995c"
 }

package/scripts/honeybadger-upload-sourcemaps.sh

@@ -174,7 +174,6 @@ if $USE_HERMES; then
 	# react native <= 0.68
 	HERMES_PATH_2="$NODE_MODULES/hermes-engine/$OS_BIN/hermesc"
 
-	
 	if [ -f "$HERMES_PATH_1" ]; then
 		HERMES_EXECUTABLE="$HERMES_PATH_1"
 	elif [ -f "$HERMES_PATH_2" ]; then
@@ -184,9 +183,6 @@ if $USE_HERMES; then
 		exit 1
 	fi
 
-	
-	echo "Generating Hermes Android source map ..."
-
 	#
 	# compile the Android code to bytecode and generate the Hermes sourcemap
 	#
@@ -209,39 +205,42 @@ if $USE_HERMES; then
 
 
 	#
-	# Need to find the Hermes compiler executable for iOS.
+	# For iOS, we're no longer using the hermes output concatenation, 
+	# even for hermes builds, as it produces incorrect sourcemaps.
 	#
 
-	HERMES_EXECUTABLE="$PROJECT_ROOT_DIR/ios/Pods/hermes-engine/destroot/bin/hermesc"
+	# HERMES_EXECUTABLE="$PROJECT_ROOT_DIR/ios/Pods/hermes-engine/destroot/bin/hermesc"
 
-	if [ ! -f "$HERMES_EXECUTABLE" ]; then
-		echo "Error: The Hermes compiler executable for iOS was not found in the expected location: $HERMES_EXECUTABLE . Did you run pod install in the ios/ directory?"
-		exit 1
-	fi
+	# if [ ! -f "$HERMES_EXECUTABLE" ]; then
+	# 	echo "Error: The Hermes compiler executable for iOS was not found in the expected location: $HERMES_EXECUTABLE . Did you run pod install in the ios/ directory?"
+	# 	exit 1
+	# fi
 
-	
-	echo "Generating Hermes iOS source map ..."
+	# echo "Generating Hermes iOS source map ..."
 
 	#
 	# Compile the iOS code to bytecode and generate the Hermes sourcemap.
 	# 
 
-	"$HERMES_EXECUTABLE" \
-		-O \
-		-emit-binary \
-		-output-source-map \
-		-out="$IOS_COMPILER_BUNDLE" \
-		"$IOS_PACKAGER_BUNDLE" > /dev/null 2>&1
+	# "$HERMES_EXECUTABLE" \
+	# 	-O \
+	# 	-emit-binary \
+	# 	-output-source-map \
+	# 	-out="$IOS_COMPILER_BUNDLE" \
+	# 	"$IOS_PACKAGER_BUNDLE" > /dev/null 2>&1
 
 	#
 	# merge the two iOS sourcemaps
 	#
 
-	node "$NODE_MODULES/react-native/scripts/compose-source-maps.js" \
-		"$IOS_PACKAGER_SOURCE_MAP" \
-		"$IOS_COMPILER_SOURCE_MAP" \
-		-o "$IOS_FINAL_SOURCE_MAP" > /dev/null 2>&1
+	# node "$NODE_MODULES/react-native/scripts/compose-source-maps.js" \
+	# 	"$IOS_PACKAGER_SOURCE_MAP" \
+	# 	"$IOS_COMPILER_SOURCE_MAP" \
+	# 	-o "$IOS_FINAL_SOURCE_MAP" > /dev/null 2>&1
+
 
+	# Same operation for hermes builds on iOS as with --no-hermes; see note above.
+	mv "$IOS_PACKAGER_SOURCE_MAP" "$IOS_FINAL_SOURCE_MAP"
 
 	#
 	# cleanup
@@ -253,9 +252,9 @@ if $USE_HERMES; then
 		"$ANDROID_COMPILER_BUNDLE" \
 		"$ANDROID_COMPILER_SOURCE_MAP" \
 		"$IOS_PACKAGER_BUNDLE" \
-		"$IOS_PACKAGER_SOURCE_MAP" \
-		"$IOS_COMPILER_BUNDLE" \
-		"$IOS_COMPILER_SOURCE_MAP"
+		"$IOS_PACKAGER_SOURCE_MAP" # \
+		# "$IOS_COMPILER_BUNDLE" \
+		# "$IOS_COMPILER_SOURCE_MAP"
 
 else
 
@@ -304,7 +303,7 @@ curl https://api.honeybadger.io/v1/source_maps \
 curl https://api.honeybadger.io/v1/source_maps \
 	-F api_key="$API_KEY" \
 	-F revision="$REVISION" \
-	-F minified_url=main.jsbundle \
+	-F minified_url="*/main.jsbundle" \
 	-F source_map=@"$IOS_FINAL_SOURCE_MAP" \
 	-F minified_file=@"$EMPTY_FILE" > /dev/null 2>&1