@honeybadger-io/js 3.2.6 → 3.2.9

package/dist/server/honeybadger.js

@@ -254,7 +254,7 @@ function runAfterNotifyHandlers(notice, handlers, error) {
     return true;
 }
 // Returns a new object with properties from other object.
-function newObject(obj) {
+function shallowClone(obj) {
     if (typeof (obj) !== 'object' || obj === null) {
         return {};
     }
@@ -281,8 +281,14 @@ function sanitize(obj, maxDepth) {
         return false;
     }
     function canSerialize(obj) {
-        // Functions are TMI and Symbols can't convert to strings.
-        if (/function|symbol/.test(typeof (obj))) {
+        var typeOfObj = typeof obj;
+        // Functions are TMI
+        if (/function/.test(typeOfObj)) {
+            // Let special toJSON method pass as it's used by JSON.stringify (#722)
+            return obj.name === 'toJSON';
+        }
+        // Symbols can't convert to strings.
+        if (/symbol/.test(typeOfObj)) {
             return false;
         }
         if (obj === null) {
@@ -309,7 +315,7 @@ function sanitize(obj, maxDepth) {
         }
         // Serialize inside arrays
         if (Array.isArray(obj)) {
-            return obj.map(function (o) { return serialize(o, depth + 1); });
+            return obj.map(function (o) { return safeSerialize(o, depth + 1); });
         }
         // Serialize inside objects
         if (typeof (obj) === 'object') {
@@ -317,7 +323,7 @@ function sanitize(obj, maxDepth) {
             for (var k in obj) {
                 var v = obj[k];
                 if (Object.prototype.hasOwnProperty.call(obj, k) && (k != null) && (v != null)) {
-                    ret[k] = serialize(v, depth + 1);
+                    ret[k] = safeSerialize(v, depth + 1);
                 }
             }
             return ret;
@@ -325,7 +331,16 @@ function sanitize(obj, maxDepth) {
         // Return everything else untouched
         return obj;
     }
-    return serialize(obj);
+    function safeSerialize(obj, depth) {
+        if (depth === void 0) { depth = 0; }
+        try {
+            return serialize(obj, depth);
+        }
+        catch (e) {
+            return "[ERROR] " + e;
+        }
+    }
+    return safeSerialize(obj);
 }
 function logger(client) {
     var log = function (method) {
@@ -364,7 +379,7 @@ function makeNotice(thing) {
         notice = merge(thing, { name: e.name, message: e.message, stack: e.stack });
     }
     else if (typeof thing === 'object') {
-        notice = newObject(thing);
+        notice = shallowClone(thing);
     }
     else {
         var m = String(thing);
@@ -488,7 +503,7 @@ function formatCGIData(vars, prefix) {
 var notifier = {
     name: 'honeybadger-js',
     url: 'https://github.com/honeybadger-io/honeybadger-js',
-    version: '3.2.6'
+    version: '3.2.9'
 };
 // Split at commas
 var TAG_SEPARATOR = /,/;
@@ -631,7 +646,7 @@ var Client = /** @class */ (function () {
             return;
         }
         opts = opts || {};
-        var metadata = newObject(opts.metadata);
+        var metadata = shallowClone(opts.metadata);
         var category = opts.category || 'custom';
         var timestamp = new Date().toISOString();
         this.__breadcrumbs.push({
@@ -830,6 +845,11 @@ function errorHandler(err, req, _res, next) {
 }
 function lambdaHandler(handler) {
     return function lambdaHandler(event, context, callback) {
+        // in the case of an async handler, the length of the handler will be less than 3 (no callback function).
+        // if this is the case, we have to explicitly call the callback function from the function we are returning.
+        // we don't have to do that if the handler has third callback function parameter,
+        // because it will be called directly from inside the handler.
+        var shouldInvokeCallbackExplicitly = handler.length < 3;
         // eslint-disable-next-line prefer-rest-params
         var args = arguments;
         var dom = domain__default['default'].create();
@@ -850,7 +870,12 @@ function lambdaHandler(handler) {
         dom.run(function () {
             process.nextTick(function () {
                 Promise.resolve(handler.apply(this, args))
-                    .then(function () { hb.clear(); })
+                    .then(function (res) {
+                    hb.clear();
+                    if (shouldInvokeCallbackExplicitly) {
+                        callback(null, res);
+                    }
+                })
                     .catch(hbHandler);
             });
         });

package/dist/server/types/core/util.d.ts

@@ -7,7 +7,7 @@ export declare function objectIsExtensible(obj: any): boolean;
 export declare function makeBacktrace(stack: string, shift?: number): BacktraceFrame[];
 export declare function runBeforeNotifyHandlers(notice: any, handlers: BeforeNotifyHandler[]): boolean;
 export declare function runAfterNotifyHandlers(notice: any, handlers: AfterNotifyHandler[], error?: any): boolean;
-export declare function newObject<T>(obj: T): T | Record<string, unknown>;
+export declare function shallowClone<T>(obj: T): T | Record<string, unknown>;
 export declare function sanitize(obj: any, maxDepth?: number): any;
 export declare function logger(client: Client): Logger;
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@honeybadger-io/js",
-  "version": "3.2.6",
+  "version": "3.2.9",
   "license": "MIT",
   "homepage": "https://github.com/honeybadger-io/honeybadger-js",
   "author": {
@@ -66,7 +66,7 @@
     "sinon": "^11.1.2",
     "supertest": "^6.1.6",
     "ts-jest": "^27.0.5",
-    "tsd": "^0.17.0",
+    "tsd": "^0.18.0",
     "tslib": "^2.3.1",
     "typescript": "^4.3.5"
   },