@honest-pitches/pitch-sdk 0.5.1 → 0.5.3

package/CHANGELOG.md

@@ -11,6 +11,72 @@ and this project adheres to
 
 ## [Unreleased]
 
+### Fixed
+
+- **`client.pitches.list is not a function` on every auth-required
+  list path (2026-07-28).** The `list` alias existed in local
+  source under the 0.5.1 version number but was never published
+  to npmjs (the 0.5.1 tarball only had `find`). Bumped to
+  **0.5.2** so a fresh `npm install @honest-pitches/pitch-sdk`
+  actually gets the alias. TSDoc updated to say stable-since
+  0.5.2 (honest about the 0.5.1 publish gap). Detail:
+  control-repo
+  [`CHANGELOG.d/2026-07-28-sdk-list-alias-and-creatorid-filter.md`](../CHANGELOG.d/2026-07-28-sdk-list-alias-and-creatorid-filter.md).
+
+### Fixes
+
+- **`videoSource` type widening to keep `pnpm run build:deploy:all`
+  green (commit `86f7ab1`, 2026-07-27).** The 2026-07-27 bug #2
+  commit `7f8b748` (`feat(pitcher-sdk): forward
+  videoSource/videoExternalId/videoExternalUrl + video helpers on
+  create/update`) widened `CreatePitchInput.videoSource` to a
+  3-literal union (`"bunny_video_id" | "external_url" | "none" |
+  null`) AND added an `input.videoSource !== ""` guard at
+  `src/pitches.ts:215`. The guard's intent — drop empty-string
+  form-field values from the wire body — is correct, but the
+  type doesn't permit `""`, so tsc flagged the comparison as
+  unreachable (TS2367) and `pnpm run build:deploy:all` failed at
+  the SDK build step. **Fix:** widen the union to add `""` on
+  both `CreatePitchInput` and `UpdatePitchInput` (the latter for
+  symmetry, since the spread-forward site could see an
+  empty-string value too). `""` now lives in the canonical
+  "do not overwrite" club alongside `null` and absent, matching
+  the MCP server's `raw[key] !== ""` guard at `pitch-write`.
+  Two pre-existing typecheck failures from the same
+  `7f8b748` commit were also repaired:
+  - **9× TS2741** — pitch-test sections were missing the
+    required `mediaIds: string[]` field (the `PitchSection`
+    contract has required it since at least the v0.3.0
+    platform-libs cut). Added `mediaIds: []` to all three
+    test-section triples.
+  - **1× TS7006** — `Headers.forEach((v, k) => …)` had
+    implicit-any parameters because the outer
+    `vi.fn(async (input: any, init?: any) => …)` signature
+    leaves `init` untyped, so the `instanceof Headers`
+    narrowing does not propagate to `init.headers`. Added
+    explicit `(v: string, k: string)` types.
+
+### Tests
+
+- **New regression test** (2026-07-27):
+  `pitches.test.ts#PitchesApi.create — body builder
+  does NOT forward videoSource/videoExternalId/videoExternalUrl
+  when set to empty string (regression: form-field hygiene)`.
+  Pins the `!== ""` guard's runtime behaviour — without it, a
+  future refactor that drops the guard would silently start
+  writing `""` to the server, which the server then rejects or
+  misinterprets depending on column nullability.
+- **Test counts:** `pnpm test` 47/47 vitest (was 46/46);
+  `pnpm test:ci` 47 vitest + 54 contract assertions across 9
+  contract suites, 0 regressions.
+
+### Version
+
+- **No version bump in this commit.** The bug #2 commit
+  (`7f8b748`) was unversioned at HEAD; this fix lands on top.
+  The next operator-pushed SDK tag should cut `v0.5.2` to ship
+  both fixes together.
+
 Next package version: `0.4.1`. See
 `CHANGELOG.d/2026-07-19-package-rename.md` for the rename to
 `@honest-pitches/pitch-sdk`.

package/dist/index.cjs

@@ -16849,10 +16849,37 @@ var PitchesApi = class {
       intendedAudience: input.intendedAudience ?? "",
       visibility: input.visibility ?? "private"
     };
+    if (input.honestyDisclosure != null && input.honestyDisclosure !== "") {
+      payload.honestyDisclosure = String(input.honestyDisclosure).slice(0, 2e3);
+    }
     if (input.categorySlug != null) payload.categorySlug = input.categorySlug;
     if (input.priceNote != null && input.priceNote !== "") {
       payload.priceNote = String(input.priceNote).slice(0, 64);
     }
+    if (input.videoSource != null && input.videoSource !== "") {
+      payload.videoSource = input.videoSource;
+    }
+    if (input.videoExternalId != null && input.videoExternalId !== "") {
+      payload.videoExternalId = String(input.videoExternalId);
+    }
+    if (input.videoExternalUrl != null && input.videoExternalUrl !== "") {
+      payload.videoExternalUrl = String(input.videoExternalUrl);
+    }
+    if (input.bunnyVideoId != null && input.bunnyVideoId !== "") {
+      payload.bunnyVideoId = String(input.bunnyVideoId);
+    }
+    if (input.primaryVideo != null && input.primaryVideo !== "") {
+      payload.primaryVideo = String(input.primaryVideo);
+    }
+    if (input.primaryVideoId != null && input.primaryVideoId !== "") {
+      payload.primaryVideoId = String(input.primaryVideoId);
+    }
+    if (input.honestyDisclosure != null && input.honestyDisclosure !== "") {
+      payload.honestyDisclosure = String(input.honestyDisclosure).slice(0, 2e3);
+    }
+    if (input.dryRun === true) {
+      payload.dryRun = true;
+    }
     const doc = await fetchPitches(this.config, {
       method: "POST",
       path: "/pitches",
@@ -16870,7 +16897,9 @@ var PitchesApi = class {
   async find(opts = {}) {
     const params = new URLSearchParams();
     if (opts.status) params.set("status", opts.status);
+    if (opts.creatorId) params.set("creatorId", opts.creatorId);
     if (typeof opts.limit === "number") params.set("limit", String(opts.limit));
+    if (opts.cursor) params.set("cursor", opts.cursor);
     const qs = params.toString();
     const docs = await fetchPitches(this.config, {
       method: "GET",
@@ -16878,6 +16907,20 @@ var PitchesApi = class {
     });
     return docs.map((d) => rowToPitch(d));
   }
+  /**
+   * Public alias for {@link PitchesApi.find}. Stable on the public
+   * npm registry since `@honest-pitches/pitch-sdk@0.5.2` (2026-07-28).
+   * If you see "client.pitches.list is not a function" you are on
+   * an older SDK — bump to `>=0.5.2`. (The 0.5.1 tarball on npmjs
+   * never shipped this alias even though the source landed under
+   * that version number locally; 0.5.2 is the first published cut.)
+   *
+   * (Added 2026-07-27; published 2026-07-28 after the agent bug
+   * report against CLI 0.5.1 / hosted MCP `list_pitches`.)
+   */
+  async list(opts = {}) {
+    return this.find(opts);
+  }
   async update(id, input) {
     const doc = await fetchPitches(this.config, {
       method: "PATCH",
@@ -16886,6 +16929,43 @@ var PitchesApi = class {
     });
     return rowToPitch(doc);
   }
+  /**
+   * Move a pitch through its lifecycle. The returned row carries BOTH
+   * `status` (row-level persisted) and `lifecycle` (computed from
+   * `status + previewToken` server-side).
+   *
+   * Status vs lifecycle (2026-07-28 FlexTape retest doc bundle):
+   *   `lifecycle` is the canonical, computed view of where the row sits
+   *   (`draft | preview | live | expired | archived`). It is derived
+   *   from `status + previewToken` server-side in
+   *   `honest-pitches-studio-api/legacy/pitch-write/src/handler.ts`.
+   *   Branch on `lifecycle` for terminal-state checks.
+   *
+   *   The mapping is:
+   *     - `lifecycle: "draft"`    ⟷ `status: "draft"`   (no previewToken)
+   *     - `lifecycle: "preview"`  ⟷ `status: "draft"`   (previewToken set)
+   *     - `lifecycle: "live"`     ⟷ `status: "live"`
+   *     - `lifecycle: "expired"`  ⟷ `status: "expired"`
+   *     - `lifecycle: "archived"` ⟷ `status: "removed"` (intentional vocab split)
+   *
+   * Token gate (Finding #17, FlexTape retest):
+   *   `to: "preview"` requires a `previewToken` that matches the row's
+   *   stored token. The server returns
+   *   `400 previewToken is required to transition to preview`
+   *   when the token is missing or wrong.
+   *
+   *   `to: "draft"` from an `archived` row ALSO requires the same
+   *   `previewToken` (the token is the only proof the caller owns the
+   *   unarchive). There is NO `archived → preview` single-step path —
+   *   the supported path is `archived → draft` (token required) and
+   *   then `draft → preview` (which may issue a NEW token).
+   *
+   * Visibility on archive (Finding #17, FlexTape retest):
+   *   `to: "archived"` does NOT touch `visibility` — the row keeps
+   *   whatever visibility it had at the time of the archive (usually
+   *   `"public"`, but `"unlisted"` is preserved too). Only `to: "live"`
+   *   assigns `visibility: "public"`.
+   */
   async transition(id, input) {
     const doc = await fetchPitches(this.config, {
       method: "POST",
@@ -16913,11 +16993,56 @@ var PitchesApi = class {
     });
     return doc;
   }
+  /**
+   * List every media asset for a pitch, joining two server-side sources:
+   *
+   *  - `pitch_assets` rows with `pitchId === id` (the explicit
+   *    uploads via `POST /pitcher/pitches/:id/media`).
+   *  - The auto-generated `thumbnailFileId` and `ogImageFileId` fields
+   *    on the pitch row itself (synthesised by `pitch-write`'s
+   *    `to=live` path; they live on the row, NOT in `pitch_assets`).
+   *
+   * Each result carries a `source: "pitch_assets" | "pitch_row"`
+   * discriminator so consumers can tell the two apart. The server
+   * may synthesise `pitch_row` rows with `sizeBytes: 0` (the auto
+   * images don't carry an upload byte count — the `cdnUrl` is the
+   * canonical handle).
+   *
+   * Added 2026-07-28 to address Bug #12 of the FlexTape retest brief
+   * (`testing-feedback/2026-07-27-flextape-rerun-3surface-retest.md`).
+   * Prior to this, `hp pitches media list <id>` returned `[]` for
+   * every pitch whose only assets were auto-generated.
+   */
+  async listMedia(id) {
+    return fetchPitches(this.config, {
+      method: "GET",
+      path: `/pitches/${encodeURIComponent(id)}/media`
+    });
+  }
   /**
    * Restore an archived pitch to `draft`. Same as `transition(id, {
    * to: "draft", previewToken })` but with a placeholder previewToken
    * if the caller didn't pass one. The server's "to=draft" path
    * mirrors the existing "to=preview" pre-condition.
+   *
+   * Status vs lifecycle (2026-07-28 FlexTape retest doc bundle):
+   *   `pitches.lifecycle` is the canonical, computed view of where
+   *   the row sits (`draft, preview, live, expired, archived`). It is
+   *   derived from `status + previewToken` server-side
+   *   (`honest-pitches-studio-api/legacy/pitch-write/src/handler.ts`).
+   *   Branch on `lifecycle` for terminal-state checks.
+   *
+   *   The mapping is:
+   *     - `lifecycle: "preview"` ⟷ `status: "draft"` (previewToken set)
+   *     - `lifecycle: "live"`    ⟷ `status: "live"`
+   *     - `lifecycle: "archived"` ⟷ `status: "removed"` (intentional vocab split)
+   *
+   *   There is NO direct `archived → preview` path — the server only
+   *   exposes `archived → draft`. To resume preview after a draft,
+   *   transition twice (`archived → draft` then `draft → preview` with
+   *   a new preview token), or use `transition(id, { to: "preview",
+   *   previewToken })` directly if your `lifecycle` is `draft` (NOT
+   *   `archived`).
    */
   async unarchive(id, opts = {}) {
     return this.transition(id, {