@hone-ai/cli 1.38.1 → 1.39.0

package/hone-cli.js

@@ -33,13 +33,16 @@ const { parseTimeoutSeconds } = require('./lib/timeout-option.js');
 // HC-GF-143 batch: both mappings were computed inline and asserted by nothing (HC-GF-136).
 const { promotePayload } = require('./lib/promote-payload');
 const { assetFetchList } = require('./lib/asset-fetch-list');
+// HC-CI-019-followup-3: no suite asserted a field of either, and this file cannot be required.
+const { detectExistingTestFramework } = require('./lib/detect-test-framework');
+const { classifySpec } = require('./lib/classify-spec');
 
 const pkg     = require('./package.json');
 const { parseReviewJSON } = require('./lib/parse-review-json');
 const { resolveBaseRef, getMaxDiffChars } = require('./lib/release-review-config');
 const { gitEnv } = require('./lib/git-env');
 const { collectIncludePaths } = require('./lib/include-paths');
-const { runArgsError, orchestratePath, apiPath, storyDir: storyDirIn, isGitRev } = require('./lib/run-target'); // HC-GF-270-followup-1, -2, -3
+const { runArgsError, orchestratePath, apiPath, storyDir: storyDirIn, isGitRev, isStoryId } = require('./lib/run-target'); // HC-GF-270-followup-1, -2, -3, -4
 const { normalizeQuestion, questionLines, gateQuestionLines, countPhrase } = require('./lib/operator-question'); // HC-GF-234
 const program = new Command();
 
@@ -1177,45 +1180,6 @@ function describeSandboxDisposition(runConfig) {
   }
 }
 
-function detectExistingTestFramework(repoRoot) {
-  const pkgPath = path.join(repoRoot, 'package.json');
-  if (!fs.existsSync(pkgPath)) return { stack: 'unknown', testFw: null, pkgMgr: null };
-
-  const pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
-  const allDeps = { ...pkg.dependencies, ...pkg.devDependencies };
-
-  // Detect stack
-  let stack = 'node';
-  if (allDeps['react']) stack = allDeps['vite'] ? 'react-vite' : 'react';
-  if (allDeps['next']) stack = 'nextjs';
-  if (allDeps['@nestjs/core']) stack = 'nestjs';
-
-  // Detect existing test framework
-  let testFw = null;
-  if (allDeps['vitest']) testFw = 'vitest';
-  else if (allDeps['jest']) testFw = 'jest';
-  else if (allDeps['mocha']) testFw = 'mocha';
-
-  // Detect Playwright
-  const hasPlaywright = !!allDeps['@playwright/test'];
-
-  // Detect package manager
-  let pkgMgr = 'npm';
-  if (fs.existsSync(path.join(repoRoot, 'yarn.lock'))) pkgMgr = 'yarn';
-  if (fs.existsSync(path.join(repoRoot, 'pnpm-lock.yaml'))) pkgMgr = 'pnpm';
-
-  // Detect existing configs
-  const hasTestConfig = ['vitest.config.js', 'vitest.config.ts', 'jest.config.js', 'jest.config.ts', 'jest.config.cjs']
-    .some(f => fs.existsSync(path.join(repoRoot, f)));
-  const hasPlaywrightConfig = fs.existsSync(path.join(repoRoot, 'playwright.config.js'))
-    || fs.existsSync(path.join(repoRoot, 'playwright.config.ts'));
-
-  // Detect existing test script
-  const hasTestScript = !!pkg.scripts?.test && pkg.scripts.test !== 'echo "Error: no test specified" && exit 1';
-
-  return { stack, testFw, hasPlaywright, pkgMgr, hasTestConfig, hasPlaywrightConfig, hasTestScript, pkg };
-}
-
 function getInstallPackages(stack) {
   const packages = {
     'react-vite': {
@@ -2727,7 +2691,15 @@ program
           if (!e || !e.id || !e.status) continue;
           // Map E13-A-L1 → E13-A (story id strips trailing -L<n>)
           const storyId = String(e.id).replace(/-L\d+$/i, '');
-          const yamlPath = path.join(learningsRoot, `${storyId}.yml`);
+          // HC-GF-270-followup-4: the id and the status come from the server — the id is a file name an org member
+          // uploaded — and they choose and rewrite a local file. An id that is not a story id is skipped and the
+          // path is contained; the status must be one word, because it is written into the YAML as text.
+          if (!isStoryId(storyId) || !/^[a-z][a-z_-]{0,31}$/.test(String(e.status))) {
+            console.log(`  ⚠ skipped a report entry whose id is not a story id or whose status is not one word: ${JSON.stringify({ id: e.id, status: e.status })}`);
+            skippedCount++;
+            continue;
+          }
+          const yamlPath = `${storyDirIn(learningsRoot, storyId)}.yml`;
           if (!fs.existsSync(yamlPath)) {
             console.log(`  ⚠ no local learnings file for ${storyId} — skip`);
             skippedCount++;
@@ -3890,63 +3862,6 @@ function scanForSpecs(dir, repoRoot, results) {
   } catch {}
 }
 
-function classifySpec(file, repoRoot) {
-  let content = '';
-  try { content = fs.readFileSync(file.fullPath, 'utf8'); } catch { }
-
-  const hasPage = /page\.(goto|click|locator|fill|waitFor|getBy)/.test(content);
-  const hasRequest = /request\.(get|post|put|delete|patch)\(/.test(content);
-  const hasExpectResponse = /response\.(status|json|ok|body)/.test(content) ||
-                            /expect\(resp/.test(content);
-
-  // Detect type
-  let type = 'UNKNOWN';
-  if (hasPage && (hasRequest || hasExpectResponse)) type = 'HYBRID';
-  else if (hasPage) type = 'BROWSER';
-  else if (hasRequest || hasExpectResponse) type = 'API';
-  else if (/import.*playwright|from.*@playwright/.test(content)) type = 'BROWSER';
-  else if (/import.*supertest|from.*supertest/.test(content)) type = 'API';
-
-  // Detect module from filename or content
-  // Detect module — filename takes priority over content, most specific first
-  let module = 'general';
-  const name = file.name.toLowerCase();
-  const contentLower = content.toLowerCase();
-
-  // Pass 1: check filename (strongest signal)
-  if (/auth|login|signup|oauth|session/.test(name)) module = 'auth';
-  else if (/trade|order|execution/.test(name)) module = 'trading';
-  else if (/position|portfolio|pnl|p&l/.test(name)) module = 'portfolio';
-  else if (/alert|notification/.test(name)) module = 'alerts';
-  else if (/dashboard|widget|overview/.test(name)) module = 'dashboard';
-  else if (/scanner|scan|market/.test(name)) module = 'market';
-  else if (/setting|config|preference/.test(name)) module = 'settings';
-
-  // Pass 2: fallback to content (if filename didn't match)
-  if (module === 'general') {
-    if (/login|authenticate|sign.?in/.test(contentLower)) module = 'auth';
-    else if (/trading|order|execute/.test(contentLower)) module = 'trading';
-    else if (/portfolio/.test(contentLower)) module = 'portfolio';
-    else if (/alert|notification/.test(contentLower)) module = 'alerts';
-    else if (/dashboard/.test(contentLower)) module = 'dashboard';
-    else if (/market|scanner/.test(contentLower)) module = 'market';
-  }
-
-  // Determine destination
-  let destination;
-  if (type === 'API') {
-    destination = `e2e/api/${file.name}`;
-  } else {
-    destination = `e2e/regression/${module}/${file.name}`;
-  }
-
-  // Smoke candidate: login, auth, critical navigation, app loads
-  const smoke = /login|auth|app.load|critical|smoke|health/.test(name) ||
-                /login|authenticate/.test(contentLower);
-
-  return { ...file, type, module, destination, smoke };
-}
-
 // ── Helpers ───────────────────────────────────────────────────────────────────
 function bundleDirectory(dir, root, files, maxFiles, currentCount) {
   if (currentCount >= maxFiles) return;
@@ -6172,6 +6087,8 @@ function runContextIo(apiConfig) {
     },
     recentlyModifiedOverlap: (touched) =>
       require('./lib/story-classifier-extract').extractRecentlyModifiedOverlap(cwd, touched, 14),
+    // HC-GF-217: the compound symbols the story names, searched in THIS checkout (the server has none to search).
+    callSites: (storyText) => require('./lib/call-sites').collectCallSites({ cwd, storyText }),
   };
 }
 
@@ -6737,7 +6654,7 @@ process.on('SIGINT', () => {
 program
   .command('queue-stories')
   .description('Queue a batch of stories for autonomous (overnight) execution')
-  .option('--file <path>', 'Text file with one story ID per line (cap: 50 lines, 16KB)')
+  .option('--file <path>', 'Text file with one story per line (cap: 50 lines, 16KB): STORY-ID, then optionally depends:STORY-B,STORY-C and paths:a.js,b.js (files to bundle into that story, as run-story --include-paths does)')
   .option('--repo <name>', 'Repository name applied to every story (default: directory name)')
   .option('--branch <name>', 'Git branch applied to every story (default: current branch)')
   .option('--status <batchId>', 'Show status of a previously submitted batch')
@@ -6934,11 +6851,12 @@ program
 
     // HC-059: `STORY-A depends:STORY-B,STORY-C` per line. HC-GF-140 stage 2: the parse lives in
     // cli/lib so it is asserted by BEHAVIOUR. Every line is parsed before anything is resolved.
+    // HC-GF-351: and `paths:a.js,b.js` for the files that story's context must hold.
     const lines = storyIds.map(line => {
       const parsed = parseStoryLine(line);
       if (parsed.error) {
         console.error(parsed.error);
-        console.error(`  Expected: "STORY-ID"  OR  "STORY-ID depends:STORY-B,STORY-C"`);
+        console.error(`  Expected: "STORY-ID", optionally followed by depends:STORY-B,STORY-C and/or paths:a.js,b.js`);
         process.exit(1);
       }
       return parsed;
@@ -6979,7 +6897,8 @@ program
     await Promise.all(Array.from({ length: Math.min(RESOLVE_CONCURRENCY, lines.length) }, async () => {
       while (nextLine < lines.length) {
         const i = nextLine++;
-        resolved[i] = await resolveStoryContext(rcIo, repoCtx, lines[i].storyId);
+        // HC-GF-351: a line's `paths:` is that story's --include-paths, resolved by the same code.
+        resolved[i] = await resolveStoryContext(rcIo, repoCtx, lines[i].storyId, { includePaths: lines[i].paths });
       }
     }));
     // One summary line per story, and every warning labelled with its story. The info lines
@@ -6987,7 +6906,9 @@ program
     for (const ctx of resolved) {
       const { storyId } = ctx;
       const src = ctx.textSource ? `${ctx.textSource} text (${ctx.rawText.length} chars)` : 'no story text';
-      console.log(`  [${storyId}] ${src} · ${ctx.bundle.files} codebase file(s) bundled`);
+      const cs = ctx.config.call_sites;
+      const csNote = cs ? ` · ${cs.symbols.length} symbol(s) searched for call sites${cs.symbols.some((s) => s.status !== 'complete') ? ' (not all whole)' : ''}` : '';
+      console.log(`  [${storyId}] ${src} · ${ctx.bundle.files} codebase file(s) bundled${csNote}`);
       printRunContextNotes(ctx.notes.pre, { prefix: `[${storyId}]`, only: 'warn' });
       printRunContextNotes(ctx.notes.post, { prefix: `[${storyId}]`, only: 'warn' });
     }
@@ -7290,6 +7211,8 @@ program
       const raw = execFileSync('git', ['diff', '--name-only', `${baseRef}...HEAD`], { encoding: 'utf8', cwd: repoRoot, env: gitEnv() });
       changedFiles = raw.trim().split('\n').filter(Boolean);
     } catch {
+      // HC-GF-270-followup-4: the review covers a different range from here on, so it says so.
+      console.error(`⚠ git could not diff ${baseRef}...HEAD — reviewing the last 10 commits (HEAD~10) instead`);
       try {
         const raw = execSync('git diff --name-only HEAD~10', { encoding: 'utf8', cwd: repoRoot, env: gitEnv() });
         changedFiles = raw.trim().split('\n').filter(Boolean);
@@ -7355,10 +7278,13 @@ program
     try {
       // HC-GF-270-followup-3: each changed file is ONE argument after `--`. They were wrapped in single quotes
       // inside a shell string, so a file a PR author named with a `'` in it ran as a command.
-      diffContent = execFileSync('git', ['diff', `${baseRef}...HEAD`, '--', ...filesToReview], {
+      // HC-GF-270-followup-4: and each is read as a literal path. Without --literal-pathspecs a file named `*.js`
+      // matched every .js file, and one named `:(evil)x.js` made git exit, which fell back to HEAD~10 silently.
+      diffContent = execFileSync('git', ['--literal-pathspecs', 'diff', `${baseRef}...HEAD`, '--', ...filesToReview], {
         encoding: 'utf8', cwd: repoRoot, env: gitEnv(), maxBuffer: 10 * 1024 * 1024,
       });
     } catch {
+      console.error(`⚠ git could not diff the changed files against ${baseRef} — reviewing the last 10 commits (HEAD~10) instead`);
       try {
         diffContent = execSync('git diff HEAD~10', { encoding: 'utf8', cwd: repoRoot, env: gitEnv(), maxBuffer: 10 * 1024 * 1024 });
       } catch (e) {
@@ -8432,10 +8358,11 @@ program
 // The server cannot execute, so a batch queued at night reached step_4 and waited for a person to type
 // check-patch, verify-patch and emit-pr. This is the I/O around cli/lib/batch-follow.js, which makes every
 // decision. The verbs run as children of THIS CLI, one at a time, so the loop runs exactly what a person runs.
-// Exit: 0 the batch completed, 1 fatal (refused, unknown batch, unreachable), 2 something needs you, 3 deadline.
+// Exit: 0 the batch completed, 1 fatal (refused, unknown batch, unreachable), 2 something needs you (HC-GF-351: or every
+// unfinished run is waiting on a person, named with its step and why), 3 deadline.
 program
   .command('follow-batch <batchId>')
-  .description('Follow a queued batch: check and verify each step_4 patch, and emit each completed run (HC-GF-098)')
+  .description('Follow a queued batch: check and verify each step_4 patch, and emit each completed run (HC-GF-098). A run hard-paused for files it was not given is re-served once with them (HC-GF-351); every pause it cannot act on is named, and it exits 2 when only people are left to act')
   .option('--poll-interval <sec>', 'Seconds between polls', '30')
   .option('--deadline <min>', 'Stop after this many minutes, even if the batch is still running')
   .option('--max-offline <min>', 'Give up once the server has been unreachable this long', '15')
@@ -8450,7 +8377,7 @@ program
       console.error(badBatch);
       process.exit(EXIT.FATAL);
     }
-    const { spawn, spawnSync } = require('child_process');
+    const { spawn, spawnSync, execFileSync } = require('child_process');
     const positive = (raw, flag, unit) => {
       const n = Number(raw);
       if (!Number.isFinite(n) || n <= 0) {
@@ -8481,12 +8408,42 @@ program
     const io = {
       fetchBatch: async (id) => (await client.get(orchestratePath(['batch', id]))).data,
       fetchRun: async (id) => (await client.get(orchestratePath([id]))).data,
-      runVerb: (argv) => new Promise((resolve) => {
+      // `capture` also returns the child's stdout (the tail of it), for the one verb whose answer the loop reads
+      // (queue-stories, HC-GF-351). Either way the child's output reaches this process's own stdout.
+      runVerb: (argv, { capture = false } = {}) => new Promise((resolve) => {
         const child = spawn(process.execPath, [process.argv[1], ...argv],
-          { cwd: process.cwd(), env: process.env, stdio: ['ignore', 'inherit', 'inherit'] });
-        child.on('error', (e) => resolve({ code: null, error: e }));
-        child.on('close', (code) => resolve({ code }));
+          { cwd: process.cwd(), env: process.env, stdio: ['ignore', capture ? 'pipe' : 'inherit', 'inherit'] });
+        let stdout = '';
+        if (capture) child.stdout.on('data', (d) => { process.stdout.write(d); stdout = (stdout + d).slice(-262144); });
+        child.on('error', (e) => resolve({ code: null, error: e, stdout }));
+        child.on('close', (code) => resolve({ code, stdout }));
       }),
+      // HC-GF-351: what a re-serve needs. The regular files git tracks in THIS checkout, listed with their modes so
+      // a tracked symlink (which the bundler would follow out of the checkout) is not among them. Run where the
+      // bundler runs, so the paths are the ones it resolves.
+      trackedPaths: () => require('./lib/context-reserve').trackedRegularFiles(execFileSync('git', ['ls-files', '-z', '-s'], {
+        cwd: process.cwd(), env: gitEnv(), encoding: 'utf8', maxBuffer: 64 * 1024 * 1024, stdio: ['ignore', 'pipe', 'ignore'], timeout: 60_000,
+      })),
+      // Where a requested path resolves on the disk NOW, relative to this checkout, or null: the index cannot see a
+      // file or a directory that was replaced by a symlink after the commit, and the bundler reads through it.
+      realPath: (rel) => require('./lib/context-reserve').repoRealPath(process.cwd(), rel),
+      // Was this story served already? A kill that failed, or a crash between the queue and the kill, leaves no marker
+      // and only a newer run of the same story, so the server's own run list is asked (GET /orchestrate?storyId=&repoName=).
+      priorServe: (action) => require('./lib/context-reserve').findServe({
+        listRuns: async (storyId, repo) => (await client.get(apiPath('orchestrate', [], { storyId, repoName: repo, limit: 100 }))).data.runs,
+        listBatches: async () => (await client.get(orchestratePath(['batch'], { limit: 20 }))).data.batches,
+        fetchBatch: async (id) => (await client.get(orchestratePath(['batch', id]))).data,
+      }, action),
+      // One line, in a directory only this invocation can read, for `queue-stories --file`.
+      writeStoriesFile: (text) => {
+        const t = require('./lib/private-temp').privateTempFile('hone-reserve', 'stories.txt');
+        fs.writeFileSync(t.file, text, { mode: 0o600 });
+        return t;
+      },
+      killRun: async (runId, reason) => {
+        if (!require('./lib/run-target').isRunId(runId)) throw new Error('not a run id');
+        await client.post(orchestratePath([runId, 'kill']), { reason });
+      },
       // The consent and provenance rule run-story applies before it runs a patch (HC-GF-064, HC-GF-270).
       verifyDecision: (run) => {
         let assessment;