@hominis/fireforge 0.55.0 → 0.60.0

package/dist/src/core/patch-lint-checkjs.js

@@ -1,563 +0,0 @@
-// SPDX-License-Identifier: EUPL-1.2
-/**
- * Optional TypeScript `checkJs` pass for patch-owned `.sys.mjs` files.
- *
- * Loads the TypeScript compiler API via dynamic import so it is only
- * required when `patchLint.checkJs` is enabled in `fireforge.json`.
- * TypeScript remains a dev-dependency. If a user enables checkJs
- * without installing it, the pass emits a clear error explaining
- * how to fix it.
- *
- * Separated from `patch-lint.ts` to keep both files within the
- * project's per-file line budget. The shim itself and the suppressed
- * diagnostic code list live in `typecheck-shim.ts` and are shared
- * with the whole-project `fireforge typecheck` command, keeping a
- * single source of truth for the Firefox-globals coverage.
- * `patchLint.checkJsStrict` only tightens `strict` / `noImplicitAny`
- * and optional allowlisted `checkJsCompilerOptions`. It does not change
- * shim composition or suppressed diagnostic codes.
- *
- * Resolution scope vs reporting scope: the TS program is built over a
- * *resolution* set (every patch-owned `.sys.mjs` the run cares about, so
- * cross-patch `resource:///` imports resolve to their real sources), while
- * diagnostics are emitted only for files in the *report* scope. Splitting
- * the two lets per-patch lint build one queue-wide program and attribute
- * findings per patch, and lets export/re-export resolve cross-patch imports
- * while reporting only the patch under export.
- */
-import { resolve } from 'node:path';
-import { toError } from '../utils/errors.js';
-import { pathExists } from '../utils/fs.js';
-import { verbose } from '../utils/logger.js';
-import { normalizePathSlashes } from '../utils/paths.js';
-import { withGeckoDomTypes } from './gecko-dom-types.js';
-import { anyTypedImportHint, createModuleLiteralResolver, isAnyTypedMemberReference, } from './patch-lint-checkjs-any-import.js';
-import { withSharedSourceFiles } from './patch-lint-checkjs-cache.js';
-import { collectCheckJsDiagnostics } from './patch-lint-checkjs-diagnostics.js';
-import { createOwnedPathMatcher, pathsTargetCandidates } from './patch-lint-checkjs-resolve.js';
-import { collectUnmanagedCompanions, retargetUnmanagedCompanionHints, } from './patch-lint-unmanaged-companion.js';
-import { composeShimSource, SHIM_FILENAME, SUPPRESSED_DIAGNOSTIC_CODES, TEST_HARNESS_SHIM, UNDEFINED_IDENTIFIER_CODES, UNDEFINED_IDENTIFIER_HINT, } from './typecheck-shim.js';
-// ---------------------------------------------------------------------------
-// Public API
-// ---------------------------------------------------------------------------
-/**
- * Converts a native path into the form TypeScript uses for `fileName`.
- *
- * TypeScript normalizes every path it hands a `CompilerHost` to forward
- * slashes on all platforms, while `resolve()` here yields the platform
- * separator. On Windows that mismatch made every `ownedAbsolute.has(fileName)`
- * and `relByAbsolute.get(fileName)` lookup miss, so the host served an empty
- * source file for each owned file and the whole pass reported zero findings.
- * It did so silently, because "no diagnostics" is indistinguishable from
- * "clean code".
- * Every path that crosses the TS boundary goes through here.
- */
-function toTsPath(path) {
-    return normalizePathSlashes(path);
-}
-/**
- * Builds the host-side module resolver for the checkJs pass: maps an import
- * specifier to a patch-owned absolute path (see `createOwnedPathMatcher`).
- */
-function createOwnedSpecifierResolver(ts, ownedAbsolute) {
-    const match = createOwnedPathMatcher(ownedAbsolute);
-    return (specifier) => {
-        const resolvedFileName = match(specifier);
-        if (resolvedFileName === undefined)
-            return undefined;
-        return { resolvedFileName, extension: ts.Extension.Mjs, isExternalLibraryImport: false };
-    };
-}
-/** Maps a resolved file path to the TS extension enum the host must report. */
-function extensionForFile(ts, file) {
-    if (file.endsWith('.d.ts'))
-        return ts.Extension.Dts;
-    if (file.endsWith('.ts'))
-        return ts.Extension.Ts;
-    if (file.endsWith('.tsx'))
-        return ts.Extension.Tsx;
-    if (file.endsWith('.cjs'))
-        return ts.Extension.Cjs;
-    if (file.endsWith('.jsx'))
-        return ts.Extension.Jsx;
-    if (file.endsWith('.json'))
-        return ts.Extension.Json;
-    return ts.Extension.Mjs;
-}
-/**
- * Builds a resolver for a reviewed `paths` mapping (route 2 of the
- * cross-patch resolution work). Each pattern may contain a single `*`.
- * Matching targets are resolved relative to `baseDir` (the engine dir, like
- * the rest of `patchLint` which is engine-relative). Resolved files are
- * recorded via `onResolved` so the compiler host knows to read them from
- * disk rather than returning empty content. No `baseUrl` is set, so this is
- * TS5090-safe: `paths` resolution is host-driven here, not config-driven.
- */
-function createPathsResolver(ts, paths, baseDir, fileExists, onResolved) {
-    return (specifier) => {
-        for (const rel of pathsTargetCandidates(paths, specifier)) {
-            const abs = toTsPath(resolve(baseDir, rel));
-            if (!fileExists(abs))
-                continue;
-            onResolved(abs);
-            return {
-                resolvedFileName: abs,
-                extension: extensionForFile(ts, abs),
-                isExternalLibraryImport: false,
-            };
-        }
-        return undefined;
-    };
-}
-/**
- * Builds the checkJs program once over `resolutionOwned` and returns its
- * diagnostics grouped by originating file. Callers slice the result by their
- * own report scope: per-patch lint attributes each file to its owning patch,
- * export/re-export keeps only the patch under export. Resolution always spans
- * every file in `resolutionOwned`, so cross-patch `resource:///`/`chrome://`
- * imports resolve to real sources.
- *
- * @param input - Program inputs. See {@link RunCheckJsGroupedInput}
- * @returns Diagnostics grouped per owning file plus run-level errors
- */
-export async function runCheckJsGrouped(input) {
-    const { repoDir, resolutionOwned, extraShimPath, rootScope } = input;
-    const empty = { byFile: new Map(), global: [] };
-    if (resolutionOwned.size === 0)
-        return empty;
-    // Dynamic import: typescript stays as a dev dependency
-    let ts;
-    try {
-        ts = await import('typescript');
-    }
-    catch {
-        return {
-            byFile: new Map(),
-            global: [
-                {
-                    file: '(checkJs)',
-                    check: 'checkjs-type-error',
-                    message: 'patchLint.checkJs is enabled but the "typescript" package is not installed. ' +
-                        'Run "npm install typescript" to enable type checking.',
-                    severity: 'error',
-                },
-            ],
-        };
-    }
-    // Resolve absolute paths for root files, filtering to files that exist.
-    // Under a rootScope, non-scoped owned files stay resolvable (host
-    // allowlist + relByAbsolute) but are not program roots. They are only
-    // parsed if a scoped root's import closure reaches them.
-    const rootFiles = [];
-    const ownedAbsolute = new Set();
-    const relByAbsolute = new Map();
-    for (const rel of resolutionOwned) {
-        const abs = toTsPath(resolve(repoDir, rel));
-        if (await pathExists(abs)) {
-            if (rootScope === undefined || rootScope.has(rel))
-                rootFiles.push(abs);
-            ownedAbsolute.add(abs);
-            relByAbsolute.set(abs, rel);
-        }
-    }
-    if (rootFiles.length === 0)
-        return empty;
-    // Compose the shim. `extraShimPath` is project-relative (validated
-    // by config-validate). Resolve it against `projectRoot`. When the
-    // caller passes neither, fall back to `repoDir`. The only way the
-    // shim path is ever read in that case is when extraShimPath is
-    // also undefined, so the resolution target is irrelevant.
-    let shimSource;
-    try {
-        const composed = await composeShimSource(input.projectRoot ?? repoDir, extraShimPath, {
-            litTypes: input.mode?.litTypes,
-        });
-        // The suffix (e.g. the loose test-harness baseline) goes
-        // after the consumer's extra shim: TypeScript resolves conflicting
-        // `declare var` redeclarations to the first declaration, so a typed
-        // consumer declaration must precede the loose fallback to win.
-        shimSource = input.builtinShimSuffix
-            ? `${composed.source}\n${input.builtinShimSuffix}`
-            : composed.source;
-        if (composed.extraShimAppended) {
-            verbose(`checkJs: extra shim ${extraShimPath ?? ''} appended to Firefox globals shim`);
-        }
-    }
-    catch (err) {
-        return {
-            byFile: new Map(),
-            global: [
-                {
-                    file: extraShimPath ?? '(checkJs)',
-                    check: 'checkjs-type-error',
-                    message: toError(err).message,
-                    severity: 'error',
-                },
-            ],
-        };
-    }
-    const shimPath = toTsPath(resolve(repoDir, SHIM_FILENAME));
-    rootFiles.push(shimPath);
-    // Loose default: implicit `any` is allowed unless `patchLint.checkJsStrict`.
-    const strict = input.mode?.strict === true;
-    const strictness = { strict, noImplicitAny: strict };
-    // Allowlisted overrides. Booleans merge directly. A reviewed `paths`
-    // mapping is applied to the compiler options and wired into the host
-    // resolver below so patch-owned modules can be typed from their real
-    // sources without a hand-generated ambient stub shim.
-    const overrides = {};
-    let pathsMapping;
-    const co = input.mode?.compilerOptions;
-    if (co) {
-        for (const key of Object.keys(co)) {
-            const v = co[key];
-            if (v === undefined)
-                continue;
-            if (key === 'paths') {
-                pathsMapping = v;
-                overrides.paths = pathsMapping;
-            }
-            else {
-                overrides[key] = v;
-            }
-        }
-    }
-    const options = {
-        allowJs: true,
-        checkJs: true,
-        noEmit: true,
-        target: ts.ScriptTarget.ESNext,
-        module: ts.ModuleKind.ESNext,
-        moduleResolution: ts.ModuleResolutionKind.Bundler,
-        skipLibCheck: true,
-        // Module resolution is host-controlled (see resolveOwnedSpecifier
-        // below): imports that match a patch-owned file resolve to the real
-        // source so JSDoc type-guard predicates and @template generics
-        // survive the module boundary. Everything else is left to fail
-        // resolution, falling back to the chrome:*/resource:* ambient
-        // wildcards plus the suppressed "cannot find module" codes. The
-        // host resolver is authoritative: TS never crawls the Firefox
-        // tree looking for upstream modules.
-        ...strictness,
-        ...overrides,
-    };
-    const resolveOwnedSpecifier = createOwnedSpecifierResolver(ts, ownedAbsolute);
-    // URL imports this program cannot resolve, per importing file (see
-    // patch-lint-checkjs-any-import.ts).
-    const anyTypedImports = new Map();
-    // Custom compiler host: reads patch-owned files from disk, returns
-    // the shim for the shim path, and returns empty content for
-    // anything else to avoid reading the full Firefox tree.
-    const defaultHost = withGeckoDomTypes(ts, ts.createCompilerHost(options));
-    // Files pulled in via a reviewed `paths` mapping: outside the owned set
-    // but read from disk so the resolver's targets actually type-check.
-    const pathsResolved = new Set();
-    const resolveViaPaths = pathsMapping
-        ? createPathsResolver(ts, pathsMapping, repoDir, (f) => defaultHost.fileExists(f), (abs) => pathsResolved.add(abs))
-        : undefined;
-    const host = {
-        ...defaultHost,
-        getSourceFile(fileName, languageVersion, onError) {
-            if (fileName === shimPath) {
-                return ts.createSourceFile(fileName, shimSource, languageVersion, true);
-            }
-            if (ownedAbsolute.has(fileName) || pathsResolved.has(fileName)) {
-                return defaultHost.getSourceFile(fileName, languageVersion, onError);
-            }
-            // For lib files (lib.es*.d.ts) delegate to the default host
-            // so built-in types like Promise, Array, etc. are available.
-            if (fileName.includes('lib.') && fileName.endsWith('.d.ts')) {
-                return defaultHost.getSourceFile(fileName, languageVersion, onError);
-            }
-            // Return an empty source file for anything else to avoid
-            // reading unrelated Firefox source files.
-            return ts.createSourceFile(fileName, '', languageVersion, true);
-        },
-        fileExists(fileName) {
-            if (fileName === shimPath)
-                return true;
-            if (ownedAbsolute.has(fileName) || pathsResolved.has(fileName))
-                return true;
-            return defaultHost.fileExists(fileName);
-        },
-        readFile(fileName) {
-            if (fileName === shimPath)
-                return shimSource;
-            return defaultHost.readFile(fileName);
-        },
-        resolveModuleNameLiterals: createModuleLiteralResolver(resolveOwnedSpecifier, resolveViaPaths, anyTypedImports),
-    };
-    const program = ts.createProgram(rootFiles, options, withSharedSourceFiles(host, input.sourceFileCache, shimPath, shimSource));
-    const byFile = groupOwnedDiagnostics(ts, collectCheckJsDiagnostics(program, relByAbsolute, input.reportOnly), relByAbsolute, input.mode?.undefinedIdentifiers ?? 'warning', anyTypedImports);
-    verbose(`checkJs: analyzed ${rootFiles.length - 1} file(s) across ${byFile.size} owning file(s)`);
-    return { byFile, global: [] };
-}
-/**
- * Groups TS diagnostics by the patch-owned file they originate in,
- * suppressing module-resolution / unknown-name noise inherent to checking
- * Firefox JS outside Mozilla's build system, and a type-member reference
- * through an unresolved URL import (see `isAnyTypedMemberReference`).
- * Diagnostics from `paths`-resolved
- * or shim files are dropped. Only owned files (in `relByAbsolute`) carry
- * findings.
- */
-function groupOwnedDiagnostics(ts, diagnostics, relByAbsolute, undefinedIdentifiers = 'warning', anyTypedImports = new Map()) {
-    const byFile = new Map();
-    for (const diag of diagnostics) {
-        if (SUPPRESSED_DIAGNOSTIC_CODES.has(diag.code))
-            continue;
-        const isUndefinedIdentifier = UNDEFINED_IDENTIFIER_CODES.has(diag.code);
-        if (isUndefinedIdentifier && undefinedIdentifiers === 'off')
-            continue;
-        const sourceFile = diag.file;
-        if (!sourceFile)
-            continue;
-        const relPath = relByAbsolute.get(sourceFile.fileName);
-        if (relPath === undefined)
-            continue;
-        const messageText = typeof diag.messageText === 'string'
-            ? diag.messageText
-            : ts.flattenDiagnosticMessageText(diag.messageText, '\n');
-        const anyTyped = anyTypedImports.get(sourceFile.fileName);
-        if (isAnyTypedMemberReference(diag.code, messageText, anyTyped))
-            continue;
-        const line = sourceFile.getLineAndCharacterOfPosition(diag.start ?? 0).line + 1;
-        const severity = isUndefinedIdentifier
-            ? undefinedIdentifiers === 'error'
-                ? 'error'
-                : 'warning'
-            : diag.category === ts.DiagnosticCategory.Error
-                ? 'error'
-                : 'warning';
-        const bucket = byFile.get(relPath) ?? [];
-        bucket.push({
-            file: relPath,
-            check: 'checkjs-type-error',
-            message: isUndefinedIdentifier
-                ? `Line ${line}: ${messageText} ${UNDEFINED_IDENTIFIER_HINT}`
-                : `Line ${line}: ${messageText}${anyTypedImportHint(diag.code, anyTyped)}`,
-            severity,
-        });
-        byFile.set(relPath, bucket);
-    }
-    return byFile;
-}
-/**
- * Flattens a {@link runCheckJsGrouped} run into a single issue list. When
- * `reportScope` is supplied, only diagnostics from files in that set are
- * returned (resolution still spans every owned file). Omitting it reports
- * every owned file's diagnostics, the historical whole-set behaviour.
- *
- * @param repoDir - Absolute engine (repository) directory
- * @param patchOwnedFiles - Patch-owned `.sys.mjs` paths to resolve against
- * @param extraShimPath - Optional project-relative extra `.d.ts`
- * @param projectRoot - Absolute project root for resolving `extraShimPath`
- * @param mode - Strictness preset plus allowlisted compiler-option overrides
- * @param reportScope - When set, restrict reported diagnostics to these
- *   repo-relative files
- * @returns Array of lint issues from TS diagnostics
- */
-export async function runCheckJs(repoDir, patchOwnedFiles, extraShimPath, projectRoot, mode, reportScope) {
-    const { byFile, global } = await runCheckJsGrouped({
-        repoDir,
-        resolutionOwned: patchOwnedFiles,
-        ...(extraShimPath !== undefined ? { extraShimPath } : {}),
-        ...(projectRoot !== undefined ? { projectRoot } : {}),
-        ...(mode !== undefined ? { mode } : {}),
-    });
-    const issues = [...global];
-    for (const [rel, list] of byFile) {
-        if (reportScope && !reportScope.has(rel))
-            continue;
-        issues.push(...list);
-    }
-    return issues;
-}
-/**
- * Invokes {@link runCheckJs} for a `patchLint` block with `checkJs: true`.
- * `projectRoot` is the FireForge project root (`dirname(engine)`).
- *
- * @param repoDir - Absolute engine (repository) directory
- * @param patchOwnedFiles - Patch-owned `.sys.mjs` paths to resolve against
- * @param patchLint - The resolved `patchLint` config block
- * @param projectRoot - FireForge project root for shim resolution
- * @param reportScope - Optional repo-relative files to report on (export /
- *   re-export passes the patch under export so cross-patch resolution does
- *   not surface other patches' diagnostics)
- */
-export async function invokePatchLintCheckJs(repoDir, patchOwnedFiles, patchLint, projectRoot, reportScope) {
-    return runCheckJs(repoDir, patchOwnedFiles, patchLint.checkJsExtraShim, projectRoot, modeFromPatchLintConfig(patchLint), reportScope);
-}
-/**
- * Runs the checkJs pass over patch-owned test `.js` files (
- * `patchLint.checkJsTestFiles`). Each test file gets its own small
- * program, with roots = the test file plus any same-directory patch-owned
- * `head*.js`, checked against the built-in Firefox shim +
- * {@link TEST_HARNESS_SHIM} + the optional consumer `checkJsTestShim`.
- * Mochitest scripts share top-level scope only with their directory's
- * `head*.js` helpers, so one multi-script program would emit false
- * cross-file redeclaration errors. Only the target file's diagnostics are
- * reported per program (head helpers report from their own program), and
- * run-level errors are de-duplicated across programs.
- *
- * With `resolvableModules`, a test's `resource:///` and `chrome://`
- * imports also resolve to the modules it returns for that test (the
- * modules the queue creates up to the test's own patch), so a test that
- * imports an earlier patch's module is typed against its real source
- * instead of the shim's `any` wildcard. Those modules are resolution
- * targets only: never roots, and never reported on.
- *
- * @param repoDir - Absolute engine (repository) directory
- * @param testFiles - Patch-owned test-script paths (repo-relative)
- * @param patchLint - The resolved `patchLint` config block
- * @param projectRoot - FireForge project root for shim resolution
- */
-export async function runCheckJsTestFilesGrouped(repoDir, testFiles, patchLint, projectRoot, rootScope, resolvableModules) {
-    const merged = { byFile: new Map(), global: [] };
-    if (testFiles.size === 0)
-        return merged;
-    const mode = modeFromPatchLintConfig(patchLint);
-    const seenGlobal = new Set();
-    const files = [...testFiles].sort((a, b) => a.localeCompare(b));
-    // Every test program below shares options and shim, and mostly the same
-    // files: TypeScript's lib declarations, the shim, and the directory's
-    // head.js helpers. Parsing them once instead of once per test file took
-    // a 467-test queue's pass from 66 s to a fraction of that.
-    const sourceFileCache = new Map();
-    const companions = await collectUnmanagedCompanions(repoDir, files, testFiles);
-    for (const file of files) {
-        // Under a rootScope only the scoped files get their own program, but
-        // head.js helper discovery still spans the full owned set so a scoped
-        // test keeps its cross-patch harness globals.
-        if (rootScope !== undefined && !rootScope.has(file))
-            continue;
-        const dir = file.slice(0, file.lastIndexOf('/') + 1);
-        const roots = new Set([file]);
-        for (const candidate of files) {
-            if (candidate === file)
-                continue;
-            const base = candidate.split('/').pop() ?? '';
-            if (candidate.startsWith(dir) && /^head(?:_.*)?\.js$/.test(base)) {
-                roots.add(candidate);
-            }
-        }
-        const result = await runCheckJsGrouped({
-            repoDir,
-            resolutionOwned: new Set([...roots, ...(resolvableModules?.(file) ?? [])]),
-            rootScope: roots,
-            reportOnly: new Set([file]),
-            ...(patchLint.checkJsTestShim !== undefined
-                ? { extraShimPath: patchLint.checkJsTestShim }
-                : {}),
-            projectRoot,
-            mode,
-            builtinShimSuffix: TEST_HARNESS_SHIM,
-            sourceFileCache,
-        });
-        const own = result.byFile.get(file);
-        if (own && own.length > 0) {
-            merged.byFile.set(file, [
-                ...(merged.byFile.get(file) ?? []),
-                ...retargetUnmanagedCompanionHints(own, companions),
-            ]);
-        }
-        for (const globalIssue of result.global) {
-            if (seenGlobal.has(globalIssue.message))
-                continue;
-            seenGlobal.add(globalIssue.message);
-            merged.global.push(globalIssue);
-        }
-    }
-    return merged;
-}
-/** Derives the {@link CheckJsMode} from a `patchLint` config block. */
-function modeFromPatchLintConfig(patchLint) {
-    const strict = patchLint.checkJsStrict === true;
-    return {
-        strict,
-        ...(strict && patchLint.checkJsCompilerOptions
-            ? { compilerOptions: patchLint.checkJsCompilerOptions }
-            : {}),
-        ...(patchLint.undefinedIdentifiers !== undefined
-            ? { undefinedIdentifiers: patchLint.undefinedIdentifiers }
-            : {}),
-        ...(patchLint.litTypes === true ? { litTypes: true } : {}),
-    };
-}
-/**
- * Grouped variant of {@link invokePatchLintCheckJs}: builds one queue-wide
- * checkJs program over `patchOwnedFiles` and returns its findings grouped by
- * owning file. The per-patch lint orchestrator calls this once per run
- * and attributes each file's findings to its owning patch, instead of
- * rebuilding the same program for every patch in the queue.
- *
- * @param repoDir - Absolute engine (repository) directory
- * @param patchOwnedFiles - Every patch-owned `.sys.mjs` in the queue
- * @param patchLint - The resolved `patchLint` config block
- * @param projectRoot - FireForge project root for shim resolution
- * @param rootScope - Optional subset of files to use as program roots
- * (`--patches`). Resolution still spans the whole queue
- */
-export async function invokePatchLintCheckJsGrouped(repoDir, patchOwnedFiles, patchLint, projectRoot, rootScope) {
-    return runCheckJsGrouped({
-        repoDir,
-        resolutionOwned: patchOwnedFiles,
-        ...(patchLint.checkJsExtraShim !== undefined
-            ? { extraShimPath: patchLint.checkJsExtraShim }
-            : {}),
-        projectRoot,
-        mode: modeFromPatchLintConfig(patchLint),
-        ...(rootScope !== undefined ? { rootScope } : {}),
-    });
-}
-/**
- * Cheap probe reproducing the only run-level ("global") checkJs findings the
- * build path can produce: a missing `typescript` package and an unreadable
- * consumer shim (`checkJsExtraShim`, and `checkJsTestShim` when
- * `checkJsTestFiles` is on). The built program itself never contributes
- * globals (see {@link runCheckJsGrouped}), so a warm all-cache-hit run can
- * satisfy the "warm never reports less than cold" invariant with this probe
- * instead of building the whole TypeScript program. Issue objects are
- * byte-identical to the build path's, deduplicated by message like
- * {@link runCheckJsTestFilesGrouped}.
- */
-export async function probeCheckJsGlobalIssues(patchLint, projectRoot) {
-    try {
-        await import('typescript');
-    }
-    catch {
-        return [
-            {
-                file: '(checkJs)',
-                check: 'checkjs-type-error',
-                message: 'patchLint.checkJs is enabled but the "typescript" package is not installed. ' +
-                    'Run "npm install typescript" to enable type checking.',
-                severity: 'error',
-            },
-        ];
-    }
-    const issues = [];
-    const seen = new Set();
-    const probeShim = async (shimPath) => {
-        try {
-            await composeShimSource(projectRoot, shimPath);
-        }
-        catch (err) {
-            const message = toError(err).message;
-            if (seen.has(message))
-                return;
-            seen.add(message);
-            issues.push({
-                file: shimPath ?? '(checkJs)',
-                check: 'checkjs-type-error',
-                message,
-                severity: 'error',
-            });
-        }
-    };
-    await probeShim(patchLint.checkJsExtraShim);
-    if (patchLint.checkJsTestFiles === true) {
-        await probeShim(patchLint.checkJsTestShim);
-    }
-    return issues;
-}

package/dist/src/core/patch-lint-chrome-jsdoc.d.ts

@@ -1,43 +0,0 @@
-/**
- * AST-based JSDoc validation for top-level declarations in patch-owned
- * chrome subscripts (`browser/base/content/<binaryName>*.js` and similar
- * `.js` files loaded via `Services.scriptloader.loadSubScript`).
- *
- * Why a separate module from {@link ./patch-lint-jsdoc.ts}: chrome
- * subscripts are not ES modules. They are parsed as scripts (no static
- * `export`) and their top-level `class`/`function` declarations are
- * exposed to the loading window as globals rather than declared exports.
- * The export-walker in `patch-lint-jsdoc.ts` would never visit them.
- *
- * The rule shape is identical to the `.sys.mjs` rule once you remove the
- * `export` framing: every top-level class needs a JSDoc, every method
- * needs one when `chromeScriptJsDoc` is at `warning`/`error`, and every
- * top-level function needs a matching @param/@returns block. So the
- * per-declaration validators are reused verbatim from the export module.
- */
-import type { PatchLintIssue } from '../types/commands/index.js';
-import type { PatchLintSeverityGate } from '../types/config.js';
-import type { JsDocIssue, ValidateExportJsDocOptions } from './patch-lint-jsdoc.js';
-/**
- * Validates JSDoc on top-level declarations in a chrome-subscript `.js`
- * source file. A parse failure returns an empty issue list. Chrome
- * subscripts that use module-only syntax (rare) silently disable the
- * rule rather than emitting confusing parse-error issues.
- *
- * @param source - File content
- * @param options - Optional gates (e.g. class-method JSDoc severity).
- *   `classMethodMode` defaults to `'off'`. The orchestrator passes the
- *   `chromeScriptJsDoc` severity here so a single knob controls both
- *   class-level and method-level enforcement.
- * @returns Array of JSDoc issues found
- */
-export declare function validateChromeScriptJsDoc(source: string, options?: ValidateExportJsDocOptions): JsDocIssue[];
-/**
- * Per-file dispatch: applies the chrome-subscript JSDoc rule to one file if
- * it qualifies, mapping {@link JsDocIssue} into {@link PatchLintIssue}.
- * Returns an empty array when the file does not qualify (not a chrome
- * subscript, not patch-owned, or the mode is `'off'` / unset). The
- * orchestrator pre-computes `isChromeOwned` (true iff the file is a
- * patch-owned `.js` non-`.sys.mjs`) so the call site fits on a single line.
- */
-export declare function lintChromeScriptJsDocForFile(file: string, content: string, isChromeOwned: boolean, mode: PatchLintSeverityGate | undefined): PatchLintIssue[];