@hominis/fireforge 0.49.0 → 0.49.2

package/CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Furnace and builds
 
 - Safer Furnace deployment and objdir cloning protect component sources and peer checkouts from shared files and directory aliases. Failed copies finish before rollback; cloned build metadata is relocated and verified.
+- `furnace create --localized` no longer scaffolds a `connectedCallback`/`disconnectedCallback` pair that calls `l10n.connectRoot(shadowRoot)` and `disconnectRoot`. `MozLitElement` already registers its shadow render root with `document.l10n`, so the generated pair registered the same root twice, which `DOMLocalization::ConnectRoot` asserts against in debug builds. The scaffold keeps the module-level `window.MozXULElement?.insertFTLIfNeeded(...)` call.
 - Build and test preflight detect broken partial configuration, stale artifacts and invalid build baselines. Scoped builds retain coverage only while their inputs remain unchanged, and builds remove dangling test links.
 
 ### Test harness
@@ -28,6 +29,7 @@
 ### Tooling
 
 - Full-Firefox integration preserves existing workspace files and Git index state, and fails on incomplete recovery. Build identity includes untracked contents and binary changes. Release checks enforce the pinned toolchain and additional module coverage floors.
+- Dev tooling: `eslint-plugin-jsdoc` 65.0.1 and `@types/node` 26.6.4. Transitive `source-map-js` 1.2.2 (GHSA-68fv-2mgg-jv7q) and `smol-toml` 1.9.0 (GHSA-r4xh-jqrq-34v2) clear `npm audit`.
 
 ## 0.48.0
 

package/dist/build-info.json

@@ -1,9 +1,9 @@
 {
   "schemaVersion": 1,
-  "version": "0.49.0",
-  "commit": "09dd0a82fdad367fb2390b4311f785a975995acd",
-  "shortCommit": "09dd0a82fdad",
+  "version": "0.49.2",
+  "commit": "c707978869b62aba07d1e8f0955be00c223d5ce0",
+  "shortCommit": "c707978869b6",
   "dirty": false,
   "dirtyHash": null,
-  "buildTime": "2026-10-04T08:17:58.923Z"
+  "buildTime": "2026-10-06T21:50:15.508Z"
 }

package/dist/src/commands/furnace/create-templates.d.ts

@@ -26,9 +26,14 @@ export interface GenerateMjsContentOptions {
  * `MozXULElement`. Calling it from `connectedCallback` on a Lit-based
  * component throws `TypeError: this.insertFTLIfNeeded is not a function` at
  * every connect. Upstream Firefox components (e.g. `moz-input-folder.mjs`)
- * solve this with a module-level guarded call on `window.MozXULElement` and
- * per-instance shadow-DOM Fluent attachment via `l10n.connectRoot`. We mirror
- * that pattern here so `--localized` produces functional code.
+ * solve this with a module-level guarded call on `window.MozXULElement`, and
+ * the template mirrors that call so `--localized` produces functional code.
+ *
+ * The template emits no `connectedCallback`/`disconnectedCallback` pair for
+ * Fluent. `MozLitElement` already connects its shadow render root to
+ * `document.l10n` on connect and disconnects it on disconnect, so a second
+ * `l10n.connectRoot(shadowRoot)` registers the same root twice, which
+ * `DOMLocalization::ConnectRoot` asserts against in debug builds.
  *
  * Path resolution precedence (when `localized` is true):
  *   1. `sharedFtl`: used verbatim. The caller has resolved it from

package/dist/src/commands/furnace/create-templates.js

@@ -11,9 +11,14 @@
  * `MozXULElement`. Calling it from `connectedCallback` on a Lit-based
  * component throws `TypeError: this.insertFTLIfNeeded is not a function` at
  * every connect. Upstream Firefox components (e.g. `moz-input-folder.mjs`)
- * solve this with a module-level guarded call on `window.MozXULElement` and
- * per-instance shadow-DOM Fluent attachment via `l10n.connectRoot`. We mirror
- * that pattern here so `--localized` produces functional code.
+ * solve this with a module-level guarded call on `window.MozXULElement`, and
+ * the template mirrors that call so `--localized` produces functional code.
+ *
+ * The template emits no `connectedCallback`/`disconnectedCallback` pair for
+ * Fluent. `MozLitElement` already connects its shadow render root to
+ * `document.l10n` on connect and disconnects it on disconnect, so a second
+ * `l10n.connectRoot(shadowRoot)` registers the same root twice, which
+ * `DOMLocalization::ConnectRoot` asserts against in debug builds.
  *
  * Path resolution precedence (when `localized` is true):
  *   1. `sharedFtl`: used verbatim. The caller has resolved it from
@@ -45,25 +50,6 @@ export function generateMjsContent(options) {
     const ftlModulePreamble = localized
         ? `
 window.MozXULElement?.insertFTLIfNeeded(${JSON.stringify(ftlPath)});
-`
-        : '';
-    const lifecycleHooks = localized
-        ? `
-  connectedCallback() {
-    super.connectedCallback();
-    const { shadowRoot } = this;
-    if (shadowRoot) {
-      this.ownerDocument.l10n?.connectRoot(shadowRoot);
-    }
-  }
-
-  disconnectedCallback() {
-    super.disconnectedCallback();
-    const { shadowRoot } = this;
-    if (shadowRoot) {
-      this.ownerDocument.l10n?.disconnectRoot(shadowRoot);
-    }
-  }
 `
         : '';
     return `${header}
@@ -80,7 +66,6 @@ class ${className} extends MozLitElement {
   /** @type {Record<string, unknown>} */
   static properties = {};
 
-${lifecycleHooks}
   render() {
     return html\`
       <link rel="stylesheet" href="chrome://global/content/elements/${name}.css" />

package/dist/src/core/objdir-maintenance.js

@@ -30,6 +30,15 @@ function replacePrefix(value, oldRoot, newRoot) {
         ? newRoot + value.slice(oldRoot.length)
         : value;
 }
+/** Rewrites references under oldRoot, including the forward-slash spelling mozbuild writes on Windows. */
+function rewriteRootReferences(content, oldRoot, newRoot) {
+    const rewritten = content.replaceAll(oldRoot + sep, newRoot + sep);
+    if (sep !== '\\')
+        return rewritten;
+    return rewritten
+        .replaceAll(oldRoot + '/', newRoot + '/')
+        .replaceAll(oldRoot.replaceAll('\\', '/') + '/', newRoot.replaceAll('\\', '/') + '/');
+}
 function isDependencyMetadata(path) {
     return (/\.(?:pp|d)$/.test(path) ||
         /[/\\]faster[/\\]/.test(path) ||
@@ -72,6 +81,13 @@ export async function relocateObjdirProducts(engineDir, objDir, oldRoot) {
                 try {
                     await rename(temp, path);
                 }
+                catch (error) {
+                    // Windows refuses to rename over a directory link; replace it in two steps.
+                    if (process.platform !== 'win32' || getNodeErrorCode(error) !== 'EPERM')
+                        throw error;
+                    await rm(path);
+                    await rename(temp, path);
+                }
                 finally {
                     await rm(temp, { force: true });
                 }
@@ -79,7 +95,7 @@ export async function relocateObjdirProducts(engineDir, objDir, oldRoot) {
         }
         else if (isDependencyMetadata(path)) {
             const content = await readFile(path, 'utf8');
-            const rewritten = content.replaceAll(oldRoot + sep, newRoot + sep);
+            const rewritten = rewriteRootReferences(content, oldRoot, newRoot);
             if (content !== rewritten)
                 await writeText(path, rewritten);
         }

package/dist/src/core/patch-parse.js

@@ -142,12 +142,14 @@ export function parseDiffGitHeader(line) {
             return { sourcePath: candidate, targetPath: candidate };
         }
     }
-    // Rename/copy (differing paths): non-greedy split at the first ` b/`.
-    const asymmetric = /^(.+?) b\/(.+)$/.exec(rest);
-    if (asymmetric?.[1] !== undefined && asymmetric[2] !== undefined) {
-        return { sourcePath: asymmetric[1], targetPath: asymmetric[2] };
-    }
-    return null;
+    // Rename/copy (differing paths): split at the first ` b/` with a path on
+    // each side. indexOf keeps this linear where a lazy regex backtracks.
+    if (/[\n\r\u2028\u2029]/.test(rest))
+        return null;
+    const split = rest.indexOf(' b/', 1);
+    if (split === -1 || split + 3 >= rest.length)
+        return null;
+    return { sourcePath: rest.slice(0, split), targetPath: rest.slice(split + 3) };
 }
 /**
  * Splits raw diff content into lines, tolerating CRLF-saved patch files.

package/dist/src/core/token-category.js

@@ -209,6 +209,33 @@ export function findCategorySection(lines, category, tokensCssPath) {
     }
     return { categoryLine: section.categoryLine, sectionEnd: section.sectionEnd };
 }
+/**
+ * Drops complete quoted strings from one CSS line in linear time. An
+ * unterminated quote is kept, and once one fails to close every later quote
+ * of that kind fails too, so no start position is ever rescanned.
+ */
+function stripCssStrings(line) {
+    let out = '';
+    const unterminated = new Set();
+    for (let i = 0; i < line.length; i++) {
+        const quote = line.charAt(i);
+        if ((quote !== '"' && quote !== "'") || unterminated.has(quote)) {
+            out += quote;
+            continue;
+        }
+        let end = i + 1;
+        while (end < line.length && line.charAt(end) !== quote)
+            end += line.charAt(end) === '\\' ? 2 : 1;
+        if (end >= line.length) {
+            unterminated.add(quote);
+            out += quote;
+        }
+        else {
+            i = end;
+        }
+    }
+    return out;
+}
 /** 0-based open/close line indices of the base `:root {` block. */
 export function findBaseRootBounds(lines) {
     const open = lines.findIndex((line) => /:root\s*\{/.test(line));
@@ -218,7 +245,7 @@ export function findBaseRootBounds(lines) {
     let depth = 0;
     for (let i = open; i < lines.length; i++) {
         // Ignore braces in CSS strings (including data URLs).
-        const code = (masked[i] ?? '').replace(/(["'])(?:\\.|(?!\1).)*\1/g, '');
+        const code = stripCssStrings(masked[i] ?? '');
         for (const char of code) {
             if (char === '{')
                 depth++;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hominis/fireforge",
-  "version": "0.49.0",
+  "version": "0.49.2",
   "description": "FireForge — a build tool for customizing Firefox",
   "type": "module",
   "main": "./dist/src/index.js",
@@ -72,13 +72,13 @@
     "dpdm": "4.3.0",
     "eslint": "^10.0.0",
     "eslint-config-prettier": "^10.1.8",
-    "eslint-plugin-jsdoc": "^64.1.0",
+    "eslint-plugin-jsdoc": "^65.0.1",
     "eslint-plugin-simple-import-sort": "^14.0.0",
     "fast-check": "^4.6.0",
     "husky": "^9.1.7",
-    "knip": "6.37.0",
+    "knip": "6.39.0",
     "lint-staged": "^17.0.4",
-    "prettier": "3.9.8",
+    "prettier": "3.9.9",
     "tsx": "^4.7.0",
     "typescript": "~6.0.0",
     "typescript-eslint": "^8.0.0",