@hominis/fireforge 0.45.0 → 0.46.1

package/dist/src/commands/furnace/chrome-doc-templates.js

@@ -12,7 +12,7 @@
  * Sentinel attribute emitted on every `furnace chrome-doc create`-scaffolded
  * root element. Platform modules (`DevToolsStartup`, `PageActions`,
  * `SessionStore`, `DownloadsButton`, …) that observe
- * `browser-delayed-startup-finished` and walk INTO the window assume the
+ * `browser-delayed-startup-finished` and walk into the window assume the
  * `browser.xhtml` DOM and throw on anything else. A fork-authored patch
  * to such a module can use `hasAttribute(...)` against this sentinel as
  * a cheap, fork-neutral guard to skip the walk on a custom chrome doc.
@@ -54,8 +54,8 @@ const FURNACE_CHROME_DOC_SENTINEL = 'data-furnace-chrome-doc';
  *   the README "Platform module compatibility" section for the pattern.
  */
 export function generateChromeDocXhtml(name, withTitlebar, license) {
-    // navigator:browser minimum set. Carrying every attribute together —
-    // not just `windowtype` — lets a fork that uses the scaffold output
+    // navigator:browser minimum set. Carrying every attribute together, not
+    // just `windowtype`, lets a fork that uses the scaffold output
     // verbatim launch as a real main window: `customtitlebar` opts into the
     // platform-native title bar handling that pairs with the buttonbox
     // markup below, the explicit width/height avoid the OS-minimum first
@@ -99,21 +99,21 @@ export function generateChromeDocXhtml(name, withTitlebar, license) {
 `;
 }
 /**
- * browser.xhtml-like scaffold for the document that ships as the fork's MAIN
- * BROWSER WINDOW.
+ * browser.xhtml-like scaffold for the document that ships as the fork's main
+ * browser window.
  *
  * The generic dialog-shaped `<window>` scaffold is wrong for the
  * `tokenHostDocuments[0]` / BROWSER_CHROME_URL target: platform C++ reads
- * the root element BEFORE any script runs, and expects the `browser.xhtml`
+ * the root element before any script runs, and expects the `browser.xhtml`
  * shape:
  *
- * - `<html id="main-window">` root (not `<window id="<name>-window">`) —
+ * - `<html id="main-window">` root (not `<window id="<name>-window">`):
  *   upstream code from nsXULWindow sizing to session restore looks up
- *   `main-window` by id;
+ *   `main-window` by id.
  * - `windowtype="navigator:browser"`, `chromehidden=""` and the geometry
- *   `persist` allowlist declared as ROOT ATTRIBUTES so the platform's
+ *   `persist` allowlist declared as root attributes so the platform's
  *   pre-script pass (window tracking, XULStore geometry, chrome flags) sees
- *   them;
+ *   them.
  * - the same head/bootstrap wiring (customElements.js, per-doc subscript,
  *   CSS + Fluent links) and `data-furnace-chrome-doc` sentinel as the
  *   generic scaffold, so jar.mn registration and the platform-module guard
@@ -252,7 +252,7 @@ export function generateChromeDocCss(name, withTitlebar, licenseHeader) {
 }${titlebarOverrides}
 `;
 }
-/** Fluent stub — one placeholder message keyed to the window title. */
+/** Fluent stub with one placeholder message keyed to the window title. */
 export function generateChromeDocFtl(name, licenseHeader) {
     return `${licenseHeader}
 
@@ -283,7 +283,7 @@ export function jarMnEntriesForChromeDoc(name) {
  * The source path is `../shared/<name>-chrome.css` because `jar.inc.mn` is
  * included from each theme-specific manifest (`browser/themes/osx/jar.mn`,
  * `.../linux/`, `.../windows/`), and every existing entry in those manifests
- * resolves paths relative to the INCLUDING manifest's directory. A bare
+ * resolves paths relative to the including manifest's directory. A bare
  * `(shared/…)` path resolves to
  * `obj-.../browser/themes/osx/shared/<name>-chrome.css`, which does not
  * exist.
@@ -295,7 +295,7 @@ export function jarIncMnEntryForChromeDoc(name) {
  * locales/jar.mn entry that registers the `.ftl` under the browser locale
  * bundle. The source path is resolved by mach-locale-jar relative to the
  * per-locale root (e.g. `engine/browser/locales/en-US/`), and the FTL file
- * is scaffolded at `browser/${name}.ftl` under that root — the `%` prefix
+ * is scaffolded at `browser/${name}.ftl` under that root. The `%` prefix
  * means "per-locale content" and the `browser/` subdirectory matches where
  * the scaffolder writes. A bare `(%${name}.ftl)` points at
  * `en-US/${name}.ftl` and breaks the first post-scaffold build with
@@ -309,11 +309,11 @@ export function localeJarMnEntryForChromeDoc(name) {
  * wildcard rooted at `%browser/` whose pattern would already pick up a
  * scaffolded `browser/<name>.ftl` file. Recognises:
  *
- *   - `(%browser/**\/*.ftl)` — recursive (the upstream shape).
- *   - `(%browser/*.ftl)` — flat.
+ *   - `(%browser/**\/*.ftl)`: recursive (the upstream shape).
+ *   - `(%browser/*.ftl)`: flat.
  *
  * Forks that have migrated entirely to `[localization]` wildcards typically
- * keep no per-file `locale/...` entries for FTL at all; appending one
+ * keep no per-file `locale/...` entries for FTL at all. Appending one
  * there is dead weight at best, and an outright build break when the fork
  * has also dropped the `% locale browser …` registration. The chrome-doc
  * scaffolder consults this predicate before its locales/jar.mn append and
@@ -323,7 +323,7 @@ export function localeJarMnEntryForChromeDoc(name) {
  * Conservative by design: only wildcards rooted at `%browser/` count, and
  * a `(%browser/foo.ftl)`-style explicit reference (no `*`) is not treated
  * as a capture. A fork with a narrower wildcard (e.g. `(%browser/about/*.ftl)`)
- * is correctly NOT captured by this predicate, because that wildcard would
+ * is correctly not captured by this predicate, because that wildcard would
  * not pick up the top-level `browser/<name>.ftl` the scaffold writes.
  */
 export function localesFtlWildcardCapturesScaffoldedName(jarMnContents) {

package/dist/src/commands/furnace/chrome-doc-tests.d.ts

@@ -1,6 +1,6 @@
 /**
  * Returns the canonical xpcshell test basename for a chrome doc packaging
- * check (`test_<name>_packaging.js`). Hyphens in `<name>` are preserved —
+ * check (`test_<name>_packaging.js`). Hyphens in `<name>` are preserved:
  * xpcshell permits them in file basenames even though the derived task
  * function names replace them with underscores.
  */
@@ -16,7 +16,7 @@ export declare function generateChromeDocPackagingTest(name: string, header: str
 /**
  * Emits the `xpcshell.toml` manifest for the packaging test directory.
  * Sets `firefox-appdir = "browser"` so XCurProcD resolves to the browser
- * subdir rather than the generic gecko runtime dir — without that, the
+ * subdir rather than the generic gecko runtime dir. Without that, the
  * path probe walks the wrong tree on every fork whose app directory is
  * not the default.
  */

package/dist/src/commands/furnace/chrome-doc-tests.js

@@ -10,7 +10,7 @@
  *   - xpcshell's `chrome://browser/*` URI registration lags what the real
  *     browser loads even with `firefox-appdir = "browser"` set, so
  *     `NetUtil.asyncFetch("chrome://browser/content/<name>.xhtml")` can fail
- *     with `NS_ERROR_FILE_NOT_FOUND` against a file that IS correctly
+ *     with `NS_ERROR_FILE_NOT_FOUND` against a file that is correctly
  *     packaged.
  *   - Browser-chrome mochitests require a `tabbrowser`, which a
  *     fork-authored chrome doc that replaces `browser.xhtml` deliberately
@@ -23,13 +23,13 @@
  * is stable across platforms at
  * `<AppDir>/chrome/browser/content/browser/<name>.xhtml` on an unpacked tree
  * (the default for `mach build` without `MOZ_CHROME_MULTILOCALE` / omnijar).
- * A tree that packs omni.ja would need a different probe; the scaffold notes
+ * A tree that packs omni.ja would need a different probe. The scaffold notes
  * that out-of-scope case explicitly rather than silently producing a test
  * that fails on packed builds.
  */
 /**
  * Returns the canonical xpcshell test basename for a chrome doc packaging
- * check (`test_<name>_packaging.js`). Hyphens in `<name>` are preserved —
+ * check (`test_<name>_packaging.js`). Hyphens in `<name>` are preserved:
  * xpcshell permits them in file basenames even though the derived task
  * function names replace them with underscores.
  */
@@ -132,7 +132,7 @@ add_task(async function test_${taskSuffix}_files_packaged() {
 /**
  * Emits the `xpcshell.toml` manifest for the packaging test directory.
  * Sets `firefox-appdir = "browser"` so XCurProcD resolves to the browser
- * subdir rather than the generic gecko runtime dir — without that, the
+ * subdir rather than the generic gecko runtime dir. Without that, the
  * path probe walks the wrong tree on every fork whose app directory is
  * not the default.
  */

package/dist/src/commands/furnace/chrome-doc.d.ts

@@ -1,10 +1,10 @@
 /**
- * `fireforge furnace chrome-doc create <name>` — scaffolds a top-level
+ * `fireforge furnace chrome-doc create <name>` scaffolds a top-level
  * chrome document (xhtml + js + css + ftl + jar.mn registrations).
  *
  * `furnace create` covers custom elements under `toolkit/content/widgets/`,
- * but top-level chrome documents — the `mybrowser.xhtml`-class entry points
- * a fork adds alongside or instead of `browser.xhtml` — are otherwise
+ * but top-level chrome documents (the `mybrowser.xhtml`-class entry points
+ * a fork adds alongside or instead of `browser.xhtml`) are otherwise
  * hand-authored with error-prone jar.mn + jar.inc.mn + locales/jar.mn glue.
  * The `*` preprocessor flag, the macOS titlebar-button carve-out, the
  * startup-topic observer, and the Fluent linkage each have silent-break
@@ -12,7 +12,7 @@
  *
  * This command writes the four source files and appends three jar.mn entries
  * under a rollback journal identical in shape to `furnace create`. A SIGINT
- * mid-scaffold restores every touched file; a successful run leaves the tree
+ * mid-scaffold restores every touched file. A successful run leaves the tree
  * ready for `fireforge build`.
  */
 /** Options for `furnace chrome-doc create`. */
@@ -28,16 +28,16 @@ export interface FurnaceChromeDocCreateOptions {
      * Scaffold an xpcshell packaging-verification test alongside the chrome
      * document. The generated test probes `XCurProcD/chrome/browser/...` on
      * disk rather than going through `chrome://` URI resolution, which
-     * bypasses xpcshell's limited browser-chrome manifest set — where
+     * bypasses xpcshell's limited browser-chrome manifest set, where
      * `NetUtil.asyncFetch` returns `NS_ERROR_FILE_NOT_FOUND` against a file
-     * that IS packaged. Registration in `XPCSHELL_TESTS_MANIFESTS` is left to
+     * that is packaged. Registration in `XPCSHELL_TESTS_MANIFESTS` is left to
      * the operator because the owning moz.build depends on the fork's layout.
      */
     withTests?: boolean;
     /** Print the scaffold plan without writing files. */
     dryRun?: boolean;
     /**
-     * Emit the browser.xhtml-like MAIN-WINDOW skeleton (`<html
+     * Emit the browser.xhtml-like main-window skeleton (`<html
      * id="main-window">` with the `windowtype`/`chromehidden`/`persist`
      * root attributes platform C++ reads before scripts run) instead of
      * the generic dialog-shaped `<window>` document. Use for the document
@@ -49,7 +49,7 @@ export interface FurnaceChromeDocCreateOptions {
 }
 /**
  * Validates a chrome-doc name. Lowercase ASCII, optional hyphens, no
- * leading digit — the name is used verbatim in CSS selectors, jar.mn
+ * leading digit. The name is used verbatim in CSS selectors, jar.mn
  * entries, FTL keys, and file basenames, so anything outside that
  * character set would break at least one downstream consumer.
  * @param name Chrome-doc name (file basename without extension).

package/dist/src/commands/furnace/chrome-doc.js

@@ -1,11 +1,11 @@
 // SPDX-License-Identifier: EUPL-1.2
 /**
- * `fireforge furnace chrome-doc create <name>` — scaffolds a top-level
+ * `fireforge furnace chrome-doc create <name>` scaffolds a top-level
  * chrome document (xhtml + js + css + ftl + jar.mn registrations).
  *
  * `furnace create` covers custom elements under `toolkit/content/widgets/`,
- * but top-level chrome documents — the `mybrowser.xhtml`-class entry points
- * a fork adds alongside or instead of `browser.xhtml` — are otherwise
+ * but top-level chrome documents (the `mybrowser.xhtml`-class entry points
+ * a fork adds alongside or instead of `browser.xhtml`) are otherwise
  * hand-authored with error-prone jar.mn + jar.inc.mn + locales/jar.mn glue.
  * The `*` preprocessor flag, the macOS titlebar-button carve-out, the
  * startup-topic observer, and the Fluent linkage each have silent-break
@@ -13,7 +13,7 @@
  *
  * This command writes the four source files and appends three jar.mn entries
  * under a rollback journal identical in shape to `furnace create`. A SIGINT
- * mid-scaffold restores every touched file; a successful run leaves the tree
+ * mid-scaffold restores every touched file. A successful run leaves the tree
  * ready for `fireforge build`.
  */
 import { join } from 'node:path';
@@ -33,7 +33,7 @@ import { chromeDocPackagingTestFileName, generateChromeDocPackagingManifest, gen
 const CHROME_DOC_NAME_PATTERN = /^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$/;
 /**
  * Validates a chrome-doc name. Lowercase ASCII, optional hyphens, no
- * leading digit — the name is used verbatim in CSS selectors, jar.mn
+ * leading digit. The name is used verbatim in CSS selectors, jar.mn
  * entries, FTL keys, and file basenames, so anything outside that
  * character set would break at least one downstream consumer.
  * @param name Chrome-doc name (file basename without extension).
@@ -154,8 +154,8 @@ function renderChromeDocCreateDryRun(name, plan) {
  */
 async function appendJarEntryIfAbsent(filePath, entry, journal) {
     if (!(await pathExists(filePath))) {
-        // Target jar.mn doesn't exist in this tree layout. We do NOT create it
-        // — a fork that moved the jar file needs the operator to choose a
+        // Target jar.mn doesn't exist in this tree layout. We do not create it:
+        // a fork that moved the jar file needs the operator to choose a
         // placement. The command surfaces this as a FurnaceError so the user
         // can investigate rather than silently writing to a non-canonical path.
         throw new FurnaceError(`Required jar file ${filePath} does not exist; cannot register chrome-doc entry. Check that the fork's engine layout matches the expected browser/ and locales/ tree.`);
@@ -177,7 +177,7 @@ async function performChromeDocMutations(args) {
     const journal = createRollbackJournal();
     args.operationContext.registerJournal(journal);
     // XHTML uses an inline XML comment since getLicenseHeader has no XML
-    // style — the SPDX convention is a single-line comment at the top.
+    // style. The SPDX convention is a single-line comment at the top.
     const jsHeader = getLicenseHeader(args.license, 'js');
     const cssHeader = getLicenseHeader(args.license, 'css');
     const ftlHeader = getLicenseHeader(args.license, 'hash');
@@ -213,7 +213,7 @@ async function performChromeDocMutations(args) {
         await snapshotFile(journal, ftlPath);
         await writeText(ftlPath, generateChromeDocFtl(args.name, ftlHeader));
         written.push(`browser/locales/en-US/browser/${args.name}.ftl`);
-        // jar.mn registrations — XHTML + JS go through the `*` preprocessor
+        // jar.mn registrations: XHTML + JS go through the `*` preprocessor
         // for brand substitution, CSS goes through jar.inc.mn, FTL through
         // the locale jar.
         const jarMnPath = join(args.engineDir, 'browser/base/jar.mn');
@@ -226,12 +226,12 @@ async function performChromeDocMutations(args) {
         written.push('browser/themes/shared/jar.inc.mn');
         const localeJarMnPath = join(args.engineDir, 'browser/locales/jar.mn');
         // Forks that have migrated to a `[localization] (%browser/**/*.ftl)`
-        // wildcard already pick up the scaffolded FTL automatically — appending
-        // a per-file `locale/...` entry on top is at best dead weight and at
-        // worst a build error when the fork has dropped the `% locale browser`
-        // registration the per-file entry depends on. The wildcard predicate is
-        // intentionally narrow: only `%browser/`-rooted globs ending in `*.ftl`
-        // count as a capture.
+        // wildcard already pick up the scaffolded FTL automatically, so
+        // appending a per-file `locale/...` entry on top is at best dead weight
+        // and at worst a build error when the fork has dropped the
+        // `% locale browser` registration the per-file entry depends on. The
+        // wildcard predicate is narrow on purpose: only `%browser/`-rooted globs
+        // ending in `*.ftl` count as a capture.
         if (await pathExists(localeJarMnPath)) {
             const existingLocaleJar = await readText(localeJarMnPath);
             if (localesFtlWildcardCapturesScaffoldedName(existingLocaleJar)) {
@@ -298,12 +298,12 @@ export async function furnaceChromeDocCreateCommand(projectRoot, name, options =
     });
     const browserWindow = options.browserWindow ?? false;
     // The browser-window skeleton always carries its own titlebar markup and
-    // chrome attributes; --no-titlebar only applies to the generic scaffold.
+    // chrome attributes. --no-titlebar only applies to the generic scaffold.
     const withTitlebar = browserWindow ? true : (options.titlebar ?? true);
     const withTests = options.withTests ?? false;
     // Hint: when the scaffolded document is the configured token-host document
     // (the fork's main browser window), the generic dialog-shaped scaffold is
-    // almost certainly wrong — correct jar.mn registrations, wrong document
+    // almost certainly wrong: correct jar.mn registrations, wrong document
     // body.
     if (!browserWindow && (await furnaceConfigExists(projectRoot))) {
         try {
@@ -317,7 +317,7 @@ export async function furnaceChromeDocCreateCommand(projectRoot, name, options =
             }
         }
         catch {
-            // A broken furnace.json must not block chrome-doc scaffolding; the
+            // A broken furnace.json must not block chrome-doc scaffolding. The
             // hint is best-effort.
         }
     }

package/dist/src/commands/furnace/create-browser-test.d.ts

@@ -1,7 +1,7 @@
 /**
  * Browser-chrome test scaffolding for `furnace create --with-tests`,
  * including the `--test-dir` redirect and collision safety (existing
- * manifests are appended to; head.js and test implementations are never
+ * manifests are appended to, and head.js and test implementations are never
  * overwritten). Split out of `create.ts` to keep that command file within
  * the per-file line budget.
  */

package/dist/src/commands/furnace/create-browser-test.js

@@ -2,7 +2,7 @@
 /**
  * Browser-chrome test scaffolding for `furnace create --with-tests`,
  * including the `--test-dir` redirect and collision safety (existing
- * manifests are appended to; head.js and test implementations are never
+ * manifests are appended to, and head.js and test implementations are never
  * overwritten). Split out of `create.ts` to keep that command file within
  * the per-file line budget.
  */
@@ -16,6 +16,7 @@ import { toError } from '../../utils/errors.js';
 import { ensureDir, pathExists, readText, writeText } from '../../utils/fs.js';
 import { info, success, warn } from '../../utils/logger.js';
 import { stripEnginePrefix } from '../../utils/paths.js';
+import { browserTestFileName, deriveTestStem } from './test-file-name.js';
 /**
  * Validates the `--test-dir` option against the resolved test style before
  * any writes. Mochikit lives in the upstream toolkit/content/tests/widgets
@@ -65,15 +66,9 @@ export function resolveTestDirOverride(raw) {
  * the harness will try to run.
  */
 export async function scaffoldTestFiles(componentName, license, forgeConfig, paths, journal, testDirOverride) {
-    const strippedName = componentName.startsWith('moz-') ? componentName.slice(4) : componentName;
-    // Avoid double-prefixing: strip binaryName prefix since the default test
-    // dir name already uses it
     const binaryName = forgeConfig.binaryName;
-    const withoutBinaryPrefix = strippedName.startsWith(binaryName + '-')
-        ? strippedName.slice(binaryName.length + 1)
-        : strippedName;
-    const underscored = withoutBinaryPrefix.replace(/-/g, '_');
-    const testFileName = `browser_${binaryName}_${underscored}.js`;
+    const underscored = deriveTestStem(componentName, binaryName);
+    const testFileName = browserTestFileName(componentName, binaryName);
     // --test-dir redirects the scaffold: the hardcoded
     // `.../test/<binaryName>/` target can collide with a test suite owned by a
     // different patch. The manifest-registration name is the path below
@@ -88,12 +83,12 @@ export async function scaffoldTestFiles(componentName, license, forgeConfig, pat
     const jsHeader = getLicenseHeader(license, 'js');
     const hashHeader = getLicenseHeader(license, 'hash');
     const testFiles = [];
-    // browser.toml — create if missing, append entry if existing
+    // browser.toml: create if missing, append entry if existing.
     const tomlPath = join(testDir, 'browser.toml');
     if (await pathExists(tomlPath)) {
         // Defensive guard: only append if the entry is not already present.
         // With a fresh journal per create, the same test file name cannot be
-        // appended twice in a single run — but retaining the check protects
+        // appended twice in a single run, but retaining the check protects
         // against accidental re-entrance or a future refactor that reuses the
         // helper with a stale test directory.
         const existingToml = await readText(tomlPath);
@@ -118,7 +113,7 @@ support-files = ["head.js"]
         await writeText(tomlPath, browserToml);
     }
     testFiles.push('browser.toml');
-    // head.js — only create if it doesn't exist (shared across components)
+    // head.js: only create if it doesn't exist (shared across components).
     const headPath = join(testDir, 'head.js');
     if (!(await pathExists(headPath))) {
         if (journal)

package/dist/src/commands/furnace/create-dry-run.d.ts

@@ -8,7 +8,7 @@ export interface DryRunPlanInput {
     /**
      * Feature-scoped Fluent bundle the component participates in (the same
      * value that will be written to `furnace.json`'s `sharedFtl`). When set,
-     * the component's own `.ftl` is NOT scaffolded and the plan preview
+     * the component's own `.ftl` is not scaffolded and the plan preview
      * reflects that. Omit the key for the default per-component scaffold.
      */
     sharedFtl?: string;
@@ -18,8 +18,8 @@ export interface DryRunPlanInput {
     /**
      * Resolved `--test-dir` override (engine-relative, already validated by
      * `resolveValidatedTestDir`). Omit for the default `<binaryName>`-derived
-     * scaffold directory. The formatters MUST receive the same value the
-     * scaffolders get — the plan used to recompute the default from
+     * scaffold directory. The formatters must receive the same value the
+     * scaffolders get. The plan used to recompute the default from
      * `binaryName` and named a directory the real run never wrote to.
      */
     testDir?: string;
@@ -35,7 +35,7 @@ export declare function formatSuccessNote(args: {
     testFiles: string[];
     testStyle: ResolvedTestStyle;
     binaryName: string;
-    /** Resolved `--test-dir` override; see {@link DryRunPlanInput.testDir}. */
+    /** Resolved `--test-dir` override. See {@link DryRunPlanInput.testDir}. */
     testDir?: string | undefined;
 }): string;
 /**

package/dist/src/commands/furnace/create-dry-run.js

@@ -3,11 +3,12 @@
  * Dry-run plan formatter for `furnace create`.
  *
  * Lives outside `create.ts` so the authoring command stays under the
- * per-file LOC budget. The formatter is pure — all inputs are already
- * resolved by the command's validation phase — so it can be exercised
+ * per-file LOC budget. The formatter is pure (all inputs are already
+ * resolved by the command's validation phase), so it can be exercised
  * independently of the mutation plumbing.
  */
 import { BROWSER_TEST_SCAFFOLD_ROOT, resolveBrowserChromeTestDir, resolveXpcshellTestDir, } from '../../core/furnace-constants.js';
+import { deriveTestStem } from './test-file-name.js';
 /**
  * Builds the test-section fragment of the dry-run plan for a given
  * harness choice. Kept separate from the top-level formatter so the
@@ -18,15 +19,11 @@ function formatTestSection(args) {
     const { testStyle, componentName, binaryName, testDir } = args;
     if (testStyle === 'none')
         return '';
-    const strippedName = componentName.startsWith('moz-') ? componentName.slice(4) : componentName;
-    const withoutBinaryPrefix = strippedName.startsWith(binaryName + '-')
-        ? strippedName.slice(binaryName.length + 1)
-        : strippedName;
-    const underscored = withoutBinaryPrefix.replace(/-/g, '_');
+    const underscored = deriveTestStem(componentName, binaryName);
     if (testStyle === 'browser-chrome') {
         // Same resolver as scaffoldTestFiles: the registration name is the
         // path below browser/base/content/test/, which under --test-dir is
-        // NOT the binary name.
+        // not the binary name.
         const testDirRel = resolveBrowserChromeTestDir(binaryName, testDir);
         const manifestName = testDirRel.slice(BROWSER_TEST_SCAFFOLD_ROOT.length);
         return (`\n\nWould create test files in engine/${testDirRel}/:\n` +
@@ -82,7 +79,7 @@ export function formatSuccessNote(args) {
 export function formatDryRunPlan(args) {
     const { componentName, localized, register, composes, stockAdditions, sharedFtl, testStyle, description, binaryName, testDir, } = args;
     const componentFiles = [`${componentName}.mjs`, `${componentName}.css`];
-    // A per-component .ftl is scaffolded only when the component does NOT
+    // A per-component .ftl is scaffolded only when the component does not
     // opt into a shared feature-scoped bundle. Mirrors writeComponentFiles.
     if (localized && !sharedFtl)
         componentFiles.push(`${componentName}.ftl`);

package/dist/src/commands/furnace/create-features.d.ts

@@ -1,7 +1,7 @@
 /**
  * Feature-flag resolution for `furnace create`. Extracted from
  * `create.ts` so the authoring command stays under the per-file LOC
- * budget — the flag resolver has grown with each new opt-in (`--xpcshell`,
+ * budget. The flag resolver has grown with each new opt-in (`--xpcshell`,
  * `--test-style`, `--shared-ftl`).
  */
 import type { FurnaceCreateOptions } from '../../types/commands/index.js';
@@ -11,7 +11,7 @@ import type { FurnaceCreateOptions } from '../../types/commands/index.js';
  * `--shared-ftl` implies `localized` and short-circuits the interactive
  * prompt so the operator is not asked to flip a flag we are about to
  * enforce. `--no-localized` combined with `--shared-ftl` is rejected
- * fast-fail; the cross-field check in furnace-config would catch it
+ * fast-fail. The cross-field check in furnace-config would catch it
  * too, but later and without a clear command-line message.
  *
  * @param isInteractive - Whether interactive prompts are available

package/dist/src/commands/furnace/create-features.js

@@ -2,7 +2,7 @@
 /**
  * Feature-flag resolution for `furnace create`. Extracted from
  * `create.ts` so the authoring command stays under the per-file LOC
- * budget — the flag resolver has grown with each new opt-in (`--xpcshell`,
+ * budget. The flag resolver has grown with each new opt-in (`--xpcshell`,
  * `--test-style`, `--shared-ftl`).
  */
 import { multiselect } from '@clack/prompts';
@@ -14,7 +14,7 @@ import { cancel, isCancel } from '../../utils/logger.js';
  * `--shared-ftl` implies `localized` and short-circuits the interactive
  * prompt so the operator is not asked to flip a flag we are about to
  * enforce. `--no-localized` combined with `--shared-ftl` is rejected
- * fast-fail; the cross-field check in furnace-config would catch it
+ * fast-fail. The cross-field check in furnace-config would catch it
  * too, but later and without a clear command-line message.
  *
  * @param isInteractive - Whether interactive prompts are available

package/dist/src/commands/furnace/create-mochikit.d.ts

@@ -3,10 +3,10 @@
  * `fireforge furnace create --test-style=mochikit`.
  *
  * Browser-chrome mochitests require a `tabbrowser` in the top-level chrome
- * document, so forks with a bespoke chrome document that deliberately omits
- * one cannot run them. MochiKit tests load the component module directly via
+ * document, so forks with a bespoke chrome document that omits one cannot
+ * run them. MochiKit tests load the component module directly via
  * `chrome://global/` and assert against `customElements`, so they work
- * against any fork that registers the upstream toolkit test manifest tree —
+ * against any fork that registers the upstream toolkit test manifest tree,
  * including those without a tabbrowser.
  */
 import { type RollbackJournal } from '../../core/furnace-rollback.js';
@@ -21,7 +21,7 @@ import type { ProjectLicense } from '../../types/config.js';
  * Appends a per-test entry to the existing `chrome.toml` when present,
  * writes a fresh `[DEFAULT]`-headed one otherwise. The caller is still
  * responsible for ensuring the `toolkit/content/tests/widgets/chrome.toml`
- * path is registered somewhere in the moz.build tree; most forks inherit
+ * path is registered somewhere in the moz.build tree. Most forks inherit
  * this from upstream via `TEST_HARNESS_FILES += [...]`.
  */
 export declare function scaffoldMochikitTestFiles(componentName: string, license: ProjectLicense, paths: {

package/dist/src/commands/furnace/create-mochikit.js

@@ -4,10 +4,10 @@
  * `fireforge furnace create --test-style=mochikit`.
  *
  * Browser-chrome mochitests require a `tabbrowser` in the top-level chrome
- * document, so forks with a bespoke chrome document that deliberately omits
- * one cannot run them. MochiKit tests load the component module directly via
+ * document, so forks with a bespoke chrome document that omits one cannot
+ * run them. MochiKit tests load the component module directly via
  * `chrome://global/` and assert against `customElements`, so they work
- * against any fork that registers the upstream toolkit test manifest tree —
+ * against any fork that registers the upstream toolkit test manifest tree,
  * including those without a tabbrowser.
  */
 import { join } from 'node:path';
@@ -26,7 +26,7 @@ import { generateMochikitChromeTomlEntry, generateMochikitChromeTomlSkeleton, ge
  * Appends a per-test entry to the existing `chrome.toml` when present,
  * writes a fresh `[DEFAULT]`-headed one otherwise. The caller is still
  * responsible for ensuring the `toolkit/content/tests/widgets/chrome.toml`
- * path is registered somewhere in the moz.build tree; most forks inherit
+ * path is registered somewhere in the moz.build tree. Most forks inherit
  * this from upstream via `TEST_HARNESS_FILES += [...]`.
  */
 export async function scaffoldMochikitTestFiles(componentName, license, paths, journal) {
@@ -50,9 +50,9 @@ export async function scaffoldMochikitTestFiles(componentName, license, paths, j
         await writeText(testFilePath, generateMochikitTestContent(componentName));
         writtenFiles.push(testFileName);
     }
-    // chrome.toml — append entry if the file already exists, otherwise write
-    // a fresh skeleton + entry. Idempotency: if the entry is already present
-    // the manifest is left untouched so re-runs don't double-register.
+    // chrome.toml: append an entry if the file already exists, otherwise
+    // write a fresh skeleton + entry. Idempotency: if the entry is already
+    // present the manifest is left untouched so re-runs don't double-register.
     const manifestPath = join(testDir, 'chrome.toml');
     const entry = generateMochikitChromeTomlEntry(componentName);
     if (await pathExists(manifestPath)) {