@hominis/fireforge 0.43.1 → 0.44.1

package/dist/src/commands/furnace/preview.js

@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: EUPL-1.2
 import { join } from 'node:path';
-import { getProjectPaths } from '../../core/config.js';
 import { applyAllComponents } from '../../core/furnace-apply.js';
-import { furnaceConfigExists, loadFurnaceConfig, updateFurnaceState, } from '../../core/furnace-config.js';
+import { updateFurnaceState } from '../../core/furnace-config.js';
 import { runFurnaceMutation } from '../../core/furnace-operation.js';
+import { assertFurnaceReady } from '../../core/furnace-precondition.js';
 import { restoreRollbackJournal } from '../../core/furnace-rollback.js';
 import { countEntriesWithBlockingStepErrors } from '../../core/furnace-step-errors.js';
 import { cleanStories, syncStories } from '../../core/furnace-stories.js';
@@ -49,14 +49,11 @@ async function runPreviewTeardown(engineDir, storiesCleanupRequired, journal) {
     return errors;
 }
 /**
- * Reports staging failures (component-level errors and per-step errors) to the
- * user and throws a single FurnaceError summarising the failure count.
- * Extracted from `furnacePreviewCommand` to keep that function under the
- * `max-lines-per-function` threshold and to colocate the failure-reporting
- * contract in one place.
+ * Reports staging failures (component-level errors and per-step errors) to
+ * the user and throws a single FurnaceError summarising the failure count.
  *
- * @returns The total failure count if there were any (always non-zero when
- *          this returns; the function throws after logging).
+ * Never returns: it always throws after logging, which is what the `never`
+ * return type states.
  */
 function reportPreviewStagingFailures(stageResult) {
     for (const err of stageResult.errors) {
@@ -76,13 +73,12 @@ function reportPreviewStagingFailures(stageResult) {
 /**
  * Filenames emitted by the Firefox build backend (not by Storybook's npm
  * package set) — their absence means `mach build` has not produced its
- * post-configure artifacts, which is a different failure mode from a
- * missing Storybook workspace dependency tree. The eval log for finding
- * #11 reported `FileNotFoundError: [...] chrome-map.json` *after* a
- * successful Storybook `npm install`, and the pre-0.16 heuristic
- * misdiagnosed it as a dep failure and sent the operator back to
- * `--install`. Pattern list is narrow on purpose so we only surface the
- * backend-rebuild hint when we are confident.
+ * post-configure artifacts, which is a different failure mode from a missing
+ * Storybook workspace dependency tree. A
+ * `FileNotFoundError: [...] chrome-map.json` AFTER a successful Storybook
+ * `npm install` is the case a dep-focused heuristic misdiagnoses, sending
+ * the operator back to `--install`. The pattern list is narrow on purpose so
+ * the backend-rebuild hint only fires when it is confident.
  */
 const BACKEND_ARTIFACT_PATTERNS = [
     /chrome-map\.json/i,
@@ -124,17 +120,14 @@ export function buildStorybookFailureMessage(output, installRequested) {
 }
 /**
  * Preflights the Firefox build + toolchain prerequisites `mach storybook`
- * quietly assumes. Pre-0.16.0 the preview staged components and launched
- * a ~1000-package `mach storybook upgrade` npm install before the
- * backend surfaced a "missing chrome-map.json" / Cargo-config failure;
- * the preflight below refuses fast and leaves the workspace untouched.
- *
- * Extracted from `furnacePreviewCommand` so the main function stays
- * under the per-function LOC budget as the preflight list grows.
+ * quietly assumes. Without it, preview stages components and launches a
+ * ~1000-package `mach storybook upgrade` npm install before the backend
+ * surfaces a "missing chrome-map.json" / Cargo-config failure; this refuses
+ * fast and leaves the workspace untouched.
  *
  * @param engineDir - Resolved engine directory
- * @throws FurnaceError when the Firefox build hasn't produced dist/, or
- *         when `.cargo/config.toml` is absent
+ * @throws FurnaceError when the Firefox build has not produced dist/, or
+ *   when `.cargo/config.toml` is absent
  */
 async function assertPreviewPrerequisites(engineDir) {
     const buildCheck = await hasBuildArtifacts(engineDir);
@@ -146,14 +139,12 @@ async function assertPreviewPrerequisites(engineDir) {
     }
     // Accept either `.cargo/config.toml` (post-configure) or
     // `.cargo/config.toml.in` (post-bootstrap template, consumed at
-    // `mach configure` time). Pre-0.16.0 the preflight insisted on the
-    // plain file, but `fireforge bootstrap` alone produces only `.in` —
-    // operators who followed the remediation instruction ("run bootstrap
-    // then rerun preview") hit the same refusal on the retry. Either name
-    // is sufficient to prove the Rust toolchain is registered; the stronger
-    // `hasBuildArtifacts` check above already guards against a completely
-    // un-configured tree, so relaxing this to an OR-check does not weaken
-    // the signal we care about.
+    // `mach configure` time). Insisting on the plain file makes operators who
+    // follow the remediation instruction ("run bootstrap then rerun preview")
+    // hit the same refusal on the retry, because `fireforge bootstrap` alone
+    // produces only `.in`. Either name is sufficient to prove the Rust
+    // toolchain is registered; the stronger `hasBuildArtifacts` check above
+    // already guards against a completely un-configured tree.
     const cargoConfigPath = join(engineDir, '.cargo', 'config.toml');
     const cargoConfigInPath = join(engineDir, '.cargo', 'config.toml.in');
     const cargoConfigPresent = (await pathExists(cargoConfigPath)) || (await pathExists(cargoConfigInPath));
@@ -165,15 +156,14 @@ async function assertPreviewPrerequisites(engineDir) {
     }
 }
 /**
- * Emits a framing banner when the Storybook workspace has not yet had
- * its npm dependencies installed. `mach storybook` will drive the
- * install internally and print ELSPROBLEMS / UNMET DEPENDENCY lines
- * verbatim; without this banner operators reliably read the npm output
- * as a failure (2026-04-24 eval Finding 13).
+ * Emits a framing banner when the Storybook workspace has not yet had its npm
+ * dependencies installed. `mach storybook` drives the install internally and
+ * prints ELSPROBLEMS / UNMET DEPENDENCY lines verbatim; without this banner
+ * operators reliably read the npm output as a failure.
  *
- * Skipped when `--install` was explicitly requested — that path already
- * runs `mach storybook upgrade` before the preview launches, so the npm
- * output for the subsequent `mach storybook` invocation is a no-op.
+ * Skipped when `--install` was explicitly requested — that path already runs
+ * `mach storybook upgrade` before the preview launches, so the npm output
+ * for the subsequent `mach storybook` invocation is a no-op.
  */
 async function announceStorybookFirstRunIfNeeded(engineDir, installRequested) {
     if (installRequested)
@@ -203,16 +193,7 @@ function announceStorybookCleanExitIfApplicable(exitCode) {
  */
 export async function furnacePreviewCommand(projectRoot, options = {}) {
     intro('Furnace Preview (Storybook)');
-    // Verify engine exists
-    const paths = getProjectPaths(projectRoot);
-    if (!(await pathExists(paths.engine))) {
-        throw new FurnaceError('Engine directory not found. Run "fireforge download" first.');
-    }
-    // Load furnace config
-    if (!(await furnaceConfigExists(projectRoot))) {
-        throw new FurnaceError('No furnace.json found. Run "fireforge furnace create" or "fireforge furnace override" to get started.');
-    }
-    const config = await loadFurnaceConfig(projectRoot);
+    const { paths, config } = await assertFurnaceReady(projectRoot);
     const stockCount = config.stock.length;
     const overrideCount = Object.keys(config.overrides).length;
     const customCount = Object.keys(config.custom).length;
@@ -226,8 +207,8 @@ export async function furnacePreviewCommand(projectRoot, options = {}) {
     if (!(await pathExists(storybookRoot))) {
         throw new FurnaceError('This Firefox checkout does not contain browser/components/storybook. Furnace preview requires the upstream Storybook workspace to exist before stories can be synced.');
     }
-    // Build + toolchain preflight (Finding #9). Extracted into a helper so
-    // the function below stays under the per-function LOC budget.
+    // Build + toolchain preflight, extracted into a helper so the function
+    // below stays under the per-function LOC budget.
     await assertPreviewPrerequisites(paths.engine);
     let previewResult;
     // True once we are about to (or have) written to engine/.../stories/furnace.
@@ -302,10 +283,8 @@ export async function furnacePreviewCommand(projectRoot, options = {}) {
                 }
                 installSpinner.stop('Storybook dependencies reinstalled');
             }
-            // 2026-04-24 eval Finding 13: frame the npm noise that `mach
-            // storybook` emits on first-run as expected progress rather than a
-            // failure. The banner-before / banner-after helpers are extracted
-            // so the command body stays under the per-function LOC budget.
+            // Frame the npm noise `mach storybook` emits on first run as expected
+            // progress rather than a failure.
             await announceStorybookFirstRunIfNeeded(paths.engine, options.install ?? false);
             // Start Storybook
             info('Starting Storybook...');
@@ -317,16 +296,17 @@ export async function furnacePreviewCommand(projectRoot, options = {}) {
             primaryError = error;
         }
         // Teardown runs unconditionally and never short-circuits: a failure in
-        // cleanStories must not prevent the journal restore, and vice versa. The
-        // previous implementation ran teardown in a `finally` block that called
-        // `restoreRollbackJournalOrThrow`, which threw synchronously — that throw
-        // bypassed the primary error and, worse, skipped downstream handling so
-        // the engine was left with staged files and the user got a teardown
-        // message with no guidance. We now collect both failures and, if anything
-        // went wrong, persist a `pendingRepair` marker that `fireforge doctor`
-        // consumes to finish the reconciliation.
-        // Teardown restores the journal itself, so the lifecycle wrapper must not
-        // restore it again when the throw below propagates out of this body.
+        // cleanStories must not prevent the journal restore, and vice versa.
+        // Running teardown in a `finally` that calls
+        // `restoreRollbackJournalOrThrow` throws synchronously, bypassing the
+        // primary error and skipping downstream handling — the engine is left
+        // with staged files and the user gets a teardown message with no
+        // guidance. Both failures are collected instead and, if anything went
+        // wrong, a `pendingRepair` marker is persisted for `fireforge doctor` to
+        // finish the reconciliation.
+        //
+        // Teardown restores the journal itself, so the lifecycle wrapper must
+        // not restore it again when the throw below propagates out of this body.
         ctx.markRolledBack();
         const teardownErrors = await runPreviewTeardown(paths.engine, storiesCleanupRequired, previewJournal);
         if (teardownErrors.length > 0) {

package/dist/src/commands/furnace/refresh.js

@@ -6,9 +6,10 @@ import { getOverrideEngineTargetPath } from '../../core/furnace-apply-helpers.js
 import { getFurnacePaths, loadFurnaceConfig, writeFurnaceConfig, } from '../../core/furnace-config.js';
 import { resolveFtlDir } from '../../core/furnace-constants.js';
 import { isComponentSourceFile } from '../../core/furnace-constants.js';
-import { recordFurnaceRollbackFailure, runFurnaceMutation } from '../../core/furnace-operation.js';
+import { completeJournalRollback, runFurnaceMutation } from '../../core/furnace-operation.js';
+import { assertFurnaceEngineReady } from '../../core/furnace-precondition.js';
 import { refreshOverrideFile } from '../../core/furnace-refresh.js';
-import { createRollbackJournal, restoreRollbackJournal, restoreRollbackJournalOrThrow, snapshotDir, snapshotFile, } from '../../core/furnace-rollback.js';
+import { createRollbackJournal, restoreRollbackJournal, snapshotDir, snapshotFile, } from '../../core/furnace-rollback.js';
 import { getHead } from '../../core/git.js';
 import { FurnaceError } from '../../errors/furnace.js';
 import { toError } from '../../utils/errors.js';
@@ -144,17 +145,15 @@ async function refreshSingleOverride(projectRoot, name, options = {}) {
             return fileResults;
         }
         catch (error) {
+            // A dry run wrote nothing, so there is no journal to restore — it
+            // rethrows without touching the lifecycle wrapper.
             if (!dryRun) {
-                // This body owns its rollback end to end, so tell the lifecycle
-                // wrapper not to restore the same journal again on the way out.
-                ctx.markRolledBack();
-                try {
-                    await restoreRollbackJournalOrThrow(journal, `Failed to refresh override "${name}"`);
-                }
-                catch (rollbackError) {
-                    await recordFurnaceRollbackFailure(projectRoot, 'refresh-rollback', `override "${name}": ${toError(rollbackError).message}`);
-                    throw rollbackError;
-                }
+                return await completeJournalRollback(ctx, journal, error, {
+                    projectRoot,
+                    operation: 'refresh-rollback',
+                    failureMessage: `Failed to refresh override "${name}"`,
+                    subject: `override "${name}"`,
+                });
             }
             throw error;
         }
@@ -228,10 +227,7 @@ export async function furnaceRefreshCommand(projectRoot, name, options = {}) {
     // Verify engine exists — refresh reads engine files for three-way merge
     // and --reset-base reads engine HEAD. Without this check, the user gets
     // an obscure git error instead of a clear precondition message.
-    const paths = getProjectPaths(projectRoot);
-    if (!(await pathExists(paths.engine))) {
-        throw new FurnaceError('Engine directory not found. Run "fireforge download" first.');
-    }
+    await assertFurnaceEngineReady(projectRoot);
     const dryRun = options.dryRun ?? false;
     if (name) {
         intro('Furnace Refresh');

package/dist/src/commands/furnace/remove-mutations.d.ts

@@ -5,12 +5,9 @@ import type { FurnaceState } from '../../types/furnace.js';
 /**
  * Engine-side and workspace-side removal for an OVERRIDE component.
  *
- * Extracted in 0.41.0: this and its custom-component sibling were the only
- * large inline blocks in the furnace subsystem never wrapped in a
- * `perform*Mutations` helper, and together they held `remove.ts` at 496/500
- * file lines with `furnaceRemoveCommand` at 149/150 — one line from a build
- * failure. Both run inside the caller's rollback journal rather than opening
- * their own, so a failure anywhere still restores the whole operation.
+ * Runs inside the caller's rollback journal rather than opening its own, so
+ * a failure anywhere in the remove still restores the whole operation as a
+ * single unit.
  */
 export declare function performOverrideRemovalMutations(args: {
     name: string;

package/dist/src/commands/furnace/remove-mutations.js

@@ -2,12 +2,10 @@
 /**
  * Engine-side and workspace-side mutation bodies for `furnace remove`.
  *
- * Split out of `remove.ts` in 0.41.0. The two `perform*RemovalMutations`
- * functions were the only large inline blocks in the furnace subsystem never
- * wrapped in a helper, and together they held `remove.ts` at 496/500 file
- * lines with `furnaceRemoveCommand` at 149/150 — one line from a build
- * failure. Extracting them inside the same file traded a function-length
- * problem for a file-length one, so they live here instead.
+ * Split out of `remove.ts`, where the two `perform*RemovalMutations`
+ * functions held the file at the per-file line cap with
+ * `furnaceRemoveCommand` at the per-function cap. Extracting them inside the
+ * same file would trade a function-length problem for a file-length one.
  *
  * Both run inside the CALLER's rollback journal rather than opening their
  * own, so a failure anywhere in the remove still restores the whole
@@ -25,6 +23,7 @@ import { isGitRepository } from '../../core/git.js';
 import { FurnaceError } from '../../errors/furnace.js';
 import { pathExists, removeDir, removeFile } from '../../utils/fs.js';
 import { info } from '../../utils/logger.js';
+import { normalizePathSlashes } from '../../utils/paths.js';
 import { removeDeployedCustomFiles } from './remove-state.js';
 /**
  * Restores every override-deployed file in `engine/` to its pristine HEAD
@@ -84,12 +83,9 @@ async function restoreOverrideEngineFiles(engineDir, overrideDir, overrideConfig
 /**
  * Engine-side and workspace-side removal for an OVERRIDE component.
  *
- * Extracted in 0.41.0: this and its custom-component sibling were the only
- * large inline blocks in the furnace subsystem never wrapped in a
- * `perform*Mutations` helper, and together they held `remove.ts` at 496/500
- * file lines with `furnaceRemoveCommand` at 149/150 — one line from a build
- * failure. Both run inside the caller's rollback journal rather than opening
- * their own, so a failure anywhere still restores the whole operation.
+ * Runs inside the caller's rollback journal rather than opening its own, so
+ * a failure anywhere in the remove still restores the whole operation as a
+ * single unit.
  */
 export async function performOverrideRemovalMutations(args) {
     const { name, paths, furnacePaths, freshConfig, freshState, ftlDir, journal } = args;
@@ -158,14 +154,15 @@ export async function performCustomRemovalMutations(args) {
         if (await pathExists(ftlPath)) {
             await snapshotFile(journal, ftlPath);
             await removeFile(ftlPath);
-            info(`Deleted localized file engine/${ftlRel}`);
+            // `ftlRel` is a native join, so on Windows an interpolated
+            // `engine/${ftlRel}` renders as `engine/toolkit\locales\...` — one
+            // message with both separators. Print the engine-relative form.
+            info(`Deleted localized file engine/${normalizePathSlashes(ftlRel)}`);
         }
         // Drop the locale jar.mn chrome registration that `applyCustomFtlFile`
         // wrote during deploy — otherwise the engine is left with a
-        // `locale/.../${name}.ftl` entry pointing at a file we just
-        // deleted. 2026-04-21 eval (Finding #1): `furnace remove` left
-        // `browser/locales/jar.mn` referencing the missing FTL, which
-        // would break the next package-manifest validation.
+        // `locale/.../${name}.ftl` entry pointing at a file just deleted, which
+        // breaks the next package-manifest validation.
         await removeCustomFtlJarMnEntry(paths.engine, `${name}.ftl`, ftlDir, customConfig, journal);
     }
 }

package/dist/src/commands/furnace/remove-state.js

@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: EUPL-1.2
+import { readdir } from 'node:fs/promises';
 import { join } from 'node:path';
 import { loadFurnaceState } from '../../core/furnace-config.js';
 import { snapshotFile } from '../../core/furnace-rollback.js';
@@ -52,7 +53,6 @@ export async function removeDeployedCustomFiles(projectRoot, engineDir, name, ta
     if (deletedCount > 0) {
         info(`Deleted ${deletedCount} deployed file(s) from engine/${targetPath}/`);
     }
-    const { readdir } = await import('node:fs/promises');
     if ((await readdir(engineTargetDir)).length === 0) {
         await removeDir(engineTargetDir);
         info(`Removed now-empty engine/${targetPath}/`);

package/dist/src/commands/furnace/remove.js

@@ -3,12 +3,13 @@ import { readdir, unlink } from 'node:fs/promises';
 import { join } from 'node:path';
 import { confirm } from '@clack/prompts';
 import { getProjectPaths, loadConfig } from '../../core/config.js';
+import { stdioIsInteractive } from '../../core/destructive.js';
 import { getFurnacePaths, loadFurnaceConfig, loadFurnaceState, updateFurnaceState, writeFurnaceConfig, } from '../../core/furnace-config.js';
 import { resolveFtlDir, xpcshellTestParentDir } from '../../core/furnace-constants.js';
-import { recordFurnaceRollbackFailure, runFurnaceMutation } from '../../core/furnace-operation.js';
-import { createRollbackJournal, restoreRollbackJournalOrThrow, snapshotDir, snapshotFile, } from '../../core/furnace-rollback.js';
+import { completeJournalRollback, runFurnaceMutation } from '../../core/furnace-operation.js';
+import { createRollbackJournal, snapshotDir, snapshotFile, } from '../../core/furnace-rollback.js';
 import { isGitRepository } from '../../core/git.js';
-import { deregisterTestManifest } from '../../core/manifest-register.js';
+import { deregisterTestManifest } from '../../core/moz-manifest-register.js';
 import { FurnaceError } from '../../errors/furnace.js';
 import { toError } from '../../utils/errors.js';
 import { pathExists, readText, removeDir, writeText } from '../../utils/fs.js';
@@ -157,23 +158,23 @@ async function cleanupCustomTestFiles(name, projectRoot, journal) {
     return { partialFailures };
 }
 /**
- * Removes the MochiKit test scaffold a `furnace create --with-tests
- * --test-style mochikit` produced for the component (matches the rename
- * counterpart in `rename.ts`). The test file is `test_<name>.html` under
- * `engine/toolkit/content/tests/widgets/` and the registration is the
- * `["test_<name>.html"]` entry in the same directory's `chrome.toml`.
+ * Removes the MochiKit test scaffold a
+ * `furnace create --with-tests --test-style mochikit` produced for the
+ * component (matches the rename counterpart in `rename.ts`). The test file is
+ * `test_<name>.html` under `engine/toolkit/content/tests/widgets/` and the
+ * registration is the `["test_<name>.html"]` entry in the same directory's
+ * `chrome.toml`.
  *
- * 2026-04-25 eval Finding 13: the prior cleanup only handled the
- * browser-chrome mochitest layout under `browser/base/content/test/
- * <binary>/`, which left mochikit-style scaffolds and their toml entries
- * orphaned after `furnace remove`. The post-rename name passed in here
- * is the canonical one written to disk by deploy/rename, so the file
- * basenames match without needing to re-derive from the old name.
+ * Cleanup that only handles the browser-chrome mochitest layout under
+ * `browser/base/content/test/<binary>/` leaves mochikit-style scaffolds and
+ * their toml entries orphaned after `furnace remove`. The post-rename name
+ * passed in here is the canonical one written to disk by deploy/rename, so
+ * the file basenames match without re-deriving from the old name.
  *
- * Best-effort: each step warns on failure rather than throwing so the
- * rest of the remove transaction proceeds. The journal still snapshots
- * touched files so the outer rollback can restore them on a later
- * failure in the same operation.
+ * Best-effort: each step warns on failure rather than throwing so the rest
+ * of the remove transaction proceeds. The journal still snapshots touched
+ * files so the outer rollback can restore them on a later failure in the
+ * same operation.
  */
 async function cleanupCustomMochikitTestFiles(name, projectRoot, journal) {
     const partialFailures = [];
@@ -216,14 +217,13 @@ async function cleanupCustomMochikitTestFiles(name, projectRoot, journal) {
 }
 /**
  * Removes generated xpcshell test scaffolds associated with a custom
- * component. 2026-04-24 eval Finding 5: `furnace remove` handled
- * browser mochitests via `cleanupCustomTestFiles` but never touched the
- * xpcshell scaffold tree, so an operator who ran
- * `furnace create --with-tests --xpcshell` followed by `furnace remove`
- * was left with orphan `xpcshell.toml` + `test_<name>_packaged.js`
- * files still referencing the removed component. This cleanup pass
- * mirrors the mochitest one — snapshot before removal, warn-and-
- * continue semantics, explicit summary when partial failures occur.
+ * component. Cleanup that handles browser mochitests via
+ * `cleanupCustomTestFiles` but never touches the xpcshell scaffold tree
+ * leaves an operator who ran `furnace create --with-tests --xpcshell`
+ * followed by `furnace remove` with orphan `xpcshell.toml` +
+ * `test_<name>_packaged.js` files still referencing the removed component.
+ * This pass mirrors the mochitest one — snapshot before removal,
+ * warn-and-continue semantics, explicit summary on partial failures.
  */
 async function cleanupCustomXpcshellTestFiles(name, projectRoot, journal) {
     const partialFailures = [];
@@ -328,7 +328,7 @@ async function requireGitEngineForRemove(type, name, engineDir) {
  * @param options - CLI options
  */
 export async function furnaceRemoveCommand(projectRoot, name, options = {}) {
-    const isInteractive = process.stdin.isTTY && process.stdout.isTTY;
+    const isInteractive = stdioIsInteractive();
     intro('Furnace Remove');
     const config = await loadFurnaceConfig(projectRoot);
     const furnacePaths = getFurnacePaths(projectRoot);
@@ -405,17 +405,12 @@ export async function furnaceRemoveCommand(projectRoot, name, options = {}) {
             }
         }
         catch (error) {
-            // This body owns its rollback end to end, so tell the lifecycle wrapper
-            // not to restore the same journal again on the way out.
-            ctx.markRolledBack();
-            try {
-                await restoreRollbackJournalOrThrow(journal, `Failed to remove component "${name}"`);
-            }
-            catch (rollbackError) {
-                await recordFurnaceRollbackFailure(projectRoot, 'remove-rollback', `component "${name}": ${toError(rollbackError).message}`);
-                throw rollbackError;
-            }
-            throw error;
+            return await completeJournalRollback(ctx, journal, error, {
+                projectRoot: projectRoot,
+                operation: 'remove-rollback',
+                failureMessage: `Failed to remove component "${name}"`,
+                subject: `component "${name}"`,
+            });
         }
     });
     info(`Removed "${name}" from furnace.json`);

package/dist/src/commands/furnace/rename-xpcshell.d.ts

@@ -1,18 +1,15 @@
 /**
  * xpcshell scaffold rename helper extracted from `rename.ts`.
  *
- * 2026-04-24 eval Finding 5: `furnace create --with-tests --xpcshell`
- * writes a scaffold at `browser/base/content/test/<binary>-xpcshell/
- * <name>/` and `furnace rename` did not update it. The helper below
- * renames the directory, updates the test filename, rewrites the
- * `xpcshell.toml` section header, and re-writes the test body so word-
- * boundary occurrences of the old tag / underscored name map to the new
- * ones.
+ * `furnace create --with-tests --xpcshell` writes a scaffold at
+ * `browser/base/content/test/<binary>-xpcshell/<name>/`, which a rename must
+ * follow. This helper renames the directory, updates the test filename,
+ * rewrites the `xpcshell.toml` section header, and re-writes the test body
+ * so word-boundary occurrences of the old tag / underscored name map to the
+ * new ones.
  *
- * Extracted to keep `rename.ts` under the per-file LOC budget —
- * `rename.ts` already carries mochikit + browser-mochitest + FTL
- * handling, and tacking xpcshell onto that tree pushed the file past
- * the limit.
+ * Extracted to keep `rename.ts` under the per-file LOC budget — it already
+ * carries mochikit + browser-mochitest + FTL handling.
  */
 import { type RollbackJournal } from '../../core/furnace-rollback.js';
 /**

package/dist/src/commands/furnace/rename-xpcshell.js

@@ -2,18 +2,15 @@
 /**
  * xpcshell scaffold rename helper extracted from `rename.ts`.
  *
- * 2026-04-24 eval Finding 5: `furnace create --with-tests --xpcshell`
- * writes a scaffold at `browser/base/content/test/<binary>-xpcshell/
- * <name>/` and `furnace rename` did not update it. The helper below
- * renames the directory, updates the test filename, rewrites the
- * `xpcshell.toml` section header, and re-writes the test body so word-
- * boundary occurrences of the old tag / underscored name map to the new
- * ones.
+ * `furnace create --with-tests --xpcshell` writes a scaffold at
+ * `browser/base/content/test/<binary>-xpcshell/<name>/`, which a rename must
+ * follow. This helper renames the directory, updates the test filename,
+ * rewrites the `xpcshell.toml` section header, and re-writes the test body
+ * so word-boundary occurrences of the old tag / underscored name map to the
+ * new ones.
  *
- * Extracted to keep `rename.ts` under the per-file LOC budget —
- * `rename.ts` already carries mochikit + browser-mochitest + FTL
- * handling, and tacking xpcshell onto that tree pushed the file past
- * the limit.
+ * Extracted to keep `rename.ts` under the per-file LOC budget — it already
+ * carries mochikit + browser-mochitest + FTL handling.
  */
 import { readdir } from 'node:fs/promises';
 import { join } from 'node:path';