@hominis/fireforge 0.35.0 → 0.37.0

package/dist/src/utils/validation.js

@@ -18,7 +18,10 @@ export function isString(value) {
  * @returns True if value is a finite number
  */
 export function isNumber(value) {
-    return typeof value === 'number' && !Number.isNaN(value);
+    // Number.isFinite matches the documented contract: NaN AND ±Infinity are
+    // excluded (a JSON config field of 1e999 parses to Infinity and used to
+    // validate as a legal number).
+    return typeof value === 'number' && Number.isFinite(value);
 }
 /**
  * Checks whether a value is a positive integer (greater than zero).
@@ -75,26 +78,6 @@ export function isObject(value) {
 export function isArray(value) {
     return Array.isArray(value);
 }
-/**
- * Asserts that a value is a string or throws.
- * @param value - Value to check
- * @param name - Name of the field for error messages
- */
-export function assertString(value, name) {
-    if (!isString(value)) {
-        throw new InvalidArgumentError(`Expected ${name} to be a string, got ${typeof value}`, name);
-    }
-}
-/**
- * Asserts that a value is a non-null object or throws.
- * @param value - Value to check
- * @param name - Name of the field for error messages
- */
-export function assertObject(value, name) {
-    if (!isObject(value)) {
-        throw new InvalidArgumentError(`Expected ${name} to be an object, got ${typeof value}`, name);
-    }
-}
 /**
  * Validates a Firefox version string.
  * Accepts formats like "140.9.0", "140.9.1", "140.9.0esr", "147.0b1"
@@ -232,11 +215,16 @@ export function validateTokenName(name) {
     if (/[\x00-\x1f\x7f]/.test(ident)) {
         return `Token name must not contain control characters: "${name}"`;
     }
-    if (ident.includes('*/')) {
-        return `Token name must not contain "*/" (would break CSS comments): "${name}"`;
+    if (ident.includes('*/') || ident.includes('/*')) {
+        // `/*` is the worse of the two by this function's own standard: an
+        // ident containing it opens an UNTERMINATED comment in tokens.css
+        // that swallows every following declaration.
+        return `Token name must not contain "/*" or "*/" (would break CSS comments): "${name}"`;
     }
-    // Reject characters that would break CSS declaration syntax
-    if (/[{}();!]/.test(ident)) {
+    // Reject characters that would break CSS declaration syntax. Quotes are
+    // included: a quote character in an ident opens a CSS string that eats
+    // the rest of the declaration block.
+    if (/[{}();!'"]/.test(ident)) {
         return `Token name contains characters that would corrupt CSS syntax: "${name}"`;
     }
     return undefined;
@@ -270,4 +258,3 @@ export function validatePatchName(name) {
         return 'Name can only contain letters, numbers, hyphens, underscores, and spaces';
     return undefined;
 }
-//# sourceMappingURL=validation.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hominis/fireforge",
-  "version": "0.35.0",
+  "version": "0.37.0",
   "description": "FireForge — a build tool for customizing Firefox",
   "type": "module",
   "main": "./dist/src/index.js",
@@ -20,9 +20,9 @@
     "fireforge": "tsx bin/fireforge.ts",
     "build": "npm run clean && tsc -p tsconfig.build.json",
     "clean": "node ./scripts/clean.mjs",
-    "lint": "eslint src/ bin/ scripts/ eslint.config.js vitest.config.ts",
-    "lint:ci": "eslint src/ bin/ scripts/ eslint.config.js vitest.config.ts --max-warnings 0",
-    "lint:fix": "eslint src/ bin/ scripts/ eslint.config.js vitest.config.ts --fix",
+    "lint": "eslint src/ bin/ scripts/ eslint.config.js vitest.config.ts vitest.pack.config.ts",
+    "lint:ci": "eslint src/ bin/ scripts/ eslint.config.js vitest.config.ts vitest.pack.config.ts --max-warnings 0",
+    "lint:fix": "eslint src/ bin/ scripts/ eslint.config.js vitest.config.ts vitest.pack.config.ts --fix",
     "typecheck": "tsc --noEmit -p tsconfig.json",
     "deadcode:check": "knip",
     "cycles:check": "dpdm --no-output --no-tree --no-warning --exit-code circular:1 src/index.ts bin/fireforge.ts",
@@ -32,10 +32,10 @@
     "test:coverage": "vitest run --coverage && node ./scripts/check-coverage-thresholds.mjs",
     "test:firefox-full": "node ./scripts/run-full-firefox-integration.mjs",
     "whitespace:check": "node ./scripts/check-worktree-whitespace.mjs",
-    "pack:verify": "vitest run src/__tests__/wrapper-smoke.test.ts",
+    "pack:verify": "vitest run --config vitest.pack.config.ts",
     "pack:dry-run": "npm pack --dry-run --json --silent",
-    "format": "prettier --write --ignore-unknown \"src/**/*.ts\" \"bin/**/*.ts\" \"scripts/**/*.mjs\" \"package.json\" \"eslint.config.js\" \"vitest.config.ts\" \"tsconfig.json\" \"tsconfig.build.json\" \".lintstagedrc.json\" \".prettierignore\" \".prettierrc\" \".gitignore\" \"README.md\" \"CHANGELOG.md\"",
-    "format:check": "prettier --check --ignore-unknown \"src/**/*.ts\" \"bin/**/*.ts\" \"scripts/**/*.mjs\" \"package.json\" \"eslint.config.js\" \"vitest.config.ts\" \"tsconfig.json\" \"tsconfig.build.json\" \".lintstagedrc.json\" \".prettierignore\" \".prettierrc\" \".gitignore\" \"README.md\" \"CHANGELOG.md\"",
+    "format": "prettier --write --ignore-unknown \"src/**/*.ts\" \"bin/**/*.ts\" \"scripts/**/*.mjs\" \"package.json\" \"eslint.config.js\" \"vitest.config.ts\" \"vitest.pack.config.ts\" \"tsconfig.json\" \"tsconfig.build.json\" \".lintstagedrc.json\" \".prettierignore\" \".prettierrc\" \".gitignore\" \"README.md\" \"CHANGELOG.md\" \"docs/**/*.md\" \"knip.json\" \"docs/**/*.md\" \"knip.json\"",
+    "format:check": "prettier --check --ignore-unknown \"src/**/*.ts\" \"bin/**/*.ts\" \"scripts/**/*.mjs\" \"package.json\" \"eslint.config.js\" \"vitest.config.ts\" \"vitest.pack.config.ts\" \"tsconfig.json\" \"tsconfig.build.json\" \".lintstagedrc.json\" \".prettierignore\" \".prettierrc\" \".gitignore\" \"README.md\" \"CHANGELOG.md\" \"docs/**/*.md\" \"knip.json\" \"docs/**/*.md\" \"knip.json\"",
     "prepare": "node -e \"import('./scripts/prepare.mjs').catch((error) => { if (error && typeof error === 'object' && 'code' in error && error.code === 'ERR_MODULE_NOT_FOUND') process.exit(0); throw error; })\"",
     "prepack": "npm run build",
     "release:check": "npm run format:check && npm run whitespace:check && npm run lint:ci && npm run typecheck && npm run deadcode:check && npm run cycles:check && npm run test:coverage && npm run pack:verify && npm run pack:dry-run",
@@ -57,6 +57,7 @@
     "acorn": "^8.14.0",
     "commander": "^15.0.0",
     "estree-walker": "^3.0.3",
+    "jsonc-parser": "^3.3.1",
     "magic-string": "^0.30.17",
     "picocolors": "^1.1.0"
   },
@@ -72,7 +73,7 @@
     "eslint-plugin-simple-import-sort": "^13.0.0",
     "fast-check": "^4.6.0",
     "husky": "^9.1.7",
-    "knip": "6.23.0",
+    "knip": "6.25.0",
     "lint-staged": "^17.0.4",
     "prettier": "3.9.4",
     "tsx": "^4.7.0",