@hominis/fireforge 0.15.2 → 0.15.3

package/dist/src/core/mach.d.ts

@@ -57,14 +57,17 @@ export declare function bootstrap(engineDir: string): Promise<number>;
  */
 export declare function bootstrapWithOutput(engineDir: string): Promise<MachCommandResult>;
 /**
- * Runs a full mach build.
+ * Runs a full mach build. On a non-zero exit, any matched error hints are
+ * surfaced on top of the raw mach output so operators get an actionable
+ * nudge alongside the cryptic mozbuild traceback.
  * @param engineDir - Path to the engine directory
  * @param jobs - Number of parallel jobs (optional)
  * @returns Exit code
  */
 export declare function build(engineDir: string, jobs?: number): Promise<number>;
 /**
- * Runs a fast UI-only build.
+ * Runs a fast UI-only build. On a non-zero exit, any matched error hints are
+ * surfaced on top of the raw mach output.
  * @param engineDir - Path to the engine directory
  * @returns Exit code
  */

package/dist/src/core/mach.js

@@ -2,7 +2,9 @@
 import { join } from 'node:path';
 import { MachNotFoundError } from '../errors/build.js';
 import { pathExists } from '../utils/fs.js';
+import { warn } from '../utils/logger.js';
 import { exec, execInherit, execInheritCapture, execStream } from '../utils/process.js';
+import { explainMachError } from './mach-error-hints.js';
 import { getPython } from './mach-python.js';
 // Re-export sub-modules so existing `from './mach.js'` imports keep working.
 export { buildArtifactMismatchMessage, hasBuildArtifacts, } from './mach-build-artifacts.js';
@@ -109,7 +111,23 @@ export async function bootstrapWithOutput(engineDir) {
     return runMachInheritCapture(['bootstrap', '--application-choice', 'browser'], engineDir);
 }
 /**
- * Runs a full mach build.
+ * Prints any matched {@link MachErrorHint} hints for the captured stderr.
+ * No-op when nothing matches. Always called before a non-zero exit propagates
+ * so the hint sits immediately below the raw mach error in the operator's
+ * terminal.
+ */
+function surfaceMachErrorHints(stderr) {
+    const hints = explainMachError(stderr);
+    if (hints.length === 0)
+        return;
+    for (const hint of hints) {
+        warn(`Hint: ${hint}`);
+    }
+}
+/**
+ * Runs a full mach build. On a non-zero exit, any matched error hints are
+ * surfaced on top of the raw mach output so operators get an actionable
+ * nudge alongside the cryptic mozbuild traceback.
  * @param engineDir - Path to the engine directory
  * @param jobs - Number of parallel jobs (optional)
  * @returns Exit code
@@ -119,15 +137,24 @@ export async function build(engineDir, jobs) {
     if (jobs !== undefined) {
         args.push('-j', String(jobs));
     }
-    return runMach(args, engineDir, { inherit: true });
+    const result = await runMachInheritCapture(args, engineDir);
+    if (result.exitCode !== 0) {
+        surfaceMachErrorHints(result.stderr);
+    }
+    return result.exitCode;
 }
 /**
- * Runs a fast UI-only build.
+ * Runs a fast UI-only build. On a non-zero exit, any matched error hints are
+ * surfaced on top of the raw mach output.
  * @param engineDir - Path to the engine directory
  * @returns Exit code
  */
 export async function buildUI(engineDir) {
-    return runMach(['build', 'faster'], engineDir, { inherit: true });
+    const result = await runMachInheritCapture(['build', 'faster'], engineDir);
+    if (result.exitCode !== 0) {
+        surfaceMachErrorHints(result.stderr);
+    }
+    return result.exitCode;
 }
 /**
  * Runs the built browser.

package/dist/src/core/patch-lint-diff-tag.d.ts

@@ -0,0 +1,33 @@
+/**
+ * Diff-scoping for `fireforge lint`.
+ *
+ * Pre-existing patch-state errors and errors introduced by the current task
+ * print identically today, so triaging "is the diff I just produced clean?"
+ * requires mentally subtracting the pre-existing noise. This module
+ * classifies each lint issue as either `introduced` (the file was touched
+ * since the user-supplied git revision) or `cumulative` (pre-existing
+ * drift), without changing what the underlying rules emit.
+ */
+import type { PatchLintIssue } from '../types/commands/index.js';
+/**
+ * Collects engine-relative paths that changed between `rev` and `HEAD`,
+ * plus any workdir modifications and untracked files. An empty set means
+ * "no diff we can prove" — downstream treats every issue as `cumulative`
+ * in that case (operator ran `lint --since HEAD` with no pending work).
+ * @param engineDir Path to the engine git repository.
+ * @param rev Git revision to diff against (e.g. `HEAD`, a branch, a SHA).
+ */
+export declare function collectDiffFilePaths(engineDir: string, rev: string): Promise<Set<string>>;
+/**
+ * Annotates a list of lint issues with `introduced` / `cumulative` tags
+ * based on whether the issue's file is part of the supplied diff set.
+ * Mutates each issue in place AND returns the list for chaining.
+ *
+ * Issues with no file (`issue.file === ''`) — e.g. cross-patch rules that
+ * describe queue-wide state — are always `cumulative` under `--since`
+ * because they describe drift accumulated across many commits, not a
+ * single current-task edit.
+ * @param issues Issues returned by the lint orchestrator.
+ * @param diffFiles File paths touched since the user's revision.
+ */
+export declare function tagLintIssues(issues: PatchLintIssue[], diffFiles: Set<string>): PatchLintIssue[];

package/dist/src/core/patch-lint-diff-tag.js

@@ -0,0 +1,83 @@
+// SPDX-License-Identifier: EUPL-1.2
+/**
+ * Diff-scoping for `fireforge lint`.
+ *
+ * Pre-existing patch-state errors and errors introduced by the current task
+ * print identically today, so triaging "is the diff I just produced clean?"
+ * requires mentally subtracting the pre-existing noise. This module
+ * classifies each lint issue as either `introduced` (the file was touched
+ * since the user-supplied git revision) or `cumulative` (pre-existing
+ * drift), without changing what the underlying rules emit.
+ */
+import { toError } from '../utils/errors.js';
+import { verbose } from '../utils/logger.js';
+import { isMissingHeadError } from './git.js';
+import { git } from './git-base.js';
+import { getUntrackedFiles } from './git-status.js';
+/**
+ * Collects engine-relative paths that changed between `rev` and `HEAD`,
+ * plus any workdir modifications and untracked files. An empty set means
+ * "no diff we can prove" — downstream treats every issue as `cumulative`
+ * in that case (operator ran `lint --since HEAD` with no pending work).
+ * @param engineDir Path to the engine git repository.
+ * @param rev Git revision to diff against (e.g. `HEAD`, a branch, a SHA).
+ */
+export async function collectDiffFilePaths(engineDir, rev) {
+    const files = new Set();
+    try {
+        const commitDiff = await git(['diff', '--name-only', `${rev}...HEAD`], engineDir);
+        for (const line of commitDiff.split('\n')) {
+            const trimmed = line.trim();
+            if (trimmed)
+                files.add(trimmed);
+        }
+    }
+    catch (error) {
+        if (!isMissingHeadError(error)) {
+            verbose(`lint --since: could not diff against ${rev} — ${toError(error).message}`);
+        }
+    }
+    try {
+        const worktreeDiff = await git(['diff', '--name-only', 'HEAD'], engineDir);
+        for (const line of worktreeDiff.split('\n')) {
+            const trimmed = line.trim();
+            if (trimmed)
+                files.add(trimmed);
+        }
+    }
+    catch (error) {
+        verbose(`lint --since: could not enumerate workdir diff — ${toError(error).message}`);
+    }
+    try {
+        for (const file of await getUntrackedFiles(engineDir)) {
+            files.add(file);
+        }
+    }
+    catch (error) {
+        verbose(`lint --since: could not list untracked files — ${toError(error).message}`);
+    }
+    return files;
+}
+/**
+ * Annotates a list of lint issues with `introduced` / `cumulative` tags
+ * based on whether the issue's file is part of the supplied diff set.
+ * Mutates each issue in place AND returns the list for chaining.
+ *
+ * Issues with no file (`issue.file === ''`) — e.g. cross-patch rules that
+ * describe queue-wide state — are always `cumulative` under `--since`
+ * because they describe drift accumulated across many commits, not a
+ * single current-task edit.
+ * @param issues Issues returned by the lint orchestrator.
+ * @param diffFiles File paths touched since the user's revision.
+ */
+export function tagLintIssues(issues, diffFiles) {
+    for (const issue of issues) {
+        if (!issue.file) {
+            issue.tag = 'cumulative';
+            continue;
+        }
+        issue.tag = diffFiles.has(issue.file) ? 'introduced' : 'cumulative';
+    }
+    return issues;
+}
+//# sourceMappingURL=patch-lint-diff-tag.js.map

package/dist/src/types/commands/options.d.ts

@@ -281,6 +281,21 @@ export interface FurnaceCreateOptions {
      * `XPCSHELL_TESTS_MANIFESTS`).
      */
     xpcshell?: boolean;
+    /**
+     * Test harness style to scaffold when `--with-tests` is set.
+     *
+     * - `mochikit` (default when `--with-tests` is set alone) — a MochiKit
+     *   test at `engine/toolkit/content/tests/widgets/test_<tag>.html` that
+     *   loads the component module directly via `chrome://global/` and
+     *   asserts against `customElements`. Runs today on forks whose
+     *   top-level chrome document (e.g. `mybrowser.xhtml`) lacks a
+     *   `tabbrowser`, because it doesn't go through `URILoadingHelper`.
+     * - `browser-chrome` — today's browser-mochitest scaffold, requires a
+     *   working tabbrowser. Use for components that talk to the browser
+     *   window or open URLs.
+     * - `xpcshell` — equivalent to setting `--xpcshell`; headless, storage-only.
+     */
+    testStyle?: 'mochikit' | 'browser-chrome' | 'xpcshell';
     /** Stock component tag names composed internally by this component */
     compose?: string[];
 }

package/dist/src/types/commands/patches.d.ts

@@ -96,4 +96,13 @@ export interface PatchLintIssue {
     message: string;
     /** Severity: errors block export, warnings are advisory, notices are informational (not counted) */
     severity: 'error' | 'warning' | 'notice';
+    /**
+     * Diff-scoping tag populated by `lint --since <rev>`. Absent when the
+     * caller did not request diff-scoping.
+     *
+     * - `introduced` — the issue's file was touched in the diff since `<rev>`.
+     * - `cumulative` — the issue is pre-existing patch-state drift not
+     *   introduced by the current task.
+     */
+    tag?: 'introduced' | 'cumulative';
 }

package/dist/src/types/furnace.d.ts

@@ -106,7 +106,7 @@ export interface FurnaceConfig {
  * state before clearing authoring markers. The string is surfaced in doctor's
  * failure message verbatim, so new entries should be self-explanatory.
  */
-export type FurnacePendingRepairOperation = 'preview-teardown' | 'apply-rollback' | 'deploy-rollback' | 'remove-rollback' | 'create-rollback' | 'override-rollback' | 'scan-rollback' | 'rename-rollback' | 'refresh-rollback';
+export type FurnacePendingRepairOperation = 'preview-teardown' | 'apply-rollback' | 'deploy-rollback' | 'remove-rollback' | 'create-rollback' | 'override-rollback' | 'scan-rollback' | 'rename-rollback' | 'refresh-rollback' | 'chrome-doc-rollback';
 /**
  * Marker persisted into `.fireforge/furnace-state.json` when a furnace
  * mutation failed to roll back cleanly. Its presence tells the next

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hominis/fireforge",
-  "version": "0.15.2",
+  "version": "0.15.3",
   "description": "FireForge — a build tool for customizing Firefox",
   "type": "module",
   "main": "./dist/src/index.js",