@hominis/fireforge 0.11.2 → 0.12.0

package/dist/src/core/patch-lint.js

@@ -6,7 +6,10 @@ import { verbose } from '../utils/logger.js';
 import { hasRawCssColors, stripJsComments } from '../utils/regex.js';
 import { loadFurnaceConfig } from './furnace-config.js';
 import { getLicenseHeader, hasAnyLicenseHeader } from './license-headers.js';
+import { runCheckJs } from './patch-lint-checkjs.js';
 import { detectNewFilesInDiff, extractAddedLinesPerFile } from './patch-lint-diff.js';
+import { validateExportJsDoc } from './patch-lint-jsdoc.js';
+import { resolvePatchOwnedSysMjs } from './patch-lint-ownership.js';
 // ---------------------------------------------------------------------------
 // Cross-patch lint re-exports
 // ---------------------------------------------------------------------------
@@ -16,8 +19,11 @@ import { detectNewFilesInDiff, extractAddedLinesPerFile } from './patch-lint-dif
 // `patch-lint-cross.ts` so the per-patch and cross-patch rule bodies can
 // each stay within the project's per-file line budget. Re-export the
 // public surface so callers continue to import from a single module.
+export { runCheckJs } from './patch-lint-checkjs.js';
 export { buildPatchQueueContext, collectNewFileCreatorsByPath, extractImportSpecifiers, extractImportSpecifiersWithLines, findForwardImportIgnoreLines, FORWARD_IMPORT_IGNORE_MARKER, isForwardImportableFile, lintPatchQueue, lintPatchQueueDuplicateCreations, lintPatchQueueForwardImports, } from './patch-lint-cross.js';
 export { buildModifiedFileAdditionsFromDiff, detectNewFilesInDiff } from './patch-lint-diff.js';
+export { validateExportJsDoc } from './patch-lint-jsdoc.js';
+export { resolvePatchOwnedSysMjs } from './patch-lint-ownership.js';
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------
@@ -156,9 +162,10 @@ export async function lintNewFileHeaders(repoDir, newFiles, config) {
  * @param affectedFiles - File paths (relative to repoDir)
  * @param newFiles - Set of files that are newly created in this patch
  * @param config - Project configuration
+ * @param patchOwnedFiles - Optional set of patch-owned `.sys.mjs` paths for scoped JSDoc enforcement
  * @returns Array of lint issues
  */
-export async function lintPatchedJs(repoDir, affectedFiles, newFiles, config) {
+export async function lintPatchedJs(repoDir, affectedFiles, newFiles, config, patchOwnedFiles) {
     const jsFiles = affectedFiles.filter(isJsFile);
     if (jsFiles.length === 0)
         return [];
@@ -195,32 +202,17 @@ export async function lintPatchedJs(repoDir, affectedFiles, newFiles, config) {
                 });
             }
         }
-        // 3. JSDoc on exports (new .sys.mjs files only)
-        if (isNew && isSysMjs) {
-            const lines = content.split('\n');
-            for (let i = 0; i < lines.length; i++) {
-                const line = lines[i] ?? '';
-                if (/^export\s+(function|class|const|let|var)\s/.test(line)) {
-                    // Walk backwards to find JSDoc
-                    let hasJsDoc = false;
-                    for (let j = i - 1; j >= 0; j--) {
-                        const prev = (lines[j] ?? '').trim();
-                        if (prev === '')
-                            continue;
-                        if (prev.endsWith('*/')) {
-                            hasJsDoc = true;
-                        }
-                        break;
-                    }
-                    if (!hasJsDoc) {
-                        issues.push({
-                            file,
-                            check: 'missing-jsdoc',
-                            message: `Export at line ${i + 1} is missing a JSDoc comment with @param/@returns.`,
-                            severity: 'warning',
-                        });
-                    }
-                }
+        // 3. JSDoc on exports (patch-owned .sys.mjs files)
+        const isOwned = patchOwnedFiles ? patchOwnedFiles.has(file) : isNew;
+        if (isOwned && isSysMjs) {
+            const jsdocIssues = validateExportJsDoc(content);
+            for (const jsdocIssue of jsdocIssues) {
+                issues.push({
+                    file,
+                    check: jsdocIssue.check,
+                    message: jsdocIssue.message,
+                    severity: 'error',
+                });
             }
         }
         // 4. Observer topic naming
@@ -346,20 +338,22 @@ export async function lintModifiedFileHeaders(repoDir, affectedFiles, newFiles)
  * @param affectedFiles - File paths (relative to repoDir) affected by the patch
  * @param diffContent - Raw unified diff string
  * @param config - Project configuration
+ * @param patchQueueCtx - Optional cross-patch context for ownership resolution
  * @returns Array of all lint issues found
  */
-export async function lintExportedPatch(repoDir, affectedFiles, diffContent, config) {
+export async function lintExportedPatch(repoDir, affectedFiles, diffContent, config, patchQueueCtx) {
     const newFiles = detectNewFilesInDiff(diffContent);
     const lineCount = diffContent.split('\n').length;
+    const patchOwnedFiles = resolvePatchOwnedSysMjs(newFiles, patchQueueCtx);
     const [cssIssues, headerIssues, jsIssues, modifiedHeaderIssues] = await Promise.all([
         lintPatchedCss(repoDir, affectedFiles, diffContent),
         lintNewFileHeaders(repoDir, [...newFiles], config),
-        lintPatchedJs(repoDir, affectedFiles, newFiles, config),
+        lintPatchedJs(repoDir, affectedFiles, newFiles, config, patchOwnedFiles),
         lintModifiedFileHeaders(repoDir, affectedFiles, newFiles),
     ]);
     const modCommentIssues = lintModificationComments(diffContent, config);
     const sizeIssues = lintPatchSize(affectedFiles, lineCount);
-    return [
+    const issues = [
         ...sizeIssues,
         ...cssIssues,
         ...headerIssues,
@@ -367,5 +361,11 @@ export async function lintExportedPatch(repoDir, affectedFiles, diffContent, con
         ...jsIssues,
         ...modCommentIssues,
     ];
+    // Optional checkJs pass — only when explicitly enabled in config
+    if (config.patchLint?.checkJs) {
+        const checkJsIssues = await runCheckJs(repoDir, patchOwnedFiles);
+        issues.push(...checkJsIssues);
+    }
+    return issues;
 }
 //# sourceMappingURL=patch-lint.js.map

package/dist/src/types/config.d.ts

@@ -42,6 +42,8 @@ export interface FireForgeConfig {
     license?: ProjectLicense;
     /** Wire command configuration */
     wire?: WireConfig;
+    /** Patch lint configuration */
+    patchLint?: PatchLintConfig;
 }
 /**
  * Wire command configuration.
@@ -50,6 +52,13 @@ export interface WireConfig {
     /** Subscript directory relative to engine/. Default: "browser/base/content" */
     subscriptDir?: string;
 }
+/**
+ * Configuration for patch lint rules.
+ */
+export interface PatchLintConfig {
+    /** Enable TypeScript checkJs pass on patch-owned .sys.mjs files */
+    checkJs?: boolean;
+}
 /**
  * Build mode for mach.
  */

package/dist/src/utils/paths.js

@@ -12,6 +12,8 @@ export function isExplicitAbsolutePath(path) {
 }
 /** Resolves a candidate path and returns whether it stays within the given root. */
 export function isPathInsideRoot(root, candidate) {
+    if (candidate.includes('\0'))
+        return false;
     const resolvedRoot = resolve(root);
     const resolvedCandidate = isExplicitAbsolutePath(candidate)
         ? resolve(candidate)
@@ -24,7 +26,7 @@ export function isPathInsideRoot(root, candidate) {
 }
 /** Checks whether a relative path stays contained within an arbitrary root. */
 export function isContainedRelativePath(path) {
-    if (isExplicitAbsolutePath(path)) {
+    if (isExplicitAbsolutePath(path) || path.includes('\0')) {
         return false;
     }
     return isPathInsideRoot(RELATIVE_PATH_ROOT, path);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hominis/fireforge",
-  "version": "0.11.2",
+  "version": "0.12.0",
   "description": "FireForge — a build tool for customizing Firefox",
   "type": "module",
   "main": "./dist/src/index.js",