@homeflare/alchemy 0.32.0 → 0.34.0

package/src/grafana/dashboard.test.ts

@@ -0,0 +1,232 @@
+/**
+ * `Grafana.Dashboard` against a fake Grafana — the noop-despite-volatile-fields normalization, the
+ * provisioned-object refusal, and 412 propagating as a genuine failure rather than being caught or
+ * overwritten blindly. Mirrors `datasource.test.ts`/`folder.test.ts`.
+ */
+import { describe, expect, test } from 'bun:test';
+import * as Effect from 'effect/Effect';
+import { spec } from './dashboard.ts';
+import { fakeFailure, fakeGrafana, fakeGrafanaLayer } from './fake-grafana.ts';
+import { GrafanaProvisionedObjectError } from './provisioned.ts';
+import { grafanaOperations } from './resource.ts';
+
+const DASH_PATH = '/api/dashboards/uid/fleet-overview';
+const CREATE_PATH = '/api/dashboards/db';
+
+const model = { panels: [{ id: 1, title: 'CPU' }], title: 'Fleet Overview' };
+
+const liveJson = {
+  dashboard: { ...model, id: 42, uid: 'fleet-overview', version: 3 },
+  meta: {
+    folderUid: 'infra',
+    provisioned: false,
+    provisionedExternalId: '',
+    url: '/d/fleet-overview',
+    version: 3,
+  },
+};
+
+const props = { dashboard: model, folderUid: 'infra', uid: 'fleet-overview' };
+
+describe('spec.fetchLive', () => {
+  test('a live dashboard decodes and normalizes into typed attributes', async () => {
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === DASH_PATH
+        ? Response.json(liveJson)
+        : fakeFailure(404, 'not found'),
+    );
+    const live = await Effect.runPromise(
+      spec.fetchLive(props).pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(live !== undefined && spec.attributes(live, props)).toEqual({
+      dashboard: { ...model, uid: 'fleet-overview' },
+      folderUid: 'infra',
+      provisioned: false,
+      provisionedExternalId: '',
+      title: 'Fleet Overview',
+      uid: 'fleet-overview',
+      url: '/d/fleet-overview',
+      version: 3,
+    });
+    expect(fake.bodies[0]).toBeUndefined();
+  });
+
+  test('a 404 folds to undefined', async () => {
+    const fake = fakeGrafana(() => fakeFailure(404, 'dashboard not found'));
+    const result = await Effect.runPromise(
+      spec.fetchLive(props).pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(result).toBeUndefined();
+  });
+});
+
+describe('create', () => {
+  test('sends the normalized model and folderUid — no volatile fields, no extra keys', async () => {
+    const fake = fakeGrafana((method, url) =>
+      method === 'POST' && url.pathname === CREATE_PATH
+        ? Response.json({
+            folderUid: 'infra',
+            id: 42,
+            status: 'success',
+            title: 'Fleet Overview',
+            uid: 'fleet-overview',
+            url: '/d/fleet-overview',
+            version: 1,
+          })
+        : fakeFailure(404, 'unexpected request'),
+    );
+    await Effect.runPromise(spec.create(props).pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))));
+    expect(fake.bodies[0]).toEqual({
+      dashboard: { ...model, uid: 'fleet-overview' },
+      folderUid: 'infra',
+    });
+  });
+});
+
+describe('reconcile — noop despite volatile fields', () => {
+  test('a declared model matching live content is a noop even though id/version/iteration differ', async () => {
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === DASH_PATH
+        ? Response.json(liveJson)
+        : fakeFailure(500, 'reconcile should not write when content is unchanged'),
+    );
+    const after = await Effect.runPromise(
+      grafanaOperations(spec)
+        .reconcile(props)
+        .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(after.uid).toBe('fleet-overview');
+    expect(fake.seen.every((s) => s.method === 'GET')).toBe(true);
+  });
+});
+
+describe('update', () => {
+  // ★ ALL THREE TESTS GO THROUGH `grafanaOperations(spec).reconcile`, NOT `spec.update` DIRECTLY —
+  //   `update` is optional on the shared `GrafanaSpec` type, and `reconcile` is what production
+  //   code actually calls; it also exercises the SAME `fetchLive` → `matches` → `update` sequence a
+  //   real plan/deploy does, rather than a hand-assembled `live` argument.
+  test('a content change sends the live version for optimistic concurrency, never overwrite', async () => {
+    const changed = { ...model, title: 'Fleet Overview v2' };
+    let saved = false;
+    const fake = fakeGrafana((method, url) => {
+      if (method === 'GET' && url.pathname === DASH_PATH) {
+        return Response.json(
+          saved
+            ? {
+                dashboard: { ...changed, id: 42, uid: 'fleet-overview', version: 4 },
+                meta: { ...liveJson.meta, version: 4 },
+              }
+            : liveJson,
+        );
+      }
+      if (method === 'POST' && url.pathname === CREATE_PATH) {
+        saved = true;
+        return Response.json({
+          folderUid: 'infra',
+          id: 42,
+          status: 'success',
+          title: 'Fleet Overview v2',
+          uid: 'fleet-overview',
+          url: '/d/fleet-overview',
+          version: 4,
+        });
+      }
+      return fakeFailure(500, 'unexpected request');
+    });
+    await Effect.runPromise(
+      grafanaOperations(spec)
+        .reconcile({ ...props, dashboard: changed })
+        .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    const post = fake.seen.findIndex((s) => s.method === 'POST');
+    expect(fake.bodies[post]).toMatchObject({
+      dashboard: { ...changed, uid: 'fleet-overview', version: 3 },
+    });
+    // ⛔ `overwrite` IS NEVER SET — Grafana's own version check stays live on every update.
+    expect((fake.bodies[post] as { overwrite?: boolean }).overwrite).toBeUndefined();
+  });
+
+  test('a 412 from a concurrent save propagates — never caught, never retried here', async () => {
+    const changed = { ...model, title: 'Fleet Overview v2' };
+    const fake = fakeGrafana((method, url) => {
+      if (method === 'GET' && url.pathname === DASH_PATH) return Response.json(liveJson);
+      if (method === 'POST' && url.pathname === CREATE_PATH) {
+        return fakeFailure(412, 'The dashboard has been changed by someone else');
+      }
+      return fakeFailure(500, 'unexpected request');
+    });
+    const failure = await Effect.runPromise(
+      Effect.flip(
+        grafanaOperations(spec)
+          .reconcile({ ...props, dashboard: changed })
+          .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+      ),
+    );
+    expect(failure._tag).toBe('PreconditionFailed');
+  });
+
+  test('a provisioned dashboard refuses the write, naming its owning file', async () => {
+    const provisioned = {
+      ...liveJson,
+      meta: { ...liveJson.meta, provisioned: true, provisionedExternalId: 'dashboards/fleet.json' },
+    };
+    const changed = { ...model, title: 'Fleet Overview v2' };
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === DASH_PATH
+        ? Response.json(provisioned)
+        : fakeFailure(500, 'no write should be attempted'),
+    );
+    const failure = await Effect.runPromise(
+      Effect.flip(
+        grafanaOperations(spec)
+          .reconcile({ ...props, dashboard: changed })
+          .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+      ),
+    );
+    expect(failure).toBeInstanceOf(GrafanaProvisionedObjectError);
+    expect(failure.message).toContain('dashboards/fleet.json');
+    expect(fake.seen.every((s) => s.method === 'GET')).toBe(true);
+  });
+});
+
+describe('destroy', () => {
+  test('deletes a live, non-provisioned dashboard by uid', async () => {
+    const fake = fakeGrafana((method, url) => {
+      if (method === 'GET' && url.pathname === DASH_PATH) return Response.json(liveJson);
+      if (method === 'DELETE' && url.pathname === DASH_PATH) {
+        return Response.json({ message: 'ok', title: 'Fleet Overview', uid: 'fleet-overview' });
+      }
+      return fakeFailure(500, 'unexpected request');
+    });
+    await Effect.runPromise(
+      grafanaOperations(spec)
+        .destroy(props)
+        .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(fake.seen).toEqual([
+      { method: 'GET', path: DASH_PATH },
+      { method: 'DELETE', path: DASH_PATH },
+    ]);
+  });
+
+  test('a provisioned dashboard refuses destroy and sends no DELETE', async () => {
+    const provisioned = {
+      ...liveJson,
+      meta: { ...liveJson.meta, provisioned: true, provisionedExternalId: 'dashboards/fleet.json' },
+    };
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === DASH_PATH
+        ? Response.json(provisioned)
+        : fakeFailure(500, 'no DELETE should be attempted'),
+    );
+    const failure = await Effect.runPromise(
+      Effect.flip(
+        grafanaOperations(spec)
+          .destroy(props)
+          .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+      ),
+    );
+    expect(failure).toBeInstanceOf(GrafanaProvisionedObjectError);
+    expect(fake.seen).toEqual([{ method: 'GET', path: DASH_PATH }]);
+  });
+});

package/src/grafana/dashboard.ts

@@ -0,0 +1,161 @@
+/**
+ * `Grafana.Dashboard` — one Grafana dashboard, keyed by `uid`. Same uid-required doctrine as
+ * `datasource.ts`/`folder.ts` (`getDashboard`/`postDashboard`/`deleteDashboard` are all UID-keyed
+ * on the wire — `postDashboard`'s own `uid` travels INSIDE the `dashboard` JSON body, not as a
+ * request field, because Grafana's classic dashboard-save API has never had one; see
+ * `dashboard-model.ts`'s `normalizeModel`, which is what puts it there).
+ *
+ * ★ THE DECLARED CONTENT IS THE DASHBOARD JSON MODEL — `DashboardProps.dashboard`, the same shape
+ *   Grafana's own "Export as JSON" produces. `dashboard-model.ts`'s `normalizeModel` strips the
+ *   volatile fields (`id`, `version`, `iteration`) and forces `uid` to this resource's own value
+ *   before ANY comparison, so a plan against an unchanged dashboard is a true noop despite those
+ *   fields moving on every live save — see that file for the full reasoning, including which
+ *   fields (`panels`, `targets`) are array-ORDER-significant and compared as such.
+ *
+ * ⛔ `matches` COMPARES "IS THE DECLARATION A SUBSET OF WHAT IS LIVE", NOT PLAIN EQUALITY —
+ *   `dashboard-model.ts`'s `declaredContentMatches`, added after an adversarial review of this PR
+ *   found plain `deepEqual` made an ordinary dashboard show `update` FOREVER: Grafana's own
+ *   schema-migration on save decorates any panel/target whose `datasource` is absent with an
+ *   explicit reference, so a declaration that never sets one would permanently disagree with what
+ *   it reads back. See that function's own header for the full reasoning and the trade-off it
+ *   accepts (an omitted field can no longer be used to CLEAR a previously-set one).
+ *
+ * ⛔ VERSION CONFLICTS (412) FAIL LOUDLY — NEVER OVERWRITTEN BLINDLY. `update` injects the
+ *   `version` this resource just read (`live.meta.version`, from the SAME `fetchLive` call
+ *   `resource.ts`'s `reconcile` already made before calling `update`) into the model it sends, and
+ *   `overwrite` is never set. If Grafana's own version check then still fails — someone else saved
+ *   in the gap between that read and this write — `postDashboard` answers `412` and
+ *   `PreconditionFailed` is left IN the error union below, uncaught: the whole reconcile fails, the
+ *   deploy stops, and nothing is written. The next run's `fetchLive` re-reads the new live version
+ *   fresh, which is the "re-read" half of "re-read and fail loudly" — there is no separate retry
+ *   loop in this file, because the next `plan`/`deploy` invocation already IS that re-read.
+ *
+ * ⛔ A PROVISIONED DASHBOARD (`meta.provisioned` — see provisioned.ts) REFUSES EVERY UPDATE AND
+ *   DESTROY, naming `meta.provisionedExternalId` (the file) when Grafana reports one. `matches`
+ *   still compares structurally regardless, so a mismatched declaration against a provisioned
+ *   dashboard shows `update` in a plan rather than a silent, permanently-hidden noop.
+ *
+ * ⚠️ NO RETAIN DEFAULT, UNLIKE `Grafana.Folder`. Deleting one dashboard is a single-object blast
+ *   radius — the same class `Grafana.Datasource` already accepts without a retain guard — not
+ *   folder.ts's multi-object cascade (a folder's delete takes its dashboards AND their alert rules
+ *   with it). See folder.ts's file header for the full contrast.
+ */
+import { Resource } from 'alchemy';
+import * as Provider from 'alchemy/Provider';
+import * as grafana from '@distilled.cloud/grafana';
+import * as Effect from 'effect/Effect';
+import {
+  type DashboardModel,
+  declaredContentMatches,
+  modelTitle,
+  normalizeModel,
+} from './dashboard-model.ts';
+import { type GrafanaProvisionedObjectError, refuseIfProvisioned } from './provisioned.ts';
+import { type GrafanaSpec, grafanaHandlers } from './resource.ts';
+
+export type { DashboardModel };
+
+export interface DashboardProps {
+  uid: string;
+  /** Omit for the General/root folder. */
+  folderUid?: string;
+  /** The dashboard JSON model — see the file header. `id`/`version`/`iteration`/`uid` inside it
+   *  are ignored; `uid` above is the single source of truth. */
+  dashboard: DashboardModel;
+}
+
+export interface DashboardAttributes {
+  uid: string;
+  title: string;
+  version: number;
+  folderUid: string;
+  url: string;
+  /** True when Grafana reports this dashboard as file-provisioned (read-only — see provisioned.ts). */
+  provisioned: boolean;
+  provisionedExternalId: string;
+  /** The live model, normalized the same way `matches` compares it. */
+  dashboard: DashboardModel;
+}
+
+export interface GrafanaDashboard extends Resource<
+  'Grafana.Dashboard',
+  DashboardProps,
+  DashboardAttributes,
+  never
+> {}
+
+export const GrafanaDashboard = Resource<GrafanaDashboard>('Grafana.Dashboard');
+
+const modelOf = (live: grafana.DashboardFullWithMeta): DashboardModel =>
+  live.dashboard !== null && typeof live.dashboard === 'object'
+    ? (live.dashboard as DashboardModel)
+    : {};
+
+export const spec: GrafanaSpec<
+  DashboardProps,
+  grafana.DashboardFullWithMeta,
+  DashboardAttributes,
+  | grafana.GetDashboardError
+  | grafana.PostDashboardError
+  | grafana.DeleteDashboardError
+  | GrafanaProvisionedObjectError
+> = {
+  attributes: (live, props) => {
+    const model = normalizeModel(modelOf(live), props.uid);
+    return {
+      dashboard: model,
+      folderUid: live.meta?.folderUid ?? '',
+      provisioned: live.meta?.provisioned ?? false,
+      provisionedExternalId: live.meta?.provisionedExternalId ?? '',
+      title: modelTitle(model),
+      uid: props.uid,
+      url: live.meta?.url ?? '',
+      version: live.meta?.version ?? 0,
+    };
+  },
+  create: (props) =>
+    grafana.postDashboard({
+      dashboard: normalizeModel(props.dashboard, props.uid),
+      ...(props.folderUid === undefined ? {} : { folderUid: props.folderUid }),
+    }),
+  destroy: (props, live) =>
+    Effect.gen(function* () {
+      if (live.meta?.provisioned) {
+        return yield* refuseIfProvisioned(
+          'Grafana.Dashboard',
+          props.uid,
+          live.meta.provisionedExternalId,
+        );
+      }
+      yield* grafana.deleteDashboard({ uid: props.uid });
+    }),
+  fetchLive: (props) =>
+    grafana
+      .getDashboard({ uid: props.uid })
+      .pipe(Effect.catchTag('NotFound', () => Effect.succeed(undefined))),
+  matches: (attributes, props) =>
+    (props.folderUid === undefined || attributes.folderUid === props.folderUid) &&
+    declaredContentMatches(normalizeModel(props.dashboard, props.uid), attributes.dashboard),
+  update: (props, live) =>
+    Effect.gen(function* () {
+      if (live.meta?.provisioned) {
+        return yield* refuseIfProvisioned(
+          'Grafana.Dashboard',
+          props.uid,
+          live.meta.provisionedExternalId,
+        );
+      }
+      return yield* grafana.postDashboard({
+        dashboard: {
+          ...normalizeModel(props.dashboard, props.uid),
+          ...(live.meta?.version === undefined ? {} : { version: live.meta.version }),
+        },
+        ...(props.folderUid === undefined ? {} : { folderUid: props.folderUid }),
+      });
+    }),
+};
+
+export const handlers = grafanaHandlers(spec);
+
+export const GrafanaDashboardProvider = () =>
+  Provider.effect(GrafanaDashboard, Effect.succeed(GrafanaDashboard.Provider.of(handlers)));

package/src/grafana/datasource.ts

@@ -20,9 +20,11 @@
 import { Resource } from 'alchemy';
 import * as Provider from 'alchemy/Provider';
 import * as grafana from '@distilled.cloud/grafana';
-import * as Data from 'effect/Data';
 import * as Effect from 'effect/Effect';
 import { type GrafanaSpec, grafanaHandlers } from './resource.ts';
+import { GrafanaSecretRefUnsetError, resolveSecretRefs } from './secret-refs.ts';
+
+export { GrafanaSecretRefUnsetError };
 
 export interface DatasourceProps {
   uid: string;
@@ -64,33 +66,9 @@ export interface GrafanaDatasource extends Resource<
 
 export const GrafanaDatasource = Resource<GrafanaDatasource>('Grafana.Datasource');
 
-/** A named secure-field env var is unset — a domain refusal, not a distilled error. */
-export class GrafanaSecretRefUnsetError extends Data.TaggedError('GrafanaSecretRefUnsetError')<{
-  readonly message: string;
-}> {}
-
 /** Reads every named env var fresh, inside the caller's effect (S24) — never at plan time. */
-const resolveSecureJsonData = (
-  refs: Record<string, string> | undefined,
-): Effect.Effect<Record<string, string> | undefined, GrafanaSecretRefUnsetError> =>
-  Effect.gen(function* () {
-    if (refs === undefined) return undefined;
-    const out: Record<string, string> = {};
-    for (const [field, envVar] of Object.entries(refs)) {
-      const raw = process.env[envVar];
-      if (raw === undefined || raw.trim() === '') {
-        return yield* Effect.fail(
-          new GrafanaSecretRefUnsetError({
-            message:
-              `${envVar} is unset. Export the value of secureJsonData.${field} there — ` +
-              'never as an Alchemy prop.',
-          }),
-        );
-      }
-      out[field] = raw.trim();
-    }
-    return out;
-  });
+const resolveSecureJsonData = (refs: Record<string, string> | undefined) =>
+  resolveSecretRefs(refs, (field) => `secureJsonData.${field}`);
 
 /** `exactOptionalPropertyTypes` means an undeclared field must be OMITTED, never sent as `undefined`. */
 const fields = (props: DatasourceProps) => ({

package/src/grafana/folder.test.ts

@@ -0,0 +1,212 @@
+/**
+ * `Grafana.Folder` against a fake Grafana — the observe-before-write "adopt" posture (S9/S10),
+ * the provisioned-object refusal (provisioned.ts) and the parentUid-is-create-only refusal, all
+ * through the REAL `@distilled.cloud/grafana` protocol. Mirrors `datasource.test.ts`.
+ */
+import { describe, expect, test } from 'bun:test';
+import * as Effect from 'effect/Effect';
+import { fakeFailure, fakeGrafana, fakeGrafanaLayer } from './fake-grafana.ts';
+import { GrafanaFolderReparentError, spec } from './folder.ts';
+import { GrafanaProvisionedObjectError } from './provisioned.ts';
+import { grafanaOperations } from './resource.ts';
+
+const FOLDER_PATH = '/api/folders/team-dashboards';
+const CREATE_PATH = '/api/folders';
+
+const liveJson = {
+  id: 3,
+  managedBy: '',
+  parentUid: '',
+  title: 'Team Dashboards',
+  uid: 'team-dashboards',
+  url: '/dashboards/f/team-dashboards',
+  version: 1,
+};
+
+const props = { title: 'Team Dashboards', uid: 'team-dashboards' };
+
+describe('spec.fetchLive', () => {
+  test('a live folder decodes into typed attributes', async () => {
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === FOLDER_PATH
+        ? Response.json(liveJson)
+        : fakeFailure(404, 'not found'),
+    );
+    const live = await Effect.runPromise(
+      spec.fetchLive(props).pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(live !== undefined && spec.attributes(live, props)).toEqual({
+      id: 3,
+      managedBy: '',
+      parentUid: '',
+      title: 'Team Dashboards',
+      uid: 'team-dashboards',
+      url: '/dashboards/f/team-dashboards',
+      version: 1,
+    });
+    expect(fake.seen).toEqual([{ method: 'GET', path: FOLDER_PATH }]);
+    // ⛔ THE POINT: a GET never carries a body — see the shared memory's "distilled JSON-encodes
+    //   unknown keys as a body even on a GET" trap.
+    expect(fake.bodies[0]).toBeUndefined();
+  });
+
+  test('a 404 folds to undefined', async () => {
+    const fake = fakeGrafana(() => fakeFailure(404, 'folder not found'));
+    const result = await Effect.runPromise(
+      spec.fetchLive(props).pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(result).toBeUndefined();
+  });
+
+  test('a 403 propagates — never folded to absent', async () => {
+    const fake = fakeGrafana(() => fakeFailure(403, 'forbidden'));
+    const failure = await Effect.runPromise(
+      Effect.flip(spec.fetchLive(props).pipe(Effect.provide(fakeGrafanaLayer(fake.fetch)))),
+    );
+    expect(failure._tag).toBe('Forbidden');
+  });
+});
+
+describe('create', () => {
+  test('sends only declared fields — parentUid omitted when undeclared', async () => {
+    const fake = fakeGrafana((method, url) =>
+      method === 'POST' && url.pathname === CREATE_PATH
+        ? Response.json(liveJson)
+        : fakeFailure(404, 'unexpected request'),
+    );
+    await Effect.runPromise(spec.create(props).pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))));
+    expect(fake.bodies[0]).toEqual({ title: 'Team Dashboards', uid: 'team-dashboards' });
+  });
+
+  test('sends description and parentUid when declared', async () => {
+    const fake = fakeGrafana(() => Response.json(liveJson));
+    await Effect.runPromise(
+      spec
+        .create({ ...props, description: 'squad dashboards', parentUid: 'engineering' })
+        .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(fake.bodies[0]).toMatchObject({
+      description: 'squad dashboards',
+      parentUid: 'engineering',
+    });
+  });
+});
+
+describe('reconcile — adopt semantics', () => {
+  test('declaring exactly what is live is a noop: no write is ever sent', async () => {
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === FOLDER_PATH
+        ? Response.json(liveJson)
+        : fakeFailure(500, 'reconcile should not write when nothing changed'),
+    );
+    const after = await Effect.runPromise(
+      grafanaOperations(spec)
+        .reconcile(props)
+        .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(after.uid).toBe('team-dashboards');
+    expect(fake.seen.every((s) => s.method === 'GET')).toBe(true);
+  });
+});
+
+describe('update', () => {
+  test('a title mismatch sends the live version for optimistic concurrency', async () => {
+    let updated = false;
+    const fake = fakeGrafana((method, url) => {
+      if (method === 'GET' && url.pathname === FOLDER_PATH) {
+        return Response.json(updated ? { ...liveJson, title: 'Renamed' } : liveJson);
+      }
+      if (method === 'PUT' && url.pathname === FOLDER_PATH) {
+        updated = true;
+        return Response.json({ ...liveJson, title: 'Renamed' });
+      }
+      return fakeFailure(500, 'unexpected request');
+    });
+    await Effect.runPromise(
+      grafanaOperations(spec)
+        .reconcile({ ...props, title: 'Renamed' })
+        .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    const put = fake.seen.findIndex((s) => s.method === 'PUT');
+    expect(put).toBeGreaterThanOrEqual(0);
+    expect(fake.bodies[put]).toMatchObject({ title: 'Renamed', version: 1 });
+  });
+
+  // ★ BOTH TESTS GO THROUGH `grafanaOperations(spec).reconcile`, NOT `spec.update` DIRECTLY —
+  //   `update` is optional on the shared `GrafanaSpec` type, and `reconcile` is what production
+  //   code actually calls; it also exercises the same `fetchLive` → `matches` → `update` sequence.
+  test('a parentUid mismatch refuses — updateFolder cannot reparent', async () => {
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === FOLDER_PATH
+        ? Response.json(liveJson)
+        : fakeFailure(500, 'no write should be attempted'),
+    );
+    const failure = await Effect.runPromise(
+      Effect.flip(
+        grafanaOperations(spec)
+          .reconcile({ ...props, parentUid: 'engineering' })
+          .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+      ),
+    );
+    expect(failure).toBeInstanceOf(GrafanaFolderReparentError);
+    expect(fake.seen.every((s) => s.method === 'GET')).toBe(true);
+  });
+
+  test('a provisioned (managedBy set) folder refuses the write and sends nothing', async () => {
+    const provisioned = { ...liveJson, managedBy: 'repo' };
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === FOLDER_PATH
+        ? Response.json(provisioned)
+        : fakeFailure(500, 'no write should be attempted'),
+    );
+    const failure = await Effect.runPromise(
+      Effect.flip(
+        grafanaOperations(spec)
+          .reconcile({ ...props, title: 'Renamed' })
+          .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+      ),
+    );
+    expect(failure).toBeInstanceOf(GrafanaProvisionedObjectError);
+    expect(failure.message).toContain('repo');
+    expect(fake.seen.every((s) => s.method === 'GET')).toBe(true);
+  });
+});
+
+describe('destroy', () => {
+  test('deletes a live, non-provisioned folder by uid', async () => {
+    const fake = fakeGrafana((method, url) => {
+      if (method === 'GET' && url.pathname === FOLDER_PATH) return Response.json(liveJson);
+      if (method === 'DELETE' && url.pathname === FOLDER_PATH) {
+        return Response.json({ id: 3, message: 'ok', title: 'Team Dashboards' });
+      }
+      return fakeFailure(500, 'unexpected request');
+    });
+    await Effect.runPromise(
+      grafanaOperations(spec)
+        .destroy(props)
+        .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+    );
+    expect(fake.seen).toEqual([
+      { method: 'GET', path: FOLDER_PATH },
+      { method: 'DELETE', path: FOLDER_PATH },
+    ]);
+  });
+
+  test('a provisioned folder refuses destroy and sends no DELETE', async () => {
+    const provisioned = { ...liveJson, managedBy: 'repo' };
+    const fake = fakeGrafana((method, url) =>
+      method === 'GET' && url.pathname === FOLDER_PATH
+        ? Response.json(provisioned)
+        : fakeFailure(500, 'no DELETE should be attempted'),
+    );
+    const failure = await Effect.runPromise(
+      Effect.flip(
+        grafanaOperations(spec)
+          .destroy(props)
+          .pipe(Effect.provide(fakeGrafanaLayer(fake.fetch))),
+      ),
+    );
+    expect(failure).toBeInstanceOf(GrafanaProvisionedObjectError);
+    expect(fake.seen).toEqual([{ method: 'GET', path: FOLDER_PATH }]);
+  });
+});