@homebridge-plugins/homebridge-tuya 3.0.0-beta.13 → 3.0.0-beta.15

package/test/localDeviceManager.behavior.test.ts

@@ -1,6 +1,8 @@
 import { beforeEach, describe, expect, jest, test } from '@jest/globals';
 import LocalDeviceManager from '../src/local/LocalDeviceManager';
 import type { LocalConfig } from '../src/local/config';
+import { TuyaPluginMode } from '../src/config';
+import { TuyaDeviceSchemaType } from '../src/cloud/device/TuyaDevice';
 import { ExLogger, initLogger } from '../src/shared/util/Logger';
 
 const createdConnections: any[] = [];
@@ -168,4 +170,181 @@ describe('LocalDeviceManager command and local mapping behavior', () => {
     expect(discovered?.ip).toBe('192.168.1.30');
     expect(discovered?.product_id).toBe('prod1');
   });
+
+  test('keeps DP mapping when a local override uses the same code as a no-op rename', async () => {
+    const config: LocalConfig = {
+      autoDiscoverDevices: false,
+      deviceOverrides: [{
+        id: 'dev-1',
+        configFor: TuyaPluginMode.local,
+        schema: [{
+          code: 'humidity_indoor',
+          newCode: 'humidity_indoor',
+          type: TuyaDeviceSchemaType.Integer,
+          property: { min: 0, max: 100, scale: 0, step: 1 },
+        }],
+      }],
+      devices: [{
+        tuyaDeviceId: 'dev-1',
+        ip: '192.168.1.10',
+        tuyaKey: 'abcdef1234567890',
+        protocolVersion: '3.5',
+        dpMapping: {
+          humidity_indoor: 6,
+        },
+      }],
+    };
+
+    const manager = new LocalDeviceManager(config);
+    await manager.initLocalDevices();
+
+    const device = manager.getDevice('dev-1');
+    const dpMap = (manager as any).dpMaps.get('dev-1');
+    const reverseMap = (manager as any).reverseDpMaps.get('dev-1');
+
+    expect(dpMap?.humidity_indoor).toBe(6);
+    expect(reverseMap?.[6]).toBe('humidity_indoor');
+    expect(device?.schema.some(schema => schema.code === 'humidity_indoor' && schema.type === TuyaDeviceSchemaType.Integer)).toBe(true);
+  });
+
+  test('applies local overrides without a rename using the original code', async () => {
+    const config: LocalConfig = {
+      autoDiscoverDevices: false,
+      deviceOverrides: [{
+        id: 'dev-1',
+        configFor: TuyaPluginMode.local,
+        schema: [{
+          code: 'humidity_indoor',
+          type: TuyaDeviceSchemaType.Integer,
+          property: { min: 0, max: 100, scale: 0, step: 1 },
+        }],
+      }],
+      devices: [{
+        tuyaDeviceId: 'dev-1',
+        ip: '192.168.1.10',
+        tuyaKey: 'abcdef1234567890',
+        protocolVersion: '3.5',
+        dpMapping: {
+          humidity_indoor: 6,
+        },
+      }],
+    };
+
+    const manager = new LocalDeviceManager(config);
+    await manager.initLocalDevices();
+
+    const device = manager.getDevice('dev-1');
+    const schema = device?.schema.find(item => item.code === 'humidity_indoor');
+
+    expect(schema).toBeDefined();
+    expect(schema?.type).toBe(TuyaDeviceSchemaType.Integer);
+    expect(device?.schema.every(item => !!item.code)).toBe(true);
+  });
+
+  test('applies local overrides', async () => {
+    const config: LocalConfig = {
+      autoDiscoverDevices: false,
+      devices: [],
+      deviceOverrides: [{
+        id: 'dev-1',
+        category: 'jsq',
+        configFor: TuyaPluginMode.local,
+        schema: [{
+          code: 'humidity_indoor',
+          type: TuyaDeviceSchemaType.Integer,
+          property: { min: 0, max: 100, scale: 0, step: 1 },
+        }],
+      }],
+    };
+
+    const manager = new LocalDeviceManager(config);
+    await manager.initLocalDevices();
+
+    (manager as any)._onDiscovered({
+      id: 'dev-1',
+      ip: '192.168.0.1',
+      version: '3.3',
+      productKey: 'prod1',
+    });
+
+    const device = manager.getDevice('dev-1');
+
+    expect(device).toBeDefined();
+    expect(device?.ip).toBe('192.168.0.1');
+    expect(device?.product_id).toBe('prod1');
+    expect(device?.category).toBe('jsq');
+    expect(device?.schema?.length).toBe(1);
+    expect(device?.schema?.[0].code).toBe('humidity_indoor');
+  });
+
+  test('do not apply cloud overrides to local devices', async () => {
+    const config: LocalConfig = {
+      autoDiscoverDevices: false,
+      devices: [],
+      deviceOverrides: [{
+        id: 'dev-1',
+        category: 'jsq',
+        configFor: TuyaPluginMode.cloud,
+        schema: [{
+          code: 'humidity_indoor',
+          type: TuyaDeviceSchemaType.Integer,
+          property: { min: 0, max: 100, scale: 0, step: 1 },
+        }],
+      }],
+    };
+
+    const manager = new LocalDeviceManager(config);
+    await manager.initLocalDevices();
+
+    (manager as any)._onDiscovered({
+      id: 'dev-1',
+      ip: '192.168.0.1',
+      version: '3.3',
+      productKey: 'prod1',
+    });
+
+    const device = manager.getDevice('dev-1');
+
+    expect(device).toBeDefined();
+    expect(device?.ip).toBe('192.168.0.1');
+    expect(device?.product_id).toBe('prod1');
+    expect(device?.category).toBe('unknown');
+    expect(device?.schema?.length).toBe(0);
+  });
+
+  test('applies overrides local device (configFor:both)', async () => {
+    const config: LocalConfig = {
+      autoDiscoverDevices: false,
+      devices: [],
+      deviceOverrides: [{
+        id: 'dev-1',
+        category: 'jsq',
+        configFor: TuyaPluginMode.both,
+        schema: [{
+          code: 'humidity_indoor',
+          type: TuyaDeviceSchemaType.Integer,
+          property: { min: 0, max: 100, scale: 0, step: 1 },
+        }],
+      }],
+    };
+
+    const manager = new LocalDeviceManager(config);
+    await manager.initLocalDevices();
+
+    (manager as any)._onDiscovered({
+      id: 'dev-1',
+      ip: '192.168.0.1',
+      version: '3.3',
+      productKey: 'prod1',
+    });
+
+    const device = manager.getDevice('dev-1');
+
+    expect(device).toBeDefined();
+    expect(device?.ip).toBe('192.168.0.1');
+    expect(device?.product_id).toBe('prod1');
+    expect(device?.category).toBe('jsq');
+    expect(device?.schema?.length).toBe(1);
+    expect(device?.schema?.[0].code).toBe('humidity_indoor');
+  });
 });