@homebridge-plugins/homebridge-tuya 2.2.1 → 3.0.0-beta.1

package/jest.config.js

@@ -2,4 +2,10 @@
 module.exports = {
   preset: 'ts-jest',
   testEnvironment: 'node',
+  moduleNameMapper: {
+    '^(\\.{1,2}/)*package\\.json$': '<rootDir>/package.json',
+    '^color-convert$': '<rootDir>/test/__mocks__/color-convert.js',
+    '^kelvin-to-rgb$': '<rootDir>/test/__mocks__/kelvin-to-rgb.js',
+    '^@homebridge/camera-utils$': '<rootDir>/test/__mocks__/@homebridge-camera-utils.js',
+  },
 };

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@homebridge-plugins/homebridge-tuya",
   "displayName": "Homebridge Tuya",
-  "version": "2.2.1",
-  "description": "Forked from 0x5e/homebridge-tuya-platform, with a focus on fixing bugs and adding new device support.",
+  "version": "3.0.0-beta.1",
+  "description": "Unified Homebridge Tuya plugin supporting both Tuya Cloud (REST/MQTT) and Tuya Local (direct LAN TCP) communication.",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -27,8 +27,11 @@
   },
   "main": "dist/index.js",
   "scripts": {
-    "lint": "eslint src/**/*.ts --max-warnings=0",
+    "check": "npm install && npm outdated",
+    "lint": "eslint src/**/*.ts",
+    "lint:fix": "eslint src/**/*.ts --fix",
     "test": "jest",
+    "coverage": "npm test -- --coverage",
     "watch": "npm run build && npm link && nodemon",
     "launch": "tsc && homebridge -I -D",
     "build": "rimraf ./dist && tsc",
@@ -40,35 +43,27 @@
     "tuya"
   ],
   "dependencies": {
-    "@homebridge/camera-utils": "^2.2.0",
-    "async-await-retry": "^2.0.1",
-    "color-convert": "^2.0.1",
-    "crypto-js": "^4.1.1",
-    "debounce": "^1.2.1",
-    "jsonschema": "^1.4.1",
+    "@homebridge/camera-utils": "^3.0.0",
+    "color-convert": "^3.1.3",
+    "jsonschema": "^1.5.0",
     "kelvin-to-rgb": "^1.0.2",
-    "lodash.isequal": "^4.5.0",
-    "mqtt": "^4.2.6",
-    "uuid": "^9.0.0"
+    "mqtt": "^5.15.1"
   },
   "devDependencies": {
-    "@types/color-convert": "^2.0.0",
-    "@types/crypto-js": "^4.1.1",
-    "@types/debounce": "^1.2.1",
-    "@types/jest": "^29.1.2",
-    "@types/lodash.isequal": "^4.5.6",
-    "@types/node": "^22.0.0",
-    "@types/uuid": "^8.3.4",
-    "@typescript-eslint/eslint-plugin": "^5.0.0",
-    "@typescript-eslint/parser": "^5.0.0",
-    "eslint": "8.57.1",
+    "@eslint/js": "^10.0.1",
+    "@types/color-convert": "^2.0.4",
+    "@types/jest": "^30.0.0",
+    "@types/node": "^25.5.0",
+    "@typescript-eslint/eslint-plugin": "^8.57.2",
+    "@typescript-eslint/parser": "^8.57.2",
+    "eslint": "^10.1.0",
     "homebridge": "^2.0.0-beta.0",
-    "jest": "^29.1.2",
-    "nodemon": "^3.1.10",
-    "rimraf": "^5.0.0",
+    "jest": "^30.3.0",
+    "nodemon": "^3.1.14",
+    "rimraf": "^6.1.3",
     "ts-jest": "^29.4.6",
-    "ts-node": "^10.3.0",
-    "typescript": "^5.0.0"
+    "ts-node": "^10.9.2",
+    "typescript": "^5.9.3"
   },
   "homebridge": {
     "plugin_type": "platform",

package/test/__mocks__/@homebridge-camera-utils.js

@@ -0,0 +1,10 @@
+module.exports = {
+  defaultFfmpegPath: '/usr/bin/ffmpeg',
+  reservePorts: async (count) => {
+    const ports = [];
+    for (let i = 0; i < count; i++) {
+      ports.push(5000 + i);
+    }
+    return ports;
+  },
+};

package/test/__mocks__/color-convert.js

@@ -0,0 +1,24 @@
+module.exports = {
+  rgb: {
+    hsv: (r, g, b) => {
+      // Simple RGB to HSV conversion mock
+      const max = Math.max(r, g, b) / 255;
+      const min = Math.min(r, g, b) / 255;
+      const l = (max + min) / 2;
+      let h = 0, s = 0;
+
+      if (max !== min) {
+        const d = max - min;
+        s = l > 0.5 ? d / (2 - max - min) : d / (max + min);
+        switch (max) {
+          case r / 255: h = (g - b) / 255 / d + (g < b ? 6 : 0); break;
+          case g / 255: h = (b - r) / 255 / d + 2; break;
+          case b / 255: h = (r - g) / 255 / d + 4; break;
+        }
+        h /= 6;
+      }
+
+      return [Math.round(h * 360), Math.round(s * 100), Math.round(max * 100)];
+    },
+  },
+};

package/test/__mocks__/kelvin-to-rgb.js

@@ -0,0 +1,21 @@
+// Simple Kelvin to RGB conversion mock
+module.exports = function kelvinToRgb(kelvin) {
+  let r = 255, g = 255, b = 255;
+
+  if (kelvin < 6600) {
+    r = 255;
+    g = Math.round(99.4708025861 * Math.log(kelvin) - 161.1195681661);
+    
+    if (kelvin < 2000) {
+      b = 0;
+    } else {
+      b = Math.round(138.5177312231 * Math.log(kelvin - 10) - 305.0447927307);
+    }
+  }
+
+  return [
+    Math.max(0, Math.min(255, r)),
+    Math.max(0, Math.min(255, g)),
+    Math.max(0, Math.min(255, b)),
+  ];
+};

package/test/accessoryFactory.test.ts

@@ -0,0 +1,522 @@
+/* eslint-disable no-console */
+import { describe, expect, test, beforeEach } from '@jest/globals';
+import { PlatformAccessory } from 'homebridge';
+import AccessoryFactory from '../src/shared/AccessoryFactory';
+import TuyaDevice, { TuyaDeviceSchemaMode, TuyaDeviceSchemaType } from '../src/cloud/device/TuyaDevice';
+import { TuyaPlatform } from '../src/platform';
+
+describe('AccessoryFactory', () => {
+  let mockPlatform: Partial<TuyaPlatform>;
+  let mockAccessory: Partial<PlatformAccessory>;
+
+  beforeEach(() => {
+    // Create proper HAP mock structure
+    class MockService {
+      static AccessoryInformation = class {};
+      static Lightbulb = class {};
+      static Switch = class {};
+      static Outlet = class {};
+      static Fan = class {};
+      static Thermostat = class {};
+      static WindowCovering = class {};
+      static GarageDoorOpener = class {};
+      static LockMechanism = class {};
+      static Valve = class {};
+      static HeaterCooler = class {};
+      static Microphone = class {};
+      static Speaker = class {};
+    }
+
+    class MockCharacteristic {
+      static On = { UUID: 'uuid-on' };
+      static Brightness = { UUID: 'uuid-brightness' };
+      static Name = { UUID: 'uuid-name' };
+      static Manufacturer = { UUID: 'uuid-manufacturer' };
+      static Model = { UUID: 'uuid-model' };
+      static SerialNumber = { UUID: 'uuid-sn' };
+      static AccessoryFlags = { UUID: 'uuid-flags' };
+      static Identify = { UUID: 'uuid-identify' };
+      static CurrentTemperature = { UUID: 'uuid-temp' };
+      static TargetTemperature = { UUID: 'uuid-target-temp' };
+      static CurrentRelativeHumidity = { UUID: 'uuid-humidity' };
+      static Saturation = { UUID: 'uuid-saturation' };
+      static Hue = { UUID: 'uuid-hue' };
+      static ColorTemperature = { UUID: 'uuid-color-temp' };
+      static RotationSpeed = { UUID: 'uuid-rotation' };
+      static CurrentPosition = { UUID: 'uuid-position' };
+      static TargetPosition = { UUID: 'uuid-target-pos' };
+      static LockCurrentState = { UUID: 'uuid-lock-state' };
+      static LockTargetState = { UUID: 'uuid-lock-target' };
+      static Active = { UUID: 'uuid-active', INACTIVE: 0, ACTIVE: 1 };
+      static CurrentHeatingCoolingState = { UUID: 'uuid-heating-cooling', OFF: 0, HEAT: 1, COOL: 2, AUTO: 3 };
+      static TargetHeatingCoolingState = { UUID: 'uuid-target-heating-cooling', OFF: 0, HEAT: 1, COOL: 2, AUTO: 3 };
+      static TemperatureDisplayUnits = { UUID: 'uuid-temp-units', CELSIUS: 0, FAHRENHEIT: 1 };
+      static CurrentHeaterCoolerState = { UUID: 'uuid-current-heater-cooler', IDLE: 0, HEATING: 1, COOLING: 2 };
+      static TargetHeaterCoolerState = { UUID: 'uuid-target-heater-cooler', OFF: 0, HEAT: 1, COOL: 2, AUTO: 3 };
+    }
+
+    mockPlatform = {
+      log: {
+        info: jest.fn(),
+        warn: jest.fn(),
+        error: jest.fn(),
+        debug: jest.fn(),
+        log: jest.fn(),
+      },
+      config: {} as any,
+      api: {
+        hap: {
+          Service: MockService as any,
+          Characteristic: MockCharacteristic as any,
+          CameraController: jest.fn(),
+        },
+      } as any,
+      accessories: [],
+      Service: MockService as any,
+      Characteristic: MockCharacteristic as any,
+      options: {
+        debug: false,
+        debugLevel: '',
+      },
+      deviceManager: {
+        getDevice: jest.fn().mockReturnValue({
+          id: 'test_device',
+          name: 'Test Device',
+          schema: [],
+          status: [],
+          product_id: 'test_product',
+          category: 'dj',
+          product_name: 'Light',
+          uuid: 'test-device-uuid',
+          model: 'Model X',
+          isVirtualDevice: jest.fn().mockReturnValue(false),
+          isIRControlHub: jest.fn().mockReturnValue(false),
+        }),
+      },
+      getDeviceSchemaConfig: jest.fn().mockReturnValue(null),
+      getDeviceStatusProperty: jest.fn().mockReturnValue(undefined),
+    } as any;
+
+    mockAccessory = {
+      UUID: 'test-uuid',
+      displayName: 'Test Device',
+      context: {
+        deviceID: 'test_device',
+      },
+      services: [],
+      getService: jest.fn().mockReturnValue(undefined),
+      addService: jest.fn().mockReturnValue({
+        setCharacteristic: jest.fn().mockReturnThis(),
+        getCharacteristic: jest.fn().mockReturnValue({
+          onGet: jest.fn(function() { return this; }),
+          onSet: jest.fn(function() { return this; }),
+          setProps: jest.fn().mockReturnThis(),
+        }),
+      }),
+      removeAllListeners: jest.fn(),
+      on: jest.fn(),
+      once: jest.fn(),
+      configureController: jest.fn(),
+    } as any;
+  });
+
+  describe('createAccessory', () => {
+    test('creates accessory for valid device', () => {
+      const device = new TuyaDevice({
+        id: 'test_device',
+        product_id: 'test_product',
+        category: 'light',
+        name: 'Test Light',
+      });
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+      expect(accessory).not.toBeNull();
+    });
+
+    test('creates accessory with category fallback', () => {
+      const device = new TuyaDevice({
+        id: 'test_device',
+        product_id: 'unknown_product',
+        category: 'switch',
+        name: 'Test Switch',
+      });
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles unknown category gracefully', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'test_device',
+          product_id: 'unknown_product',
+          category: 'unknown_category',
+          name: 'Unknown Device',
+        }
+      );
+
+      // Should not throw
+      expect(() => {
+        AccessoryFactory.createAccessory(
+          mockPlatform as TuyaPlatform,
+          mockAccessory as PlatformAccessory,
+          device,
+        );
+      }).not.toThrow();
+    });
+  });
+
+  describe('device categories', () => {
+    test('handles light category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'light_1',
+          product_id: 'prod_light',
+          category: 'dj',
+          name: 'Smart Light',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles switch category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'switch_1',
+          product_id: 'prod_switch',
+          category: 'kg',
+          name: 'Smart Switch',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles outlet category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'outlet_1',
+          product_id: 'prod_outlet',
+          category: 'cz',
+          name: 'Smart Outlet',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles fan category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'fan_1',
+          product_id: 'prod_fan',
+          category: 'fs',
+          name: 'Smart Fan',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles thermostat category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'thermostat_1',
+          product_id: 'prod_thermostat',
+          category: 'wk',
+          name: 'Smart Thermostat',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles lock category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'lock_1',
+          product_id: 'prod_lock',
+          category: 'jtmspro',
+          name: 'Smart Lock',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles security system category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'security_1',
+          product_id: 'prod_security',
+          category: 'zd_3in1',
+          name: 'Security Hub',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles camera category', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'camera_1',
+          product_id: 'prod_camera',
+          category: 'sp',
+          name: 'Smart Camera',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+  });
+
+  describe('device properties', () => {
+    test('handles device with standard schema', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'device_with_schema',
+          product_id: 'prod_123',
+          category: 'kg',
+          name: 'Device',
+          status: [
+            { code: 'switch_1', value: true },
+          ],
+          schema: [
+            {
+              code: 'switch_1',
+              mode: TuyaDeviceSchemaMode.READ_WRITE,
+              type: TuyaDeviceSchemaType.Boolean,
+              property: {} as any,
+            },
+          ],
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles device with minimal properties', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'minimal_device',
+          product_id: 'prod_minimal',
+          category: 'kg',
+          name: 'Minimal',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles device with no product_id', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'device_no_product',
+          product_id: '',
+          category: 'kg',
+          name: 'No Product ID',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+  });
+
+  describe('IR Remote Control devices', () => {
+    test('handles IR remote control - generic', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'ir_remote_1',
+          product_id: 'ir_prod',
+          category: 'ir',
+          name: 'IR Remote',
+          remote_keys: {
+            category_id: 99,
+            org_category_id: 99,
+            brand_id: 0,
+            remote_index: 0,
+            single_air: false,
+            duplicate_power: false,
+            key_list: [],
+            key_range: [],
+          },
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles IR remote control - AC', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'ir_ac_1',
+          product_id: 'ir_ac_prod',
+          category: 'ir',
+          name: 'IR AC Remote',
+          remote_keys: {
+            category_id: 5, // AC
+            org_category_id: 5,
+            brand_id: 0,
+            remote_index: 0,
+            single_air: false,
+            duplicate_power: false,
+            key_list: [],
+            key_range: [],
+          },
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+  });
+
+  describe('edge cases', () => {
+    test('handles device with special characters in name', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'device_special',
+          product_id: 'prod_special',
+          category: 'kg',
+          name: 'Device "Test" & More!',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles device with empty name', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'device_no_name',
+          product_id: 'prod_no_name',
+          category: 'kg',
+          name: '',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+
+    test('handles device with unicode characters', () => {
+      const device = new TuyaDevice(
+        {
+          id: 'device_unicode',
+          product_id: 'prod_unicode',
+          category: 'kg',
+          name: '智能开关 中文设备',
+        }
+      );
+
+      const accessory = AccessoryFactory.createAccessory(
+        mockPlatform as TuyaPlatform,
+        mockAccessory as PlatformAccessory,
+        device,
+      );
+
+      expect(accessory).toBeDefined();
+    });
+  });
+});