@homebridge-plugins/homebridge-tado 9.3.0 → 9.3.2

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+# v9.3.2 - 2026-06-21
+- Fix: Add a defensive `CurrentTemperature` fallback for `HOT_WATER` HeaterCooler accessories when tado does not provide `sensorDataPoints.insideTemperature` (#169)
+
+# v9.3.1 - 2026-06-19
+- Fix: Preserve previous update buffer behaviour for default `preferSiriTemperature` handling while keeping the `HOT_WATER` range safeguards (#169)
+- Fix: Improve HeaterCooler threshold value correction during startup
+
 # v9.3.0 - 2026-06-18
 - Fix: Treat tado zone id `0` as a valid zone id when resolving and updating configured zones (#169)
 - Fix: Resolve missing `HOT_WATER` zone ids for temperature-controlled boiler `HeaterCooler` accessories before sending overlays (#169)
@@ -215,9 +222,9 @@
 ## v6.0.9 - 2021-03-22
 - Added "Dummy Switch" option to Central Switch
 - Added new accessory type option (LightSensor) to Solar Intensity Accessory
-- Added new mode (CUSTOM) to HOT_WATER devices
+- Added new mode (CUSTOM) to `HOT_WATER` devices
 - Fixed current state of HeaterCooler if temperature is reached
-- Fixed AUTO mode for HOT_WATER devices
+- Fixed AUTO mode for `HOT_WATER` devices
 - Bugfixes
 - Bump deps
 
@@ -229,7 +236,7 @@
 
 ## v6.0.6 - 2021-03-16
 - Added minValue, maxValue, minStep options to config
-- Fixed target temperature for HOT_WATER if power = "ON"
+- Fixed target temperature for `HOT_WATER` if power = "ON"
 - Other little bugfixes & improvements
 
 ## v6.0.5 - 2021-03-16
@@ -247,7 +254,7 @@
 
 ## v6.0.1 - 2021-03-15
 - Fixed a bug with faucet accessory appearing as air quality sensor
-- Fixed a bug for HOT_WATER devices without temperature support
+- Fixed a bug for `HOT_WATER` devices without temperature support
 - Improvements
 
 **Note:**
@@ -256,7 +263,7 @@ Hot water devices show 0° when they are first started in Apple Home if they are
 
 **IMPORTANT:**
 
-If you previously used your "HOT_WATER" device/zone as a faucet, then disable the zone after the update and restart Homebridge pls. After the restart, you can enable the zone with the faucet again.
+If you previously used your "`HOT_WATER`" device/zone as a faucet, then disable the zone after the update and restart Homebridge pls. After the restart, you can enable the zone with the faucet again.
 
 ## v6.0.0 - 2021-03-14
 **<u>NOTE:</u>** Updating from **<= v5.x** to **v6.x** will crash your homebridge, please **REMOVE** the old version first and check also the new [example-config.json](https://github.com/homebridge-plugins/homebridge-tado/blob/latest/example-config.json) 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@homebridge-plugins/homebridge-tado",
-  "version": "9.3.0",
+  "version": "9.3.2",
   "description": "Homebridge plugin for controlling tado° devices.",
   "main": "index.js",
   "scripts": {

package/src/accessories/heatercooler.js

@@ -1,6 +1,6 @@
 import Logger from '../helper/logger.js';
 import moment from 'moment';
-import { TadoUpdateBuffer } from '../helper/update-buffer.js'
+import { TadoUpdateBuffer } from '../helper/update-buffer.js';
 
 const timeout = (ms) => new Promise((res) => setTimeout(res, ms));
 
@@ -255,12 +255,11 @@ export default class HeaterCoolerAccessory {
     });
 
     let heatingThresholdValue = Number(heatingThreshold.value);
-
-    if (!Number.isFinite(heatingThresholdValue) || heatingThresholdValue < minValue)
+    if (!Number.isFinite(heatingThresholdValue) || heatingThresholdValue < minValue) {
       heatingThreshold.updateValue(minValue);
-
-    if (Number.isFinite(heatingThresholdValue) && heatingThresholdValue > maxValue)
+    } else if (heatingThresholdValue > maxValue) {
       heatingThreshold.updateValue(maxValue);
+    }
 
     if (this.accessory.context.config.type === 'HEATING') {
       const coolingThreshold = service.getCharacteristic(this.api.hap.Characteristic.CoolingThresholdTemperature);
@@ -272,12 +271,11 @@ export default class HeaterCoolerAccessory {
       });
 
       let coolingThresholdValue = Number(coolingThreshold.value);
-
-      if (!Number.isFinite(coolingThresholdValue) || coolingThresholdValue < minValue)
+      if (!Number.isFinite(coolingThresholdValue) || coolingThresholdValue < minValue) {
         coolingThreshold.updateValue(minValue);
-
-      if (Number.isFinite(coolingThresholdValue) && coolingThresholdValue > maxValue)
+      } else if (coolingThresholdValue > maxValue) {
         coolingThreshold.updateValue(maxValue);
+      }
     }
 
     if (!service.testCharacteristic(this.api.hap.Characteristic.ValvePosition))

package/src/helper/handler.js

@@ -129,6 +129,14 @@ export default (api, accessories, config, tado, telegram) => {
     return { min, max };
   }
 
+  function _getTemperatureValue(temperature) {
+    if (!temperature) return undefined;
+
+    return config.temperatureUnit === 'FAHRENHEIT'
+      ? temperature.fahrenheit
+      : temperature.celsius;
+  }
+
   function _normalizeTemperatureForAccessory(accessory, temp) {
     if (temp === null || temp === undefined) return temp;
 
@@ -1091,16 +1099,10 @@ export default (api, accessories, config, tado, telegram) => {
 
         //HEATING
         if (zoneState.sensorDataPoints.insideTemperature) {
-          currentTemp =
-            config.temperatureUnit === 'FAHRENHEIT'
-              ? zoneState.sensorDataPoints.insideTemperature.fahrenheit
-              : zoneState.sensorDataPoints.insideTemperature.celsius;
+          currentTemp = _getTemperatureValue(zoneState.sensorDataPoints.insideTemperature);
 
           if (zoneState.setting.power === 'ON') {
-            targetTemp =
-              config.temperatureUnit === 'FAHRENHEIT'
-                ? zoneState.setting.temperature.fahrenheit
-                : zoneState.setting.temperature.celsius;
+            targetTemp = _getTemperatureValue(zoneState.setting.temperature);
 
             tempEqual = Math.round(currentTemp) === Math.round(targetTemp);
 
@@ -1230,28 +1232,22 @@ export default (api, accessories, config, tado, telegram) => {
         // Non-HEATING zones (AIR_CONDITIONING, HOT_WATER, etc.)
         battery = zone.battery === 'NORMAL' ? 100 : 10;
 
-        if (zoneState.sensorDataPoints.humidity) {
+        if (zoneState.sensorDataPoints && zoneState.sensorDataPoints.humidity) {
           humidity = zoneState.sensorDataPoints.humidity.percentage;
         }
 
-        // Get current temperature from sensor data (same as HEATING zones)
-        if (zoneState.sensorDataPoints.insideTemperature) {
-          currentTemp =
-            config.temperatureUnit === 'FAHRENHEIT'
-              ? zoneState.sensorDataPoints.insideTemperature.fahrenheit
-              : zoneState.sensorDataPoints.insideTemperature.celsius;
+        // Get current temperature from sensor data if tado provides it.
+        // HOT_WATER zones often do not expose sensorDataPoints.insideTemperature;
+        // the HeaterCooler service applies a fallback below when needed.
+        if (zoneState.sensorDataPoints && zoneState.sensorDataPoints.insideTemperature) {
+          currentTemp = _getTemperatureValue(zoneState.sensorDataPoints.insideTemperature);
         }
 
         if (zoneState.setting.power === 'ON') {
           active = 1;
 
           // Get target temperature from setting
-          targetTemp =
-            zoneState.setting.temperature !== null && zoneState.setting.temperature
-              ? config.temperatureUnit === 'FAHRENHEIT'
-                ? zoneState.setting.temperature.fahrenheit
-                : zoneState.setting.temperature.celsius
-              : undefined;
+          targetTemp = _getTemperatureValue(zoneState.setting.temperature);
 
           // Enhanced AC state handling
           if (zone.type === 'AIR_CONDITIONING') {
@@ -1309,11 +1305,30 @@ export default (api, accessories, config, tado, telegram) => {
 
               service.getCharacteristic(characteristicTargetState).updateValue(targetState);
 
-              // Set current temperature from sensor data
-              if (!isNaN(currentTemp) || acc.context.currentTemp) {
-                if (!isNaN(currentTemp)) acc.context.currentTemp = currentTemp; //store current temp in config
+              // Set current temperature from sensor data when available.
+              // HOT_WATER zones can have no sensorDataPoints.insideTemperature in the tado API.
+              // In that case, keep the last known value; if none exists, fall back to the
+              // configured hot-water target temperature and finally the configured minimum.
+              let homeKitCurrentTemp = currentTemp;
+              const isValidTemperature = (value) => value !== undefined && value !== null && !isNaN(value);
+
+              if (zone.type === 'HOT_WATER' && !isValidTemperature(homeKitCurrentTemp)) {
+                if (isValidTemperature(acc.context.currentTemp)) {
+                  homeKitCurrentTemp = acc.context.currentTemp;
+                } else if (isValidTemperature(targetTemp)) {
+                  homeKitCurrentTemp = targetTemp;
+                } else if (isValidTemperature(zone.minValue)) {
+                  homeKitCurrentTemp = zone.minValue;
+                } else if (acc.context.config && isValidTemperature(acc.context.config.minValue)) {
+                  homeKitCurrentTemp = acc.context.config.minValue;
+                } else {
+                  homeKitCurrentTemp = 30;
+                }
+              }
 
-                service.getCharacteristic(characteristicCurrentTemp).updateValue(acc.context.currentTemp);
+              if (!isNaN(homeKitCurrentTemp)) {
+                acc.context.currentTemp = homeKitCurrentTemp; //store current temp in config
+                service.getCharacteristic(characteristicCurrentTemp).updateValue(homeKitCurrentTemp);
               }
 
               // Set target temperature for both heating and cooling
@@ -1569,12 +1584,10 @@ export default (api, accessories, config, tado, telegram) => {
       const weather = await tado.getWeather(config.homeId);
 
       if (weatherTemperatureAccessory.length && weather.outsideTemperature) {
-        let tempUnit = config.temperatureUnit;
         let service = weatherTemperatureAccessory[0].getService(api.hap.Service.TemperatureSensor);
         let characteristic = api.hap.Characteristic.CurrentTemperature;
 
-        let temp =
-          tempUnit === 'FAHRENHEIT' ? weather.outsideTemperature.fahrenheit : weather.outsideTemperature.celsius;
+        let temp = _getTemperatureValue(weather.outsideTemperature);
 
         service.getCharacteristic(characteristic).updateValue(temp);
       }

package/src/helper/update-buffer.js

@@ -54,7 +54,7 @@ export class TadoUpdateBuffer {
     const tempSet = temp !== null;
     this.pendingState = null;
     this.pendingTemperature = null;
-    if (tempSet && !siriAutoTemperature) this.lastTemperature = temp;
+    if (tempSet && (!siriAutoTemperature || !this.preferSiriTemperature)) this.lastTemperature = temp;
 
     //Siri temperature heuristic
     if (this.preferSiriTemperature && state === 3 && tempSet) {