@homebridge-plugins/homebridge-tado 8.5.0 → 8.5.1-beta.1

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## v8.5.1 - 2025-10-28
+- Fix: Incorrect update of config zone properties leading to unwanted heating changes (#178)
+
 ## v8.5.0 - 2025-10-27
 - Change minimum polling interval to 30s due to improvements made in v8.2.0
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@homebridge-plugins/homebridge-tado",
-  "version": "8.5.0",
+  "version": "8.5.1-beta.1",
   "description": "Homebridge plugin for controlling tado° devices.",
   "main": "index.js",
   "scripts": {
@@ -51,4 +51,4 @@
     "globals": "^16.4.0",
     "prettier": "^3.6.2"
   }
-}
+}

package/src/helper/handler.js

@@ -27,7 +27,6 @@ export default (api, accessories, config, tado, telegram) => {
 
   async function setStates(accessory, accs, target, value) {
     let zoneUpdated = false;
-    let allZonesUpdated = false;
 
     accessories = accs.filter((acc) => acc && acc.context.config.homeName === config.homeName);
 
@@ -376,7 +375,6 @@ export default (api, accessories, config, tado, telegram) => {
             }
           }
 
-          allZonesUpdated = true;
           await tado.setPresenceLock(config.homeId, targetState);
 
           break;
@@ -428,7 +426,6 @@ export default (api, accessories, config, tado, telegram) => {
                 })
                 .filter((id) => id);
 
-              allZonesUpdated = true;
               await tado.resumeShedule(config.homeId, roomIds);
 
               //Turn all back to AUTO/ON
@@ -553,7 +550,6 @@ export default (api, accessories, config, tado, telegram) => {
               .updateValue(false);
           }
 
-          allZonesUpdated = true;
           await tado.switchAll(config.homeId, rooms);
 
           break;
@@ -570,7 +566,7 @@ export default (api, accessories, config, tado, telegram) => {
       errorHandler(err);
     } finally {
       //always update zone to set correct state in Apple Home
-      if (zoneUpdated || allZonesUpdated) await updateZones(allZonesUpdated ? undefined : accessory.context.config.zoneId);
+      if (zoneUpdated) await updateZones(accessory.context.config.zoneId);
       settingState = false;
     }
   }
@@ -875,36 +871,34 @@ export default (api, accessories, config, tado, telegram) => {
         }
       }
 
-      if (idToUpdate === undefined) {
-        const allZones = (await tado.getZones(config.homeId)) || [];
+      const allZones = (await tado.getZones(config.homeId)) || [];
 
-        for (const [index, zone] of config.zones.entries()) {
-          allZones.forEach((zoneWithID) => {
-            if (zoneWithID.name === zone.name) {
-              const heatAccessory = accessories.filter(
-                (acc) => acc && acc.displayName === config.homeName + ' ' + zone.name + ' Heater'
-              );
+      for (const [index, zone] of config.zones.entries()) {
+        allZones.forEach((zoneWithID) => {
+          if (zoneWithID.name === zone.name) {
+            const heatAccessory = accessories.filter(
+              (acc) => acc && acc.displayName === config.homeName + ' ' + zone.name + ' Heater'
+            );
 
-              if (heatAccessory.length) heatAccessory[0].context.config.zoneId = zoneWithID.id;
-
-              config.zones[index].id = zoneWithID.id;
-              config.zones[index].battery = !config.zones[index].noBattery
-                ? zoneWithID.devices.filter(
-                  (device) =>
-                    device &&
-                    (zone.type === 'HEATING' || zone.type === 'AIR_CONDITIONING') &&
-                    typeof device.batteryState === 'string' &&
-                    !device.batteryState.includes('NORMAL')
-                ).length
-                  ? zoneWithID.devices.filter((device) => device && !device.batteryState.includes('NORMAL'))[0]
-                    .batteryState
-                  : zoneWithID.devices.filter((device) => device && device.duties.includes('ZONE_LEADER'))[0].batteryState
-                : false;
-              config.zones[index].openWindowEnabled =
-                zoneWithID.openWindowDetection && zoneWithID.openWindowDetection.enabled ? true : false;
-            }
-          });
-        }
+            if (heatAccessory.length) heatAccessory[0].context.config.zoneId = zoneWithID.id;
+
+            config.zones[index].id = zoneWithID.id;
+            config.zones[index].battery = !config.zones[index].noBattery
+              ? zoneWithID.devices.filter(
+                (device) =>
+                  device &&
+                  (zone.type === 'HEATING' || zone.type === 'AIR_CONDITIONING') &&
+                  typeof device.batteryState === 'string' &&
+                  !device.batteryState.includes('NORMAL')
+              ).length
+                ? zoneWithID.devices.filter((device) => device && !device.batteryState.includes('NORMAL'))[0]
+                  .batteryState
+                : zoneWithID.devices.filter((device) => device && device.duties.includes('ZONE_LEADER'))[0].batteryState
+              : false;
+            config.zones[index].openWindowEnabled =
+              zoneWithID.openWindowDetection && zoneWithID.openWindowDetection.enabled ? true : false;
+          }
+        });
       }
 
       let zonesToUpdate = [];