@homebridge-plugins/homebridge-meross 10.19.0 → 10.19.1-beta.0

package/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 All notable changes to `@homebridge-plugins/homebridge-meross` will be documented in this file.
 
+## v10.19.1 (Pending Release)
+
+### Changed
+
+- docs: add node 26 to the supported node versions
+- chore: exclude test files and the test config from the published package
+- fix: restore debug logging when the plugin runs in a child bridge
+- fix: only turn adaptive lighting off when a colour is genuinely chosen elsewhere
+- fix: send a colour change when only the saturation moves, and mend the al cleanup
+- fix: keep the cloud accessories when the device list could not be fetched
+- fix: stop the hub's follow-up request growing on every poll until it fails
+- fix: stop the polling timers on shutdown for a local-only setup, not just a cloud one
+- fix: stop the garage's quick polling when the door is operated again mid-close
+- fix: apply the smoke sensor's battery reading, instead of failing on every update
+
 ## v10.19.0 (2026-08-01)
 
 ### Changed

package/README.md

@@ -28,7 +28,7 @@ Homebridge plugin to integrate Meross devices into HomeKit
 ### Prerequisites
 
 - To use this plugin, you will need to already have:
-  - [Node](https://nodejs.org): latest version of `v22` or `v24` - any other major version is not supported.
+  - [Node](https://nodejs.org): latest version of `v22`, `v24` or `v26` - any other major version is not supported.
   - [Homebridge](https://homebridge.io): `v1.6` or above - refer to link for more information and installation instructions.
 
 ### Setup

package/lib/device/garage-single.js

@@ -105,6 +105,18 @@ export default class {
     platform.log('[%s] %s %s.', this.name, platformLang.devInitOpts, opts)
   }
 
+  /**
+   * Cancel the quick polling started when the door was told to close. Kept in one
+   * place so every path that ends a close - a new operation, the door settling,
+   * or Homebridge shutting down - stops it rather than leaving it running.
+   */
+  stopExtremePolling() {
+    if (this.extremePolling) {
+      clearInterval(this.extremePolling)
+      this.extremePolling = false
+    }
+  }
+
   async internalTargetUpdate(value) {
     // Add the request to the queue so updates are sent apart
     try {
@@ -226,6 +238,13 @@ export default class {
           const updateKey = generateRandomString(5)
           this.updateKey = updateKey
 
+          // A new operation supersedes any close still in progress, so its quick
+          // polling has to stop here. Without this it was orphaned: the close
+          // timeout returned early on the changed key and never reached its own
+          // clearInterval, so the device was polled every 3 seconds for ever, and
+          // each open-during-close cycle leaked another one.
+          this.stopExtremePolling()
+
           // Update the Eve times opened characteristic
           this.accessory.eveService.addEntry({ status: 0 })
           this.service.updateCharacteristic(
@@ -262,6 +281,7 @@ export default class {
         */
         if (action === 'close') {
           const updateKey = generateRandomString(5)
+          this.stopExtremePolling()
           if (this.accessory.context.connection === 'local') {
             this.extremePolling = setInterval(() => this.requestUpdate(), 3000)
           }
@@ -281,10 +301,7 @@ export default class {
             this.accessory.log(`${platformLang.curState} [${this.states[this.cacheCurrent]}]`)
 
             // Cancel any 'extreme' polling intervals from setting the garage to close
-            if (this.extremePolling) {
-              clearInterval(this.extremePolling)
-              this.extremePolling = false
-            }
+            this.stopExtremePolling()
           }, (this.operationTime + 15) * 1000)
         }
       })
@@ -482,10 +499,7 @@ export default class {
           }
 
           // Cancel any 'extreme' polling intervals from setting the garage to close
-          if (this.extremePolling) {
-            clearInterval(this.extremePolling)
-            this.extremePolling = false
-          }
+          this.stopExtremePolling()
           break
         }
         default:

package/lib/device/garage-sub.js

@@ -84,6 +84,18 @@ export default class {
     platform.log('[%s] %s %s.', this.name, platformLang.devInitOpts, opts)
   }
 
+  /**
+   * Cancel the quick polling started when the door was told to close. Kept in one
+   * place so every path that ends a close - a new operation, the door settling,
+   * or Homebridge shutting down - stops it rather than leaving it running.
+   */
+  stopExtremePolling() {
+    if (this.extremePolling) {
+      clearInterval(this.extremePolling)
+      this.extremePolling = false
+    }
+  }
+
   async internalTargetUpdate(value) {
     // Add the request to the queue so updates are sent apart
     try {
@@ -205,6 +217,13 @@ export default class {
           const updateKey = generateRandomString(5)
           this.updateKey = updateKey
 
+          // A new operation supersedes any close still in progress, so its quick
+          // polling has to stop here. Without this it was orphaned: the close
+          // timeout returned early on the changed key and never reached its own
+          // clearInterval, so the device was polled every 3 seconds for ever, and
+          // each open-during-close cycle leaked another one.
+          this.stopExtremePolling()
+
           // Update the Eve times opened characteristic
           this.accessory.eveService.addEntry({ status: 0 })
           this.service.updateCharacteristic(
@@ -241,6 +260,7 @@ export default class {
       */
         if (action === 'close') {
           const updateKey = generateRandomString(5)
+          this.stopExtremePolling()
           if (this.accessory.context.connection === 'local') {
             this.extremePolling = setInterval(() => this.priAcc.control.requestUpdate(), 3000)
           }
@@ -260,10 +280,7 @@ export default class {
             this.accessory.log(`${platformLang.curState} [${this.states[this.cacheCurrent]}]`)
 
             // Cancel any 'extreme' polling intervals from setting the garage to close
-            if (this.extremePolling) {
-              clearInterval(this.extremePolling)
-              this.extremePolling = false
-            }
+            this.stopExtremePolling()
           }, (this.operationTime + 15) * 1000)
         }
       })
@@ -363,10 +380,7 @@ export default class {
           }
 
           // Cancel any 'extreme' polling intervals from setting the garage to close
-          if (this.extremePolling) {
-            clearInterval(this.extremePolling)
-            this.extremePolling = false
-          }
+          this.stopExtremePolling()
           break
         }
         default:

package/lib/device/hub-main.js

@@ -92,6 +92,13 @@ export default class {
             && data.all.digest.hub.subdevice
             && Array.isArray(data.all.digest.hub.subdevice)
           ) {
+            // Rebuild these each poll. They used to be appended to and never
+            // cleared, so with one valve on the hub and the default 300s refresh
+            // the follow-up request carried 288 copies of the same id after a day,
+            // growing until the hub stopped answering and state stopped updating.
+            this.mtsList = []
+            this.waterList = []
+
             data.all.digest.hub.subdevice.forEach((subdevice) => {
               // Check whether the homebridge accessory this relates to exists
               const subAcc = this.devicesInHB.get(

package/lib/device/hub-smoke.js

@@ -1,5 +1,5 @@
 import platformConsts from '../utils/constants.js'
-import { parseError } from '../utils/functions.js'
+import { hasProperty, parseError } from '../utils/functions.js'
 import platformLang from '../utils/lang-en.js'
 
 export default class {
@@ -32,7 +32,30 @@ export default class {
 
   applyUpdate(data) {
     try {
-      this.log.warn('[%s]\n%s.', this.name, JSON.stringify(data))
+      // This warned every incoming frame through `this.log`, which the class never
+      // defines - so it threw on every update, the catch below turned that into a
+      // warning the owner could do nothing about, and the battery reading was
+      // never applied at all. Routine frames belong in the debug log.
+      this.accessory.logDebug(JSON.stringify(data))
+
+      // Battery % from reported voltage, the same way the other hub sensors do it
+      if (hasProperty(data, 'voltage')) {
+        // 1. Reduce/enlarge value so in [2000, 3000]
+        let newVoltage = Math.min(Math.max(data.voltage, 2000), 3000)
+
+        // 2. Scale this from [2000, 3000] to [0, 100] and round to nearest whole number
+        newVoltage = Math.round((newVoltage - 2000) / 10)
+
+        // This should be a rough estimate of the battery %
+        if (newVoltage !== this.cacheBatt) {
+          this.cacheBatt = newVoltage
+          this.battService.updateCharacteristic(this.hapChar.BatteryLevel, this.cacheBatt)
+          this.battService.updateCharacteristic(
+            this.hapChar.StatusLowBattery,
+            this.cacheBatt < this.lowBattThreshold ? 1 : 0,
+          )
+        }
+      }
     } catch (err) {
       this.accessory.logWarn(`${platformLang.refFailed} ${parseError(err)}`)
     }

package/lib/device/light-cct.js

@@ -43,10 +43,22 @@ export default class {
     this.service = this.accessory.getService(this.hapServ.Lightbulb)
       || this.accessory.addService(this.hapServ.Lightbulb)
 
-    // If adaptive lighting has just been disabled then remove and re-add service to hide AL icon
+    // Adaptive lighting has just been switched off, so take away the three
+    // characteristics that make Home offer it. Only these need to go: the whole
+    // Lightbulb service used to be thrown away and rebuilt here, which does hide
+    // the icon but presents Home with what looks like a different light, and an
+    // owner can lose that light's room and its automations as a result.
     if (this.alShift === -1 && this.accessory.context.adaptiveLighting) {
-      this.accessory.removeService(this.service)
-      this.service = this.accessory.addService(this.hapServ.Lightbulb)
+      [
+        'SupportedCharacteristicValueTransitionConfiguration',
+        'CharacteristicValueTransitionControl',
+        'CharacteristicValueActiveTransitionCount',
+      ].forEach((charName) => {
+        const char = this.hapChar[charName]
+        if (char && this.service.testCharacteristic(char)) {
+          this.service.removeCharacteristic(this.service.getCharacteristic(char))
+        }
+      })
       this.accessory.context.adaptiveLighting = false
     }
 
@@ -463,7 +475,13 @@ export default class {
           this.cacheMired = hkTemp
           const kelvin = Math.round(1000000 / this.cacheMired)
           this.accessory.log(`${platformLang.curLightTemp} [${this.cacheMired} / ${kelvin}]`)
-          if (dif > 10 && this.alController && this.alController.isAdaptiveLightingActive()) {
+          // A light repeating back the temperature adaptive lighting just set
+          // can land a few mireds off through the conversion, and treating that
+          // as the owner's doing would switch adaptive lighting off moments
+          // after it was switched on. Further apart than that and somebody set
+          // this temperature themselves, outside HomeKit - which nothing else
+          // would notice, so adaptive lighting has to be stopped here.
+          if (dif > 10 && this.alController?.isAdaptiveLightingActive?.()) {
             this.alController.disableAdaptiveLighting()
             this.accessory.log(platformLang.alDisabled)
           }

package/lib/device/light-rgb.js

@@ -49,10 +49,22 @@ export default class {
     this.service = this.accessory.getService(this.hapServ.Lightbulb)
       || this.accessory.addService(this.hapServ.Lightbulb)
 
-    // If adaptive lighting has just been disabled then remove and re-add service to hide AL icon
+    // Adaptive lighting has just been switched off, so take away the three
+    // characteristics that make Home offer it. Only these need to go: the whole
+    // Lightbulb service used to be thrown away and rebuilt here, which does hide
+    // the icon but presents Home with what looks like a different light, and an
+    // owner can lose that light's room and its automations as a result.
     if (this.alShift === -1 && this.accessory.context.adaptiveLighting) {
-      this.accessory.removeService(this.service)
-      this.service = this.accessory.addService(this.hapServ.Lightbulb)
+      [
+        'SupportedCharacteristicValueTransitionConfiguration',
+        'CharacteristicValueTransitionControl',
+        'CharacteristicValueActiveTransitionCount',
+      ].forEach((charName) => {
+        const char = this.hapChar[charName]
+        if (char && this.service.testCharacteristic(char)) {
+          this.service.removeCharacteristic(this.service.getCharacteristic(char))
+        }
+      })
       this.accessory.context.adaptiveLighting = false
     }
 
@@ -73,6 +85,14 @@ export default class {
     this.service
       .getCharacteristic(this.hapChar.Hue)
       .onSet(async value => this.internalColourUpdate(value))
+    // Saturation needs a handler of its own. HomeKit writes hue and saturation
+    // separately, so with only hue listened for, dragging saturation alone -
+    // the same colour made paler or richer - reached nothing at all. Both
+    // handlers share one update, and the debounce inside it collapses a
+    // hue-and-saturation pair into a single command.
+    this.service
+      .getCharacteristic(this.hapChar.Saturation)
+      .onSet(async () => this.internalColourUpdate(this.service.getCharacteristic(this.hapChar.Hue).value))
     this.cacheHue = this.service.getCharacteristic(this.hapChar.Hue).value
     this.cacheSat = this.service.getCharacteristic(this.hapChar.Saturation).value
 
@@ -495,11 +515,19 @@ export default class {
           this.cacheHue = newHue
           this.cacheSat = newSat
           this.accessory.log(`${platformLang.curLightColour} [${this.cacheHue}, ${this.cacheSat}] / [${r}, ${g}, ${b}]`)
-        }
-        //  Disable adaptive lighting
-        if (this.alController && this.alController.isAdaptiveLightingActive()) {
-          this.alController.disableAdaptiveLighting()
-          this.accessory.log(platformLang.alDisabled)
+
+          // Somebody chose this colour outside HomeKit - in the Meross app, on
+          // a remote, or at the wall. Homebridge catches changes made in the
+          // Home app itself, but nothing else sees these, so adaptive lighting
+          // would carry on and move the light off that colour within minutes.
+          //
+          // This used to sit outside the check above and fire on every report,
+          // so a routine refresh that simply repeated the current colour back
+          // switched adaptive lighting off seconds after it was switched on.
+          if (this.alController?.isAdaptiveLightingActive?.()) {
+            this.alController.disableAdaptiveLighting()
+            this.accessory.log(platformLang.alDisabled)
+          }
         }
       }
       if (
@@ -517,7 +545,13 @@ export default class {
           this.cacheMired = hkTemp
           const kelvin = Math.round(1000000 / this.cacheMired)
           this.accessory.log(`${platformLang.curLightTemp} [${this.cacheMired} / ${kelvin}]`)
-          if (dif > 10 && this.alController && this.alController.isAdaptiveLightingActive()) {
+          // A light repeating back the temperature adaptive lighting just set
+          // can land a few mireds off through the conversion, and treating that
+          // as the owner's doing would switch adaptive lighting off moments
+          // after it was switched on. Further apart than that and somebody set
+          // this temperature themselves, outside HomeKit - which nothing else
+          // would notice, so adaptive lighting has to be stopped here.
+          if (dif > 10 && this.alController?.isAdaptiveLightingActive?.()) {
             this.alController.disableAdaptiveLighting()
             this.accessory.log(platformLang.alDisabled)
           }

package/lib/homebridge-ui/public/index.html

@@ -197,7 +197,7 @@
 <ul>
   <li>To use this plugin, you will need to already have:</li>
   <ul>
-    <li><a href="https://nodejs.org" target="_blank">Node</a>: latest version of <code>v22</code> or <code>v24</code> - any other major version is not supported.</li>
+    <li><a href="https://nodejs.org" target="_blank">Node</a>: latest version of <code>v22</code>, <code>v24</code> or <code>v26</code> - any other major version is not supported.</li>
     <li><a href="https://homebridge.io" target="_blank">Homebridge</a>: <code>v1.6</code> or above - refer to link for more information and installation instructions.</li>
   </ul>
 </ul>

package/lib/platform.js

@@ -29,7 +29,6 @@ export default class {
     try {
       this.api = api
       this.log = log
-      this.isBeta = process.argv.includes('-D')
       this.cloudClient = false
       this.deviceConf = {}
       this.devicesInHB = new Map()
@@ -304,13 +303,16 @@ export default class {
       this.log('%s.', platformLang.initialised)
 
       // Sort out some logging functions
-      if (this.isBeta) {
-        this.log.debug = this.log
-        this.log.debugWarn = this.log.warn
-      } else {
-        this.log.debug = () => {}
-        this.log.debugWarn = () => {}
-      }
+      // Homebridge already decides whether debug lines are shown, and it gets it
+      // right in a child bridge too. This used to work it out for itself by
+      // looking for `-D` in the plugin's own process arguments, which a child
+      // bridge does not receive unless that bridge has its own debug setting
+      // turned on - so debug logging silently disappeared for anyone running the
+      // plugin in a child bridge with debug enabled globally.
+      //
+      // `debugWarn` has no equivalent on Homebridge's logger, so it goes out as
+      // a debug line too rather than being invented here.
+      this.log.debugWarn = (...args) => this.log.debug(...args)
 
       // Require any libraries that the accessory instances use
       this.cusChar = new platformChars(this.api)
@@ -339,6 +341,7 @@ export default class {
       // If the user has configured cloud username and password then get a device list
       this.accountDetails = {}
       let cloudDevices = []
+      let cloudListFetched = false
       try {
         if (!this.config.username || !this.config.password) {
           throw new Error(platformLang.missingCreds)
@@ -381,6 +384,7 @@ export default class {
         }
 
         // Initialise the cloud configured devices into Homebridge
+        cloudListFetched = true
         cloudDevices.forEach(device => this.initialiseDevice(device))
       } catch (err) {
         const eText = parseError(err, [platformLang.mfaFail, platformLang.missingCreds, platformLang.accTokenInvalid])
@@ -434,7 +438,12 @@ export default class {
         switch (accessory.context.connection) {
           case 'cloud':
           case 'hybrid':
-            if (!cloudDevices.some(el => el.uuid === accessory.context.serialNumber)) {
+            // Only a list that actually arrived says anything about what is on the
+            // account. `cloudDevices` is also empty when the login or the device
+            // request failed, and an owner with a user key set reaches this code
+            // in that case - so one bad morning at Meross used to wipe their whole
+            // setup out of HomeKit, rooms, scenes and automations included.
+            if (cloudListFetched && !cloudDevices.some(el => el.uuid === accessory.context.serialNumber)) {
               this.removeAccessory(accessory)
             }
             break
@@ -464,42 +473,43 @@ export default class {
   pluginShutdown() {
     // A function that is called when the plugin fails to load or Homebridge restarts
     try {
-      // Close the mqtt connection for the accessories with an open connection
-      if (this.cloudClient) {
-        this.devicesInHB.forEach((accessory) => {
-          if (accessory.mqtt) {
-            accessory.mqtt.disconnect()
-          }
-          if (accessory.refreshInterval) {
-            clearInterval(accessory.refreshInterval)
-          }
-          if (accessory.powerInterval) {
-            clearInterval(accessory.powerInterval)
-          }
-        })
-      }
+      // Stop every accessory's timers. Only the mqtt disconnect needs a cloud
+      // client: this whole block used to sit behind that check, so a local-only
+      // setup - no username or password, just a user key - kept polling every
+      // device while Homebridge was tearing down, and kept the process alive
+      this.devicesInHB.forEach((accessory) => {
+        if (this.cloudClient && accessory.mqtt) {
+          accessory.mqtt.disconnect()
+        }
+        if (accessory.refreshInterval) {
+          clearInterval(accessory.refreshInterval)
+        }
+        if (accessory.powerInterval) {
+          clearInterval(accessory.powerInterval)
+        }
+        accessory.control?.stopExtremePolling?.()
+      })
     } catch (err) {
       // No need to show errors at this point
     }
   }
 
   applyAccessoryLogging(accessory) {
-    if (this.isBeta) {
-      accessory.log = msg => this.log('[%s] %s.', accessory.displayName, msg)
-      accessory.logWarn = msg => this.log.warn('[%s] %s.', accessory.displayName, msg)
-      accessory.logDebug = msg => this.log('[%s] %s.', accessory.displayName, msg)
-      accessory.logDebugWarn = msg => this.log.warn('[%s] %s.', accessory.displayName, msg)
-    } else {
-      if (this.config.disableDeviceLogging) {
-        accessory.log = () => {}
-        accessory.logWarn = () => {}
-      } else {
-        accessory.log = msg => this.log('[%s] %s.', accessory.displayName, msg)
-        accessory.logWarn = msg => this.log.warn('[%s] %s.', accessory.displayName, msg)
-      }
-      accessory.logDebug = () => {}
-      accessory.logDebugWarn = () => {}
+    // Debug lines always go to Homebridge's debug logger, which prints them only
+    // when debug is on - so there is nothing to decide here. Working it out from
+    // the process arguments instead is what lost debug logging entirely for
+    // anyone running the plugin in a child bridge.
+    accessory.logDebug = msg => this.log.debug('[%s] %s.', accessory.displayName, msg)
+    accessory.logDebugWarn = accessory.logDebug
+
+    if (this.config.disableDeviceLogging) {
+      accessory.log = () => {}
+      accessory.logWarn = () => {}
+      return
     }
+
+    accessory.log = msg => this.log('[%s] %s.', accessory.displayName, msg)
+    accessory.logWarn = msg => this.log.warn('[%s] %s.', accessory.displayName, msg)
   }
 
   async initialiseDevice(device) {

package/lib/utils/lang-en.js

@@ -6,7 +6,7 @@ export default {
   accTokenNoExist: 'does not exist, this is normally not an issue',
   accTokenStoreErr: 'could not store access token as',
   accTokenUserChange: 'username has changed',
-  alDisabled: 'adaptive lighting disabled due to change of colour detected',
+  alDisabled: 'adaptive lighting turned off, as the colour was changed outside HomeKit',
   brand: 'Meross Technology',
   cfgDef: 'is not a valid number so using default of',
   cfgDup: 'will be ignored since another entry with this ID already exists',

package/package.json

@@ -2,7 +2,7 @@
   "name": "@homebridge-plugins/homebridge-meross",
   "alias": "Meross",
   "type": "module",
-  "version": "10.19.0",
+  "version": "10.19.1-beta.0",
   "description": "Homebridge plugin to integrate Meross devices into HomeKit.",
   "author": {
     "name": "bwp91",

package/lib/utils/functions.test.js

@@ -1,78 +0,0 @@
-import { Buffer } from 'node:buffer'
-
-import { describe, expect, it } from 'vitest'
-
-import { encodeParams, generateRandomString, hasProperty, parseError } from './functions.js'
-
-describe('encodeParams', () => {
-  it('base64 encodes the json body the meross cloud expects', () => {
-    const encoded = encodeParams({ email: 'a@b.com', password: 'x' })
-    expect(JSON.parse(Buffer.from(encoded, 'base64').toString())).toEqual({
-      email: 'a@b.com',
-      password: 'x',
-    })
-  })
-
-  it('produces valid base64 with no line breaks', () => {
-    // The value goes straight into a request body, so a wrapped or padded
-    // encoding would be rejected by the cloud.
-    const encoded = encodeParams({ a: 'x'.repeat(200) })
-    expect(encoded).toMatch(/^[A-Z0-9+/]+=*$/i)
-  })
-
-  it('handles an empty object', () => {
-    expect(Buffer.from(encodeParams({}), 'base64').toString()).toBe('{}')
-  })
-})
-
-describe('generateRandomString', () => {
-  it('returns the requested length', () => {
-    expect(generateRandomString(16)).toHaveLength(16)
-    expect(generateRandomString(1)).toHaveLength(1)
-  })
-
-  it('uses only lowercase letters and digits', () => {
-    // The nonce is signed alongside the request, so any character outside the
-    // documented set risks a signature mismatch.
-    expect(generateRandomString(200)).toMatch(/^[a-z0-9]+$/)
-  })
-
-  it('does not return the same value twice in a row', () => {
-    expect(generateRandomString(32)).not.toBe(generateRandomString(32))
-  })
-})
-
-describe('hasProperty', () => {
-  it('detects own properties only', () => {
-    expect(hasProperty({ a: 1 }, 'a')).toBe(true)
-    expect(hasProperty({ a: undefined }, 'a')).toBe(true)
-    expect(hasProperty({}, 'a')).toBe(false)
-  })
-
-  it('ignores inherited properties', () => {
-    // A device payload with no "toString" key must not read as having one.
-    expect(hasProperty({}, 'toString')).toBe(false)
-  })
-})
-
-describe('parseError', () => {
-  it('appends the first stack frame to the message', () => {
-    const err = new Error('boom')
-    err.stack = 'Error: boom\n    at thing (/a.js:1:1)'
-    expect(parseError(err)).toBe('boom at thing (/a.js:1:1)')
-  })
-
-  it('returns just the message when the error is listed in hideStack', () => {
-    // Routine failures - a device being unreachable - are logged without a
-    // stack so the log stays readable.
-    const err = new Error('offline')
-    err.stack = 'Error: offline\n    at thing (/a.js:1:1)'
-    expect(parseError(err, ['offline'])).toBe('offline')
-  })
-
-  it('returns the message when there is no stack at all', () => {
-    const err = new Error('nostack')
-    err.stack = ''
-    expect(parseError(err)).toBe('nostack')
-  })
-})