@homebridge-plugins/homebridge-meross 10.17.1 → 10.18.0

package/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 All notable changes to `@homebridge-plugins/homebridge-meross` will be documented in this file.
 
+## v10.18.0 (2026-07-30)
+
+### Changed
+
+- chore: add a test setup with tests for the shared helper functions
+- chore(github): run the build and tests in ci, on node 22, 24 and 26
+- chore: use the same lint setup across every plugin
+- chore: add a changelog:sync script to populate the pending section from the commits
+- chore: count a repeated commit subject once when syncing the changelog
+- chore(github): check the changelog against the commits in ci
+- feat(thermostat): honour SummerMode on MTS215/MTS215B (@marcaicart)
+- chore(deps): dependency updates
+
 ## v10.17.1 (2026-07-28)
 
 ### Changed

package/lib/device/thermostat-mts215.js

@@ -43,19 +43,32 @@ export default class {
       4: this.cusChar.ValveEconomyMode,
     }
 
+    // Appliance.Control.Thermostat.SummerMode (mode: 1 = heat orientation, 2 = cool
+    // orientation) tells us whether the device is wired to heating or cooling
+    // equipment -- it flips which direction "state: 1" (actively calling) means,
+    // and which HomeKit HeatingCoolingState value should represent it. Comes
+    // bundled in the same Appliance.System.All digest as mode/windowOpened, so no
+    // extra request is needed; corrected as soon as the first poll comes back.
+    //
+    // Read-only here on purpose: this reflects how the installation is physically
+    // wired (boiler vs AC), not something to flip live from HomeKit like a sensor
+    // or a mode setting. If that's ever wanted, it can be set with
+    //   sendUpdate(accessory, { namespace: 'Appliance.Control.Thermostat.SummerMode',
+    //     payload: { summerMode: [{ channel: 0, mode: 1|2 }] } })
+    // -- note the SETACK payload comes back empty even on success, so the write
+    // has to be confirmed with a follow-up GET rather than trusted from the SET
+    // response (confirmed empirically, same device).
+    this.cacheSummerMode = false
+
     // Add the thermostat service if it doesn't already exist
     this.service = this.accessory.getService(this.hapServ.Thermostat)
       || this.accessory.addService(this.hapServ.Thermostat)
 
     this.service
       .getCharacteristic(this.hapChar.TargetHeatingCoolingState)
-      .setProps({
-        minValue: 0,
-        maxValue: 1,
-        validValues: [0, 1],
-      })
       .onSet(async value => this.internalStateUpdate(value))
     this.cacheState = this.service.getCharacteristic(this.hapChar.TargetHeatingCoolingState).value
+    this.updateHeatCoolProps()
 
     this.service
       .getCharacteristic(this.hapChar.TargetTemperature)
@@ -282,10 +295,13 @@ export default class {
         this.cacheTarg = value
         this.accessory.log(`${platformLang.curTarg} [${value}°C]`)
 
-        // Update the current heating state
+        // Update the current heating state (optimistic -- confirmed by the next poll).
+        // Direction depends on SummerMode: heating calls when the target is above the
+        // current temperature, cooling calls when it's below.
+        const isCalling = this.cacheSummerMode ? value < this.cacheTemp : value > this.cacheTemp
         this.service.updateCharacteristic(
           this.hapChar.CurrentHeatingCoolingState,
-          value > this.cacheTemp ? 1 : 0,
+          isCalling ? this.heatCoolValue() : this.hapChar.CurrentHeatingCoolingState.OFF,
         )
 
         // Turn the modes off as back to manual mode
@@ -323,6 +339,30 @@ export default class {
     }
   }
 
+  // Returns which HomeKit HeatingCoolingState value ("calling") means on this
+  // device right now: Cool if Appliance.Control.Thermostat.SummerMode says this is
+  // wired to cooling equipment, Heat otherwise.
+  heatCoolValue() {
+    return this.cacheSummerMode ? this.hapChar.CurrentHeatingCoolingState.COOL : this.hapChar.CurrentHeatingCoolingState.HEAT
+  }
+
+  // Restricts TargetHeatingCoolingState to Off + whichever of Heat/Cool actually
+  // applies given the current SummerMode -- offering the other one in HomeKit would
+  // let the user pick a state the device can't actually honour (SummerMode is
+  // read-only here, see the constructor for why).
+  updateHeatCoolProps() {
+    const validValues = this.cacheSummerMode
+      ? [this.hapChar.TargetHeatingCoolingState.OFF, this.hapChar.TargetHeatingCoolingState.COOL]
+      : [this.hapChar.TargetHeatingCoolingState.OFF, this.hapChar.TargetHeatingCoolingState.HEAT]
+    this.service
+      .getCharacteristic(this.hapChar.TargetHeatingCoolingState)
+      .setProps({
+        minValue: 0,
+        maxValue: Math.max(...validValues),
+        validValues,
+      })
+  }
+
   // Creates or removes a ContactSensor based on whether the corresponding protection
   // is armed on the device. Only called on the first poll after startup: these are
   // manually-configured device settings that don't change often, and re-evaluating on
@@ -495,6 +535,18 @@ export default class {
 
   applyUpdate(data) {
     try {
+      // Read SummerMode before mode/state so the heat-vs-cool direction used below
+      // is already up to date if both arrived in the same digest (the normal case).
+      const summerModeData = data.summerMode?.[0]
+      if (summerModeData && hasProperty(summerModeData, 'mode')) {
+        const newSummerMode = summerModeData.mode === 2
+        if (this.cacheSummerMode !== newSummerMode) {
+          this.cacheSummerMode = newSummerMode
+          this.updateHeatCoolProps()
+          this.accessory.log(`${platformLang.curSummerMode} [${newSummerMode ? 'cool' : 'heat'}]`)
+        }
+      }
+
       const modeData = data.mode?.[0]
       if (modeData) {
         let needsUpdate = false
@@ -503,7 +555,10 @@ export default class {
 
           // Check against the cache and update HomeKit and the cache if needed
           if (this.cacheState !== newState) {
-            this.service.updateCharacteristic(this.hapChar.TargetHeatingCoolingState, newState)
+            this.service.updateCharacteristic(
+              this.hapChar.TargetHeatingCoolingState,
+              newState === 1 ? this.heatCoolValue() : this.hapChar.TargetHeatingCoolingState.OFF,
+            )
             this.cacheState = newState
             this.accessory.log(`${platformLang.curState} [${newState === 1 ? 'on' : 'off'}]`)
             needsUpdate = true
@@ -536,11 +591,15 @@ export default class {
           }
         }
 
-        // Update the current heating state
+        // Update the current heating state. Direction depends on SummerMode: heating
+        // calls when the target is above the current temperature, cooling calls when
+        // it's below -- but this.cacheState (from the device's own "state" field)
+        // already reflects whether it's actually calling either way, so it's trusted
+        // directly rather than re-derived from the temperatures here.
         if (needsUpdate) {
           this.service.updateCharacteristic(
             this.hapChar.CurrentHeatingCoolingState,
-            this.cacheState === 1 && this.cacheTarg > this.cacheTemp ? 1 : 0,
+            this.cacheState === 1 ? this.heatCoolValue() : this.hapChar.CurrentHeatingCoolingState.OFF,
           )
         }
       }

package/lib/utils/functions.test.js

@@ -0,0 +1,78 @@
+import { Buffer } from 'node:buffer'
+
+import { describe, expect, it } from 'vitest'
+
+import { encodeParams, generateRandomString, hasProperty, parseError } from './functions.js'
+
+describe('encodeParams', () => {
+  it('base64 encodes the json body the meross cloud expects', () => {
+    const encoded = encodeParams({ email: 'a@b.com', password: 'x' })
+    expect(JSON.parse(Buffer.from(encoded, 'base64').toString())).toEqual({
+      email: 'a@b.com',
+      password: 'x',
+    })
+  })
+
+  it('produces valid base64 with no line breaks', () => {
+    // The value goes straight into a request body, so a wrapped or padded
+    // encoding would be rejected by the cloud.
+    const encoded = encodeParams({ a: 'x'.repeat(200) })
+    expect(encoded).toMatch(/^[A-Z0-9+/]+=*$/i)
+  })
+
+  it('handles an empty object', () => {
+    expect(Buffer.from(encodeParams({}), 'base64').toString()).toBe('{}')
+  })
+})
+
+describe('generateRandomString', () => {
+  it('returns the requested length', () => {
+    expect(generateRandomString(16)).toHaveLength(16)
+    expect(generateRandomString(1)).toHaveLength(1)
+  })
+
+  it('uses only lowercase letters and digits', () => {
+    // The nonce is signed alongside the request, so any character outside the
+    // documented set risks a signature mismatch.
+    expect(generateRandomString(200)).toMatch(/^[a-z0-9]+$/)
+  })
+
+  it('does not return the same value twice in a row', () => {
+    expect(generateRandomString(32)).not.toBe(generateRandomString(32))
+  })
+})
+
+describe('hasProperty', () => {
+  it('detects own properties only', () => {
+    expect(hasProperty({ a: 1 }, 'a')).toBe(true)
+    expect(hasProperty({ a: undefined }, 'a')).toBe(true)
+    expect(hasProperty({}, 'a')).toBe(false)
+  })
+
+  it('ignores inherited properties', () => {
+    // A device payload with no "toString" key must not read as having one.
+    expect(hasProperty({}, 'toString')).toBe(false)
+  })
+})
+
+describe('parseError', () => {
+  it('appends the first stack frame to the message', () => {
+    const err = new Error('boom')
+    err.stack = 'Error: boom\n    at thing (/a.js:1:1)'
+    expect(parseError(err)).toBe('boom at thing (/a.js:1:1)')
+  })
+
+  it('returns just the message when the error is listed in hideStack', () => {
+    // Routine failures - a device being unreachable - are logged without a
+    // stack so the log stays readable.
+    const err = new Error('offline')
+    err.stack = 'Error: offline\n    at thing (/a.js:1:1)'
+    expect(parseError(err, ['offline'])).toBe('offline')
+  })
+
+  it('returns the message when there is no stack at all', () => {
+    const err = new Error('nostack')
+    err.stack = ''
+    expect(parseError(err)).toBe('nostack')
+  })
+})

package/lib/utils/lang-en.js

@@ -44,6 +44,7 @@ export default {
   curSpeed: 'current speed',
   curSpray: 'current spray',
   curState: 'current state',
+  curSummerMode: 'current summer mode',
   curTarg: 'current target',
   curTemp: 'current temperature',
   curVol: 'current volume',

package/package.json

@@ -2,7 +2,7 @@
   "name": "@homebridge-plugins/homebridge-meross",
   "alias": "Meross",
   "type": "module",
-  "version": "10.17.1",
+  "version": "10.18.0",
   "description": "Homebridge plugin to integrate Meross devices into HomeKit.",
   "author": {
     "name": "bwp91",
@@ -50,11 +50,15 @@
   "main": "lib/index.js",
   "engines": {
     "homebridge": "^1.6.0 || ^2.0.0",
-    "node": "^22.12.0 || ^24.0.0"
+    "node": "^22.12.0 || ^24.0.0 || ^26.0.0"
   },
   "scripts": {
     "lint": "eslint . --max-warnings=0",
-    "lint:fix": "npm run lint -- --fix"
+    "lint:fix": "npm run lint -- --fix",
+    "test": "vitest run",
+    "test:watch": "vitest watch",
+    "test-coverage": "npm run test -- --coverage",
+    "changelog:sync": "node .github/scripts/sync-changelog.mjs"
   },
   "dependencies": {
     "@homebridge/plugin-ui-utils": "^2.2.5",
@@ -65,6 +69,8 @@
     "p-timeout": "^7.0.1"
   },
   "devDependencies": {
-    "@antfu/eslint-config": "^9.2.0"
+    "@antfu/eslint-config": "^9.2.0",
+    "@vitest/coverage-v8": "^4.1.10",
+    "vitest": "^4.1.10"
   }
 }