@homebridge-plugins/homebridge-govee 11.34.2-beta.5 → 11.34.2-beta.6

package/CHANGELOG.md

@@ -19,6 +19,7 @@ All notable changes to `@homebridge-plugins/homebridge-govee` will be documented
 - fix: apply the openapi disable and refresh settings instead of asking for them to be removed
 - fix: say once when a bluetooth reading arrives for an unknown device, not on every broadcast
 - fix: reject a refresh time so large it would make the plugin poll every millisecond
+- fix(H5054): don't let a slow leak warning block other sensors
 
 ## v11.34.1 (2026-08-06)
 

package/lib/platform.js

@@ -408,11 +408,7 @@ export default class {
 
       // Set up the http client sync needed for leak and thermo sensor devices
       if (this.httpClient && httpSyncNeeded) {
-        this.goveeHTTPSync()
-        this.refreshHTTPInterval = setInterval(
-          () => this.runPeriodicSync('HTTP', () => this.goveeHTTPSync()),
-          this.config.httpRefreshTime * 1000,
-        )
+        this.setupHTTPSync()
       }
 
       if (this.openApiClient && (openApiDevicesWereInitialised || httpDevicesWereInitialised)) {
@@ -787,6 +783,14 @@ export default class {
     }
   }
 
+  setupHTTPSync() {
+    this.runPeriodicSync('HTTP', () => this.goveeHTTPSync())
+    this.refreshHTTPInterval = setInterval(
+      () => this.runPeriodicSync('HTTP', () => this.goveeHTTPSync()),
+      this.config.httpRefreshTime * 1000,
+    )
+  }
+
   async goveeAWSSync(allDevices = false) {
     const pollList = allDevices ? awsDevices : awsDevicesToPoll
     if (pollList.length === 0) {
@@ -864,123 +868,129 @@ export default class {
       // Obtain a refreshed device list
       const devices = await this.httpClient.getDevices(true)
 
-      // Filter those which are leak sensors
-      for (const device1 of devices
-        .filter(device => [...platformConsts.models.sensorLeak, ...platformConsts.models.sensorThermo, ...platformConsts.models.sensorMonitor].includes(device.sku))) {
-        try {
-          // Reformat the device id
-          if (!device1.device.includes(':')) {
-            // Eg converts abcd1234abcd1234 to AB:CD:12:34:AB:CD:12:34
-            // For sensors with an add-on sensor like H5178
-            // Eg converts abcd1234abcd1234_1 to AB:CD:12:34:AB:CD:12:34_1
-            device1.device = device1.device.replace(DEVICE_ID_FORMAT_REGEX, '$&:').toUpperCase()
-          }
+      // A stalled leak-warning request must not hold every water sensor behind
+      // it. Queue only those cloud requests so thermometer and monitor updates
+      // still arrive immediately, while a poll stays gentle on Govee's API.
+      const leakWarningQueue = new PQueue({ concurrency: 2 })
+      await Promise.all(devices
+        .filter(device => [...platformConsts.models.sensorLeak, ...platformConsts.models.sensorThermo, ...platformConsts.models.sensorMonitor].includes(device.sku))
+        .map(async (device1) => {
+          try {
+            // Reformat the device id
+            if (!device1.device.includes(':')) {
+              // Eg converts abcd1234abcd1234 to AB:CD:12:34:AB:CD:12:34
+              // For sensors with an add-on sensor like H5178
+              // Eg converts abcd1234abcd1234_1 to AB:CD:12:34:AB:CD:12:34_1
+              device1.device = device1.device.replace(DEVICE_ID_FORMAT_REGEX, '$&:').toUpperCase()
+            }
 
-          // Generate the UIID from which we can match our Homebridge accessory
-          const uiid = this.api.hap.uuid.generate(device1.device)
+            // Generate the UIID from which we can match our Homebridge accessory
+            const uiid = this.api.hap.uuid.generate(device1.device)
 
-          // Don't continue if the accessory doesn't exist
-          if (!devicesInHB.has(uiid)) {
-            continue
-          }
+            // Don't continue if the accessory doesn't exist
+            if (!devicesInHB.has(uiid)) {
+              return
+            }
 
-          // Retrieve the Homebridge accessory
-          const accessory = devicesInHB.get(uiid)
+            // Retrieve the Homebridge accessory
+            const accessory = devicesInHB.get(uiid)
 
-          // Make sure the data we need for the device exists
-          if (!device1.deviceExt || !device1.deviceExt.deviceSettings || !device1.deviceExt.lastDeviceData) {
-            continue
-          }
+            // Make sure the data we need for the device exists
+            if (!device1.deviceExt || !device1.deviceExt.deviceSettings || !device1.deviceExt.lastDeviceData) {
+              return
+            }
 
-          // Parse the data received
-          let parsedSettings
-          let parsedData
-          try {
-            parsedSettings = JSON.parse(device1.deviceExt.deviceSettings)
-            parsedData = JSON.parse(device1.deviceExt.lastDeviceData)
-          } catch {
-            continue
-          }
+            // Parse the data received
+            let parsedSettings
+            let parsedData
+            try {
+              parsedSettings = JSON.parse(device1.deviceExt.deviceSettings)
+              parsedData = JSON.parse(device1.deviceExt.lastDeviceData)
+            } catch {
+              return
+            }
 
-          const toReturn = { source: 'HTTP' }
-          if (platformConsts.models.sensorLeak.includes(device1.sku)) {
-            accessory.logDebug(`raw data: ${JSON.stringify({ ...parsedData, ...parsedSettings })}`)
+            const toReturn = { source: 'HTTP' }
+            if (platformConsts.models.sensorLeak.includes(device1.sku)) {
+              accessory.logDebug(`raw data: ${JSON.stringify({ ...parsedData, ...parsedSettings })}`)
 
-            // Keep the gateway details up to date for matching real-time leak
-            // events relayed by the gateway over AWS (#1276)
-            if (hasProperty(parsedSettings, 'sno') && parsedSettings.gatewayInfo?.device) {
-              accessory.context.gatewaySno = parsedSettings.sno
-              accessory.context.gatewayDevice = parsedSettings.gatewayInfo.device
-            }
+              // Keep the gateway details up to date for matching real-time leak
+              // events relayed by the gateway over AWS (#1276)
+              if (hasProperty(parsedSettings, 'sno') && parsedSettings.gatewayInfo?.device) {
+                accessory.context.gatewaySno = parsedSettings.sno
+                accessory.context.gatewayDevice = parsedSettings.gatewayInfo.device
+              }
 
-            // Leak Sensors - check to see of any warnings if the lastTime is above 0
-            let hasUnreadLeak = false
-            if (parsedData.lastTime > 0) {
-              // Obtain the leak warning messages for this device
-              const msgs = await this.httpClient.getLeakDeviceWarning(device1.device, device1.sku)
+              // Leak Sensors - check to see of any warnings if the lastTime is above 0
+              let hasUnreadLeak = false
+              if (parsedData.lastTime > 0) {
+                // Obtain the leak warning messages for this device
+                const msgs = await leakWarningQueue.add(
+                  () => this.httpClient.getLeakDeviceWarning(device1.device, device1.sku),
+                )
 
-              accessory.logDebug(`raw messages: ${JSON.stringify(msgs)}`)
+                accessory.logDebug(`raw messages: ${JSON.stringify(msgs)}`)
 
-              // Check to see if unread messages exist
-              const unreadCount = msgs.filter(msg => !msg.read && msg.message.toLowerCase().replace(WHITESPACE_REGEX, '').startsWith('leakagealert'))
-              if (unreadCount.length > 0) {
-                hasUnreadLeak = true
+                // Check to see if unread messages exist
+                const unreadCount = msgs.filter(msg => !msg.read && msg.message.toLowerCase().replace(WHITESPACE_REGEX, '').startsWith('leakagealert'))
+                if (unreadCount.length > 0) {
+                  hasUnreadLeak = true
+                }
               }
-            }
 
-            // Generate the params to return
-            toReturn.battery = parsedSettings.battery
-            toReturn.leakDetected = hasUnreadLeak
-            toReturn.online = parsedData.gwonline && parsedData.online
-          } else if (platformConsts.models.sensorThermo.includes(device1.sku)) {
-            // Some accounts report `tem` in hundredths of a degree Fahrenheit
-            // rather than Celsius, which lands in HomeKit as a reading roughly
-            // 90 degrees too high (#1269). The unit is not stated anywhere in
-            // the response, so log the raw payload to work out what
-            // distinguishes those accounts before converting anything.
-            accessory.logDebug(`[HTTP] raw sensor data: ${JSON.stringify(parsedData)}`)
-
-            if (hasProperty(parsedSettings, 'battery')) {
-              toReturn.battery = parsedSettings.battery
-            }
-            if (hasProperty(parsedData, 'tem')) {
-              toReturn.temperature = parsedData.tem
-            }
-            if (hasProperty(parsedData, 'hum')) {
-              toReturn.humidity = parsedData.hum
-            }
-            if (hasProperty(parsedData, 'online')) {
-              toReturn.online = parsedData.online
-            }
-          } else if (platformConsts.models.sensorMonitor.includes(device1.sku)) {
-            // The H5106 normally reports over AWS, but some accounts never
-            // receive those messages, leaving the readings at zero (#1322).
-            // The HTTP device list carries the same readings, so use it as a
-            // second source. Every field is guarded and the raw payload is
-            // logged, since the format for this model is not confirmed on
-            // every account
-            accessory.logDebug(`[HTTP] raw sensor data: ${JSON.stringify(parsedData)}`)
-
-            if (hasProperty(parsedSettings, 'battery')) {
+              // Generate the params to return
               toReturn.battery = parsedSettings.battery
+              toReturn.leakDetected = hasUnreadLeak
+              toReturn.online = parsedData.gwonline && parsedData.online
+            } else if (platformConsts.models.sensorThermo.includes(device1.sku)) {
+              // Some accounts report `tem` in hundredths of a degree Fahrenheit
+              // rather than Celsius, which lands in HomeKit as a reading roughly
+              // 90 degrees too high (#1269). The unit is not stated anywhere in
+              // the response, so log the raw payload to work out what
+              // distinguishes those accounts before converting anything.
+              accessory.logDebug(`[HTTP] raw sensor data: ${JSON.stringify(parsedData)}`)
+
+              if (hasProperty(parsedSettings, 'battery')) {
+                toReturn.battery = parsedSettings.battery
+              }
+              if (hasProperty(parsedData, 'tem')) {
+                toReturn.temperature = parsedData.tem
+              }
+              if (hasProperty(parsedData, 'hum')) {
+                toReturn.humidity = parsedData.hum
+              }
+              if (hasProperty(parsedData, 'online')) {
+                toReturn.online = parsedData.online
+              }
+            } else if (platformConsts.models.sensorMonitor.includes(device1.sku)) {
+              // The H5106 normally reports over AWS, but some accounts never
+              // receive those messages, leaving the readings at zero (#1322).
+              // The HTTP device list carries the same readings, so use it as a
+              // second source. Every field is guarded and the raw payload is
+              // logged, since the format for this model is not confirmed on
+              // every account
+              accessory.logDebug(`[HTTP] raw sensor data: ${JSON.stringify(parsedData)}`)
+
+              if (hasProperty(parsedSettings, 'battery')) {
+                toReturn.battery = parsedSettings.battery
+              }
+              if (hasProperty(parsedData, 'tem')) {
+                toReturn.temperature = parsedData.tem
+              }
+              if (hasProperty(parsedData, 'hum')) {
+                toReturn.humidity = parsedData.hum
+              }
+              if (hasProperty(parsedData, 'online')) {
+                toReturn.online = parsedData.online
+              }
             }
-            if (hasProperty(parsedData, 'tem')) {
-              toReturn.temperature = parsedData.tem
-            }
-            if (hasProperty(parsedData, 'hum')) {
-              toReturn.humidity = parsedData.hum
-            }
-            if (hasProperty(parsedData, 'online')) {
-              toReturn.online = parsedData.online
-            }
-          }
 
-          // Send the information to the update receiver function
-          this.receiveDeviceUpdate(accessory, toReturn)
-        } catch (err) {
-          this.log.warn('[%s] %s %s.', device1.deviceName, platformLang.devNotRef, parseError(err))
-        }
-      }
+            // Send the information to the update receiver function
+            this.receiveDeviceUpdate(accessory, toReturn)
+          } catch (err) {
+            this.log.warn('[%s] %s %s.', device1.deviceName, platformLang.devNotRef, parseError(err))
+          }
+        }))
     } catch (err) {
       this.log.warn('[HTTP] %s %s.', platformLang.syncFail, parseError(err))
     }

package/package.json

@@ -2,7 +2,7 @@
   "name": "@homebridge-plugins/homebridge-govee",
   "alias": "Govee",
   "type": "module",
-  "version": "11.34.2-beta.5",
+  "version": "11.34.2-beta.6",
   "description": "Homebridge plugin to integrate Govee devices into HomeKit.",
   "author": {
     "name": "bwp91",