@homebridge-plugins/homebridge-govee 11.34.2-beta.11 → 11.34.2-beta.12

package/lib/utils/device-context.js

@@ -74,17 +74,27 @@ export function applyDeviceContext(platform, accessory, device, deviceConf, join
   // label in the configuration.
   //
   // ⚠️ This used to run for LAN-only devices only, so every other device kept
-  // whatever name it was discovered under, forever. Renaming in the Govee app
-  // did nothing, and a name HAP complains about (brackets, say) could not be
-  // cleared without deleting the cached accessory and losing its room and
-  // automations (#1344).
+  // whatever name it was discovered under, forever. A name HAP complains about
+  // (brackets, say) could then not be cleared without deleting the cached
+  // accessory and losing its room and automations (#1344).
   //
-  // The AccessoryInformation characteristics are set alongside displayName
-  // because addAccessory sets all three, and HAP's own warning reads the
-  // characteristic rather than the display name.
+  // ⚠️ This does NOT rename anything in the Home app. HomeKit fixes the name a
+  // user sees when the accessory is first added, and a rename made there never
+  // comes back to us either. What this fixes is the name Homebridge itself
+  // shows and, through the Name characteristic, the HAP warning.
+  //
+  // `updateDisplayName` is the supported way to do it - assigning to
+  // `displayName` sets only Homebridge's copy and leaves the HAP accessory
+  // behind. It arrived in Homebridge v1.10.0, and this plugin still supports
+  // ^1.6.0, hence the check.
   if (device.deviceName && accessory.displayName !== device.deviceName) {
     platform.log('[%s] %s [%s].', accessory.displayName, platformLang.devRenamed, device.deviceName)
-    accessory.displayName = device.deviceName
+
+    if (typeof accessory.updateDisplayName === 'function') {
+      accessory.updateDisplayName(device.deviceName)
+    } else {
+      accessory.displayName = device.deviceName
+    }
 
     const hapChar = platform.api?.hap?.Characteristic
     const infoService = accessory.getService?.(platform.api?.hap?.Service?.AccessoryInformation)

package/package.json

@@ -2,7 +2,7 @@
   "name": "@homebridge-plugins/homebridge-govee",
   "alias": "Govee",
   "type": "module",
-  "version": "11.34.2-beta.11",
+  "version": "11.34.2-beta.12",
   "description": "Homebridge plugin to integrate Govee devices into HomeKit.",
   "author": {
     "name": "bwp91",