@homebridge-plugins/homebridge-govee 11.33.1 → 11.33.2-beta.0

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to `@homebridge-plugins/homebridge-govee` will be documented in this file.
 
+## v11.33.2 (Pending Release)
+
+### Changed
+
+- fix: implement the H7105 oscillation toggle, which threw a not-implemented error (#1339)
+
 ## v11.33.1 (2026-08-04)
 
 ### Changed

package/lib/device/fan-H7105.js

@@ -187,33 +187,42 @@ export default class extends GoveeDevice {
 
   async internalSwingUpdate(value) {
     try {
-      // Don't continue if the new value is the same as before
-      if (this.cacheSwing === value) {
+      const newValue = value ? 'on' : 'off'
+      // Don't continue if the new value is the same as before. The comparison
+      // has to be against the mapped string - cacheSwing holds 'on'/'off' and
+      // value arrives as a boolean, so comparing them directly never matched
+      if (this.cacheSwing === newValue) {
         return
       }
 
-      throw new Error('Swing mode update not implemented yet')
-
-      // const newValue = value ? 'on' : 'off'
-      // The existing cacheSwingCode might be something like aa1d0101960384000000000000000000000000a6
-      // We need to change the third hex value to 00 for off or 01 for on
-      // const hexValues = [
-      //   0x3A,
-      //   0x1D,
-      //   value ? 0x01 : 0x00,
-      //   ...this.cacheSwingCode.slice(6, 14).match(/.{1,2}/g).map(byte => Number.parseInt(byte, 16)),
-      // ]
-      //
-      // await this.platform.sendDeviceUpdate(this.accessory, {
-      //   cmd: 'multiSync',
-      //   value: generateCodeFromHexValues(hexValues),
-      // })
+      // Same oscillation shape as the H7107, which is the only other fan that
+      // reports a swing RANGE rather than a plain on/off. Turning ON carries
+      // over the range bytes from the last report seen; turning OFF must not,
+      // because a parameterised off command was answered with a zero-tailed
+      // frame while the fan kept oscillating (#1334, #1339)
+      const tailBytes = value && this.cacheSwingCode
+        ? this.cacheSwingCode.slice(6, 14).match(/.{1,2}/g).map(byte => Number.parseInt(byte, 16))
+        : []
+      await this.platform.sendDeviceUpdate(this.accessory, {
+        cmd: 'ptReal',
+        value: generateCodeFromHexValues([0x33, 0x1D, value ? 0x01 : 0x00, ...tailBytes]),
+        openApi: this.accessory.context.openApiCapabilities?.oscillationToggle
+          ? { instance: 'oscillationToggle', capabilityType: 'devices.capabilities.toggle', value: value ? 1 : 0 }
+          : undefined,
+      })
+
+      // The fan's own oscillation state travels as multiSync traffic, so send
+      // that shape too. Whichever the model ignores is harmless
+      await this.platform.sendDeviceUpdate(this.accessory, {
+        cmd: 'multiSync',
+        value: generateCodeFromHexValues([0x3A, 0x1D, value ? 0x01 : 0x00, ...tailBytes]),
+      })
 
       // Cache the new state and log if appropriate
-      // if (this.cacheSwing !== newValue) {
-      //   this.cacheSwing = newValue
-      //   this.accessory.log(`${platformLang.curSwing} [${newValue}]`)
-      // }
+      if (this.cacheSwing !== newValue) {
+        this.cacheSwing = newValue
+        this.accessory.log(`${platformLang.curSwing} [${newValue}]`)
+      }
     } catch (err) {
       this.failUpdate(err, () => {
         this.service.updateCharacteristic(this.hapChar.SwingMode, this.cacheSwing === 'on' ? 1 : 0)

package/package.json

@@ -2,7 +2,7 @@
   "name": "@homebridge-plugins/homebridge-govee",
   "alias": "Govee",
   "type": "module",
-  "version": "11.33.1",
+  "version": "11.33.2-beta.0",
   "description": "Homebridge plugin to integrate Govee devices into HomeKit.",
   "author": {
     "name": "bwp91",