@homebound/form-state 2.22.3 → 2.22.4

package/dist/fields/listField.js

@@ -31,7 +31,9 @@ function newListFieldState(parentCopy, parentInstance, parentState, key, rules,
         if (!childState) {
             for (const [, otherState] of rowMap.entries()) {
                 if (otherState.isSameEntity(child)) {
-                    otherState.set(child, opts);
+                    // If we're being called from `list.rows`, we should be careful to not trigger mutations
+                    if (!(opts === null || opts === void 0 ? void 0 : opts.skipSet))
+                        otherState.set(child, opts);
                     rowMap.set(child, otherState);
                     return otherState;
                 }
@@ -100,7 +102,7 @@ function newListFieldState(parentCopy, parentInstance, parentState, key, rules,
                 (0, utils_1.fail)();
             // Avoid using `this.value` to avoid registering `_childTick` as a dependency
             const value = parentInstance[key];
-            return (value || []).map((child) => getOrCreateChildState(child));
+            return (value || []).map((child) => getOrCreateChildState(child, { skipSet: true }));
         },
         // TODO Should this be true when all rows are touched?
         get touched() {

package/dist/formState.test.js

@@ -442,6 +442,20 @@ describe("formState", () => {
         a1.books.remove(0);
         expect(a1.dirty).toBeFalsy();
     });
+    it("handles list fields with duplicate ids", () => {
+        // Given an author that incorrectly has duplicate books
+        const a1 = createAuthorInputState({
+            books: [
+                { id: "b:1", title: "b1" },
+                { id: "b:1", title: "b2" },
+            ],
+        });
+        // Then it didn't blow up
+        expect(a1.books.dirty).toBeFalsy();
+        // And the 1st book won
+        expect(a1.books.rows[0].title.value).toBe("b1");
+        expect(a1.books.rows[1].title.value).toBe("b1");
+    });
     it("calls maybeAutoSave when adding or removing to a list", () => {
         const maybeAutoSave = jest.fn();
         const a1 = createAuthorInputState({ books: [] }, maybeAutoSave);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@homebound/form-state",
-  "version": "2.22.3",
+  "version": "2.22.4",
   "author": "Homebound",
   "license": "MIT",
   "main": "dist/index.js",