@homebound/beam 2.396.0 → 2.397.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -47,6 +47,16 @@ For them, a MUI application in Company A shouldn't have to look & behave exactly
47
47
 
48
48
  But for Beam at Homebound, we specifically _want_ a component that behaves in our App A to look & behave the same as it does in our App B.
49
49
 
50
+ ## Adding Props Checklist
51
+
52
+ When designers have new Figmas, or give UX feedback, that would require adding new stylistic props to Beam components (i.e. props to change color, size, layout, etc), we should:
53
+
54
+ - Let them know their change doesn't match the existing Beam style, and confirm they really meant for this to be a non-standard change (discouraged).
55
+
56
+ - Ask them if they want this change to be rolled out app-wide, which would be fine & means we can avoid adding the per-page props (preferred).
57
+
58
+ - If they insist this is both a necessary change, but not app-wide, can we describe this ask as a "variant" or "style" or other "high-level knob", that is not making pages pick individual, low-level pixels and color values (fine now & then).
59
+
50
60
  ## Beam and Open Source
51
61
 
52
62
  As we open source Beam, this vision of "as few props as possible", "components must look _the same_ in every app" doesn't seem like something that other companies/projects would adopt (i.e. surely they want different colors, slightly different behavior to suit their user base, etc.).
package/dist/index.cjs CHANGED
@@ -5751,7 +5751,7 @@ function IconButton(props) {
5751
5751
  }
5752
5752
  );
5753
5753
  return maybeTooltip({
5754
- title: resolveTooltip(disabled, tooltip),
5754
+ title: resolveTooltip(disabled ?? label, tooltip),
5755
5755
  placement: "top",
5756
5756
  children: getButtonOrLink(buttonContent, onPress, buttonAttrs, openInNew, download)
5757
5757
  });