@homebound/beam 2.308.1 → 2.309.1

package/dist/components/Table/GridTable.d.ts

@@ -77,8 +77,6 @@ export interface GridTableProps<R extends Kinded, X> {
     filter?: string;
     /** Caps the client-side filter to a max number of rows. */
     filterMaxRows?: number;
-    /** Accepts the number of filtered rows (based on `filter`), for the caller to observe and display if they want. */
-    setRowCount?: (rowCount: number) => void;
     /** A combination of CSS settings to set the static look & feel (vs. rowStyles which is per-row styling). */
     style?: GridStyle | GridStyleDef;
     /**

package/dist/components/Table/GridTable.js

@@ -85,7 +85,7 @@ exports.setGridTableDefaults = setGridTableDefaults;
  */
 function GridTable(props) {
     var _a, _b, _c;
-    const { id = "gridTable", as = "div", columns: _columns, rows, style: maybeStyle = defaults.style, rowStyles, stickyHeader = defaults.stickyHeader, stickyOffset = 0, xss, filter, filterMaxRows, fallbackMessage = "No rows found.", infoMessage, setRowCount, persistCollapse, resizeTarget, activeRowId, activeCellId, visibleColumnsStorageKey, infiniteScroll, } = props;
+    const { id = "gridTable", as = "div", columns: _columns, rows, style: maybeStyle = defaults.style, rowStyles, stickyHeader = defaults.stickyHeader, stickyOffset = 0, xss, filter, filterMaxRows, fallbackMessage = "No rows found.", infoMessage, persistCollapse, resizeTarget, activeRowId, activeCellId, visibleColumnsStorageKey, infiniteScroll, } = props;
     const columnsWithIds = (0, react_1.useMemo)(() => (0, columns_1.assignDefaultColumnIds)(_columns), [_columns]);
     // We only use this in as=virtual mode, but keep this here for rowLookup to use
     const virtuosoRef = (0, react_1.useRef)(null);
@@ -195,10 +195,6 @@ function GridTable(props) {
         // Refs are cheap to assign to, so we don't bother doing this in a useEffect
         rowLookup.current = (0, GridRowLookup_1.createRowLookup)(columns, visibleDataRows, virtuosoRef);
     }
-    // TODO: Replace setRowCount with clients observing TableState via the API
-    (0, react_1.useEffect)(() => {
-        setRowCount && (visibleDataRows === null || visibleDataRows === void 0 ? void 0 : visibleDataRows.length) !== undefined && setRowCount(visibleDataRows.length);
-    }, [visibleDataRows === null || visibleDataRows === void 0 ? void 0 : visibleDataRows.length, setRowCount]);
     const noData = visibleDataRows.length === 0;
     const firstRowMessage = (noData && fallbackMessage) || (tooManyClientSideRows && "Hiding some rows, use filter...") || infoMessage;
     const borderless = (_a = style === null || style === void 0 ? void 0 : style.presentationSettings) === null || _a === void 0 ? void 0 : _a.borderless;

package/dist/hooks/useComputed.js

@@ -1,12 +1,9 @@
 "use strict";
-var __importDefault = (this && this.__importDefault) || function (mod) {
-    return (mod && mod.__esModule) ? mod : { "default": mod };
-};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.useComputed = void 0;
-const fast_deep_equal_1 = __importDefault(require("fast-deep-equal"));
 const mobx_1 = require("mobx");
 const react_1 = require("react");
+const shallowEqual_1 = require("../utils/shallowEqual");
 /** Evaluates a computed function `fn` to a regular value and triggers a re-render whenever it changes. */
 function useComputed(fn, deps) {
     // We always return the useRef value, and use this just to trigger re-renders
@@ -37,7 +34,11 @@ function useComputed(fn, deps) {
             // Only trigger a re-render if this is not the 1st autorun. Note
             // that if deps has changed, we're inherently in a re-render so also
             // don't need to trigger an additional re-render.
-            if (oldHasRun && !(0, fast_deep_equal_1.default)(newValue, oldValue)) {
+            //
+            // Also, we avoid a deep equality, b/c if a `useComputed` is returning something
+            // complicated/cyclic, like ReactElement, deep equality will crawl into the guts
+            // of React/ReactFiber and cycle/infinite loop.
+            if (oldHasRun && !(0, shallowEqual_1.shallowEqual)(newValue, oldValue)) {
                 setTick((tick) => tick + 1);
             }
         });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@homebound/beam",
-  "version": "2.308.1",
+  "version": "2.309.1",
   "author": "Homebound",
   "license": "MIT",
   "main": "dist/index.js",
@@ -81,16 +81,16 @@
     "@homebound/tsconfig": "^1.0.3",
     "@semantic-release/exec": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
-    "@storybook/addon-docs": "^7.0.26",
-    "@storybook/addon-essentials": "^7.0.26",
-    "@storybook/addon-interactions": "^7.0.26",
-    "@storybook/addon-links": "^7.0.26",
-    "@storybook/addon-mdx-gfm": "^7.0.26",
-    "@storybook/addons": "^7.0.26",
-    "@storybook/manager-api": "^7.0.26",
-    "@storybook/mdx2-csf": "1.1.0",
-    "@storybook/react": "^7.0.26",
-    "@storybook/react-vite": "^7.0.26",
+    "@storybook/addon-docs": "^7.3.0",
+    "@storybook/addon-essentials": "^7.3.0",
+    "@storybook/addon-interactions": "^7.3.0",
+    "@storybook/addon-links": "^7.3.0",
+    "@storybook/addon-mdx-gfm": "^7.3.0",
+    "@storybook/addons": "^7.3.0",
+    "@storybook/manager-api": "^7.3.0",
+    "@storybook/mdx2-csf": "^1.1.0",
+    "@storybook/react": "^7.3.0",
+    "@storybook/react-vite": "^7.3.0",
     "@storybook/testing-library": "^0.2.0",
     "@testing-library/jest-dom": "^5.16.5",
     "@tsconfig/recommended": "^1.0.2",
@@ -107,7 +107,7 @@
     "chromatic": "^6.17.0",
     "conventional-changelog-conventionalcommits": "^5.0.0",
     "eslint": "^8.12.0",
-    "eslint-plugin-storybook": "^0.6.12",
+    "eslint-plugin-storybook": "^0.6.13",
     "husky": "^5.1.1",
     "identity-obj-proxy": "^3.0.0",
     "jest": "^29.4.3",
@@ -121,7 +121,7 @@
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "semantic-release": "^20.1.0",
-    "storybook": "^7.0.26",
+    "storybook": "^7.3.0",
     "storybook-addon-designs": "beta",
     "ts-jest": "^29.0.5",
     "ts-node": "^10.9.1",