@holmes-lab/holmes-kit 0.35.8 → 0.35.9

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file.
5
5
  The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
6
6
  and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
7
7
  <!-- @implements A-SPEC-209 -->
8
+ ## [0.35.9] - 2026-10-06
9
+
10
+ ### Security
11
+
12
+ - **The single-key approval screen shows in full what it asks about** (A-SPEC-497.4). In `holmes-kit approve --watch`
13
+ on a terminal, an item whose subject did not fit its row was shown as `… (258자 잘림)` and one keypress approved
14
+ it — most of the command was never on the screen. Such an item's full text is now printed before the keys are
15
+ offered, and `v` shows the details of any item without deciding anything (`[a]approve [v]details [d]deny
16
+ [q]question [s]skip`). The text comes from the same escaped, capped renderer the line-based screen's `[v]` uses.
17
+ `holmes-kit approve --status` shows recent outcomes if you want to review what was approved this way.
18
+
8
19
  ## [0.35.8] - 2026-10-06
9
20
 
10
21
  ### Added
package/dist/.build-id CHANGED
@@ -1 +1 @@
1
- 60474c12-muvgbymb
1
+ f3d900b3-muvjdy3u
@@ -14,7 +14,7 @@ export interface KeyStream {
14
14
  * rejects with AbortError: leaving is not deciding. No deadline anywhere: the MAIN LANE's whole
15
15
  * point is that a human terminal can wait forever (H-SPEC-497).
16
16
  */
17
- export declare function decideByKey(stream: KeyStream, _item: Pick<PendingRequest, 'id'>): Promise<'granted' | 'denied' | 'skipped' | {
17
+ export declare function decideByKey(stream: KeyStream, _item: Pick<PendingRequest, 'id'>, onView?: () => void): Promise<'granted' | 'denied' | 'skipped' | {
18
18
  question: string;
19
19
  }>;
20
20
  /**
@@ -5,7 +5,7 @@ exports.decideByKey = decideByKey;
5
5
  exports.presentByKey = presentByKey;
6
6
  exports.defaultWaitIdle = defaultWaitIdle;
7
7
  exports.runWatch = runWatch;
8
- // @implements A-SPEC-262.2
8
+ // @implements A-SPEC-262.2, A-SPEC-497.4
9
9
  //
10
10
  // The RESIDENCE of the decision surface. S-262.1 made the surface's CONTENT (transcript-zero
11
11
  // references, context, one-key/batch); this is a thin polling loop over that content, so a request
@@ -16,6 +16,8 @@ exports.runWatch = runWatch;
16
16
  // existing runInteractive, and waits between polls when the queue is empty.
17
17
  const approval_queue_1 = require("../governance/approval-queue");
18
18
  const approve_1 = require("./approve");
19
+ const approve_context_1 = require("./approve-context");
20
+ const screen_safe_1 = require("./screen-safe");
19
21
  // @implements A-SPEC-497.2
20
22
  /**
21
23
  * ONE raw keypress decides an item — a/d/q/s; q collects one follow-up line (the question).
@@ -23,7 +25,7 @@ const approve_1 = require("./approve");
23
25
  * rejects with AbortError: leaving is not deciding. No deadline anywhere: the MAIN LANE's whole
24
26
  * point is that a human terminal can wait forever (H-SPEC-497).
25
27
  */
26
- function decideByKey(stream, _item) {
28
+ function decideByKey(stream, _item, onView) {
27
29
  return new Promise((resolve, reject) => {
28
30
  let questionMode = false;
29
31
  let line = '';
@@ -69,6 +71,11 @@ function decideByKey(stream, _item) {
69
71
  questionMode = true;
70
72
  continue;
71
73
  }
74
+ // @implements A-SPEC-497.4 — seeing is not deciding: the details are shown and the same item keeps waiting.
75
+ if (ch === 'v' && onView) {
76
+ onView();
77
+ continue;
78
+ }
72
79
  // any other key: not a decision — keep listening
73
80
  }
74
81
  };
@@ -85,8 +92,14 @@ function decideByKey(stream, _item) {
85
92
  async function presentByKey(root, io, actor, stream, state) {
86
93
  for (const p of state.pending) {
87
94
  io.print(`\n─ ${(0, approve_1.subjectCells)('─ ', p)}`);
88
- io.print('[a]approve [d]deny [q]question [s]skip > ');
89
- const d = await decideByKey(stream, p);
95
+ // @implements A-SPEC-497.4 — owner report 2026-10-05: the row ended in a notice that 258 characters were cut, and one key approved it. A
96
+ // clipped subject is a subject the operator did not see, so it is shown in full before any key is offered; `v`
97
+ // shows the details of any item. The renderer is the line-based screen's own `[v]` — nothing is rendered here.
98
+ const details = () => io.print((0, approve_context_1.renderDecisionContext)(root, p));
99
+ if ((0, screen_safe_1.isClipped)(p.target, (0, approve_1.subjectRoom)('─ ', p)))
100
+ details();
101
+ io.print('[a]approve [v]details [d]deny [q]question [s]skip > ');
102
+ const d = await decideByKey(stream, p, details);
90
103
  if (d === 'granted') {
91
104
  const r = (0, approve_1.grantRequest)(root, p.id, { actor });
92
105
  io.print(r.ok ? `✓ approved — ${(0, approve_1.subjectCells)('✓ approved — ', p)}` : `✗ ${r.reason}`);
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "//": "@implements A-SPEC-209",
3
3
  "name": "@holmes-lab/holmes-kit",
4
- "version": "0.35.8",
4
+ "version": "0.35.9",
5
5
  "description": "Holmes-Kit — deterministic Agentic Software Engineering (ASE) harness with causal traceability (spec chain + D-CPG + RTM + phase guardrail)",
6
6
  "main": "dist/holmes/mcp/server.js",
7
7
  "types": "dist/holmes/mcp/server.d.ts",