@holmes-lab/holmes-kit 0.3.1 → 0.3.2

package/CHANGELOG.md

@@ -4,6 +4,24 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+<!-- @implements A-SPEC-209 -->
+## [0.3.2] - 2026-08-31
+
+Windows doctor unbroken: the wiring-handshake checks can now actually run the wiring they judge.
+
+### Fixed
+
+- **doctor wiring handshake on Windows** (A-SPEC-499.1): the four wiring checks (claude / codex /
+  antigravity handshake + mcp wiring spawn) spawned `npx` directly, which on win32 is `npx.cmd`
+  and cannot be executed by a plain spawn — every check died `spawn npx ENOENT` on a correctly
+  wired target (field-measured on 0.3.1). A pure platform adapter now reroutes execution through
+  `cmd.exe /d /s /c` (whitespace-bearing tokens quoted — space-in-username installs included);
+  posix spawn arguments are value-identical to before.
+- **ENOENT prescription**: a command the OS cannot find no longer gets "Re-run `holmes-kit init`"
+  — re-initing into the identical failure forever was the measured loop. It now says the command
+  could not be resolved (PATH/platform) and to try it in a shell; genuine stale-wiring failures
+  keep the re-init wording byte-for-byte.
+
 <!-- @implements A-SPEC-209 -->
 ## [0.3.1] - 2026-08-31
 

package/dist/.build-id

@@ -1 +1 @@
-9dd2f60-mthaxwnr
+5010ff8-mthc0xla

package/dist/holmes/cli/doctor.d.ts

@@ -95,6 +95,13 @@ export interface ProbeRunner {
     };
 }
 export declare function runDoctor(packageRoot: string, target?: string, opts?: DoctorOptions, extraChecks?: Check[]): Promise<Check[]>;
+/**
+ * Drive a real MCP stdio handshake: initialize -> initialized -> tools/list, with a timeout.
+ * Async by necessity — the protocol is a ROUND TRIP, so a spawnSync that writes everything at once
+ * and closes stdin makes the server exit before answering (a false FAIL this check produced on its
+ * very first run against a healthy server).
+ */
+export declare function wiringSpawnCheck(command: string, args: string[], timeoutMs?: number, platform?: NodeJS.Platform): Promise<Check>;
 export declare function formatChecks(checks: Check[]): string;
 /**
  * Prove that EVERY wired harness can actually start a server, not merely that its file parses.

package/dist/holmes/cli/doctor.js

@@ -39,6 +39,7 @@ exports.npmCliEntry = npmCliEntry;
 exports.prefixVerdict = prefixVerdict;
 exports.probeEnv = probeEnv;
 exports.runDoctor = runDoctor;
+exports.wiringSpawnCheck = wiringSpawnCheck;
 exports.formatChecks = formatChecks;
 exports.wiringHandshakeChecks = wiringHandshakeChecks;
 exports.semanticTierVerdict = semanticTierVerdict;
@@ -52,6 +53,7 @@ const path = __importStar(require("node:path"));
 const role_policy_1 = require("../governance/role-policy");
 const blind_spots_1 = require("../guardrail/blind-spots");
 const node_child_process_1 = require("node:child_process");
+const spawn_spec_1 = require("./spawn-spec");
 const os = __importStar(require("node:os"));
 const settings_merge_1 = require("./settings-merge");
 const playbook_skills_1 = require("./playbook-skills");
@@ -1026,8 +1028,20 @@ function cleanupOnSignal(dir) {
 // Spawn the TARGET's wiring verbatim and require initialize inside the deadline. Unlike
 // `mcpHandshakeCheck` below (which proves this INSTALL can serve), this proves the WIRING the
 // harness will actually run reaches a server — the gap the dead npx form lived in.
-function wiringSpawnCheck(command, args, timeoutMs = 30000) {
+// @implements A-SPEC-499.1 — exported for the prescription tests; `platform` is injectable so the
+// win32 branch is testable off-Windows.
+function wiringSpawnCheck(command, args, timeoutMs = 30000, platform = process.platform) {
+    // The DISPLAYED command stays the original wiring string even when the win32 adapter rewraps the
+    // execution — the user compares this against their wiring file, not against cmd.exe plumbing.
     const quoted = `${command} ${args.join(' ')}`;
+    // @implements A-SPEC-499.1 — Windows field measurement: four wiring checks on a correctly rewired
+    // 0.3.1 target all died `spawn npx ENOENT`, because `npx` is `npx.cmd` there and a plain spawn
+    // cannot execute a .cmd shim. The adapter reroutes through cmd.exe; posix is value-identical.
+    const spec = (0, spawn_spec_1.spawnSpecFor)(command, args, platform);
+    // The re-init prescription is only honest when the wiring might actually be stale. A command the
+    // OS cannot find (ENOENT) re-inits into the identical failure forever — the measured loop.
+    const enoentFix = `\`${command}\` 명령을 찾지 못했습니다(PATH 또는 플랫폼) — 배선 문자열이 옳다면 재-init은 도움이 되지 않습니다. 같은 명령을 셸에서 직접 실행해 확인하십시오.`;
+    const spawnFailFix = (e) => e?.code === 'ENOENT' ? enoentFix : 'Re-run `holmes-kit init` in the target to rewrite the wiring.';
     return new Promise((resolve) => {
         let done = false;
         let out = '';
@@ -1045,13 +1059,13 @@ function wiringSpawnCheck(command, args, timeoutMs = 30000) {
         };
         const timer = setTimeout(() => finish('FAIL', `wiring did not answer initialize within ${timeoutMs / 1000}s: \`${quoted}\``, 'Re-run `holmes-kit init` in the target to rewrite the wiring, then re-run doctor.'), timeoutMs);
         try {
-            child = (0, node_child_process_1.spawn)(command, args, { stdio: ['pipe', 'pipe', 'pipe'] });
+            child = (0, node_child_process_1.spawn)(spec.command, spec.args, { stdio: ['pipe', 'pipe', 'pipe'] });
         }
         catch (e) {
-            finish('FAIL', `wiring could not be spawned: \`${quoted}\` — ${e.message}`, 'Re-run `holmes-kit init` in the target to rewrite the wiring.');
+            finish('FAIL', `wiring could not be spawned: \`${quoted}\` — ${e.message}`, spawnFailFix(e));
             return;
         }
-        child.on('error', (e) => finish('FAIL', `wiring could not be spawned: \`${quoted}\` — ${e.message}`, 'Re-run `holmes-kit init` in the target to rewrite the wiring.'));
+        child.on('error', (e) => finish('FAIL', `wiring could not be spawned: \`${quoted}\` — ${e.message}`, spawnFailFix(e)));
         child.on('exit', (code) => finish('FAIL', `wiring exited (code ${code}) before answering initialize: \`${quoted}\``, 'Re-run `holmes-kit init` in the target to rewrite the wiring.'));
         child.stdin?.on('error', () => { });
         child.stdout?.on('data', (d) => {

package/dist/holmes/cli/spawn-spec.d.ts

@@ -0,0 +1,15 @@
+/**
+ * Platform adapter for spawning a WIRING command verbatim. On win32, `npx` is `npx.cmd`, and a
+ * plain child_process.spawn cannot execute a .cmd shim (Node's CVE-2024-27980 hardening) — the
+ * Windows field measurement: doctor's four wiring-handshake checks all died `spawn npx ENOENT`
+ * on a target whose wiring was provably correct. Routing through cmd.exe is what the check's own
+ * purpose demands (it executes what the wiring file says), and no interpolation is added: tokens
+ * pass through byte-identical, quoted only when they carry whitespace (the measured
+ * space-in-username install path).
+ *
+ * PURE — platform arrives as an argument so every branch is testable off-Windows.
+ */
+export declare function spawnSpecFor(command: string, args: string[], platform: NodeJS.Platform): {
+    command: string;
+    args: string[];
+};

package/dist/holmes/cli/spawn-spec.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.spawnSpecFor = spawnSpecFor;
+// @implements A-SPEC-499.1
+/**
+ * Platform adapter for spawning a WIRING command verbatim. On win32, `npx` is `npx.cmd`, and a
+ * plain child_process.spawn cannot execute a .cmd shim (Node's CVE-2024-27980 hardening) — the
+ * Windows field measurement: doctor's four wiring-handshake checks all died `spawn npx ENOENT`
+ * on a target whose wiring was provably correct. Routing through cmd.exe is what the check's own
+ * purpose demands (it executes what the wiring file says), and no interpolation is added: tokens
+ * pass through byte-identical, quoted only when they carry whitespace (the measured
+ * space-in-username install path).
+ *
+ * PURE — platform arrives as an argument so every branch is testable off-Windows.
+ */
+function spawnSpecFor(command, args, platform) {
+    if (platform !== 'win32')
+        return { command, args: [...args] };
+    const joined = [command, ...args].map((t) => (/\s/.test(t) ? `"${t}"` : t)).join(' ');
+    return { command: 'cmd.exe', args: ['/d', '/s', '/c', joined] };
+}

package/package.json

@@ -1,7 +1,7 @@
 {
   "//": "@implements A-SPEC-209",
   "name": "@holmes-lab/holmes-kit",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "Holmes-Kit — deterministic Agentic Software Engineering (ASE) harness with causal traceability (spec chain + D-CPG + RTM + phase guardrail)",
   "main": "dist/holmes/mcp/server.js",
   "types": "dist/holmes/mcp/server.d.ts",