@hoilab/ada-cli 0.84.21 → 0.85.0

package/dist/core/memory-engine/engine.js

@@ -13,16 +13,16 @@
  * conversation.
  */
 import { createHash } from "node:crypto";
-import { readFile, writeFile, mkdir } from "node:fs/promises";
 import { existsSync } from "node:fs";
+import { mkdir, readFile, writeFile } from "node:fs/promises";
 import { join } from "node:path";
-import { ObservationStore, listProjectHashes, ENTRY_DELIMITER } from "./observation-store.js";
+import { AuditLog } from "./audit.js";
 import { InvertedIndex } from "./inverted-index.js";
-import { SessionIndexer } from "./session-indexer.js";
+import { ENTRY_DELIMITER, listProjectHashes, ObservationStore } from "./observation-store.js";
+import { invertBatch, RefinementJournal } from "./refinements.js";
 import { classifySensitive } from "./security.js";
-import { AuditLog } from "./audit.js";
-import "./types.js";
-import { OBSERVATION_TYPES } from "./types.js";
+import { SessionIndexer } from "./session-indexer.js";
+import { OBSERVATION_TYPES, } from "./types.js";
 // ─── Prompts (captured/adapted from pi-hermes-memory + pi-memory) ───
 export const MEMORY_POLICY_PROMPT = `<memory-policy>
 Persistent memory is available through memory tools. Do not assume memory has already been loaded into the prompt.
@@ -119,12 +119,7 @@ const CORRECTION_STRONG_PATTERNS = [
     /^please don'?t/i,
     /^that'?s not what I/i,
 ];
-const CORRECTION_WEAK_PATTERNS = [
-    /^no[,\.\s!]/i,
-    /^wrong[,\.\s!]/i,
-    /^actually[,\.\s]/i,
-    /^stop[,\.\s!]/i,
-];
+const CORRECTION_WEAK_PATTERNS = [/^no[,.\s!]/i, /^wrong[,.\s!]/i, /^actually[,.\s]/i, /^stop[,.\s!]/i];
 const CORRECTION_NEGATIVE_PATTERNS = [
     /^no worries/i,
     /^no problem/i,
@@ -134,9 +129,29 @@ const CORRECTION_NEGATIVE_PATTERNS = [
     /^stop.{0,5}(there|here|for now)/i,
 ];
 const CORRECTION_DIRECTIVE_WORDS = [
-    "use", "don't", "dont", "do", "try", "make", "run", "install", "add",
-    "remove", "delete", "change", "fix", "put", "set", "write", "go",
-    "stop", "start", "the", "that", "this", "it",
+    "use",
+    "don't",
+    "dont",
+    "do",
+    "try",
+    "make",
+    "run",
+    "install",
+    "add",
+    "remove",
+    "delete",
+    "change",
+    "fix",
+    "put",
+    "set",
+    "write",
+    "go",
+    "stop",
+    "start",
+    "the",
+    "that",
+    "this",
+    "it",
 ];
 function escapeRegexLiteral(value) {
     return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
@@ -185,7 +200,6 @@ export class MemoryEngine {
     _userTurns = 0;
     _pendingCorrection = false;
     _turnsSinceCorrection = 3;
-    _lastReviewAt = 0;
     _consolidationLocks = new Set();
     currentSessionId = "";
     auditLog = null;
@@ -198,7 +212,12 @@ export class MemoryEngine {
         this.stores = {
             global: new ObservationStore({ rootDir: this.rootDir, projectHash: null, charLimit: 5000, target: "global" }),
             user: new ObservationStore({ rootDir: this.rootDir, projectHash: null, charLimit: 5000, target: "user" }),
-            failure: new ObservationStore({ rootDir: this.rootDir, projectHash: null, charLimit: 10000, target: "failure" }),
+            failure: new ObservationStore({
+                rootDir: this.rootDir,
+                projectHash: null,
+                charLimit: 10000,
+                target: "failure",
+            }),
             project: null,
         };
         this.sessionIndexer = new SessionIndexer({
@@ -245,16 +264,36 @@ export class MemoryEngine {
                 await this.auditLog.load();
             }
             const limits = this.config.charLimits;
-            this.stores.global = new ObservationStore({ rootDir: this.rootDir, projectHash: null, charLimit: limits.global, target: "global" });
-            this.stores.user = new ObservationStore({ rootDir: this.rootDir, projectHash: null, charLimit: limits.user, target: "user" });
-            this.stores.failure = new ObservationStore({ rootDir: this.rootDir, projectHash: null, charLimit: limits.failure, target: "failure" });
+            this.stores.global = new ObservationStore({
+                rootDir: this.rootDir,
+                projectHash: null,
+                charLimit: limits.global,
+                target: "global",
+            });
+            this.stores.user = new ObservationStore({
+                rootDir: this.rootDir,
+                projectHash: null,
+                charLimit: limits.user,
+                target: "user",
+            });
+            this.stores.failure = new ObservationStore({
+                rootDir: this.rootDir,
+                projectHash: null,
+                charLimit: limits.failure,
+                target: "failure",
+            });
             await Promise.all([
                 this.stores.global.loadFromDisk(),
                 this.stores.user.loadFromDisk(),
                 this.stores.failure.loadFromDisk(),
             ]);
             if (this.projectHash) {
-                this.stores.project = new ObservationStore({ rootDir: this.rootDir, projectHash: this.projectHash, charLimit: limits.project, target: "project" });
+                this.stores.project = new ObservationStore({
+                    rootDir: this.rootDir,
+                    projectHash: this.projectHash,
+                    charLimit: limits.project,
+                    target: "project",
+                });
                 await this.stores.project.loadFromDisk();
                 await this.migrateLegacyProjectMemory();
             }
@@ -302,14 +341,28 @@ export class MemoryEngine {
                 project: this.projectHash,
                 lastReferenced: new Date().toISOString().split("T")[0],
             });
-            await this.audit({ action: "migrate", source: "auto", target: "project", scope: this.projectHash ?? "global", ok: true });
+            await this.audit({
+                action: "migrate",
+                source: "auto",
+                target: "project",
+                scope: this.projectHash ?? "global",
+                ok: true,
+            });
         }
     }
     // ─── Accessors ───
-    get globalStore() { return this.stores.global; }
-    get userStore() { return this.stores.user; }
-    get failureStore() { return this.stores.failure; }
-    get projectStore() { return this.stores.project; }
+    get globalStore() {
+        return this.stores.global;
+    }
+    get userStore() {
+        return this.stores.user;
+    }
+    get failureStore() {
+        return this.stores.failure;
+    }
+    get projectStore() {
+        return this.stores.project;
+    }
     getStore(target) {
         if (target === "global")
             return this.stores.global;
@@ -386,7 +439,8 @@ export class MemoryEngine {
             };
         }
         const result = await store.add(input.content, {
-            type: input.type ?? (input.target === "user" ? "user-info" : input.target === "failure" ? "failure" : "discovery"),
+            type: input.type ??
+                (input.target === "user" ? "user-info" : input.target === "failure" ? "failure" : "discovery"),
             project: this.projectHash,
         });
         if (result.success) {
@@ -430,7 +484,13 @@ export class MemoryEngine {
         const result = await store.replace(oldText, content, { type });
         if (result.success) {
             this.upsertObservationIndex(target, store);
-            await this.audit({ action: "replace", source: "agent", target, scope: this.projectHash ?? "global", ok: true });
+            await this.audit({
+                action: "replace",
+                source: "agent",
+                target,
+                scope: this.projectHash ?? "global",
+                ok: true,
+            });
         }
         return result;
     }
@@ -448,16 +508,21 @@ export class MemoryEngine {
         return result;
     }
     /** Apply structured JSON operations (review/correction/flush/consolidation). */
-    async applyOperations(operations) {
+    async applyOperations(operations, source = "review") {
         let applied = 0;
         let skipped = 0;
         const errors = [];
+        // Historial deshacible: el engine edita la memoria solo, así que sin esto
+        // una escritura automática incorrecta es irreversible para el usuario.
+        const done = [];
         for (const op of operations) {
             try {
                 if (op.action === "add") {
                     const result = await this.addMemory({ target: op.target, content: op.content ?? "", type: op.type });
-                    if (result.success)
+                    if (result.success) {
                         applied++;
+                        done.push({ action: "add", target: op.target, after: op.content ?? "" });
+                    }
                     else {
                         skipped++;
                         errors.push(result.error ?? "add failed");
@@ -465,8 +530,10 @@ export class MemoryEngine {
                 }
                 else if (op.action === "replace") {
                     const result = await this.replaceMemory(op.target, op.old_text ?? "", op.content ?? "", op.type);
-                    if (result.success)
+                    if (result.success) {
                         applied++;
+                        done.push({ action: "replace", target: op.target, before: result.previous, after: op.content ?? "" });
+                    }
                     else {
                         skipped++;
                         errors.push(result.error ?? "replace failed");
@@ -474,8 +541,10 @@ export class MemoryEngine {
                 }
                 else {
                     const result = await this.removeMemory(op.target, op.old_text ?? "");
-                    if (result.success)
+                    if (result.success) {
                         applied++;
+                        done.push({ action: "remove", target: op.target, before: result.previous });
+                    }
                     else {
                         skipped++;
                         errors.push(result.error ?? "remove failed");
@@ -486,7 +555,63 @@ export class MemoryEngine {
                 skipped++;
             }
         }
-        return { applied, skipped, errors };
+        let batchId;
+        if (done.length > 0) {
+            batchId = `r${Date.now().toString(36)}`;
+            await this.refinements()
+                .append({ id: batchId, ts: new Date().toISOString(), source, ops: done })
+                .catch(() => {
+                // El historial nunca debe romper una escritura de memoria.
+            });
+        }
+        return { applied, skipped, errors, batchId };
+    }
+    // ─── Historial deshacible ───
+    refinementJournal = null;
+    refinements() {
+        if (!this.refinementJournal) {
+            this.refinementJournal = new RefinementJournal(this.rootDir, this.config.privacyLevel);
+        }
+        return this.refinementJournal;
+    }
+    /** Lotes de cambios automáticos, del más reciente al más antiguo. */
+    async refinementBatches(limit = 20) {
+        return this.refinements().list(limit);
+    }
+    /** Diff legible de un lote (`/memory diff <id>`). */
+    async refinementDiff(id) {
+        const batch = await this.refinements().get(id);
+        return batch ? RefinementJournal.renderDiff(batch) : null;
+    }
+    /**
+     * Deshace un lote entero (`/memory rollback <id>`). Aplica las operaciones
+     * inversas en orden inverso, y queda registrado como un lote más — deshacer
+     * también es auditable.
+     */
+    async refinementRollback(id) {
+        const batch = await this.refinements().get(id);
+        if (!batch)
+            return { ok: false, applied: 0, error: `No existe el lote '${id}'.` };
+        const inverse = invertBatch(batch);
+        let applied = 0;
+        for (const op of inverse) {
+            const result = op.action === "add"
+                ? await this.addMemory({ target: op.target, content: op.after ?? "" })
+                : op.action === "remove"
+                    ? await this.removeMemory(op.target, op.before ?? "")
+                    : await this.replaceMemory(op.target, op.before ?? "", op.after ?? "");
+            if (result.success)
+                applied++;
+        }
+        await this.refinements()
+            .append({
+            id: `r${Date.now().toString(36)}`,
+            ts: new Date().toISOString(),
+            source: `rollback:${id}`,
+            ops: inverse,
+        })
+            .catch(() => { });
+        return { ok: applied > 0, applied };
     }
     // ─── Memory search ───
     async rebuildMemoriesIndex() {
@@ -501,7 +626,12 @@ export class MemoryEngine {
     }
     upsertObservationIndex(target, store) {
         for (const entry of store.getRawEntries()) {
-            this.memoriesIndex.upsert(`${target}:${entry.id}`, entry.text, { target, type: entry.type, created: entry.created, project: entry.project });
+            this.memoriesIndex.upsert(`${target}:${entry.id}`, entry.text, {
+                target,
+                type: entry.type,
+                created: entry.created,
+                project: entry.project,
+            });
         }
     }
     searchMemories(query) {
@@ -579,7 +709,7 @@ export class MemoryEngine {
         return this.buildPromptContext();
     }
     /** Build the memory context block (policy mode by default). */
-    buildPromptContext(prompt) {
+    buildPromptContext(_prompt) {
         if (!this.config.enabled)
             return "";
         if (this.config.mode === "policy") {
@@ -603,11 +733,13 @@ export class MemoryEngine {
         }
         push(this.stores.user.formatForSystemPrompt("USER PROFILE (who the user is)"));
         push(this.stores.global.formatForSystemPrompt("MEMORY (your personal notes)"));
-        const recentFailures = this.failureStore.getEntries()
+        const recentFailures = this.failureStore
+            .getEntries()
             .filter((e) => e.type === "failure" || e.type === "correction")
             .slice(-this.config.failureInjectMaxEntries);
         if (recentFailures.length > 0) {
-            const block = `═`.repeat(46) + `\nRECENT FAILURES & LESSONS (learn from these):\n` +
+            const block = `═`.repeat(46) +
+                `\nRECENT FAILURES & LESSONS (learn from these):\n` +
                 recentFailures.map((e) => `• [${e.type}] ${e.text}`).join("\n");
             push(this.fence(block));
         }
@@ -736,16 +868,21 @@ export class MemoryEngine {
         if (!this.deps.complete)
             return;
         const assistantText = extractMessageText(turn.message?.content);
-        const currentMemory = this.stores.global.getEntries().map((e) => e.text).join(ENTRY_DELIMITER) || "(empty)";
-        const currentUser = this.stores.user.getEntries().map((e) => e.text).join(ENTRY_DELIMITER) || "(empty)";
-        const currentProject = this.stores.project ? this.stores.project.getEntries().map((e) => e.text).join(ENTRY_DELIMITER) || "(empty)" : null;
-        const sections = [
-            "--- Current Memory ---",
-            currentMemory,
-            "",
-            "--- Current User Profile ---",
-            currentUser,
-        ];
+        const currentMemory = this.stores.global
+            .getEntries()
+            .map((e) => e.text)
+            .join(ENTRY_DELIMITER) || "(empty)";
+        const currentUser = this.stores.user
+            .getEntries()
+            .map((e) => e.text)
+            .join(ENTRY_DELIMITER) || "(empty)";
+        const currentProject = this.stores.project
+            ? this.stores.project
+                .getEntries()
+                .map((e) => e.text)
+                .join(ENTRY_DELIMITER) || "(empty)"
+            : null;
+        const sections = ["--- Current Memory ---", currentMemory, "", "--- Current User Profile ---", currentUser];
         if (currentProject !== null) {
             sections.push("", "--- Current Project Memory ---", currentProject);
         }
@@ -768,13 +905,18 @@ export class MemoryEngine {
         // Always record the correction as a failure entry (fast, no LLM).
         const userText = extractMessageText(turn.message?.content);
         if (userText) {
-            await this.stores.failure.add(`[correction] ${userText.slice(0, 300)}`, {
+            await this.stores.failure
+                .add(`[correction] ${userText.slice(0, 300)}`, {
                 type: "correction",
                 project: this.projectHash,
-            }).catch(() => ({ success: false }));
+            })
+                .catch(() => ({ success: false }));
         }
         if (this.deps.complete) {
-            const currentUser = this.stores.user.getEntries().map((e) => e.text).join(ENTRY_DELIMITER) || "(empty)";
+            const currentUser = this.stores.user
+                .getEntries()
+                .map((e) => e.text)
+                .join(ENTRY_DELIMITER) || "(empty)";
             try {
                 const output = await this.deps.complete(CORRECTION_SYSTEM_PROMPT, `--- Current User Profile ---\n${currentUser}\n\n--- Latest User Message ---\n${userText ?? ""}`);
                 const operations = parseOperations(output);
@@ -793,8 +935,16 @@ export class MemoryEngine {
         if (!this.config.enabled || !this.deps.complete)
             return;
         try {
-            const currentUser = this.stores.user.getEntries().map((e) => e.text).join(ENTRY_DELIMITER) || "(empty)";
-            const currentProject = this.stores.project ? this.stores.project.getEntries().map((e) => e.text).join(ENTRY_DELIMITER) || "(empty)" : null;
+            const currentUser = this.stores.user
+                .getEntries()
+                .map((e) => e.text)
+                .join(ENTRY_DELIMITER) || "(empty)";
+            const currentProject = this.stores.project
+                ? this.stores.project
+                    .getEntries()
+                    .map((e) => e.text)
+                    .join(ENTRY_DELIMITER) || "(empty)"
+                : null;
             const sections = [
                 "--- Current User Profile ---",
                 currentUser,
@@ -808,7 +958,13 @@ export class MemoryEngine {
             const operations = parseOperations(output);
             if (operations.length > 0) {
                 const result = await this.applyOperations(operations);
-                await this.audit({ action: "flush", source: "auto", target: "project", scope: this.projectHash ?? "global", ok: result.applied > 0 });
+                await this.audit({
+                    action: "flush",
+                    source: "auto",
+                    target: "project",
+                    scope: this.projectHash ?? "global",
+                    ok: result.applied > 0,
+                });
             }
         }
         catch {
@@ -851,10 +1007,18 @@ export class MemoryEngine {
                 await store.remove(op.old_text ?? "").catch(() => ({ success: false }));
             }
             for (const op of adds) {
-                await store.add(op.content ?? "", { type: op.type, project: this.projectHash }).catch(() => ({ success: false }));
+                await store
+                    .add(op.content ?? "", { type: op.type, project: this.projectHash })
+                    .catch(() => ({ success: false }));
             }
             await this.rebuildMemoriesIndex();
-            await this.audit({ action: "consolidate", source: "auto", target, scope: this.projectHash ?? "global", ok: true });
+            await this.audit({
+                action: "consolidate",
+                source: "auto",
+                target,
+                scope: this.projectHash ?? "global",
+                ok: true,
+            });
             return { consolidated: true };
         }
         catch (error) {