@hogsend/engine 0.18.0 → 0.20.0

package/src/lib/seed-posthog-destination.ts

@@ -23,6 +23,19 @@ const POSTHOG_FUNNEL_EVENTS = [
   "email.complained",
 ] as const;
 
+/**
+ * Person-property propagation events (the contact → analytics-person rail).
+ * The preset's `syncPersons` flag turns these into `$set` captures of the
+ * contact's properties under its canonical key; without the flag the
+ * transform SKIPS them, so subscribing them is only meaningful together
+ * with `config.syncPersons: true`.
+ */
+const POSTHOG_PERSON_SYNC_EVENTS = [
+  "contact.created",
+  "contact.updated",
+  "contact.unsubscribed",
+] as const;
+
 /**
  * Idempotently seed ONE `kind="posthog"` webhook endpoint subscribed to the
  * email funnel, so the full email lifecycle fans out to PostHog DURABLY on the
@@ -56,6 +69,7 @@ export async function seedPostHogDestination(opts: {
         id: webhookEndpoints.id,
         url: webhookEndpoints.url,
         eventTypes: webhookEndpoints.eventTypes,
+        config: webhookEndpoints.config,
       })
       .from(webhookEndpoints)
       .where(
@@ -78,19 +92,31 @@ export async function seedPostHogDestination(opts: {
         const current = Array.isArray(found.eventTypes)
           ? (found.eventTypes as string[])
           : [];
-        const missing = POSTHOG_FUNNEL_EVENTS.filter(
-          (e) => !current.includes(e),
-        );
-        if (missing.length > 0) {
+        const missing = [
+          ...POSTHOG_FUNNEL_EVENTS,
+          ...POSTHOG_PERSON_SYNC_EVENTS,
+        ].filter((e) => !current.includes(e));
+        // Person-sync default-on for the ENGINE-seeded row, but never override
+        // an explicit operator choice: only set the flag when it is ABSENT
+        // from config (an explicit `false` stays false).
+        const existingConfig = (found.config ?? {}) as Record<string, unknown>;
+        const needsSyncFlag = existingConfig.syncPersons === undefined;
+        if (missing.length > 0 || needsSyncFlag) {
           await tx
             .update(webhookEndpoints)
             .set({
-              eventTypes: [...current, ...missing],
+              ...(missing.length > 0
+                ? { eventTypes: [...current, ...missing] }
+                : {}),
+              ...(needsSyncFlag
+                ? { config: { ...existingConfig, syncPersons: true } }
+                : {}),
               updatedAt: new Date(),
             })
             .where(eq(webhookEndpoints.id, found.id));
-          logger.info("Reconciled seeded PostHog destination event types", {
+          logger.info("Reconciled seeded PostHog destination", {
             added: missing,
+            syncPersonsEnabled: needsSyncFlag,
           });
         }
       }
@@ -110,8 +136,13 @@ export async function seedPostHogDestination(opts: {
         // remaps the canonical "email.clicked" back so existing PostHog funnels
         // keep working after the cutover.
         eventNames: { "email.clicked": "email.link_clicked" },
+        // Person-property propagation ON for the seeded destination: contact
+        // truth ($set of contact.properties) lands on the same PostHog person
+        // the identify loop addresses. Disable per-endpoint via the admin API
+        // (config.syncPersons: false).
+        syncPersons: true,
       },
-      eventTypes: [...POSTHOG_FUNNEL_EVENTS],
+      eventTypes: [...POSTHOG_FUNNEL_EVENTS, ...POSTHOG_PERSON_SYNC_EVENTS],
       secret: null,
       secretPrefix: null,
       disabled: false,

package/src/routes/admin/analytics.ts

@@ -0,0 +1,261 @@
+import { DEFAULT_HOST, derivePrivateHost } from "@hogsend/plugin-posthog";
+import { createRoute, OpenAPIHono, z } from "@hono/zod-openapi";
+import type { AppEnv } from "../../app.js";
+import { createTokenManager } from "../../lib/oauth-token-manager.js";
+import {
+  ProvisionPostHogLoopError,
+  provisionPostHogLoop,
+} from "../../lib/provision-posthog-loop.js";
+import { errorSchema } from "../../lib/schemas.js";
+
+/**
+ * Admin analytics-connection routes — the server half of
+ * `hogsend connect posthog`. Mounted at `/v1/admin/analytics`, inheriting
+ * `requireAdmin` + `rateLimit` + `auditMiddleware` from the admin router root.
+ *
+ * - `GET /connect-info` surfaces the instance's PostHog env signal so the CLI
+ *   needs NO PostHog env vars locally (it learns the region + readiness from
+ *   the server). Pure env projection — it never discovers anything.
+ * - `POST /provision-loop` runs the idempotent PostHog → Hogsend hog-function
+ *   provisioner server-side with the server's own credential (OAuth credential
+ *   via a route-local token manager, falling back to the personal API key).
+ */
+
+export const connectInfoSchema = z.object({
+  providerId: z.literal("posthog"),
+  analyticsConfigured: z.boolean(),
+  privateHost: z.string().nullable(),
+  hostExplicit: z.boolean(),
+  projectIdHint: z.string().nullable(),
+  personalKeyConfigured: z.boolean(),
+  webhookSecretConfigured: z.boolean(),
+  apiPublicUrl: z.string(),
+});
+export type ConnectInfo = z.infer<typeof connectInfoSchema>;
+
+/**
+ * True when a public URL points at a loopback/unspecified address — PostHog
+ * Cloud can never deliver to it, so provisioning must refuse rather than
+ * create (or repoint!) a destination nobody can reach.
+ */
+export function isLoopbackPublicUrl(publicUrl: string): boolean {
+  try {
+    const host = new URL(publicUrl).hostname.toLowerCase();
+    return (
+      host === "localhost" ||
+      host === "127.0.0.1" ||
+      host === "0.0.0.0" ||
+      host === "[::1]" ||
+      host === "::1" ||
+      host.endsWith(".localhost")
+    );
+  } catch {
+    return false;
+  }
+}
+
+/**
+ * Pure env projection, exported for unit tests — no app boot needed.
+ *
+ * `privateHost: null` only when the server has NO PostHog signal at all (no
+ * API key, no host overrides). When `POSTHOG_API_KEY` is set without a host,
+ * the provider defaults to US Cloud, so the derived `https://us.posthog.com`
+ * is returned with `hostExplicit: false` — the CLI warns and confirms.
+ *
+ * Surfaces env ONLY — project-id discovery belongs to the provisioner (M8),
+ * and the webhook secret VALUE never leaves the server (only its
+ * configured-ness does).
+ */
+export function resolveConnectInfo(env: {
+  POSTHOG_API_KEY?: string;
+  POSTHOG_HOST?: string;
+  POSTHOG_PRIVATE_HOST?: string;
+  POSTHOG_PROJECT_ID?: string;
+  POSTHOG_PERSONAL_API_KEY?: string;
+  POSTHOG_WEBHOOK_SECRET?: string;
+  API_PUBLIC_URL: string;
+}): ConnectInfo {
+  const hostExplicit = Boolean(env.POSTHOG_PRIVATE_HOST ?? env.POSTHOG_HOST);
+  const configuredAtAll = Boolean(env.POSTHOG_API_KEY) || hostExplicit;
+  const privateHost = !configuredAtAll
+    ? null
+    : (
+        env.POSTHOG_PRIVATE_HOST ??
+        derivePrivateHost(env.POSTHOG_HOST ?? DEFAULT_HOST)
+      ).replace(/\/+$/, "");
+
+  return {
+    providerId: "posthog",
+    analyticsConfigured: Boolean(env.POSTHOG_API_KEY),
+    privateHost,
+    hostExplicit,
+    projectIdHint: env.POSTHOG_PROJECT_ID ?? null,
+    personalKeyConfigured: Boolean(env.POSTHOG_PERSONAL_API_KEY),
+    webhookSecretConfigured: Boolean(env.POSTHOG_WEBHOOK_SECRET),
+    apiPublicUrl: env.API_PUBLIC_URL,
+  };
+}
+
+const provisionLoopResponseSchema = z.object({
+  provisioned: z.literal(true),
+  /** `action === "created"` — false covers both "updated" and "unchanged". */
+  created: z.boolean(),
+  action: z.enum(["created", "updated", "unchanged"]),
+  hogFunctionId: z.string(),
+  webhookUrl: z.string(),
+  dashboardUrl: z.string(),
+});
+
+const provisionFailureSchema = z.object({
+  error: z.string(),
+  detail: z.string(),
+  remediation: z.string(),
+});
+
+const connectInfoRoute = createRoute({
+  method: "get",
+  path: "/connect-info",
+  tags: ["Admin — Analytics"],
+  summary: "PostHog connection info for `hogsend connect posthog`",
+  responses: {
+    200: {
+      content: {
+        "application/json": { schema: connectInfoSchema },
+      },
+      description:
+        "The instance's PostHog env signal (region, readiness flags) — " +
+        "secrets never appear, only their configured-ness",
+    },
+    401: {
+      content: { "application/json": { schema: errorSchema } },
+      description: "Missing or invalid admin credentials",
+    },
+  },
+});
+
+const provisionLoopRoute = createRoute({
+  method: "post",
+  path: "/provision-loop",
+  tags: ["Admin — Analytics"],
+  summary: "Provision the PostHog → Hogsend event loop (webhook destination)",
+  responses: {
+    200: {
+      content: {
+        "application/json": { schema: provisionLoopResponseSchema },
+      },
+      description:
+        "Loop provisioned (idempotent: created, updated, or unchanged)",
+    },
+    401: {
+      content: { "application/json": { schema: errorSchema } },
+      description: "Missing or invalid admin credentials",
+    },
+    409: {
+      content: { "application/json": { schema: errorSchema } },
+      description:
+        "Refused: `no_posthog_credential` (no OAuth credential and no " +
+        "personal API key), `posthog_not_configured` (no PostHog env signal " +
+        "at all), `webhook_secret_missing` (POSTHOG_WEBHOOK_SECRET unset), " +
+        "or `api_public_url_unreachable` (API_PUBLIC_URL is loopback — " +
+        "PostHog cannot deliver to it)",
+    },
+    502: {
+      content: { "application/json": { schema: provisionFailureSchema } },
+      description:
+        "PostHog rejected the provisioning call — error is the provisioner " +
+        "error code, remediation is operator-facing and printed verbatim",
+    },
+  },
+});
+
+export const analyticsAdminRouter = new OpenAPIHono<AppEnv>()
+  .openapi(connectInfoRoute, (c) => {
+    return c.json(resolveConnectInfo(c.get("container").env), 200);
+  })
+  .openapi(provisionLoopRoute, async (c) => {
+    const { db, env, logger } = c.get("container");
+    const info = resolveConnectInfo(env);
+
+    // Credential check FIRST (M3), secret refusal second (enforced by the
+    // provisioner itself). The container does NOT expose the token manager
+    // (it is closed over inside the provider's accessor), so a route-local
+    // instance is correct — the DB row is the shared truth and provisioning
+    // is a one-shot admin action.
+    const tokenManager = createTokenManager({
+      db,
+      providerId: "posthog",
+      logger,
+    });
+    const accessToken =
+      (await tokenManager.getAccessToken()) ??
+      env.POSTHOG_PERSONAL_API_KEY ??
+      null;
+    if (!accessToken) {
+      return c.json({ error: "no_posthog_credential" }, 409);
+    }
+
+    if (info.privateHost === null) {
+      // A credential exists but the server has no PostHog env signal to tell
+      // us which region to provision against.
+      return c.json({ error: "posthog_not_configured" }, 409);
+    }
+
+    // PostHog Cloud cannot deliver webhooks to a loopback address — and a
+    // local instance with a misconfigured API_PUBLIC_URL must never repoint
+    // a production destination at localhost. Refuse BEFORE any PostHog call.
+    if (isLoopbackPublicUrl(info.apiPublicUrl)) {
+      return c.json(
+        {
+          error: "api_public_url_unreachable",
+          detail: `API_PUBLIC_URL is ${info.apiPublicUrl} — PostHog cannot reach a loopback address.`,
+          remediation:
+            "Run this against your DEPLOYED instance (the credential is already stored there if you connected it): hogsend connect posthog --provision-only --url https://your-instance",
+        },
+        409,
+      );
+    }
+
+    try {
+      const result = await provisionPostHogLoop({
+        privateHost: info.privateHost,
+        accessToken,
+        // M8: pass the env project id when set; else the provisioner runs its
+        // own one-shot `@current` discovery.
+        ...(env.POSTHOG_PROJECT_ID !== undefined
+          ? { projectId: env.POSTHOG_PROJECT_ID }
+          : {}),
+        apiPublicUrl: info.apiPublicUrl,
+        webhookSecret: env.POSTHOG_WEBHOOK_SECRET,
+        logger,
+      });
+
+      // M4 translation: the CLI's documented shape, with `action` riding
+      // along for --json consumers.
+      return c.json(
+        {
+          provisioned: true as const,
+          created: result.action === "created",
+          action: result.action,
+          hogFunctionId: result.functionId,
+          webhookUrl: result.webhookUrl,
+          dashboardUrl: result.dashboardUrl,
+        },
+        200,
+      );
+    } catch (error) {
+      if (error instanceof ProvisionPostHogLoopError) {
+        if (error.code === "missing-webhook-secret") {
+          return c.json({ error: "webhook_secret_missing" }, 409);
+        }
+        return c.json(
+          {
+            error: error.code,
+            detail: error.message,
+            remediation: error.remediation,
+          },
+          502,
+        );
+      }
+      throw error;
+    }
+  });

package/src/routes/admin/index.ts

@@ -4,6 +4,7 @@ import { auditMiddleware } from "../../middleware/audit.js";
 import { rateLimit } from "../../middleware/rate-limit.js";
 import { requireAdmin } from "../../middleware/require-admin.js";
 import { alertsRouter } from "./alerts.js";
+import { analyticsAdminRouter } from "./analytics.js";
 import { apiKeysRouter } from "./api-keys.js";
 import { auditLogsRouter } from "./audit-logs.js";
 import { bucketsRouter } from "./buckets.js";
@@ -17,6 +18,7 @@ import { journeyLogsRouter } from "./journey-logs.js";
 import { journeysRouter } from "./journeys.js";
 import { metricsRouter } from "./metrics.js";
 import { preferencesRouter } from "./preferences.js";
+import { providerCredentialsRouter } from "./provider-credentials.js";
 import { reportingRouter } from "./reporting.js";
 import { suppressionsRouter } from "./suppressions.js";
 import { templatesRouter } from "./templates.js";
@@ -42,6 +44,8 @@ adminRouter.route("/templates", templatesRouter);
 adminRouter.route("/suppressions", suppressionsRouter);
 adminRouter.route("/api-keys", apiKeysRouter);
 adminRouter.route("/webhooks", webhooksRouter);
+adminRouter.route("/provider-credentials", providerCredentialsRouter);
+adminRouter.route("/analytics", analyticsAdminRouter);
 adminRouter.route("/audit-logs", auditLogsRouter);
 adminRouter.route("/alerts", alertsRouter);
 adminRouter.route("/dlq", dlqRouter);

package/src/routes/admin/provider-credentials.ts

@@ -0,0 +1,184 @@
+import { createRoute, OpenAPIHono, z } from "@hono/zod-openapi";
+import type { AppEnv } from "../../app.js";
+import {
+  deleteProviderCredential,
+  getProviderCredential,
+  ProviderCredentialDecryptError,
+  type ProviderCredentialMeta,
+  saveProviderCredential,
+  toCredentialMeta,
+} from "../../lib/provider-credentials.js";
+import { errorSchema } from "../../lib/schemas.js";
+
+/**
+ * Admin provider-credential management. Mounted at
+ * `/v1/admin/provider-credentials`, it inherits `requireAdmin` + `rateLimit`
+ * + `auditMiddleware` from the admin router root — no per-route auth here.
+ *
+ * INVARIANT: decrypted token material NEVER appears in any HTTP response —
+ * this router returns meta only. (The audit middleware is body-blind, so a
+ * PUT body carrying tokens is not persisted to `audit_logs` either.)
+ */
+
+const providerIdParam = z.object({
+  providerId: z.string().min(1).max(100),
+});
+
+// The canonical OAuth credential payload (SYNTHESIS §0) — keep textually
+// identical to the token manager's runtime parse.
+const oauthPayloadSchema = z.object({
+  accessToken: z.string().min(1),
+  refreshToken: z.string().min(1),
+  expiresAt: z.string().datetime({ offset: true }),
+  tokenEndpoint: z.string().url(),
+  clientId: z.string().url(),
+  scopes: z.array(z.string()).default([]),
+  scopedTeams: z.array(z.number().int()).default([]),
+  scopedOrganizations: z.array(z.string()).default([]),
+});
+
+const putBodySchema = z.object({
+  kind: z.literal("oauth").default("oauth"),
+  payload: oauthPayloadSchema,
+});
+
+// Wire meta — Dates serialized to ISO strings. Token material never appears.
+const credentialMetaSchema = z.object({
+  providerId: z.string(),
+  kind: z.literal("oauth"),
+  scopes: z.array(z.string()),
+  expiresAt: z.string(),
+  scopedTeams: z.array(z.number()),
+  createdAt: z.string(),
+  updatedAt: z.string(),
+});
+
+const upsertRoute = createRoute({
+  method: "put",
+  path: "/{providerId}",
+  tags: ["Admin — Provider Credentials"],
+  summary: "Store (upsert) a provider credential",
+  request: {
+    params: providerIdParam,
+    body: {
+      content: {
+        "application/json": { schema: putBodySchema },
+      },
+    },
+  },
+  responses: {
+    200: {
+      content: {
+        "application/json": { schema: credentialMetaSchema },
+      },
+      description:
+        "Credential stored (encrypted at rest) — meta only, tokens are never returned",
+    },
+  },
+});
+
+const getRoute = createRoute({
+  method: "get",
+  path: "/{providerId}",
+  tags: ["Admin — Provider Credentials"],
+  summary: "Get a provider credential's meta",
+  request: {
+    params: providerIdParam,
+  },
+  responses: {
+    200: {
+      content: {
+        "application/json": { schema: credentialMetaSchema },
+      },
+      description: "Credential meta — decrypted tokens are NEVER returned",
+    },
+    404: {
+      content: { "application/json": { schema: errorSchema } },
+      description: "No credential stored for this provider",
+    },
+    409: {
+      content: { "application/json": { schema: errorSchema } },
+      description:
+        "Credential exists but cannot be decrypted — BETTER_AUTH_SECRET rotated; PUT a new credential or DELETE",
+    },
+  },
+});
+
+const deleteRoute = createRoute({
+  method: "delete",
+  path: "/{providerId}",
+  tags: ["Admin — Provider Credentials"],
+  summary: "Delete a provider credential",
+  request: {
+    params: providerIdParam,
+  },
+  responses: {
+    200: {
+      content: {
+        "application/json": { schema: z.object({ deleted: z.boolean() }) },
+      },
+      description: "Credential hard-deleted",
+    },
+    404: {
+      content: { "application/json": { schema: errorSchema } },
+      description: "No credential stored for this provider",
+    },
+  },
+});
+
+function serializeMeta(meta: ProviderCredentialMeta) {
+  return {
+    providerId: meta.providerId,
+    kind: meta.kind,
+    scopes: meta.scopes,
+    expiresAt: meta.expiresAt.toISOString(),
+    scopedTeams: meta.scopedTeams,
+    createdAt: meta.createdAt.toISOString(),
+    updatedAt: meta.updatedAt.toISOString(),
+  };
+}
+
+export const providerCredentialsRouter = new OpenAPIHono<AppEnv>()
+  .openapi(upsertRoute, async (c) => {
+    const { db } = c.get("container");
+    const { providerId } = c.req.valid("param");
+    const body = c.req.valid("json");
+
+    // PUT is a full idempotent upsert — create and update are the same 200.
+    const meta = await saveProviderCredential(db, {
+      providerId,
+      kind: body.kind,
+      payload: body.payload,
+    });
+
+    return c.json(serializeMeta(meta), 200);
+  })
+  .openapi(getRoute, async (c) => {
+    const { db } = c.get("container");
+    const { providerId } = c.req.valid("param");
+
+    try {
+      const record = await getProviderCredential(db, providerId);
+      if (!record) {
+        return c.json({ error: "Provider credential not found" }, 404);
+      }
+      return c.json(serializeMeta(toCredentialMeta(record)), 200);
+    } catch (error) {
+      if (error instanceof ProviderCredentialDecryptError) {
+        return c.json({ error: error.message }, 409);
+      }
+      throw error;
+    }
+  })
+  .openapi(deleteRoute, async (c) => {
+    const { db } = c.get("container");
+    const { providerId } = c.req.valid("param");
+
+    // Never decrypts — DELETE must succeed even when the payload is
+    // undecryptable (the operator's escape hatch after a secret rotation).
+    const deleted = await deleteProviderCredential(db, providerId);
+    if (!deleted) {
+      return c.json({ error: "Provider credential not found" }, 404);
+    }
+    return c.json({ deleted: true }, 200);
+  });

package/src/worker.ts

@@ -108,8 +108,9 @@ export function createWorker(opts: CreateWorkerOptions): Worker {
       _worker?.stop(),
       // Shut down the injected analytics instance (same object the worker's
       // tasks use), not the module singleton. Undefined when no analytics is
-      // configured — the optional chain makes that a no-op.
-      container.analytics?.shutdown(),
+      // configured, and `shutdown` is optional on the provider contract —
+      // both optional chains make that a no-op.
+      container.analytics?.shutdown?.(),
       getRedisIfConnected()?.quit(),
     ]);
   }