@hoardodile/host 0.1.1 → 0.1.3

package/src/sandbox/host.ts

@@ -337,7 +337,14 @@ export function createPluginSandbox(
 			await teardownChild(previous)
 		}
 		if (!opts.eager) {
-			void teardownChild(state)
+			// AWAITED, not fire-and-forget: the hook list was probed by
+			// this load, and the loader returns the sandboxed definition
+			// the moment we resolve. A caller that invokes a hook
+			// immediately after (e.g. the post-install `onInstall`) must
+			// not find a half-alive child: `ensureLoaded` would see the
+			// not-yet-torn-down child and post its invocation into a
+			// dying process (rejected as "worker stopped").
+			await teardownChild(state)
 		}
 		return createSandboxedPlugin(state.hooks ?? ["detect"], (hook, api) =>
 			invoke(state, hook, api),
@@ -611,6 +618,28 @@ export function createPluginSandbox(
 			throw new Error(`plugin ${state.id} sandbox unavailable`)
 		}
 
+		try {
+			return await invokeOnChild(state, child, hook, api)
+		} finally {
+			// An install hook is one-shot and the host may immediately
+			// re-commit the same plugin (an update): a kept-alive worker
+			// holding the plugin directory (Windows keeps directory ops
+			// pinned while a child is alive) would make the vault-move
+			// during the next commit fail with EPERM. Drop the child right
+			// after an `onInstall`; the next invocation respawns it.
+			if (hook === "onInstall") {
+				state.respawnTimes = []
+				await teardownChild(state)
+			}
+		}
+	}
+
+	function invokeOnChild(
+		state: PluginState,
+		child: ChildProcess,
+		hook: HookName,
+		api: ResourceAPI,
+	): Promise<unknown> {
 		const callId = nextCallId++
 		return new Promise((resolveCall, reject) => {
 			const call: PendingCall = {

package/src/sandbox/worker-entry.mjs

@@ -43,6 +43,7 @@ const HOOK_NAMES = [
 	"coverLocal",
 	"listFiles",
 	"imageHashes",
+	"onInstall",
 ]
 
 const API_METHOD_NAMES = [
@@ -283,7 +284,11 @@ function send(message) {
 function approxByteSize(value) {
 	if (value instanceof Uint8Array) return value.byteLength
 	try {
-		return JSON.stringify(value).length * 2
+		// `undefined` (hooks that legitimately return nothing — e.g.
+		// `onInstall`) stringifies to `undefined`, not a string: an empty
+		// payload must size 0, never throw into the Infinity branch.
+		const text = JSON.stringify(value)
+		return (typeof text === "string" ? text : "").length * 2
 	} catch {
 		return Infinity
 	}