@hncode/hncode 0.4.2 → 0.5.0

package/src/tools/shell.js

@@ -15,10 +15,26 @@
 // on which one was found.
 
 import cp from 'node:child_process';
+import fs from 'node:fs';
 
 // The two PowerShell families, by the name they are invoked as.
 export const SHELL_CANDIDATES = ['pwsh', 'powershell'];
 
+// Last-resort Windows fallback. A Windows box always has cmd.exe (%COMSPEC%),
+// so when neither PowerShell exists the Bash tool must still run SOMETHING
+// rather than failing outright. `cmd` is not a PowerShell, so the syntax
+// guidance and the spawn args differ (see cmdSpawnArgs).
+export function findCmdExe() {
+  const fromEnv = process.env.COMSPEC || process.env.ComSpec;
+  if (fromEnv) {
+    try { if (fs.existsSync(fromEnv)) return fromEnv; } catch { /* fall through to the PATH probe */ }
+  }
+  if (process.platform === 'win32') {
+    return whichSync('cmd') || whichSync('cmd.exe') || 'cmd.exe';
+  }
+  return null;
+}
+
 /**
  * Resolve an executable name through PATH without spawning it.
  *
@@ -42,13 +58,15 @@ function whichSync(name) {
 }
 
 /**
- * Find a usable PowerShell: pwsh first, then the built-in powershell.
- * Returns { path, name, edition } or null when neither exists.
+ * Find a usable shell: pwsh, then the built-in powershell, then (on Windows)
+ * cmd.exe as a last resort. Returns { path, name, edition } or null.
  *
  * `edition` drives syntax guidance — see the header. It is inferred from the NAME
  * rather than by running the binary (a spawn per probe is not worth it, and
  * PowerShell 6, also named `pwsh`, is EOL and not a realistic target, so `pwsh`
- * safely implies 7+).
+ * safely implies 7+). `edition: 'cmd'` means neither PowerShell exists and the
+ * Bash tool is running through cmd.exe: it still works, but the command syntax is
+ * cmd's, not PowerShell's.
  */
 export function detectShell() {
   for (const name of SHELL_CANDIDATES) {
@@ -57,6 +75,9 @@ export function detectShell() {
       return { path, name, edition: name === 'pwsh' ? 'core' : 'desktop' };
     }
   }
+  // No PowerShell at all: on Windows, guarantee cmd.exe so the tool is not dead.
+  const cmd = findCmdExe();
+  if (cmd) return { path: cmd, name: 'cmd', edition: 'cmd' };
   return null;
 }
 
@@ -91,16 +112,23 @@ export function resetShellCache() {
  * on every single tool call, and `-NonInteractive` stops a command that prompts
  * from hanging the tool forever with no way to answer.
  *
- * Throws a message naming the fix when no PowerShell is installed, instead of
- * letting the caller hit a bare ENOENT.
+ * When neither PowerShell exists, `edition === 'cmd'` selects cmd.exe args instead
+ * (see detectShell). Throws a message naming the fix only when no shell at all
+ * was found, instead of letting the caller hit a bare ENOENT.
  */
 export function shellSpawnArgs(command) {
   const shell = getShell();
   if (!shell) {
     throw new Error(
-      'No PowerShell found on PATH (tried pwsh, powershell). '
+      'No shell found (tried pwsh, powershell, and cmd.exe). '
       + 'Install PowerShell 7+ or add it to PATH, then retry.',
     );
   }
+  if (shell.edition === 'cmd') {
+    // cmd.exe: `/d` skips AutoRun commands, `/s` makes `/c` quoting behave
+    // predictably. The command is passed as ONE argv element, so Node does the
+    // quoting and we do not wrap it ourselves.
+    return { bin: shell.path, args: ['/d', '/s', '/c', command], shell };
+  }
   return { bin: shell.path, args: ['-NoProfile', '-NonInteractive', '-Command', command], shell };
 }