@hmcts/rpx-xui-common-lib 3.2.16 → 3.2.17-exui-4454

package/fesm2022/hmcts-rpx-xui-common-lib.mjs

@@ -2152,7 +2152,8 @@ class FilterService {
     persist(setting, persistence) {
         switch (persistence) {
             case 'local':
-                this.persistLocal(setting);
+                // Backwards compatibility only, EXUI-4454: localStorage should not be used.
+                this.persistSession(setting);
                 break;
             case 'session':
                 this.persistSession(setting);
@@ -2170,19 +2171,16 @@ class FilterService {
         if (sessionStorage.getItem(id)) {
             return JSON.parse(sessionStorage.getItem(id));
         }
+        // Remove legacy persistent data without reading it back into the application.
+        // Filter settings are user-associated and must not survive the browser session.
         if (localStorage.getItem(id)) {
-            if (this.isSameUser(id)) {
-                return JSON.parse(window.localStorage.getItem(id));
-            }
-            else {
-                return null;
-            }
+            localStorage.removeItem(id);
         }
         return null;
     }
     isSameUser(id) {
-        const filterSetting = JSON.parse(window.localStorage.getItem(id));
-        return !!filterSetting.idamId && filterSetting.idamId === this.getUserId();
+        void id;
+        return false;
     }
     getStream(id) {
         if (!this.streams[id]) {
@@ -2200,10 +2198,6 @@ class FilterService {
             this.streams[id].next(null);
         }
     }
-    persistLocal(setting) {
-        setting.idamId = this.getUserId();
-        window.localStorage.setItem(setting.id, JSON.stringify(setting));
-    }
     persistSession(setting) {
         sessionStorage.setItem(setting.id, JSON.stringify(setting));
     }