@hkdigital/lib-core 0.5.75 → 0.5.77

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@hkdigital/lib-core",
-	"version": "0.5.75",
+	"version": "0.5.77",
 	"author": {
 		"name": "HKdigital",
 		"url": "https://hkdigital.nl"

package/scripts/validate-imports.mjs

@@ -286,6 +286,7 @@ async function findExternalBarrelExport(importPath, targetName) {
   // 1. Explicit index.js imports
   // 2. Component files (.svelte)
   // 3. Class files (capitalized .js)
+  // 4. Imports without extension (missing extension or directory)
   let shouldCheck = false;
 
   if (lastPart === 'index.js') {
@@ -294,6 +295,9 @@ async function findExternalBarrelExport(importPath, targetName) {
     shouldCheck = true;
   } else if (lastPart.match(/^[A-Z][^/]*\.js$/)) {
     shouldCheck = true;
+  } else if (!lastPart.includes('.')) {
+    // No extension - could be missing or directory import
+    shouldCheck = true;
   }
 
   if (!shouldCheck) return null;
@@ -421,6 +425,7 @@ async function findAliasBarrelExport(importPath, targetName) {
   // 1. Explicit index.js imports
   // 2. Component files (.svelte)
   // 3. Class files (capitalized .js)
+  // 4. Imports without extension (missing extension or directory)
   let shouldCheck = false;
 
   if (lastPart === 'index.js') {
@@ -429,6 +434,9 @@ async function findAliasBarrelExport(importPath, targetName) {
     shouldCheck = true;
   } else if (lastPart.match(/^[A-Z][^/]*\.js$/)) {
     shouldCheck = true;
+  } else if (!lastPart.includes('.')) {
+    // No extension - could be missing or directory import
+    shouldCheck = true;
   }
 
   if (!shouldCheck) return null;
@@ -534,6 +542,7 @@ async function validateFile(filePath) {
       const importedNames = extractImportNames(line);
 
       // Check each imported name for barrel exports
+      let foundBarrel = false;
       for (const importedName of importedNames) {
         const barrelPath = await findAliasBarrelExport(
           importPath,
@@ -546,35 +555,38 @@ async function validateFile(filePath) {
             `  from '${importPath}'\n` +
             `  => from '${barrelPath}' (use barrel export)`
           );
+          foundBarrel = true;
           break; // Only report once per line
         }
       }
 
-      // Check if alias import is missing file extension
-      // Allow any extension (not just .js/.svelte) to support assets
-      const hasExtension = importPath.match(/\.[^/]+$/);
-
-      if (!hasExtension) {
-        // Extract path after alias to check if it's not just the alias
-        let pathAfterAlias = null;
-        for (const alias of Object.keys(PROJECT_ALIASES)) {
-          if (importPath === alias || importPath.startsWith(alias + '/')) {
-            pathAfterAlias = importPath.slice(alias.length);
-            if (pathAfterAlias.startsWith('/')) {
-              pathAfterAlias = pathAfterAlias.slice(1);
+      // Only check for missing extension if no barrel was found
+      if (!foundBarrel) {
+        const hasExtension = importPath.match(/\.[^/]+$/);
+
+        if (!hasExtension) {
+          // Extract path after alias
+          let pathAfterAlias = null;
+          for (const alias of Object.keys(PROJECT_ALIASES)) {
+            if (importPath === alias ||
+                importPath.startsWith(alias + '/')) {
+              pathAfterAlias = importPath.slice(alias.length);
+              if (pathAfterAlias.startsWith('/')) {
+                pathAfterAlias = pathAfterAlias.slice(1);
+              }
+              break;
             }
-            break;
           }
-        }
 
-        // Only error if there's a path after the alias
-        if (pathAfterAlias && pathAfterAlias.length > 0) {
-          errors.push(
-            `${relativePath}:${lineNum}\n` +
-            `  from '${importPath}'\n` +
-            `  => Missing file extension (add .js, .svelte, ` +
-            `or .svelte.js)`
-          );
+          // Only error if there's a path after the alias
+          if (pathAfterAlias && pathAfterAlias.length > 0) {
+            errors.push(
+              `${relativePath}:${lineNum}\n` +
+              `  from '${importPath}'\n` +
+              `  => Missing file extension ` +
+              `(add .js, .svelte, or .svelte.js)`
+            );
+          }
         }
       }
 
@@ -598,6 +610,7 @@ async function validateFile(filePath) {
         const importedNames = extractImportNames(line);
 
         // Check each imported name for barrel exports
+        let foundBarrel = false;
         for (const importedName of importedNames) {
           const barrelPath = await findExternalBarrelExport(
             importPath,
@@ -610,28 +623,30 @@ async function validateFile(filePath) {
               `  from '${importPath}'\n` +
               `  => from '${barrelPath}' (use barrel export)`
             );
+            foundBarrel = true;
             break; // Only report once per line
           }
         }
 
-        // Check if external import is missing file extension
-        // Allow any extension (not just .js/.svelte) to support assets
-        const hasExtension = importPath.match(/\.[^/]+$/);
+        // Only check for missing extension if no barrel was found
+        if (!foundBarrel) {
+          const hasExtension = importPath.match(/\.[^/]+$/);
 
-        if (!hasExtension) {
-          // Extract package name and check if there's a path
-          const pkgName = importPath.startsWith('@') ?
-            `${parts[0]}/${parts[1]}` : parts[0];
-          const pathInPackage = importPath.slice(pkgName.length);
+          if (!hasExtension) {
+            // Extract package name and check if there's a path
+            const pkgName = importPath.startsWith('@') ?
+              `${parts[0]}/${parts[1]}` : parts[0];
+            const pathInPackage = importPath.slice(pkgName.length);
 
-          // Only error if there's a path in the package (not just pkg name)
-          if (pathInPackage && pathInPackage.length > 1) {
-            errors.push(
-              `${relativePath}:${lineNum}\n` +
-              `  from '${importPath}'\n` +
-              `  => Missing file extension (add .js, .svelte, ` +
-              `or .svelte.js)`
-            );
+            // Only error if path exists in the package (not just pkg name)
+            if (pathInPackage && pathInPackage.length > 1) {
+              errors.push(
+                `${relativePath}:${lineNum}\n` +
+                `  from '${importPath}'\n` +
+                `  => Missing file extension ` +
+                `(add .js, .svelte, or .svelte.js)`
+              );
+            }
           }
         }
       }