@hkdigital/lib-core 0.4.34 → 0.4.36

package/CLAUDE.md

@@ -38,6 +38,12 @@ This is a modern SvelteKit library built with Svelte 5 and Skeleton.dev v3 compo
 - English for all documentation and comments
 - No dollar signs in variable names (reserved for Svelte)
 
+### Testing Commands
+- Run all tests: `pnpm test`
+- Run specific test file: `pnpm test:file path/to/test.js`
+- Run tests in directory: `pnpm test:file src/lib/logging/`
+- Use `pnpm test:file` for single test execution - it's cross-platform compatible
+
 ### ESLint Rule Suppression
 - Use specific rule suppression instead of blanket disables
 - For unused variables in method signatures (e.g., base class methods to be overridden):

package/dist/logging/README.md

@@ -103,40 +103,92 @@ export async function handle({ event, resolve }) {
 ### Client-side logging (src/hooks.client.js)
 
 ```javascript
-import { createClientLogger } from '@hkdigital/lib-core/logging/index.js';
+import { initClientServices } from '$lib/services/client.js';
+import { getClientLogger } from '$lib/logging/client.js';
 
-const logger = createClientLogger('client');
+export async function init() {
+  // Init services
+  try {
+    await initClientServices();
+
+    getClientLogger().info('Client initialization complete');
+  } catch (error) {
+    getClientLogger().error('Client initialization failed', 
+      /** @type {Error} */ (error));
+    // throw error;
+  }
+  finally {
+    getClientLogger().info('Client application initialized', {
+      userAgent: navigator.userAgent,
+      viewport: `${window.innerWidth}x${window.innerHeight}`
+    });
+  }
+}
 
 /** @type {import('@sveltejs/kit').HandleClientError} */
 export function handleError({ error, event }) {
-  logger.error(error, { 
-    url: event.url?.pathname, 
-    userAgent: navigator.userAgent 
+  // Handle SvelteKit-specific errors:
+  // navigation errors, load function failures, component errors, ...
+  getClientLogger().error(/** @type {Error} */ (error), {
+    url: event.url?.pathname,
+    userAgent: navigator.userAgent
   });
 }
+```
 
-// Initialize client-side logging
-export function init() {
-  logger.info('Client application initialized', {
-    userAgent: navigator.userAgent,
-    viewport: `${window.innerWidth}x${window.innerHeight}`
-  });
-  
-  // Log unhandled errors
-  window.addEventListener('error', (event) => {
-    logger.error(event, { url: window.location.pathname });
-  });
-  
-  // Log unhandled promise rejections
-  window.addEventListener('unhandledrejection', (event) => {
-    logger.error(event, { url: window.location.pathname });
-  });
+### Client Service Integration
+
+When integrating with a service management system, you can set up global 
+error handling and forward service logs to the main logger:
+
+```javascript
+import { ServiceManager } from '$hklib-core/services/index.js';
+import { initClientLogger } from '$lib/logging/client.js';
+
+/** @type {ServiceManager} */
+let manager;
+
+export async function initClientServices() {
+  if (!manager) {
+    const logger = initClientLogger();
+
+    // Catch errors and unhandled promise rejections
+    
+    // Log unhandled errors
+    window.addEventListener('error', (event) => {
+      logger.error(event, { url: window.location.pathname });
+      event.preventDefault();
+    });
+
+    // Log unhandled promise rejections
+    window.addEventListener('unhandledrejection', (event) => {
+      logger.error(event, { url: window.location.pathname });
+      // Ignored by Firefox
+      event.preventDefault();
+    });
+
+    manager = new ServiceManager({ debug: true });
+
+    // Listen to all log events and forward them to the logger
+    manager.onLogEvent((logEvent) => {
+      logger.logFromEvent(logEvent);
+    });
+
+    // Register services
+    manager.register(SERVICE_AUDIO, AudioService);
+    manager.register(SERVICE_EVENT_LOG, EventLogService);
+    manager.register(SERVICE_PLAYER_DATA, PlayerDataService);
+  }
+
+  await manager.startAll();
+  return manager;
 }
 
-// Cleanup when app is destroyed
-export function destroy() {
-  logger.info('Client application destroyed');
-  // Note: Console adapter doesn't require cleanup
+export function getManager() {
+  if (!manager) {
+    throw new Error('Client services should be initialised first');
+  }
+  return manager;
 }
 ```
 

package/dist/logging/internal/adapters/console.js

@@ -212,7 +212,9 @@ export class ConsoleAdapter {
           message: details.message,
           stack: cleanedStack,
           errorType: formatErrorDisplay(errorMeta),
-          ...(relevantFrameIndex >= 0 && { relevantFrameIndex })
+          ...(relevantFrameIndex >= 0 && { relevantFrameIndex }),
+          ...('details' in details && { details: details.details }),
+          ...('status' in details && { status: details.status })
         };
       }
     } else if (details.error instanceof Error) {
@@ -233,7 +235,9 @@ export class ConsoleAdapter {
           message: details.error.message,
           stack: cleanedStack,
           errorType: formatErrorDisplay(errorMeta),
-          ...(relevantFrameIndex >= 0 && { relevantFrameIndex })
+          ...(relevantFrameIndex >= 0 && { relevantFrameIndex }),
+          ...('details' in details.error && { details: details.error.details }),
+          ...('status' in details.error && { status: details.error.status })
         };
       }
       // Include other details except the error
@@ -377,8 +381,22 @@ export class ConsoleAdapter {
         'node_modules/vite-deps'
       );
 
+      // Clean up pnpm paths - convert complex pnpm paths to simple package names
+      // Before: node_modules/.pnpm/@hkdigital+lib-core@0.4.35_@eslint+js@9.35.0_.../node_modules/@hkdigital/lib-core/dist/...
+      // After: @hkdigital/lib-core/dist/...
+      cleaned = cleaned.replace(
+        /node_modules\/\.pnpm\/([^\/]+)@[^_]+[^\/]*\/node_modules\/([^\/]+(?:\/[^\/]+)?)\//g,
+        '$2/'
+      );
+
+      // Clean up regular node_modules paths for known HK packages
+      cleaned = cleaned.replace(
+        /node_modules\/@hkdigital\/([^\/]+)\//g,
+        '@hkdigital/$1/'
+      );
+
       // Clean up query parameters on source files
-      cleaned = cleaned.replace(/\?t=\d+/g, '');
+      cleaned = cleaned.replace(/\?[tv]=[a-f0-9]+/g, '');
 
       // Skip vite-deps (Svelte framework internals) but keep other node_modules
       if (cleaned.includes('node_modules/vite-deps')) {

package/dist/logging/internal/adapters/formatting.js

@@ -404,8 +404,6 @@ export function isMeaningfulFunctionName(functionName) {
   if (
     !functionName ||
     functionName === '' ||
-    functionName.includes('<') ||
-    functionName.includes('/') ||
     functionName.startsWith('async ') ||
     functionName === 'async' ||
     functionName === 'Promise' ||
@@ -416,6 +414,13 @@ export function isMeaningfulFunctionName(functionName) {
     return false;
   }
 
+  // Skip pure anonymous functions (just '<' without a parent function name)
+  if (functionName === '<' || functionName === '</') {
+    return false;
+  }
+
+  // Allow function names that contain '/<' (anonymous functions within named functions)
+  // These are meaningful as they show "parentFunction/<anonymous>"
   return true;
 }
 
@@ -429,17 +434,35 @@ export function parseFunctionName(frame) {
   // Handle both Firefox format: "functionName@file:line:col"
   // and Node.js format: "at functionName (file:line:col)" or "at Module.functionName (file:line:col)"
 
+  let functionName = null;
+
   // Firefox format
   const firefoxMatch = frame.match(/^([^@]+)@/);
   if (firefoxMatch) {
-    return firefoxMatch[1];
+    functionName = firefoxMatch[1];
+  } else {
+    // Node.js format
+    const nodeMatch = frame.match(/^\s*at\s+(?:Module\.)?([^\s(]+)/);
+    if (nodeMatch) {
+      functionName = nodeMatch[1];
+    }
   }
 
-  // Node.js format
-  const nodeMatch = frame.match(/^\s*at\s+(?:Module\.)?([^\s(]+)/);
-  if (nodeMatch) {
-    return nodeMatch[1];
+  if (!functionName) {
+    return null;
   }
 
-  return null;
+  // Clean up common patterns
+  functionName = functionName.trim();
+
+  // Handle anonymous functions within named functions
+  // Convert "functionName/<" to "functionName (anonymous)"
+  if (functionName.endsWith('/<')) {
+    const baseName = functionName.slice(0, -2);
+    if (baseName) {
+      functionName = `${baseName} (anonymous)`;
+    }
+  }
+
+  return functionName;
 }

package/dist/logging/internal/logger/Logger.js

@@ -200,6 +200,10 @@ export default class Logger extends EventEmitter {
       // Log without message
       return this.#log(ERROR, errorObject.message, errorObject);
     }
+    // else if( message ) {
+    //   // Only log message, no Error object supplied
+    //   return this.#log(ERROR, message);
+    // }
     else {
       // Missing error like object
       // => invalid parameters supplied to logger.error

package/dist/services/service-manager/ServiceManager.js

@@ -66,8 +66,8 @@
 import { EventEmitter } from '../../generic/events.js';
 import { Logger, DEBUG, INFO } from '../../logging/index.js';
 
-import { 
-  SERVICE_LOG, 
+import {
+  SERVICE_LOG,
   STATE_CHANGED,
   HEALTH_CHANGED,
   ERROR,
@@ -298,9 +298,10 @@ export class ServiceManager extends EventEmitter {
         this.logger.debug(`Starting dependency '${dep}' for '${name}'`);
 
         const started = await this.startService(dep);
+
         if (!started) {
           this.logger.error(
-            `Failed to start dependency '${dep}' for '${name}'`
+            new Error(`Failed to start dependency '${dep}' for '${name}'`)
           );
           return false;
         }
@@ -396,14 +397,7 @@ export class ServiceManager extends EventEmitter {
       results.set(name, success);
 
       if (!success) {
-        this.logger.error(`Failed to start '${name}', stopping`);
-        // Mark remaining services as not started
-        for (const remaining of sorted) {
-          if (!results.has(remaining)) {
-            results.set(remaining, false);
-          }
-        }
-        break;
+        throw new Error(`Failed to start service [${name}], stopping`);
       }
     }
 
@@ -430,7 +424,7 @@ export class ServiceManager extends EventEmitter {
     const results = new Map();
 
     // Handle global timeout if specified
-    if (stopOptions.timeout > 0) {
+    if (stopOptions.timeout) {
       const timeoutPromise = new Promise((_, reject) =>
         setTimeout(
           () => reject(new Error('Global shutdown timeout')),
@@ -445,8 +439,10 @@ export class ServiceManager extends EventEmitter {
           timeoutPromise
         ]);
       } catch (error) {
-        if (error.message === 'Global shutdown timeout') {
-          this.logger.error('Global shutdown timeout reached');
+        if (
+          /** @type {Error} */ (error).message === 'Global shutdown timeout'
+        ) {
+          this.logger.error( new Error('Global shutdown timeout reached' ) );
           // Mark any remaining services as failed
           for (const name of sorted) {
             if (!results.has(name)) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@hkdigital/lib-core",
-	"version": "0.4.34",
+	"version": "0.4.36",
 	"author": {
 		"name": "HKdigital",
 		"url": "https://hkdigital.nl"
@@ -27,6 +27,7 @@
 		"format": "prettier --write .",
 		"lint": "run-s lint:*",
 		"test": "run-s test:unit-run",
+		"test:file": "vitest run",
 		"prepack": "run-s prepack:*",
 		"publish:npm": "run-s publish:npm:version publish:npm:publish git:push",
 		"upgrade:hk": "run-s upgrade:hk:update pnpm:install",