@hkdigital/lib-core 0.3.7 → 0.3.9

package/dist/logging/internal/adapters/pino.js

@@ -15,32 +15,44 @@ export class PinoAdapter {
    * @param {Object} [options] - Pino configuration options
    */
   constructor(options = {}) {
-    const defaultOptions = dev
-      ? {
-          level: 'debug',
-          serializers: {
-            err: (err) => {
-              const chain = [];
-              let current = err;
-              let isFirst = true;
+    const baseOptions = {
+      serializers: {
+        err: (err) => {
+          const chain = [];
+          let current = err;
+          let isFirst = true;
 
-              while (current) {
-                const serialized = {
-                  name: current.name,
-                  message: current.message,
-                  ...(isFirst &&
-                    this.pino.level === 'debug' && {
-                      stack: current.stack
-                    })
-                };
-                chain.push(serialized);
-                current = current.cause;
-                isFirst = false;
-              }
+          while (current) {
+            const serialized = {
+              name: current.name,
+              message: current.message,
+              ...(isFirst &&
+                this.pino.level === 'debug' && {
+                  stack: current.stack
+                })
+            };
 
-              return { errorChain: chain };
+            // Include HttpError-specific properties
+            if (current.status !== undefined) {
+              serialized.status = current.status;
             }
-          },
+            if (current.details !== undefined) {
+              serialized.details = current.details;
+            }
+
+            chain.push(serialized);
+            current = current.cause;
+            isFirst = false;
+          }
+
+          return { errorChain: chain };
+        }
+      }
+    };
+
+    const devOptions = dev
+      ? {
+          level: 'debug',
           transport: {
             target: 'pino-pretty',
             options: {
@@ -50,7 +62,7 @@ export class PinoAdapter {
         }
       : {};
 
-    this.pino = pino({ ...defaultOptions, ...options });
+    this.pino = pino({ ...baseOptions, ...devOptions, ...options });
   }
 
   /**
@@ -63,10 +75,28 @@ export class PinoAdapter {
 
     const logData = {
       source,
-      timestamp,
-      ...(details && { details })
+      timestamp
     };
 
+    // Check if details contains an error and promote it to err property for pino serializer
+    if (details) {
+      if (details instanceof Error) {
+        // details is directly an error
+        logData.err = details;
+      } else if (details.error instanceof Error) {
+        // details has an error property
+        logData.err = details.error;
+        // Include other details except the error
+        const { error, ...otherDetails } = details;
+        if (Object.keys(otherDetails).length > 0) {
+          logData.details = otherDetails;
+        }
+      } else {
+        // No error found in details, include all details
+        logData.details = details;
+      }
+    }
+
     this.pino[level](logData, message);
   }
 

package/dist/util/http/response.js

@@ -1,4 +1,4 @@
-import { ResponseError } from '../../errors/index.js';
+import { ResponseError, HttpError } from '../../errors/index.js';
 import * as expect from '../expect/index.js';
 import { toURL } from './url.js';
 
@@ -155,11 +155,35 @@ export async function waitForAndCheckResponse(responsePromise, url) {
     response = await responsePromise;
 
     if (response && false === response.ok) {
-      // if response.ok is false, it also indicates a network error
-      throw new Error(`Response failed [response.ok=false]`);
+      // Check if this is a network error (status 0) vs HTTP error
+      if (response.status === 0) {
+        // Network error - treat as before
+        throw new Error(`Response failed [response.ok=false]`);
+      }
+      
+      // HTTP error - get response body for detailed error information
+      const responseBody = await response.text();
+      let errorDetails;
+
+      try {
+        // Try to parse as JSON (common for API errors)
+        errorDetails = JSON.parse(responseBody);
+      } catch {
+        // Fallback to plain text
+        errorDetails = responseBody;
+      }
+
+      throw new HttpError(
+        response.status,
+        `HTTP ${response.status}: ${response.statusText}`,
+        errorDetails
+      );
     }
   } catch (e) {
-    if (e instanceof TypeError || response?.ok === false) {
+    if (e instanceof HttpError) {
+      // Re-throw HttpError as-is
+      throw e;
+    } else if (e instanceof TypeError || response?.ok === false) {
       throw new ResponseError(
         `A network error occurred for request [${href(url)}]`,
         {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@hkdigital/lib-core",
-	"version": "0.3.7",
+	"version": "0.3.9",
 	"author": {
 		"name": "HKdigital",
 		"url": "https://hkdigital.nl"