@hitchy/plugin-auth 0.2.0 → 0.3.0

package/.gitlab-ci.yml

@@ -7,40 +7,61 @@ cache:
   paths:
     - .npm
 
-.common-install: &common-install
-  before_script:
-    - npm ci --cache .npm --prefer-offline
 
-alpine-lts:
-  <<: *common-install
+.common-test: &common-test
   stage: test
-  image: "node:lts-alpine"
   script:
+    - npm i -g npm
+    - node -v
+    - npm -v
+    - npm ci --cache .npm --prefer-offline
     - npm run lint
     - npm run test
 
+
+alpine-current:
+  image: "node:current-alpine"
+  <<: *common-test
+
+alpine-lts:
+  image: "node:lts-alpine"
+  <<: *common-test
+
+alpine-old:
+  image: "node:erbium-alpine"
+  <<: *common-test
+  allow_failure: true
+
+alpine-legacy:
+  image: "node:fermium-alpine"
+  <<: *common-test
+  allow_failure: true
+
+debian-current:
+  image: "node:current"
+  <<: *common-test
+
 debian-lts:
-  <<: *common-install
-  stage: test
-  image: "node:lts-buster"
-  script:
-    - npm run lint
-    - npm run test
+  image: "node:lts"
+  <<: *common-test
+
+debian-old:
+  image: "node:erbium"
+  <<: *common-test
+  allow_failure: true
+
+debian-legacy:
+  image: "node:fermium"
+  <<: *common-test
+  allow_failure: true
 
-alpine-12:
-  <<: *common-install
-  stage: test
-  image: "node:12-alpine"
-  script:
-    - npm run lint
-    - npm run test
 
 pages:
-  <<: *common-install
   stage: deploy
   image: node:lts-alpine
   script:
-    - npm run doc:build
+    - npm ci --cache .npm --prefer-offline
+    - npm run docs:build
   artifacts:
     paths:
       - public

package/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2022 cepharum GmbH
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/api/controller/user.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 module.exports = function() {
@@ -91,7 +63,8 @@ module.exports = function() {
 						authenticated: req.user ? {
 							uuid: req.user.uuid,
 							name: req.user.name,
-							roles: req.user.roles,
+							strategy: req.user.strategy || "local",
+							roles: req.user.roles.map( role => role.name ),
 						} : false,
 					} );
 				},

package/api/model/authorization/rule.js

@@ -1,30 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
 "use strict";
 
 module.exports = function() {

package/api/model/role.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 /**

package/api/model/user-to-role.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 /**

package/api/model/user.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 const crypto = require( "crypto" );
@@ -46,7 +18,7 @@ module.exports = function() {
 	 * @property {string} role name of user's role (user-role relationship is 1:n)
 	 * @property {string} password hash of user's password required for authenticating as
 	 * @property {string} strategy name of passport strategy used for authentication
-	 * @property {string} provider additional information specific to strategy used
+	 * @property {string} strategyData additional information specific to strategy used
 	 *
 	 * @name Hitchy.Plugin.Auth.User
 	 */
@@ -58,7 +30,7 @@ module.exports = function() {
 			},
 			password: {},
 			strategy: {},
-			provider: {},
+			strategyData: {},
 		},
 		hooks: {
 			afterValidate( errors ) {

package/api/policy/authentication.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 module.exports = function() {
@@ -91,37 +63,50 @@ module.exports = function() {
 			const { AuthenticationStrategies, AuthenticationPassport, AuthManager } = service;
 			const defaultStrategy = AuthenticationStrategies.defaultStrategy();
 
-			req.fetchBody().then( body => {
-				req.body = body; // eslint-disable-line no-param-reassign
+			req.fetchBody()
+				.then( body => {
+					req.body = body; // eslint-disable-line no-param-reassign
 
-				AuthenticationPassport.authenticate( strategy || defaultStrategy )( req, res, err => {
-					if ( err ) {
-						AlertLog( err );
-						AuthenticationPolicy.logout( req, res, () => { next( err ); } );
-					} else if ( req.user ) {
-						const { uuid, name } = req.user;
+					return new Promise( ( resolve, reject ) => {
+						AuthenticationPassport.authenticate( strategy || defaultStrategy )( req, res, err => {
+							if ( err ) {
+								reject( err );
+								return;
+							}
 
-						return AuthManager.listRolesOfUser( new model.User( uuid ) )
-							.then( roles => {
-								req.user.roles = roles; // eslint-disable-line no-param-reassign
+							if ( req.user ) {
+								const { uuid, name } = req.user;
 
-								DebugLog( "authenticated as", req.user.name );
+								AuthManager.listRolesOfUser( new model.User( uuid ) )
+									.then( roles => {
+										req.user.roles = roles; // eslint-disable-line no-param-reassign
 
-								res.set( "X-Authenticated-As", name );
-								res.set( "X-Authorized-As", roles.join( "," ) );
+										DebugLog( "authenticated as", req.user.name );
 
-								next();
-							} );
-					} else {
-						AuthenticationPolicy.logout( req, res, next );
-					}
+										res.set( "X-Authenticated-As", name );
+										res.set( "X-Authorized-As", roles.join( "," ) );
 
-					return undefined;
+										resolve();
+									} )
+									.catch( reject );
+							} else {
+								AuthenticationPolicy.logout( req, res, cause => ( cause ? reject( cause ) : resolve() ) );
+							}
+						} );
+					} );
+				} )
+				.then( next )
+				.catch( err => {
+					AlertLog( err );
+
+					AuthenticationPolicy.logout( req, res, cause => {
+						if ( cause ) {
+							AlertLog( `applying logout policy after failed login has caused another issue: ${cause.stack}` );
+						}
+
+						next( err );
+					} );
 				} );
-			} ).catch( err => {
-				AlertLog( err );
-				AuthenticationPolicy.logout( req, res, () => next( err ) );
-			} );
 		}
 
 		/**
@@ -133,21 +118,39 @@ module.exports = function() {
 		 * @returns {void}
 		 */
 		static logout( req, res, next ) {
-			try {
-				if ( typeof req.logout === "function" ) {
-					req.logout();
-				}
+			Promise.resolve()
+				.then( () => {
+					// (optional) log out remotely using current user's authentication strategy
+					if ( req.user ) {
+						const strategyName = req.user.strategy;
+
+						if ( strategyName ) {
+							const strategy = api.config.auth.strategies[strategyName];
+
+							if ( strategy && typeof strategy.logOutRemotely === "function" ) {
+								return strategy.logOutRemotely( req );
+							}
+						}
+					}
+
+					return undefined;
+				} )
+				.then( async willLogoutInFuture => {
+					if ( !willLogoutInFuture ) {
+						if ( typeof req.logout === "function" ) {
+							await req.logout();
+						}
 
-				req.session.drop();
-				req.user = undefined; // eslint-disable-line no-param-reassign
+						req.session.drop();
+						req.user = undefined; // eslint-disable-line no-param-reassign
 
-				res.set( "X-Authenticated-As", undefined );
-				res.set( "X-Authorized-As", undefined );
+						res.set( "X-Authenticated-As", undefined );
+						res.set( "X-Authorized-As", undefined );
 
-				next();
-			} catch ( e ) {
-				next( e );
-			}
+						next();
+					}
+				} )
+				.catch( next );
 		}
 
 		/**

package/api/policy/authorization.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 module.exports = function() {

package/api/policy/user.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 module.exports = function() {

package/api/service/auth/manager.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 module.exports = function() {
@@ -89,6 +61,15 @@ module.exports = function() {
 			}
 
 			const { Role } = models;
+
+			if ( !( role instanceof Role ) ) {
+				role = String( role ); // eslint-disable-line no-param-reassign
+
+				if ( !/^[a-z_]/i.test( role ) || /\s/.test( role ) ) {
+					throw new TypeError( "missing role information" );
+				}
+			}
+
 			const roles = role instanceof Role ? [role] : await Role.find( {
 				eq: { name: "name", value: role.name || role },
 			} );

package/api/service/authentication/passport.js

@@ -1,31 +1,3 @@
-/**
- * (c) 2021 cepharum GmbH, Berlin, http://cepharum.de
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2021 cepharum GmbH
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * @author: cepharum
- */
-
 "use strict";
 
 const PassportLib = require( "passport" );
@@ -86,7 +58,7 @@ module.exports = function() {
 
 			if ( strategy ) {
 				try {
-					passport.use( strategy.name, strategy );
+					passport.use( name, strategy );
 				} catch ( error ) {
 					AlertLog( `using passport strategy ${name} failed:`, error );
 				}