@hippo-digital/hippocampus 1.0.0-rc.3 → 1.0.0-rc.4

package/CHANGELOG.md

@@ -56,6 +56,11 @@ journeys and screens they justify, rendered as a viewer inside your prototype.
   into `.github/skills` and every skill names its `owners` by agent, so either
   half alone is a set of dangling references. `--no-agents` installs the skills
   only.
+- A file that already exists in the host and was not written by this command is
+  left exactly as it is and named in the output. Only files it had written
+  before were protected previously, which is backwards for the first install
+  into a repo that already has its own agents - the repo most likely to have
+  some. `--force` still overwrites, and now says what that would cost.
 - Everything the agents and skills reference that is not a repo file is read
   from the installed package, so those references are version-matched too.
 - `skills validate` checks both directions between skills and agents: a skill

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hippo-digital/hippocampus",
-  "version": "1.0.0-rc.3",
+  "version": "1.0.0-rc.4",
   "description": "A design-knowledge base for NHS Prototype Kit projects: research, insights, needs, journeys and screens, traceable end to end.",
   "license": "MIT",
   "main": "index.js",

package/scripts/install-skills.js

@@ -61,6 +61,7 @@ function main () {
   const trees = TREES.filter((tree) => tree.key === 'files' || withAgents)
   let wroteAnything = false
   let anySkipped = false
+  let anyForeign = false
 
   for (const tree of trees) {
     manifest[tree.key] = manifest[tree.key] || {}
@@ -79,6 +80,11 @@ function main () {
       console.log(`  left alone because they have been edited here (${result.skipped.length}):`)
       for (const name of result.skipped) console.log(`    ${name}`)
     }
+    if (result.foreign.length) {
+      anyForeign = true
+      console.log(`  already yours, not written (${result.foreign.length}):`)
+      for (const name of result.foreign) console.log(`    ${name}`)
+    }
 
     if (tree.key === 'files') {
       const merged = mergeCatalog(skillsTarget, manifest)
@@ -99,6 +105,12 @@ function main () {
     console.log('Re-install edited files with --force once you have kept whatever you changed.\n')
   }
 
+  if (anyForeign) {
+    console.log('The files listed as already yours share a name with ours but were not')
+    console.log('written by this command, so they have been left exactly as they are.')
+    console.log('`--force` would overwrite them - copy anything you want to keep first.\n')
+  }
+
   if (!dryRun && wroteAnything) {
     manifest.version = require('../package.json').version
     manifest.updatedAt = new Date().toISOString()
@@ -118,6 +130,7 @@ function installTree (sourceDir, targetDir, manifestFiles) {
   const skipped = []
   const unchanged = []
   const kept = []
+  const foreign = []
 
   for (const name of fs.readdirSync(sourceDir)) {
     if (name === 'skills.json' || !/\.(skill\.md|md|json)$/.test(name)) continue
@@ -131,6 +144,14 @@ function installTree (sourceDir, targetDir, manifestFiles) {
       if (current === incoming) { unchanged.push(name); continue }
       if (NEVER_OVERWRITE.has(name)) { kept.push(name); continue }
       const installed = manifestFiles[name]
+
+      // A file we have no record of writing is the host's, not a stale copy of
+      // ours that happens to share a name. The hash check above only ever
+      // protected files we had written before, which is backwards for the case
+      // that matters: the FIRST install into a repo that already has its own
+      // agents. Getting this wrong overwrites work nobody had a copy of.
+      if (!installed && !force) { foreign.push(name); continue }
+
       if (installed && current !== installed && !force) { skipped.push(name); continue }
     }
 
@@ -142,7 +163,7 @@ function installTree (sourceDir, targetDir, manifestFiles) {
     manifestFiles[name] = incoming
   }
 
-  return { written, skipped, unchanged, kept }
+  return { written, skipped, unchanged, kept, foreign }
 }
 
 /**