@hilbras/omninode 0.6.0 → 0.7.0

package/README.md

@@ -18,7 +18,7 @@ existing intelligence; it does not try to become another model.
 
 ## Status
 
-**v0.6.0 — Phase 5: Pipeline Engine** (see [docs/DEVELOPMENT_PLAN.md](docs/DEVELOPMENT_PLAN.md)
+**v0.7.0 — Phase 6: Multi-AI Report System** (see [docs/DEVELOPMENT_PLAN.md](docs/DEVELOPMENT_PLAN.md)
 for the full plan and roadmap).
 
 What exists today:
@@ -66,6 +66,14 @@ What exists today:
   - Failure handling: retries per step, `on-success`/`on-failure`/`always`
     conditions, combined context threaded downstream; every task runs through
     the TaskEngine and every run is persisted to `.omninode/pipelines.json`
+- **Multi-AI report system** (`src/reports/`):
+  - Report collection from finished tasks — structured protocol reports pass
+    through; plain text output is normalized via deterministic extraction
+    (findings/recommendations/evidence sections, severity guessing)
+  - Persistence in `.omninode/reports.json` with full source attribution
+  - Aggregation (§17): duplicate/similar findings merged via deterministic
+    token-set similarity, sources preserved, highest severity kept
+  - Combined reports generated automatically at the end of every pipeline run
 - Typed error hierarchy (`src/errors/`)
 - Leveled logger with pluggable sink (`src/logger/`)
 - Configuration system: `omninode.yaml` with `${ENV_VAR}` expansion and strict
@@ -144,6 +152,8 @@ project:
 
 ```bash
 omninode pipeline run repo-audit "Audit the authentication module"
+omninode report combined          # the aggregated intelligence of that run
+omninode report show combined-xxx # grouped findings with per-source attribution
 ```
 
 See [omninode.yaml.example](omninode.yaml.example) for a full configuration.
@@ -180,8 +190,7 @@ Phases 0–11 are laid out in [docs/DEVELOPMENT_PLAN.md](docs/DEVELOPMENT_PLAN.m
 | v0.3.0 | OmniHilbras Integration (optional, like every provider) |
 | v0.4.0 | Agent System |
 | v0.5.0 | Roles & Tasks |
-| **v0.6.0** | **Pipeline Engine (current)** |
-| v0.7.0 | Multi-AI Reports |
+| **v0.7.0** | **Multi-AI Reports (current)** |
 | v0.8.0 | Remembera (optional memory integration) |
 | v0.9.0 | Planner |
 | v0.10.0 | End-to-End Runtime |

package/dist/cli/index.js

@@ -6,7 +6,7 @@ import { realpathSync } from "fs";
 import { Command } from "commander";
 
 // src/version.ts
-var OMNINODE_VERSION = "0.6.0";
+var OMNINODE_VERSION = "0.7.0";
 
 // src/errors/index.ts
 var OmniNodeError = class extends Error {
@@ -675,6 +675,9 @@ function notImplemented(command, when) {
     `${command} is planned for ${when}. Edit omninode.yaml directly for now.`
   );
 }
+function truncate(text, max) {
+  return text.length > max ? `${text.slice(0, max - 1)}\u2026` : text;
+}
 function appendToConfigList(listKey, item) {
   const configPath = findConfigFile();
   if (!configPath) {
@@ -1404,6 +1407,8 @@ var TaskEngine = class {
     const result = {
       ...output.summary !== void 0 ? { summary: output.summary } : {},
       ...output.reports !== void 0 && output.reports.length > 0 ? { reports: output.reports } : {},
+      // Keep the verbatim output (bounded) for report extraction and audit.
+      ...output.rawOutput !== void 0 && output.rawOutput.length > 0 ? { rawOutput: output.rawOutput.slice(0, 1e4) } : {},
       ...output.error !== void 0 ? { error: output.error } : {},
       finishedAt: (/* @__PURE__ */ new Date()).toISOString()
     };
@@ -1538,7 +1543,7 @@ function registerTaskCommands(program) {
       return;
     }
     for (const t of tasks) {
-      console.log(`${t.id}  ${t.status.padEnd(10)} ${truncate(t.objective, 60)}`);
+      console.log(`${t.id}  ${t.status.padEnd(10)} ${truncate2(t.objective, 60)}`);
     }
   });
   task.command("cancel <task-id>").description("Cancel a task that has not finished yet.").action(async (taskId) => {
@@ -1568,20 +1573,392 @@ function printOutcome(task, options = {}) {
   if (result.error) console.log(`  error:   ${result.error}`);
   if (result.finishedAt) console.log(`  ended:   ${result.finishedAt}`);
 }
-function truncate(text, max) {
+function truncate2(text, max) {
+  return text.length > max ? `${text.slice(0, max - 1)}\u2026` : text;
+}
+
+// src/reports/aggregate.ts
+import { randomBytes as randomBytes2 } from "crypto";
+var SEVERITY_RANK = {
+  info: 0,
+  low: 1,
+  medium: 2,
+  high: 3,
+  critical: 4
+};
+function aggregateReports(reports, options = {}) {
+  const threshold = options.similarityThreshold ?? 0.7;
+  const findingGroups = [];
+  const recommendationGroups = [];
+  for (const report of reports) {
+    for (const finding of report.findings) {
+      mergeFinding(findingGroups, finding, report, threshold);
+    }
+    for (const text of report.recommendations) {
+      mergeRecommendation(recommendationGroups, text, report, threshold);
+    }
+  }
+  const sources = [...new Set(reports.map((r) => r.agent))].sort();
+  const totalRawFindings = reports.reduce((sum, r) => sum + r.findings.length, 0);
+  const summary = `${reports.length} report(s) from ${sources.length > 0 ? sources.join(", ") : "no agents"}: ${findingGroups.length} unique finding group(s) (${totalRawFindings} raw), ${recommendationGroups.length} recommendation group(s).`;
+  return {
+    id: `combined-${Date.now().toString(36)}-${randomBytes2(3).toString("hex")}`,
+    title: options.objective !== void 0 ? truncate3(options.objective, 120) : "Combined report",
+    ...options.objective !== void 0 ? { objective: options.objective } : {},
+    ...options.pipelineRunId !== void 0 ? { pipelineRunId: options.pipelineRunId } : {},
+    taskIds: options.taskIds ?? [],
+    summary,
+    findings: findingGroups.sort((a, b) => rank(b) - rank(a)),
+    recommendations: recommendationGroups,
+    sources,
+    reportIds: reports.map((r) => r.id),
+    createdAt: (/* @__PURE__ */ new Date()).toISOString()
+  };
+}
+function rank(finding) {
+  return finding.severity ? SEVERITY_RANK[finding.severity] : -1;
+}
+function mergeFinding(groups, finding, report, threshold) {
+  const source = { agent: report.agent, reportId: report.id };
+  const group = groups.find((g) => similar(g.title, finding.title, threshold));
+  if (group) {
+    group.occurrences += 1;
+    group.details.push(finding.detail);
+    group.sources.push(source);
+    group.evidence.push(...finding.evidence ?? []);
+    if (finding.severity && (!group.severity || SEVERITY_RANK[finding.severity] > SEVERITY_RANK[group.severity])) {
+      group.severity = finding.severity;
+    }
+    return;
+  }
+  groups.push({
+    title: finding.title,
+    details: [finding.detail],
+    sources: [source],
+    occurrences: 1,
+    ...finding.severity ? { severity: finding.severity } : {},
+    evidence: [...finding.evidence ?? []]
+  });
+}
+function mergeRecommendation(groups, text, report, threshold) {
+  const source = { agent: report.agent, reportId: report.id };
+  const group = groups.find((g) => similar(g.text, text, threshold));
+  if (group) {
+    group.occurrences += 1;
+    group.sources.push(source);
+    return;
+  }
+  groups.push({ text, sources: [source], occurrences: 1 });
+}
+function similar(a, b, threshold) {
+  const left = tokens(a);
+  const right = tokens(b);
+  if (left.size === 0 || right.size === 0) return false;
+  let intersection = 0;
+  for (const token of left) {
+    if (right.has(token)) intersection += 1;
+  }
+  const union = left.size + right.size - intersection;
+  return intersection / union >= threshold;
+}
+function tokens(text) {
+  return new Set(
+    text.toLowerCase().replace(/[^a-z0-9\s]/g, " ").split(/\s+/).filter((t) => t.length >= 3)
+  );
+}
+function truncate3(text, max) {
+  return text.length > max ? `${text.slice(0, max - 1)}\u2026` : text;
+}
+
+// src/reports/extract.ts
+var BULLET = /^(?:[-*•]|\d+[.)])\s+(.*)$/;
+function parseSections(raw) {
+  const sections = [];
+  let current = { heading: "", bullets: [] };
+  for (const line of raw.split("\n")) {
+    const heading = /^(#{1,6})\s+(.*)$/.exec(line.trim());
+    if (heading) {
+      if (current.heading.length > 0 || current.bullets.length > 0) {
+        sections.push(current);
+      }
+      current = { heading: heading[2]?.toLowerCase() ?? "", bullets: [] };
+      continue;
+    }
+    const bullet = BULLET.exec(line.trim());
+    if (bullet && current.heading.length > 0) {
+      current.bullets.push(bullet[1]?.trim() ?? "");
+    }
+  }
+  if (current.heading.length > 0 || current.bullets.length > 0) {
+    sections.push(current);
+  }
+  return sections;
+}
+function collectBullets(sections, patterns) {
+  const matches = sections.filter((section) => patterns.some((p) => p.test(section.heading)));
+  return matches.flatMap((section) => section.bullets).filter((b) => b.length > 0);
+}
+function guessSeverity(text) {
+  if (/critical|severe/i.test(text)) return "critical";
+  if (/\bhigh\b|major/i.test(text)) return "high";
+  if (/medium|moderate/i.test(text)) return "medium";
+  if (/\blow\b|minor/i.test(text)) return "low";
+  return void 0;
+}
+function extractReportFromText(raw, meta) {
+  const trimmed = raw.trim();
+  const nonEmpty = trimmed.split("\n").map((line) => line.trim()).filter((line) => line.length > 0);
+  const proseLine = nonEmpty.find((line) => !line.startsWith("#") && !BULLET.test(line)) ?? nonEmpty[0] ?? "";
+  const cleaned = proseLine.replace(/^#{1,6}\s+/, "").replace(BULLET, "$1");
+  const summary = cleaned.length > 0 ? truncate4(cleaned, 200) : "(no output)";
+  const sections = parseSections(trimmed);
+  const findingTexts = collectBullets(sections, [/finding/, /issue/, /problem/, /vulnerab/]);
+  const recommendationTexts = collectBullets(sections, [/recommend/, /suggestion/, /next step/, /action/]);
+  const evidenceTexts = collectBullets(sections, [/evidence/, /proof/, /log/]);
+  const findings = findingTexts.map((text, index) => ({
+    id: `${meta.taskId}-f-${index + 1}`,
+    title: truncate4(text, 120),
+    detail: text,
+    severity: guessSeverity(text)
+  }));
+  return {
+    id: `${meta.taskId}-report`,
+    taskId: meta.taskId,
+    agent: meta.agent,
+    ...meta.model !== void 0 ? { model: meta.model } : {},
+    summary,
+    findings,
+    recommendations: recommendationTexts.map((t) => truncate4(t, 200)),
+    metadata: evidenceTexts.length > 0 ? { evidence: evidenceTexts } : void 0,
+    createdAt: (/* @__PURE__ */ new Date()).toISOString()
+  };
+}
+function truncate4(text, max) {
   return text.length > max ? `${text.slice(0, max - 1)}\u2026` : text;
 }
 
+// src/reports/service.ts
+var ReportService = class {
+  constructor(store, log = logger) {
+    this.store = store;
+    this.log = log.child({ component: "reports" });
+  }
+  store;
+  log;
+  get storeRef() {
+    return this.store;
+  }
+  /** Normalizes finished tasks into reports (§17 — normalizer). */
+  async collectFromTasks(tasks) {
+    const reports = [];
+    for (const task of tasks) {
+      const structured = task.result?.reports ?? [];
+      if (structured.length > 0) {
+        reports.push(...structured);
+        continue;
+      }
+      const text = task.result?.rawOutput ?? task.result?.summary ?? "";
+      if (text.trim().length === 0) continue;
+      reports.push(
+        extractReportFromText(text, {
+          taskId: task.id,
+          agent: task.agent ?? "unknown"
+        })
+      );
+    }
+    return reports;
+  }
+  async saveReports(reports) {
+    if (reports.length === 0) return;
+    await this.store.saveReports(reports);
+    this.log.info(`Stored ${reports.length} report(s).`);
+  }
+  async generateCombined(reports, meta = {}) {
+    if (reports.length === 0) return void 0;
+    const options = {
+      ...meta.objective !== void 0 ? { objective: meta.objective } : {},
+      ...meta.pipelineRunId !== void 0 ? { pipelineRunId: meta.pipelineRunId } : {},
+      ...meta.taskIds !== void 0 ? { taskIds: meta.taskIds } : {}
+    };
+    const combined = aggregateReports(reports, options);
+    await this.store.saveCombined(combined);
+    this.log.info(`Generated combined report ${combined.id}.`);
+    return combined;
+  }
+};
+
+// src/reports/store.ts
+import { mkdir as mkdir2, readFile as readFile2, rename as rename2, writeFile as writeFile2 } from "fs/promises";
+import { dirname as dirname2 } from "path";
+var FileReportStore = class {
+  filePath;
+  queue = Promise.resolve();
+  constructor(directory = `${process.cwd()}/.omninode`) {
+    this.filePath = `${directory}/reports.json`;
+  }
+  async saveReports(reports) {
+    return this.synchronized(async () => {
+      const entries = await this.load();
+      for (const report of reports) {
+        const index = entries.findIndex(
+          (e) => e.kind === "report" && e.report.id === report.id
+        );
+        const entry2 = { kind: "report", report };
+        if (index >= 0) entries[index] = entry2;
+        else entries.push(entry2);
+      }
+      await this.write(entries);
+    });
+  }
+  async listReports(filter = {}) {
+    return this.synchronized(async () => {
+      const entries = await this.load();
+      return entries.filter((e) => e.kind === "report").map((e) => e.report).filter((report) => filter.taskId ? report.taskId === filter.taskId : true).filter((report) => filter.agent ? report.agent === filter.agent : true).sort((a, b) => a.createdAt.localeCompare(b.createdAt));
+    });
+  }
+  async saveCombined(combined) {
+    return this.synchronized(async () => {
+      const entries = await this.load();
+      const index = entries.findIndex(
+        (e) => e.kind === "combined" && e.combined.id === combined.id
+      );
+      const entry2 = { kind: "combined", combined };
+      if (index >= 0) entries[index] = entry2;
+      else entries.push(entry2);
+      await this.write(entries);
+    });
+  }
+  async getCombined(id) {
+    return this.synchronized(async () => {
+      const entries = await this.load();
+      const found = entries.find((e) => e.kind === "combined" && e.combined.id === id);
+      return found?.kind === "combined" ? found.combined : void 0;
+    });
+  }
+  async listCombined(filter = {}) {
+    return this.synchronized(async () => {
+      const entries = await this.load();
+      return entries.filter((e) => e.kind === "combined").map((e) => e.combined).filter(
+        (combined) => filter.pipelineRunId ? combined.pipelineRunId === filter.pipelineRunId : true
+      ).sort((a, b) => a.createdAt.localeCompare(b.createdAt));
+    });
+  }
+  synchronized(operation) {
+    const result = this.queue.then(operation, operation);
+    this.queue = result.then(
+      () => void 0,
+      () => void 0
+    );
+    return result;
+  }
+  async load() {
+    try {
+      const raw = await readFile2(this.filePath, "utf8");
+      const parsed = JSON.parse(raw);
+      return Array.isArray(parsed) ? parsed : [];
+    } catch {
+      return [];
+    }
+  }
+  async write(entries) {
+    const tmp = `${this.filePath}.tmp`;
+    await mkdir2(dirname2(this.filePath), { recursive: true });
+    await writeFile2(tmp, `${JSON.stringify(entries, null, 2)}
+`, "utf8");
+    await rename2(tmp, this.filePath);
+  }
+};
+
 // src/cli/commands/reports.ts
+function service() {
+  return new ReportService(new FileReportStore());
+}
 function registerReportCommands(program) {
-  const report = program.command("report").description("Inspect AI reports (Phase 6+).");
-  report.command("list").description("List collected reports (planned for Phase 6 \u2014 Multi-AI Report System).").action(() => {
-    throw notImplemented("omninode report list", "Phase 6 (Multi-AI Report System)");
+  const report = program.command("report").description("Inspect AI reports collected from tasks and pipelines (\xA716\u2013\xA717).");
+  report.command("list").description("List stored reports.").option("--task <taskId>", "Only reports for this task.").option("--agent <name>", "Only reports from this agent.").action(async (options) => {
+    const svc = service();
+    const reports = await svc.storeRef.listReports({
+      ...options.task !== void 0 ? { taskId: options.task } : {},
+      ...options.agent !== void 0 ? { agent: options.agent } : {}
+    });
+    if (reports.length === 0) {
+      console.log("No reports stored yet. Run a pipeline to collect some.");
+      return;
+    }
+    for (const r of reports) {
+      console.log(`${r.id}  ${r.agent.padEnd(10)} ${truncate(r.summary, 60)}`);
+    }
+  });
+  report.command("combined").description("List combined reports (aggregated intelligence, \xA717).").option("--run <pipelineRunId>", "Only combined reports for this pipeline run.").action(async (options) => {
+    const svc = service();
+    const combined = await svc.storeRef.listCombined({
+      ...options.run !== void 0 ? { pipelineRunId: options.run } : {}
+    });
+    if (combined.length === 0) {
+      console.log("No combined reports stored yet. Run a pipeline to generate one.");
+      return;
+    }
+    for (const c of combined) {
+      console.log(
+        `${c.id}  ${c.findings.length} finding(s) from ${c.sources.length} source(s)${c.pipelineRunId ? `  run=${c.pipelineRunId}` : ""}`
+      );
+    }
+  });
+  report.command("show <id>").description("Show a stored report or combined report in full.").action(async (id) => {
+    const svc = service();
+    const reports = await svc.storeRef.listReports();
+    const raw = reports.find((r) => r.id === id);
+    if (raw) {
+      console.log(`Report ${raw.id}`);
+      console.log(`  agent:     ${raw.agent}${raw.model ? ` (${raw.model})` : ""}`);
+      console.log(`  task:      ${raw.taskId}`);
+      console.log(`  summary:   ${raw.summary}`);
+      if (raw.findings.length > 0) {
+        console.log("  findings:");
+        for (const finding of raw.findings) {
+          console.log(`    - [${finding.severity ?? "info"}] ${finding.title}`);
+          for (const evidence of finding.evidence ?? []) {
+            console.log(`      evidence: ${evidence}`);
+          }
+        }
+      }
+      if (raw.recommendations.length > 0) {
+        console.log("  recommendations:");
+        for (const recommendation of raw.recommendations) {
+          console.log(`    - ${recommendation}`);
+        }
+      }
+      return;
+    }
+    const combined = await svc.storeRef.getCombined(id);
+    if (combined) {
+      console.log(`Combined report ${combined.id}`);
+      console.log(`  sources:   ${combined.sources.join(", ")}`);
+      console.log(`  reports:   ${combined.reportIds.length}`);
+      if (combined.pipelineRunId) console.log(`  run:       ${combined.pipelineRunId}`);
+      console.log(`  summary:   ${combined.summary}`);
+      if (combined.findings.length > 0) {
+        console.log("  findings (grouped, duplicates merged):");
+        for (const finding of combined.findings) {
+          console.log(
+            `    - [${finding.severity ?? "info"}] ${finding.title} (x${finding.occurrences}, sources: ${finding.sources.map((s) => s.agent).join(", ")})`
+          );
+        }
+      }
+      if (combined.recommendations.length > 0) {
+        console.log("  recommendations:");
+        for (const recommendation of combined.recommendations) {
+          console.log(`    - ${recommendation.text} (x${recommendation.occurrences})`);
+        }
+      }
+      return;
+    }
+    throw new OmniNodeError("REPORT_NOT_FOUND", `Report "${id}" was not found in the report store.`);
   });
 }
 
 // src/pipelines/engine.ts
-import { randomBytes as randomBytes2 } from "crypto";
+import { randomBytes as randomBytes3 } from "crypto";
 var PipelineEngine = class {
   constructor(options) {
     this.options = options;
@@ -1694,7 +2071,7 @@ var PipelineEngine = class {
     }
     const now = (/* @__PURE__ */ new Date()).toISOString();
     const run2 = {
-      id: `run-${Date.now().toString(36)}-${randomBytes2(3).toString("hex")}`,
+      id: `run-${Date.now().toString(36)}-${randomBytes3(3).toString("hex")}`,
       pipelineId: def.id,
       status: "running",
       startedAt: now,
@@ -1751,11 +2128,28 @@ ${contribution}`);
     }
     const failed = [...outcomes.values()].some((o) => o.status === "failed");
     const finalStatus = failed ? "failed" : "completed";
+    let combinedReportId;
+    if (this.options.reports) {
+      const taskIds = [...outcomes.values()].flatMap((o) => o.taskIds);
+      const tasks = (await Promise.all(taskIds.map((id) => this.options.tasks.get(id)))).filter((task) => task !== void 0);
+      const collected = await this.options.reports.collectFromTasks(tasks);
+      await this.options.reports.saveReports(collected);
+      const combined = await this.options.reports.generateCombined(collected, {
+        objective,
+        pipelineRunId: run2.id,
+        taskIds
+      });
+      combinedReportId = combined?.id;
+      if (collected.length > 0) {
+        run2.reports = collected;
+      }
+    }
     const finished = {
       ...run2,
       status: finalStatus,
       finishedAt: (/* @__PURE__ */ new Date()).toISOString(),
-      ...allReports.length > 0 ? { reports: allReports } : {}
+      ...run2.reports !== void 0 && run2.reports.length > 0 ? { reports: run2.reports } : {},
+      ...combinedReportId !== void 0 ? { combinedReportId } : {}
     };
     await this.options.store.save(finished);
     this.log.info(`Pipeline ${def.id} finished: ${finalStatus}.`);
@@ -1935,8 +2329,8 @@ function createDefaultChatFn(providers) {
 }
 
 // src/pipelines/store.ts
-import { mkdir as mkdir2, readFile as readFile2, rename as rename2, writeFile as writeFile2 } from "fs/promises";
-import { dirname as dirname2 } from "path";
+import { mkdir as mkdir3, readFile as readFile3, rename as rename3, writeFile as writeFile3 } from "fs/promises";
+import { dirname as dirname3 } from "path";
 var FilePipelineRunStore = class {
   filePath;
   queue = Promise.resolve();
@@ -1974,7 +2368,7 @@ var FilePipelineRunStore = class {
   }
   async load() {
     try {
-      const raw = await readFile2(this.filePath, "utf8");
+      const raw = await readFile3(this.filePath, "utf8");
       const parsed = JSON.parse(raw);
       return Array.isArray(parsed) ? parsed : [];
     } catch {
@@ -1983,10 +2377,10 @@ var FilePipelineRunStore = class {
   }
   async write(runs) {
     const tmp = `${this.filePath}.tmp`;
-    await mkdir2(dirname2(this.filePath), { recursive: true });
-    await writeFile2(tmp, `${JSON.stringify(runs, null, 2)}
+    await mkdir3(dirname3(this.filePath), { recursive: true });
+    await writeFile3(tmp, `${JSON.stringify(runs, null, 2)}
 `, "utf8");
-    await rename2(tmp, this.filePath);
+    await rename3(tmp, this.filePath);
   }
 };
 
@@ -2007,6 +2401,7 @@ function buildPipelineEngine(config, log = logger) {
     providers: config.project.providers,
     store: new FilePipelineRunStore(),
     chat: createDefaultChatFn(config.project.providers),
+    reports: new ReportService(new FileReportStore(), log),
     log
   });
 }
@@ -2045,6 +2440,9 @@ function registerPipelineCommands(program) {
     if (finished.reports && finished.reports.length > 0) {
       console.log(`  reports: ${finished.reports.length} structured report(s)`);
     }
+    if (finished.combinedReportId) {
+      console.log(`  combined report: ${finished.combinedReportId}`);
+    }
     console.log(`Pipeline ${finished.status}. Run id: ${finished.id}`);
     if (finished.status !== "completed") process.exitCode = 1;
   });