@hienlh/ppm 0.9.46 → 0.9.48

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [0.9.48] - 2026-04-06
+
+### Changed
+- **Memory → Identity layer**: Stripped custom memory extraction, decay, periodic AI extraction prompts. PPMBot now stores only identity/preferences + explicit `/remember` facts. Contextual memory delegated to provider's native system (Claude Code MEMORY.md). `ppmbot-memory.ts` 333→111 LOC.
+- **Removed "don't write memory" directive**: AI provider manages its own contextual memory naturally.
+
+## [0.9.47] - 2026-04-06
+
+### Fixed
+- **AI writes to Claude memory files**: Added core directive preventing AI from managing its own memory/identity files. Memory is handled by PPMBot externally.
+- **Garbage identity saved**: Removed `hasCheckedIdentity` fallback that saved random messages as identity. Identity only collected through `/start` onboarding flow.
+- **Identity onboarding context**: AI now gets a hint that the message is an identity intro, so it acknowledges warmly instead of treating it as a task.
+
 ## [0.9.46] - 2026-04-06
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hienlh/ppm",
-  "version": "0.9.46",
+  "version": "0.9.48",
   "description": "Personal Project Manager — mobile-first web IDE with AI assistance",
   "author": "hienlh",
   "license": "MIT",

package/src/services/db.service.ts

@@ -1097,19 +1097,6 @@ export function deletePPMBotMemoriesByTopic(
   return matches.length;
 }
 
-export function decayPPMBotMemories(): void {
-  getDb().query(
-    `UPDATE clawbot_memories
-     SET importance = importance * 0.95,
-         updated_at = unixepoch()
-     WHERE superseded_by IS NULL
-       AND category NOT IN ('preference', 'architecture')
-       AND updated_at < unixepoch() - 604800`,
-  ).run();
-  getDb().query(
-    `DELETE FROM clawbot_memories WHERE importance < 0.1 AND superseded_by IS NULL`,
-  ).run();
-}
 
 // ---------------------------------------------------------------------------
 // PPMBot pairing helpers

package/src/services/ppmbot/ppmbot-memory.ts

@@ -4,51 +4,22 @@ import {
   getPPMBotMemories,
   supersedePPMBotMemory,
   deletePPMBotMemoriesByTopic,
-  decayPPMBotMemories,
-  getDb,
 } from "../db.service.ts";
-import { configService } from "../config.service.ts";
 import type {
   PPMBotMemoryCategory,
   MemoryRecallResult,
 } from "../../types/ppmbot.ts";
-import type { ProjectConfig } from "../../types/config.ts";
-
-/** Max memories per project before pruning */
-const MAX_MEMORIES_PER_PROJECT = 500;
-
-/** Fact extracted from AI response */
-interface ExtractedFact {
-  content: string;
-  category: PPMBotMemoryCategory;
-  importance?: number;
-}
 
+/**
+ * Lightweight memory layer for PPMBot.
+ *
+ * Stores identity, preferences, and explicit user facts (/remember).
+ * Contextual memory (decisions, architecture, etc.) is left to the
+ * AI provider's native memory system (e.g. Claude Code MEMORY.md).
+ */
 export class PPMBotMemory {
-  /**
-   * Recall relevant memories for a project.
-   * If query provided, use FTS5 search. Otherwise return top by importance.
-   */
-  recall(project: string, query?: string, limit = 20): MemoryRecallResult[] {
-    if (query) {
-      const sanitized = this.sanitizeFtsQuery(query);
-      if (sanitized) {
-        try {
-          const results = searchPPMBotMemories(project, sanitized, limit);
-          return results.map((r) => ({
-            id: r.id,
-            content: r.content,
-            category: r.category,
-            importance: r.importance,
-            project: r.project,
-            rank: r.rank,
-          }));
-        } catch {
-          // FTS query syntax error — fallback to importance-based
-        }
-      }
-    }
-
+  /** Get all active memories for a project (+ _global) */
+  getSummary(project: string, limit = 30): MemoryRecallResult[] {
     const rows = getPPMBotMemories(project, limit);
     return rows.map((r) => ({
       id: r.id,
@@ -59,61 +30,7 @@ export class PPMBotMemory {
     }));
   }
 
-  /**
-   * Enhanced recall: include memories from mentioned projects.
-   * Detects project names in message and fetches their memories too.
-   */
-  recallWithCrossProject(
-    currentProject: string,
-    query: string | undefined,
-    message: string,
-    limit = 20,
-  ): MemoryRecallResult[] {
-    const mainMemories = this.recall(currentProject, query, limit);
-    const mentioned = this.detectMentionedProjects(message, currentProject);
-
-    if (mentioned.length === 0) return mainMemories;
-
-    const crossMemories: MemoryRecallResult[] = [];
-    for (const proj of mentioned.slice(0, 3)) {
-      const projMems = this.recall(proj, query, 5);
-      crossMemories.push(...projMems.map((m) => ({ ...m, project: proj })));
-    }
-
-    return [...mainMemories, ...crossMemories].slice(0, limit);
-  }
-
-  /**
-   * Save multiple extracted facts. Checks for duplicates via FTS
-   * and supersedes old facts when new ones are similar.
-   */
-  save(project: string, facts: ExtractedFact[], sessionId?: string): number {
-    let inserted = 0;
-    for (const fact of facts) {
-      if (!fact.content?.trim()) continue;
-
-      const existingId = this.findSimilar(project, fact.content);
-
-      const newId = insertPPMBotMemory(
-        project,
-        fact.content.trim(),
-        fact.category || "fact",
-        fact.importance ?? 1.0,
-        sessionId,
-      );
-
-      if (existingId) {
-        supersedePPMBotMemory(existingId, newId);
-      }
-
-      inserted++;
-    }
-
-    this.pruneExcess(project);
-    return inserted;
-  }
-
-  /** Save a single fact immediately (from /remember command) */
+  /** Save a single fact (identity, /remember) */
   saveOne(
     project: string,
     content: string,
@@ -128,26 +45,14 @@ export class PPMBotMemory {
     return newId;
   }
 
-  /** Delete memories matching a topic (from /forget command) */
+  /** Delete memories matching a topic (/forget) */
   forget(project: string, topic: string): number {
     const sanitized = this.sanitizeFtsQuery(topic);
     if (!sanitized) return 0;
     return deletePPMBotMemoriesByTopic(project, sanitized);
   }
 
-  /** Get summary of all active memories for a project */
-  getSummary(project: string, limit = 30): MemoryRecallResult[] {
-    const rows = getPPMBotMemories(project, limit);
-    return rows.map((r) => ({
-      id: r.id,
-      content: r.content,
-      category: r.category,
-      importance: r.importance,
-      project: r.project,
-    }));
-  }
-
-  /** Build system prompt section with recalled memories */
+  /** Build system prompt section with identity/preferences */
   buildRecallPrompt(memories: MemoryRecallResult[]): string {
     if (memories.length === 0) return "";
 
@@ -158,9 +63,7 @@ export class PPMBotMemory {
       grouped.get(cat)!.push(mem.content);
     }
 
-    let prompt = "\n\n## Cross-Session Memory\n";
-    prompt += "The following facts are recalled from previous sessions:\n\n";
-
+    let prompt = "\n\n## User Identity & Preferences\n";
     for (const [category, facts] of grouped) {
       prompt += `### ${category.charAt(0).toUpperCase() + category.slice(1)}s\n`;
       for (const fact of facts) {
@@ -168,126 +71,11 @@ export class PPMBotMemory {
       }
       prompt += "\n";
     }
-
-    prompt += "Use these as context. Correct any that seem outdated.\n";
     return prompt;
   }
 
-  /** Build the extraction prompt sent at session end */
-  buildExtractionPrompt(): string {
-    return `Summarize the key facts, decisions, and preferences from this conversation as a JSON array. Each entry:
-{"content": "the fact", "category": "fact|decision|preference|architecture|issue", "importance": 0.5-2.0}
-
-Rules:
-- Only include facts worth remembering across sessions
-- Skip ephemeral details (file line numbers, temp debug info)
-- Prefer concise, self-contained statements
-- Max 10 entries
-- Return ONLY the JSON array, no markdown fencing
-
-If nothing worth remembering, return []`;
-  }
-
-  /**
-   * Parse the AI's extraction response into structured facts.
-   * Handles: raw JSON array, markdown-fenced JSON, or graceful failure.
-   */
-  parseExtractionResponse(text: string): ExtractedFact[] {
-    let cleaned = text.trim();
-    if (cleaned.startsWith("```")) {
-      cleaned = cleaned.replace(/^```\w*\n?/, "").replace(/\n?```$/, "");
-    }
-
-    try {
-      const parsed = JSON.parse(cleaned);
-      if (!Array.isArray(parsed)) return [];
-
-      return parsed
-        .filter(
-          (item: unknown): item is Record<string, unknown> =>
-            typeof item === "object" && item !== null && "content" in item,
-        )
-        .map((item) => ({
-          content: String(item.content ?? ""),
-          category: this.validateCategory(String(item.category ?? "fact")),
-          importance: Math.max(0, Math.min(2, Number(item.importance ?? 1))),
-        }))
-        .filter((f) => f.content.length > 0);
-    } catch {
-      console.warn("[ppmbot-memory] Failed to parse extraction response");
-      return [];
-    }
-  }
-
-  /**
-   * Regex-based fallback for memory extraction.
-   * Used when AI extraction returns empty or fails.
-   */
-  extractiveMemoryFallback(conversationText: string): ExtractedFact[] {
-    const facts: ExtractedFact[] = [];
-    const patterns: Array<{ re: RegExp; category: PPMBotMemoryCategory }> = [
-      { re: /(?:decided|chose|went with|picked|selected)\s+(.{10,100})/gi, category: "decision" },
-      { re: /(?:prefer|always use|like to|rather)\s+(.{10,80})/gi, category: "preference" },
-      { re: /(?:uses?|built with|stack is|powered by|database is)\s+(.{5,80})/gi, category: "architecture" },
-      { re: /(?:bug|issue|problem|broken|fails?|error)\s+(?:with|in|when)\s+(.{10,100})/gi, category: "issue" },
-    ];
-    for (const { re, category } of patterns) {
-      let match: RegExpExecArray | null;
-      while ((match = re.exec(conversationText)) !== null) {
-        const content = (match[1] || match[0]).trim();
-        if (content.length > 10) {
-          facts.push({ content, category, importance: 0.7 });
-        }
-      }
-    }
-    return facts.slice(0, 10);
-  }
-
-  /** Run importance decay on old memories */
-  runDecay(): void {
-    try {
-      decayPPMBotMemories();
-    } catch (err) {
-      console.error("[ppmbot-memory] Decay error:", (err as Error).message);
-    }
-  }
-
-  /** Remove excess memories beyond the per-project cap */
-  pruneExcess(project: string, maxCount = MAX_MEMORIES_PER_PROJECT): void {
-    try {
-      const count = (getDb().query(
-        `SELECT COUNT(*) as cnt FROM clawbot_memories
-         WHERE project = ? AND superseded_by IS NULL`,
-      ).get(project) as { cnt: number })?.cnt ?? 0;
-
-      if (count <= maxCount) return;
-
-      const excess = count - maxCount;
-      getDb().query(
-        `DELETE FROM clawbot_memories WHERE id IN (
-           SELECT id FROM clawbot_memories
-           WHERE project = ? AND superseded_by IS NULL
-           ORDER BY importance ASC, updated_at ASC
-           LIMIT ?
-         )`,
-      ).run(project, excess);
-    } catch (err) {
-      console.error("[ppmbot-memory] Prune error:", (err as Error).message);
-    }
-  }
-
   // ── Private ─────────────────────────────────────────────────────
 
-  /** Detect project names mentioned in user message */
-  private detectMentionedProjects(message: string, currentProject: string): string[] {
-    const allProjects = configService.get("projects") as ProjectConfig[];
-    if (!allProjects?.length) return [];
-    return allProjects
-      .filter((p) => p.name !== currentProject)
-      .filter((p) => message.toLowerCase().includes(p.name.toLowerCase()))
-      .map((p) => p.name);
-  }
-
   /** Find an existing memory similar to the given content */
   private findSimilar(project: string, content: string): number | null {
     const words = content
@@ -320,14 +108,4 @@ If nothing worth remembering, return []`;
       .replace(/\s+/g, " ")
       .trim();
   }
-
-  /** Validate category string against known values */
-  private validateCategory(cat: string): PPMBotMemoryCategory {
-    const valid: PPMBotMemoryCategory[] = [
-      "fact", "decision", "preference", "architecture", "issue",
-    ];
-    return valid.includes(cat as PPMBotMemoryCategory)
-      ? (cat as PPMBotMemoryCategory)
-      : "fact";
-  }
 }

package/src/services/ppmbot/ppmbot-service.ts

@@ -4,7 +4,6 @@ import {
   isPairedChat,
   getPairingByChatId,
   createPairingRequest,
-  approvePairing,
   getSessionTitles,
   getApprovedPairedChats,
 } from "../db.service.ts";
@@ -41,15 +40,6 @@ class PPMBotService {
   /** Chat IDs that just received identity onboarding prompt */
   private identityPending = new Set<string>();
 
-  /** Chat IDs where we've already checked for identity (once per session) */
-  private hasCheckedIdentity = new Set<string>();
-
-  /** Message count per session for periodic memory save */
-  private messageCount = new Map<string, number>();
-
-  /** Interval (messages) between automatic memory saves */
-  private readonly MEMORY_SAVE_INTERVAL = 5;
-
   // ── Lifecycle ─────────────────────────────────────────────────
 
   async start(): Promise<void> {
@@ -69,9 +59,6 @@ class PPMBotService {
       this.telegram = new PPMBotTelegram(telegramConfig.bot_token);
       this.running = true;
 
-      // Run memory decay on startup
-      this.memory.runDecay();
-
       // Start polling (non-blocking)
       this.telegram.startPolling((update) => this.handleUpdate(update));
 
@@ -95,8 +82,6 @@ class PPMBotService {
     this.processing.clear();
     this.messageQueue.clear();
     this.identityPending.clear();
-    this.hasCheckedIdentity.clear();
-    this.messageCount.clear();
 
     console.log("[ppmbot] Stopped");
   }
@@ -251,7 +236,6 @@ class PPMBotService {
       return;
     }
 
-    await this.saveSessionMemory(chatId);
     const session = await this.sessions.switchProject(chatId, args);
     await this.telegram!.sendMessage(
       Number(chatId),
@@ -260,7 +244,6 @@ class PPMBotService {
   }
 
   private async cmdNew(chatId: string): Promise<void> {
-    await this.saveSessionMemory(chatId);
     const active = this.sessions.getActiveSession(chatId);
     const projectName = active?.projectName;
     await this.sessions.closeSession(chatId);
@@ -303,7 +286,6 @@ class PPMBotService {
       await this.telegram!.sendMessage(Number(chatId), "Usage: /resume &lt;number&gt;");
       return;
     }
-    await this.saveSessionMemory(chatId);
     const session = await this.sessions.resumeSessionById(chatId, index);
     if (!session) {
       await this.telegram!.sendMessage(Number(chatId), "Session not found.");
@@ -329,7 +311,6 @@ class PPMBotService {
   }
 
   private async cmdStop(chatId: string): Promise<void> {
-    await this.saveSessionMemory(chatId);
     await this.sessions.closeSession(chatId);
     await this.telegram!.sendMessage(Number(chatId), "Session ended ✓");
   }
@@ -497,14 +478,10 @@ class PPMBotService {
         this.titledSessions.add(session.sessionId);
       }
 
-      // Recall memories (with cross-project detection)
-      const memories = this.memory.recallWithCrossProject(
-        session.projectName,
-        text,
-        text,
-      );
+      // Recall identity & preferences (global + project)
+      const memories = this.memory.getSummary(session.projectName);
 
-      // Build system prompt with memory
+      // Build system prompt with identity/preferences
       let systemPrompt = config?.system_prompt ?? "";
       const memorySection = this.memory.buildRecallPrompt(memories);
       if (memorySection) {
@@ -516,23 +493,19 @@ class PPMBotService {
         permissionMode: (config?.permission_mode ?? "bypassPermissions") as PermissionMode,
       };
 
-      let fullMessage = text;
-      if (systemPrompt) {
-        fullMessage = `<system-context>\n${systemPrompt}\n</system-context>\n\n${text}`;
-      }
-
       // Save identity BEFORE streaming — must persist even if streaming times out
+      let messageForAI = text;
       if (this.identityPending.has(chatId)) {
         this.identityPending.delete(chatId);
         this.memory.saveOne("_global", `User identity: ${text}`, "preference", session.sessionId);
         console.log("[ppmbot] Saved identity memory from onboarding");
-      } else if (!this.hasCheckedIdentity.has(chatId)) {
-        this.hasCheckedIdentity.add(chatId);
-        const globalMems = this.memory.getSummary("_global", 50);
-        if (!globalMems.some((m) => m.category === "preference" && /identity/i.test(m.content))) {
-          this.memory.saveOne("_global", `User identity: ${text}`, "preference", session.sessionId);
-          console.log("[ppmbot] Saved identity memory (first message, no identity found)");
-        }
+        // Tell AI this is an identity intro so it acknowledges warmly
+        messageForAI = `[User just introduced themselves in response to onboarding prompt. Acknowledge warmly and briefly.]\n\n${text}`;
+      }
+
+      let fullMessage = messageForAI;
+      if (systemPrompt) {
+        fullMessage = `<system-context>\n${systemPrompt}\n</system-context>\n\n${messageForAI}`;
       }
 
       const events = chatService.sendMessage(
@@ -553,15 +526,6 @@ class PPMBotService {
         },
       );
 
-      // Periodic memory extraction — fire-and-forget every N messages
-      const count = (this.messageCount.get(session.sessionId) ?? 0) + 1;
-      this.messageCount.set(session.sessionId, count);
-      if (count % this.MEMORY_SAVE_INTERVAL === 0) {
-        this.saveSessionMemory(chatId).catch((err) =>
-          console.warn("[ppmbot] Periodic memory save failed:", (err as Error).message),
-        );
-      }
-
       // Check context window — auto-rotate if near limit
       if (
         result.contextWindowPct != null &&
@@ -588,48 +552,14 @@ class PPMBotService {
     }
   }
 
-  // ── Memory Save / Session Rotate ────────────────────────────────
-
-  private async saveSessionMemory(chatId: string): Promise<void> {
-    const session = this.sessions.getActiveSession(chatId);
-    if (!session) return;
-
-    try {
-      const extractionPrompt = this.memory.buildExtractionPrompt();
-      const events = chatService.sendMessage(
-        session.providerId,
-        session.sessionId,
-        extractionPrompt,
-        { permissionMode: "bypassPermissions" },
-      );
-
-      let responseText = "";
-      for await (const event of events) {
-        if (event.type === "text") responseText += event.content;
-      }
-
-      const facts = this.memory.parseExtractionResponse(responseText);
-      if (facts.length > 0) {
-        const count = this.memory.save(session.projectName, facts, session.sessionId);
-        console.log(`[ppmbot] Saved ${count} memories for ${session.projectName}`);
-      } else {
-        // Fallback: regex-based extraction
-        // Note: we don't have conversation history text here easily,
-        // so regex fallback only triggers when AI extraction fails
-        console.log("[ppmbot] No memories extracted via AI");
-      }
-    } catch (err) {
-      console.warn("[ppmbot] Memory save failed:", (err as Error).message);
-    }
-  }
+  // ── Session Rotate ──────────────────────────────────────────────
 
   private async rotateSession(chatId: string, projectName: string): Promise<void> {
-    await this.saveSessionMemory(chatId);
     await this.sessions.closeSession(chatId);
     await this.sessions.getOrCreateSession(chatId, projectName);
     await this.telegram?.sendMessage(
       Number(chatId),
-      "<i>Context window near limit — starting fresh session. Memories saved.</i>",
+      "<i>Context window near limit — starting fresh session.</i>",
     );
   }