@hienlh/ppm 0.8.85 → 0.8.87

package/.claude.bak/agent-memory/tester/MEMORY.md

@@ -0,0 +1,3 @@
+# Tester Agent Memory Index
+
+- [project-ppm-test-conventions.md](project-ppm-test-conventions.md) - PPM test setup, gotchas, and conventions

package/.claude.bak/agent-memory/tester/project-ppm-test-conventions.md

@@ -0,0 +1,32 @@
+---
+name: PPM test conventions and gotchas
+description: Key patterns, pitfalls, and setup details for writing tests in the PPM project
+type: project
+---
+
+## Test runner: `bun test` (Jest-compatible API from `bun:test`)
+
+## Test structure
+- `tests/setup.ts` — shared helpers: `createTempDir`, `cleanupDir`, `createTempGitRepo`, `buildTestApp`
+- `tests/unit/services/` — unit tests for ConfigService, ProjectService, FileService, GitService
+- `tests/integration/api/` — integration tests using `app.request()` (no real server needed)
+
+## Critical gotchas
+
+### ppm.yaml in CWD
+The project root has a real `ppm.yaml` with `port: 5555`. `ConfigService.load(missingPath)` falls through to `LOCAL_CONFIG = "ppm.yaml"` in CWD when the given path doesn't exist. Always write an actual file before calling `load()` to avoid picking up this real config.
+
+### Global configService in git routes
+`src/server/routes/git.ts` imports and uses the global `configService` singleton (not injected). Integration tests for git API must mutate `configService.config.projects` directly to register the test repo. Restore to `[]` in `afterEach`.
+
+### ConfigService.load() fallback behavior
+Candidates checked in order: explicit path → PPM_CONFIG env → LOCAL_CONFIG (ppm.yaml) → HOME_CONFIG (~/.ppm/config.yaml). A missing explicit path does NOT stop the fallback chain.
+
+### buildTestApp in setup.ts
+Overrides `configService.save = () => {}` (no-op) to prevent tests writing to disk. Injects config directly by mutating private fields via `as unknown as`.
+
+### Real git repos for git tests
+`createTempGitRepo()` uses `Bun.spawn` with git env vars (author name/email) to create a real repo with an initial commit. No mocks for git operations.
+
+**Why:** Tests must use real implementations — no fakes/mocks that diverge from production behavior.
+**How to apply:** Always use `createTempGitRepo` for anything touching GitService or git API routes.

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [0.8.87] - 2026-04-01
+
+### Fixed
+- **Session message loss on auth retry**: OAuth token expiry mid-query (e.g. during long bash commands) caused retry to create a new SDK session, overwriting the session mapping and losing all prior messages. Retry now resumes existing session instead.
+- **Session CWD fallback to homedir**: `resumeSession()` didn't restore `projectPath` from SDK metadata, causing queries to use `$HOME` as CWD and JSONL to be stored under wrong project. Now extracts `cwd` from SDK session data.
+
 ## [0.8.85] - 2026-04-01
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hienlh/ppm",
-  "version": "0.8.85",
+  "version": "0.8.87",
   "description": "Personal Project Manager — mobile-first web IDE with AI assistance",
   "author": "hienlh",
   "license": "MIT",

package/src/providers/claude-agent-sdk.ts

@@ -181,6 +181,7 @@ export class ClaudeAgentSdkProvider implements AIProvider {
           id: sessionId,
           providerId: this.id,
           title: dbTitle ?? found.customTitle ?? found.summary ?? "Resumed Chat",
+          projectPath: (found as any).cwd || undefined,
           createdAt: new Date(found.lastModified).toISOString(),
         };
         this.activeSessions.set(sessionId, meta);
@@ -495,8 +496,9 @@ export class ClaudeAgentSdkProvider implements AIProvider {
           if ((msg as any).type === "result" && (msg as any).subtype === "error_during_execution" && ((msg as any).num_turns ?? 0) === 0 && retryCount < MAX_RETRIES) {
             retryCount++;
             console.warn(`[sdk] transient error on first event — retrying (attempt ${retryCount}/${MAX_RETRIES})`);
-            // Re-create query for retry — don't reuse sessionId in case SDK partially created it
-            const retryOpts = { ...queryOptions, sessionId: undefined, resume: undefined };
+            // Resume existing SDK session on retry to preserve conversation history.
+            // If first message, SDK may have partially created the session — resume with sdkId.
+            const retryOpts = { ...queryOptions, sessionId: undefined, resume: sdkId };
             const rq = query({
               prompt: message,
               options: { ...retryOpts, ...(permissionHooks && { hooks: permissionHooks }), canUseTool } as any,
@@ -666,7 +668,8 @@ export class ClaudeAgentSdkProvider implements AIProvider {
                   console.log(`[sdk] session=${sessionId} OAuth token refreshed for ${account.id} (${label}) — retrying`);
                   yield { type: "account_retry" as const, reason: "Token refreshed", accountId: refreshedAccount.id, accountLabel: label };
                   const retryEnv = this.buildQueryEnv(meta.projectPath, refreshedAccount);
-                  const retryOpts = { ...queryOptions, sessionId: undefined, resume: undefined, env: retryEnv };
+                  // Resume existing SDK session to preserve conversation history
+                  const retryOpts = { ...queryOptions, sessionId: undefined, resume: sdkId, env: retryEnv };
                   const rq = query({
                     prompt: message,
                     options: { ...retryOpts, ...(permissionHooks && { hooks: permissionHooks }), canUseTool } as any,
@@ -759,7 +762,8 @@ export class ClaudeAgentSdkProvider implements AIProvider {
                     console.log(`[sdk] 401 in result on account ${account.id} (${label}) — token refreshed, retrying`);
                     yield { type: "account_retry" as const, reason: "Token refreshed", accountId: refreshedAccount.id, accountLabel: label };
                     const retryEnv = this.buildQueryEnv(meta.projectPath, refreshedAccount);
-                    const retryOpts = { ...queryOptions, sessionId: undefined, resume: undefined, env: retryEnv };
+                    // Resume existing SDK session to preserve conversation history
+                  const retryOpts = { ...queryOptions, sessionId: undefined, resume: sdkId, env: retryEnv };
                     const rq = query({
                       prompt: message,
                       options: { ...retryOpts, ...(permissionHooks && { hooks: permissionHooks }), canUseTool } as any,

package/docs/streaming-input-guide.md

@@ -1,267 +0,0 @@
-# Streaming Input Migration Quick Reference (v0.8.55+)
-
-## What Changed?
-
-**Before (v0.8.54):** Each message triggered a new SDK query
-```
-Message 1 → SDK subprocess spawn → generate response → close
-Message 2 → SDK subprocess spawn → generate response → close
-(Slow, context resets between messages)
-```
-
-**After (v0.8.55):** Single persistent streaming session
-```
-Session created → AsyncGenerator streaming input opened
-Message 1 → Push into generator → process events
-Message 2 → Push into same generator → continue streaming
-(Fast, continuous context, no SDK restarts)
-```
-
-## Key Concepts
-
-### Session State (BE-Owned)
-The backend maintains a `SessionEntry` per chat session:
-- Tracks connected clients (can be zero if FE disconnected)
-- Maintains streaming phase (idle, connecting, thinking, streaming)
-- Buffers events for reconnection sync
-- Auto-cleans after 5 minutes of FE inactivity
-
-### Message Priority (v0.8.55+)
-```typescript
-// Send message with priority
-ws.send({
-  type: "message",
-  content: "Debug this code",
-  priority: "now"  // "now" | "next" | "later"
-})
-```
-- **"now"** — Abort current query, restart with this message
-- **"next"** — Queue after current, run next
-- **"later"** — Append to queue, run last
-
-### Event Buffering on Reconnect
-When FE WS reconnects after disconnect:
-1. BE sends `session_state` with current phase + pending approval
-2. BE sends `turn_events` with all buffered events since last connection
-3. FE rebuilds chat UI state from buffered events
-4. No message loss (unless session cleaned up after 5min)
-
-## Common Patterns
-
-### Frontend: Send Message
-```typescript
-// In useChat hook or message input handler
-ws.send(JSON.stringify({
-  type: "message",
-  content: userInput,
-  priority: "now",  // Optional
-  images: [{ id: "img1", data: "base64..." }]  // Optional
-}));
-```
-
-### Frontend: Handle Reconnection
-```typescript
-function handleReconnect() {
-  // 1. WS open fires
-  // 2. Server sends session_state
-  const sessionState = JSON.parse(msg);
-  // 3. Server sends turn_events
-  const turnEvents = JSON.parse(msg);
-
-  // 4. FE rebuilds state from buffered events
-  turnEvents.events.forEach(event => {
-    chatStore.addEvent(event);
-  });
-
-  // 5. FE is now synced with BE
-}
-```
-
-### Backend: Session Lifecycle
-```typescript
-// 1. FE connects
-open(ws) {
-  const entry = activeSessions.get(sessionId);
-  if (!entry) {
-    // Create new session entry
-    activeSessions.set(sessionId, {
-      phase: "idle",
-      clients: new Set([ws]),
-      turnEvents: []
-    });
-  } else {
-    // Reconnect: clear cleanup timer, add client
-    entry.clients.add(ws);
-  }
-}
-
-// 2. FE sends message
-message(ws, data) {
-  const parsed = JSON.parse(data);
-  if (parsed.type === "message") {
-    // Abort current if streaming, wait for cleanup
-    if (entry.phase !== "idle") {
-      entry.abort.abort();
-      await entry.streamPromise;
-    }
-    // Start new streaming loop (detached)
-    entry.streamPromise = runStreamLoop(...);
-  }
-}
-
-// 3. Streaming loop runs independently
-async function runStreamLoop() {
-  for await (const event of chatService.sendMessage(...)) {
-    bufferAndBroadcast(sessionId, event);  // To all connected clients
-  }
-  setPhase(sessionId, "idle");  // Back to idle when done
-  if (entry.clients.size === 0) {
-    startCleanupTimer(sessionId);  // 5-min cleanup
-  }
-}
-
-// 4. FE disconnects
-close(ws) {
-  entry.clients.delete(ws);
-  // Stream continues! (BE owns the connection)
-  // Timer started if no more clients
-}
-```
-
-## Phase State Machine
-
-```
-     ┌─ initializing  (setup, session resume)
-     ↓
-  idle ←→ connecting  (waiting for first SDK event, heartbeat)
-     ↑         ↓
-     │    ┌──→ thinking  (extended thinking)
-     │    ↓  ↓
-     └─── streaming  (text/tool_use content)
-          ↑     ↓
-          └─────┘ (dynamic switch)
-```
-
-**Transitions:**
-- Heartbeat: `connecting` → (5s elapsed updates) → `thinking` (when content arrives)
-- Content: `thinking` → `streaming` (first text event)
-- Dynamic: `streaming` ↔ `thinking` (based on event types)
-- Done: Any → `idle` (stream complete, ready for next message)
-
-## WebSocket Messages (v0.8.55+)
-
-### Client → Server
-```typescript
-// Send message
-{ type: "message"; content: string; priority?: string; images?: {...}[] }
-
-// Approve tool
-{ type: "approval_response"; requestId: string; approved: boolean }
-
-// Cancel current
-{ type: "cancel" }
-
-// Handshake after open
-{ type: "ready" }
-```
-
-### Server → Client
-```typescript
-// Content
-{ type: "text"; content: string }
-{ type: "thinking"; content: string }
-
-// Tool execution
-{ type: "tool_use"; tool: string; input: unknown }
-{ type: "tool_result"; output: string; isError?: boolean }
-
-// User approval request
-{ type: "approval_request"; requestId: string; tool: string; input: unknown }
-
-// Session state (sent on open/ready)
-{ type: "session_state"; sessionId: string; phase: SessionPhase; pendingApproval: {...} | null }
-
-// Buffered events (on reconnect)
-{ type: "turn_events"; events: unknown[] }
-
-// Metadata
-{ type: "account_info"; accountId: string; accountLabel: string }
-{ type: "phase_changed"; phase: SessionPhase; elapsed?: number }
-{ type: "title_updated"; title: string }
-
-// Completion
-{ type: "done"; sessionId: string; contextWindowPct?: number }
-
-// Error
-{ type: "error"; message: string }
-
-// Keepalive
-{ type: "ping" }
-```
-
-## Benefits
-
-| Aspect | Before (v0.8.54) | After (v0.8.55) |
-|--------|------------------|-----------------|
-| **SDK Restarts** | Per message | Once per session |
-| **Context** | Resets between messages | Persistent |
-| **Startup Time** | 2-5s per message | Instant follow-ups |
-| **Reconnection** | Message loss | Event buffering ensures sync |
-| **Concurrency** | N/A | Multiple clients per session |
-| **Tool Approvals** | Restarts query | Integrated in stream |
-
-## Troubleshooting
-
-### Session Cleaned Up (No Longer Exists)
-**Cause:** FE disconnected for >5 minutes
-**Solution:** Create new session, FE reconnects with new sessionId
-
-### Events Missing After Reconnect
-**Cause:** Server-side event buffer (10k event limit) overflowed
-**Solution:** Flush buffer periodically or increase limit if needed
-
-### Phase Stuck in "Connecting"
-**Cause:** SDK subprocess not responding (120s timeout)
-**Solution:** Check environment (ANTHROPIC_API_KEY, network), see error message for hints
-
-### Multiple Clients Out of Sync
-**Cause:** Broadcast failed for one client, others ahead
-**Solution:** Evicted client will reconnect and re-sync from buffered events
-
-## Debugging
-
-### Enable Logging
-```bash
-# Check server logs for session lifecycle
-[chat] session=abc123 phase → connecting
-[chat] session=abc123 first SDK event after 1250ms: type=text
-[chat] session=abc123 stream completed (45 events)
-[chat] session=abc123 phase → idle
-```
-
-### Check Session State
-```typescript
-// On WS message handler
-console.log(`Session entry:`, activeSessions.get(sessionId));
-// Outputs: { phase, clients.size, pendingApprovalEvent, turnEvents.length }
-```
-
-### Monitor Reconnections
-```typescript
-// In WS open handler
-console.log(`FE reconnected (phase=${existing.phase}, clients=${existing.clients.size})`);
-// Tells you: active streaming, how many clients connected
-```
-
-## Performance Notes
-
-- **No SDK overhead:** Persistent streaming eliminates subprocess spawn overhead
-- **Event buffering:** Clients see all events after reconnect (max 10k events per turn)
-- **Memory:** Session entries cleaned after 5min (bounded memory usage)
-- **Latency:** Follow-up messages start immediately (no SDK init)
-
----
-
-**For detailed architecture:** See `docs/system-architecture.md` → "Chat Streaming Flow" section
-**For API types:** See `src/types/api.ts` and `src/types/chat.ts`
-**For implementation:** See `src/server/ws/chat.ts` and `src/providers/claude-agent-sdk.ts`