@hiai-gg/hiai-opencode 0.1.0 → 0.1.1

package/src/agents/critic/agent.ts

@@ -1,105 +1,105 @@
-import type { AgentConfig } from "@opencode-ai/sdk";
-import type { AgentMode, AgentPromptMetadata } from "../types";
-
-const MODE: AgentMode = "subagent";
-
-const CRITIC_PROMPT = `
-<identity>
-You are Critic — high-accuracy review gate for plans and implementations.
-</identity>
-
-<role>
-**Your ONLY job**: receive a plan or implementation, then respond with:
-- APPROVED (green) — if it meets all quality gates
-- REJECTED (red) — if it has gaps, flaws, or missing verification
-
-You do NOT implement. You do NOT plan. You judge.
-</role>
-
-<workflow>
-1. Receive the artifact (plan text, code snippet, or implementation description)
-2. Check against the quality criteria listed below
-3. State your verdict: APPROVED or REJECTED
-4. If REJECTED: list specific gaps with evidence (what's missing, what will break, what was overlooked)
-5. Do NOT propose fixes yourself — return gaps only, let the author fix
-</workflow>
-
-<quality_criteria>
-## For Plans:
-- Scope is concrete and bounded (no vague "improve X")
-- Each task has verifiable completion criteria
-- Dependencies are explicit
-- Parallel opportunities are identified
-- Risks are acknowledged
-- No acceptance criteria requiring manual user testing
-
-## For Implementations:
-- Code matches the plan scope
-- Error handling present
-- No hard-coded secrets or paths
-- Type-safe (no suppression)
-- Verification evidence exists in the output
-</quality_criteria>
-
-<output_format>
-## Verdict: [APPROVED|REJECTED]
-
-## Quality Gate Results:
-- **Scope bounded** → ✅/❌ → ...
-- **Verifiable criteria** → ✅/❌ → ...
-- **Dependencies explicit** → ✅/❌ → ...
-- **Parallel opportunities** → ✅/❌ → ...
-- **Risks acknowledged** → ✅/❌ → ...
-- **No manual-test AC** → ✅/❌ → ...
-
-## Gaps (if REJECTED):
-1. ...
-2. ...
-</output_format>
-
-<forbidden>
-- Do NOT write code or plans yourself
-- Do NOT give implementation hints in rejection notes
-- Do NOT soften feedback to avoid offending the author
-- Do NOT approve just because most of it looks okay
-</forbidden>
-`;
-
-export function createCriticAgent(model: string): AgentConfig {
-  return {
-    description: "High-accuracy review gate. Judge, not executor. (Critic - HiaiOpenCode)",
-    mode: MODE,
-    model,
-    temperature: 0.3,
-    prompt: CRITIC_PROMPT,
-    thinking: { type: "enabled", budgetTokens: 24000 },
-  };
-}
-createCriticAgent.mode = MODE;
-
-export const criticPromptMetadata: AgentPromptMetadata = {
-  category: "advisor",
-  cost: "EXPENSIVE",
-  promptAlias: "Critic",
-  triggers: [
-    {
-      domain: "Plan Verification",
-      trigger: "High-accuracy plan review or strict approve/reject validation",
-    },
-    {
-      domain: "Implementation Review",
-      trigger: "After implementation is complete, before merge or delivery",
-    },
-  ],
-  useWhen: [
-    "High-risk decision with significant consequences",
-    "Architecture change affecting multiple systems",
-    "Security-sensitive implementation",
-    "Critical bug fix with unclear root cause",
-  ],
-  avoidWhen: [
-    "Simple single-file changes",
-    "Trivial typo or formatting fixes",
-    "When the author already verified everything",
-  ],
-};
+import type { AgentConfig } from "@opencode-ai/sdk";
+import type { AgentMode, AgentPromptMetadata } from "../types";
+
+const MODE: AgentMode = "subagent";
+
+const CRITIC_PROMPT = `
+<identity>
+You are Critic — high-accuracy review gate for plans and implementations.
+</identity>
+
+<role>
+**Your ONLY job**: receive a plan or implementation, then respond with:
+- APPROVED (green) — if it meets all quality gates
+- REJECTED (red) — if it has gaps, flaws, or missing verification
+
+You do NOT implement. You do NOT plan. You judge.
+</role>
+
+<workflow>
+1. Receive the artifact (plan text, code snippet, or implementation description)
+2. Check against the quality criteria listed below
+3. State your verdict: APPROVED or REJECTED
+4. If REJECTED: list specific gaps with evidence (what's missing, what will break, what was overlooked)
+5. Do NOT propose fixes yourself — return gaps only, let the author fix
+</workflow>
+
+<quality_criteria>
+## For Plans:
+- Scope is concrete and bounded (no vague "improve X")
+- Each task has verifiable completion criteria
+- Dependencies are explicit
+- Parallel opportunities are identified
+- Risks are acknowledged
+- No acceptance criteria requiring manual user testing
+
+## For Implementations:
+- Code matches the plan scope
+- Error handling present
+- No hard-coded secrets or paths
+- Type-safe (no suppression)
+- Verification evidence exists in the output
+</quality_criteria>
+
+<output_format>
+## Verdict: [APPROVED|REJECTED]
+
+## Quality Gate Results:
+- **Scope bounded** → ✅/❌ → ...
+- **Verifiable criteria** → ✅/❌ → ...
+- **Dependencies explicit** → ✅/❌ → ...
+- **Parallel opportunities** → ✅/❌ → ...
+- **Risks acknowledged** → ✅/❌ → ...
+- **No manual-test AC** → ✅/❌ → ...
+
+## Gaps (if REJECTED):
+1. ...
+2. ...
+</output_format>
+
+<forbidden>
+- Do NOT write code or plans yourself
+- Do NOT give implementation hints in rejection notes
+- Do NOT soften feedback to avoid offending the author
+- Do NOT approve just because most of it looks okay
+</forbidden>
+`;
+
+export function createCriticAgent(model: string): AgentConfig {
+  return {
+    description: "High-accuracy review gate. Judge, not executor. (Critic - HiaiOpenCode)",
+    mode: MODE,
+    model,
+    temperature: 0.3,
+    prompt: CRITIC_PROMPT,
+    thinking: { type: "enabled", budgetTokens: 24000 },
+  };
+}
+createCriticAgent.mode = MODE;
+
+export const criticPromptMetadata: AgentPromptMetadata = {
+  category: "advisor",
+  cost: "EXPENSIVE",
+  promptAlias: "Critic",
+  triggers: [
+    {
+      domain: "Plan Verification",
+      trigger: "High-accuracy plan review or strict approve/reject validation",
+    },
+    {
+      domain: "Implementation Review",
+      trigger: "After implementation is complete, before merge or delivery",
+    },
+  ],
+  useWhen: [
+    "High-risk decision with significant consequences",
+    "Architecture change affecting multiple systems",
+    "Security-sensitive implementation",
+    "Critical bug fix with unclear root cause",
+  ],
+  avoidWhen: [
+    "Simple single-file changes",
+    "Trivial typo or formatting fixes",
+    "When the author already verified everything",
+  ],
+};

package/src/agents/custom-agent-summaries.ts

@@ -1,61 +1,61 @@
-import type { AgentPromptMetadata } from "./types"
-import { truncateDescription } from "../shared/truncate-description"
-
-type RegisteredAgentSummary = {
-  name: string
-  description: string
-}
-
-function sanitizeMarkdownTableCell(value: string): string {
-  return value
-    .replace(/\r?\n/g, " ")
-    .replace(/\|/g, "\\|")
-    .replace(/\s+/g, " ")
-    .trim()
-}
-
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return typeof value === "object" && value !== null
-}
-
-export function parseRegisteredAgentSummaries(input: unknown): RegisteredAgentSummary[] {
-  if (!Array.isArray(input)) return []
-
-  const result: RegisteredAgentSummary[] = []
-  for (const item of input) {
-    if (!isRecord(item)) continue
-
-    const name = typeof item.name === "string" ? item.name : undefined
-    if (!name) continue
-
-    const hidden = item.hidden
-    if (hidden === true) continue
-
-    const disabled = item.disabled
-    if (disabled === true) continue
-
-    const enabled = item.enabled
-    if (enabled === false) continue
-
-    const description = typeof item.description === "string" ? item.description : ""
-    result.push({ name: sanitizeMarkdownTableCell(name), description: sanitizeMarkdownTableCell(description) })
-  }
-
-  return result
-}
-
-export function buildCustomAgentMetadata(agentName: string, description: string): AgentPromptMetadata {
-  const shortDescription = sanitizeMarkdownTableCell(truncateDescription(description))
-  const safeAgentName = sanitizeMarkdownTableCell(agentName)
-
-  return {
-    category: "specialist",
-    cost: "CHEAP",
-    triggers: [
-      {
-        domain: `Custom agent: ${safeAgentName}`,
-        trigger: shortDescription || "Use when this agent's description matches the task",
-      },
-    ],
-  }
-}
+import type { AgentPromptMetadata } from "./types"
+import { truncateDescription } from "../shared/truncate-description"
+
+type RegisteredAgentSummary = {
+  name: string
+  description: string
+}
+
+function sanitizeMarkdownTableCell(value: string): string {
+  return value
+    .replace(/\r?\n/g, " ")
+    .replace(/\|/g, "\\|")
+    .replace(/\s+/g, " ")
+    .trim()
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return typeof value === "object" && value !== null
+}
+
+export function parseRegisteredAgentSummaries(input: unknown): RegisteredAgentSummary[] {
+  if (!Array.isArray(input)) return []
+
+  const result: RegisteredAgentSummary[] = []
+  for (const item of input) {
+    if (!isRecord(item)) continue
+
+    const name = typeof item.name === "string" ? item.name : undefined
+    if (!name) continue
+
+    const hidden = item.hidden
+    if (hidden === true) continue
+
+    const disabled = item.disabled
+    if (disabled === true) continue
+
+    const enabled = item.enabled
+    if (enabled === false) continue
+
+    const description = typeof item.description === "string" ? item.description : ""
+    result.push({ name: sanitizeMarkdownTableCell(name), description: sanitizeMarkdownTableCell(description) })
+  }
+
+  return result
+}
+
+export function buildCustomAgentMetadata(agentName: string, description: string): AgentPromptMetadata {
+  const shortDescription = sanitizeMarkdownTableCell(truncateDescription(description))
+  const safeAgentName = sanitizeMarkdownTableCell(agentName)
+
+  return {
+    category: "specialist",
+    cost: "CHEAP",
+    triggers: [
+      {
+        domain: `Custom agent: ${safeAgentName}`,
+        trigger: shortDescription || "Use when this agent's description matches the task",
+      },
+    ],
+  }
+}

package/src/agents/dynamic-agent-category-skills-guide.ts

@@ -1,138 +1,138 @@
-import type {
-  AvailableCategory,
-  AvailableSkill,
-} from "./dynamic-agent-prompt-types"
-
-function buildSkillsSection(skills: AvailableSkill[]): string {
-  const builtinSkills = skills.filter((skill) => skill.location === "plugin")
-  const customSkills = skills.filter((skill) => skill.location !== "plugin")
-
-  const builtinNames = builtinSkills.map((skill) => skill.name).join(", ")
-  const customNames = customSkills
-    .map((skill) => {
-      const source = skill.location === "project" ? "project" : "user"
-      return `${skill.name} (${source})`
-    })
-    .join(", ")
-
-  if (customSkills.length > 0 && builtinSkills.length > 0) {
-    return `#### Available Skills (via \`skill\` tool)
-
-**Built-in**: ${builtinNames}
-**⚡ YOUR SKILLS (PRIORITY)**: ${customNames}
-
-> User-installed skills OVERRIDE built-in defaults. ALWAYS prefer YOUR SKILLS when domain matches.
-> Full skill descriptions → use the \`skill\` tool to check before EVERY delegation.`
-  }
-
-  if (customSkills.length > 0) {
-    return `#### Available Skills (via \`skill\` tool)
-
-**⚡ YOUR SKILLS (PRIORITY)**: ${customNames}
-
-> User-installed skills OVERRIDE built-in defaults. ALWAYS prefer YOUR SKILLS when domain matches.
-> Full skill descriptions → use the \`skill\` tool to check before EVERY delegation.`
-  }
-
-  if (builtinSkills.length > 0) {
-    return `#### Available Skills (via \`skill\` tool)
-
-**Built-in**: ${builtinNames}
-
-> Full skill descriptions → use the \`skill\` tool to check before EVERY delegation.`
-  }
-
-  return ""
-}
-
-export function buildCategorySkillsDelegationGuide(
-  categories: AvailableCategory[],
-  skills: AvailableSkill[],
-): string {
-  if (categories.length === 0 && skills.length === 0) {
-    return ""
-  }
-
-  const categoryRows = categories.map((category) => {
-    const description = category.description || category.name
-    return `- \`${category.name}\` - ${description}`
-  })
-
-  const customSkills = skills.filter((skill) => skill.location !== "plugin")
-  const skillsSection = buildSkillsSection(skills)
-  const customPriorityNote =
-    customSkills.length > 0
-      ? `
-> **User-installed skills get PRIORITY.** When in doubt, INCLUDE rather than omit.`
-      : ""
-
-  return `### Category + Skills Delegation System
-
-**task() combines categories and skills for optimal task execution.**
-
-#### Available Categories (Domain-Optimized Models)
-
-Each category is configured with a model optimized for that domain. Read the description to understand when to use it.
-
-${categoryRows.join("\n")}
-
-${skillsSection}
-
----
-
-### Category + Skill Selection Protocol
-
-**STEP 1: Select Category**
-- Read each category's description
-- Match task requirements to category domain
-- Select the category whose domain BEST fits the task
-
-**STEP 2: Evaluate ALL Skills**
-Check the \`skill\` tool for available skills and their descriptions. For EVERY skill, ask:
-> "Does this skill's expertise domain overlap with my task?"
-
-- If YES → INCLUDE in \`load_skills=[...]\`
-- If NO → OMIT (no justification needed)${customPriorityNote}
-
----
-
-### Delegation Pattern
-
-\`\`\`typescript
-task(
-  category="[selected-category]",
-  load_skills=["skill-1", "skill-2"],  // Include ALL relevant skills - ESPECIALLY user-installed ones
-  prompt="..."
-)
-\`\`\`
-
-**ANTI-PATTERN (will produce poor results):**
-\`\`\`typescript
-task(category="...", load_skills=[], run_in_background=false, prompt="...")  // Empty load_skills without justification
-\`\`\`
-
----
-
-### Category Domain Matching (ZERO TOLERANCE)
-
-Every delegation MUST use the category that matches the task's domain. Mismatched categories produce measurably worse output because each category runs on a model optimized for that specific domain.
-
-**VISUAL WORK = ALWAYS \`visual-engineering\`. NO EXCEPTIONS.**
-
-Any task involving UI, UX, CSS, styling, layout, animation, design, or frontend components MUST go to \`visual-engineering\`. Never delegate visual work to \`quick\`, \`unspecified-*\`, or any other category.
-
-\`\`\`typescript
-// CORRECT: Visual work → visual-engineering category
-task(category="visual-engineering", load_skills=["frontend-ui-ux"], prompt="Redesign the sidebar layout with new spacing...")
-
-// WRONG: Visual work in wrong category - WILL PRODUCE INFERIOR RESULTS
-task(category="quick", load_skills=[], prompt="Redesign the sidebar layout with new spacing...")
-\`\`\`
-
-**UI, styling, animations, layout, design** → \`visual-engineering\`
-**Hard logic, architecture decisions, algorithms** → \`ultrabrain\`
-**Autonomous research + end-to-end implementation** → \`deep\`
-**Single-file typo, trivial config change** → \`quick\`
-
-**When in doubt about category, it is almost never \`quick\` or \`unspecified-*\`. Match the domain.**`
-}
+import type {
+  AvailableCategory,
+  AvailableSkill,
+} from "./dynamic-agent-prompt-types"
+
+function buildSkillsSection(skills: AvailableSkill[]): string {
+  const builtinSkills = skills.filter((skill) => skill.location === "plugin")
+  const customSkills = skills.filter((skill) => skill.location !== "plugin")
+
+  const builtinNames = builtinSkills.map((skill) => skill.name).join(", ")
+  const customNames = customSkills
+    .map((skill) => {
+      const source = skill.location === "project" ? "project" : "user"
+      return `${skill.name} (${source})`
+    })
+    .join(", ")
+
+  if (customSkills.length > 0 && builtinSkills.length > 0) {
+    return `#### Available Skills (via \`skill\` tool)
+
+**Built-in**: ${builtinNames}
+**⚡ YOUR SKILLS (PRIORITY)**: ${customNames}
+
+> User-installed skills OVERRIDE built-in defaults. ALWAYS prefer YOUR SKILLS when domain matches.
+> Full skill descriptions → use the \`skill\` tool to check before EVERY delegation.`
+  }
+
+  if (customSkills.length > 0) {
+    return `#### Available Skills (via \`skill\` tool)
+
+**⚡ YOUR SKILLS (PRIORITY)**: ${customNames}
+
+> User-installed skills OVERRIDE built-in defaults. ALWAYS prefer YOUR SKILLS when domain matches.
+> Full skill descriptions → use the \`skill\` tool to check before EVERY delegation.`
+  }
+
+  if (builtinSkills.length > 0) {
+    return `#### Available Skills (via \`skill\` tool)
+
+**Built-in**: ${builtinNames}
+
+> Full skill descriptions → use the \`skill\` tool to check before EVERY delegation.`
+  }
+
+  return ""
+}
+
+export function buildCategorySkillsDelegationGuide(
+  categories: AvailableCategory[],
+  skills: AvailableSkill[],
+): string {
+  if (categories.length === 0 && skills.length === 0) {
+    return ""
+  }
+
+  const categoryRows = categories.map((category) => {
+    const description = category.description || category.name
+    return `- \`${category.name}\` - ${description}`
+  })
+
+  const customSkills = skills.filter((skill) => skill.location !== "plugin")
+  const skillsSection = buildSkillsSection(skills)
+  const customPriorityNote =
+    customSkills.length > 0
+      ? `
+> **User-installed skills get PRIORITY.** When in doubt, INCLUDE rather than omit.`
+      : ""
+
+  return `### Category + Skills Delegation System
+
+**task() combines categories and skills for optimal task execution.**
+
+#### Available Categories (Domain-Optimized Models)
+
+Each category is configured with a model optimized for that domain. Read the description to understand when to use it.
+
+${categoryRows.join("\n")}
+
+${skillsSection}
+
+---
+
+### Category + Skill Selection Protocol
+
+**STEP 1: Select Category**
+- Read each category's description
+- Match task requirements to category domain
+- Select the category whose domain BEST fits the task
+
+**STEP 2: Evaluate ALL Skills**
+Check the \`skill\` tool for available skills and their descriptions. For EVERY skill, ask:
+> "Does this skill's expertise domain overlap with my task?"
+
+- If YES → INCLUDE in \`load_skills=[...]\`
+- If NO → OMIT (no justification needed)${customPriorityNote}
+
+---
+
+### Delegation Pattern
+
+\`\`\`typescript
+task(
+  category="[selected-category]",
+  load_skills=["skill-1", "skill-2"],  // Include ALL relevant skills - ESPECIALLY user-installed ones
+  prompt="..."
+)
+\`\`\`
+
+**ANTI-PATTERN (will produce poor results):**
+\`\`\`typescript
+task(category="...", load_skills=[], run_in_background=false, prompt="...")  // Empty load_skills without justification
+\`\`\`
+
+---
+
+### Category Domain Matching (ZERO TOLERANCE)
+
+Every delegation MUST use the category that matches the task's domain. Mismatched categories produce measurably worse output because each category runs on a model optimized for that specific domain.
+
+**VISUAL WORK = ALWAYS \`visual-engineering\`. NO EXCEPTIONS.**
+
+Any task involving UI, UX, CSS, styling, layout, animation, design, or frontend components MUST go to \`visual-engineering\`. Never delegate visual work to \`quick\`, \`unspecified-*\`, or any other category.
+
+\`\`\`typescript
+// CORRECT: Visual work → visual-engineering category
+task(category="visual-engineering", load_skills=["frontend-ui-ux"], prompt="Redesign the sidebar layout with new spacing...")
+
+// WRONG: Visual work in wrong category - WILL PRODUCE INFERIOR RESULTS
+task(category="quick", load_skills=[], prompt="Redesign the sidebar layout with new spacing...")
+\`\`\`
+
+**UI, styling, animations, layout, design** → \`visual-engineering\`
+**Hard logic, architecture decisions, algorithms** → \`ultrabrain\`
+**Autonomous research + end-to-end implementation** → \`deep\`
+**Single-file typo, trivial config change** → \`quick\`
+
+**When in doubt about category, it is almost never \`quick\` or \`unspecified-*\`. Match the domain.**`
+}