@heytherevibin/skillforge 0.8.0 → 0.10.1

package/python/tests/test_routing_overlay.py

@@ -0,0 +1,55 @@
+"""Project routing overlay: notes, excludes, boosts."""
+from __future__ import annotations
+
+from app.route_policies import (
+    build_routing_overlay_payload,
+    merge_project_notes_into_route_query,
+    parse_routing_overlay,
+)
+
+
+def test_merge_notes_requires_project_root() -> None:
+    rq = merge_project_notes_into_route_query("hello", "note text", None)
+    assert rq == "hello"
+    rq2 = merge_project_notes_into_route_query("hello", "note text", "")
+    assert rq2 == "hello"
+
+
+def test_merge_notes_prepends_when_project_set() -> None:
+    rq = merge_project_notes_into_route_query("task", "We use Django 5.", "/repo", max_chars=100)
+    assert rq.startswith("Project routing notes:\n")
+    assert "Django" in rq
+    assert "task" in rq
+
+
+def test_parse_routing_overlay_boost_clamp() -> None:
+    ex, boosts, notes = parse_routing_overlay(
+        {"routing_boosts": {"a": 9.0, "b": -9.0}},
+        by_name={"a": 1, "b": 1},
+    )
+    assert not ex
+    assert boosts["a"] == 2.0
+    assert boosts["b"] == -2.0
+    assert notes == ""
+
+
+def test_parse_exclude_unknown_with_audit() -> None:
+    audit = []
+    ex, _b, _n = parse_routing_overlay(
+        {"exclude_skills": ["ghost"]},
+        by_name={"real": 1},
+        audit_out=audit,
+    )
+    assert "ghost" not in ex
+    assert any(a.get("effect") == "unknown_skill" for a in audit)
+
+
+def test_build_payload_none_when_empty() -> None:
+    assert build_routing_overlay_payload(
+        project_root="",
+        exclude_skills=frozenset(),
+        routing_boosts={},
+        project_notes_applied=False,
+        project_notes_len=0,
+        audit=[],
+    ) is None

package/python/tests/test_routing_signals.py

@@ -7,6 +7,7 @@ import pytest
 from app.main import Skill, parse_skill_md
 from app.routing_signals import (
     build_route_query_text,
+    host_pick_shortlist_lines,
     keyword_overlap_scores,
     normalize_minmax,
     skill_routing_card,
@@ -63,6 +64,40 @@ def test_keyword_overlap_scores() -> None:
     assert sc[0] > sc[1]
 
 
+def test_host_pick_shortlist_lines_basic() -> None:
+    facets = [
+        {
+            "name": "alpha-skill",
+            "title": "Alpha",
+            "cosine_similarity": 0.42,
+            "description_preview": "Does alpha testing patterns for flaky CI.",
+        }
+    ]
+    md, rows = host_pick_shortlist_lines(
+        prompt="fix flaky tests",
+        route_query="fix flaky tests",
+        facet_rows=facets,
+        max_candidates=5,
+        line_chars=90,
+    )
+    assert "alpha-skill" in md
+    assert "fix flaky" in md
+    assert len(rows) == 1
+    assert rows[0]["name"] == "alpha-skill"
+    assert rows[0]["id"] == "alpha-skill"
+    assert rows[0]["rank"] == 1
+
+
+def test_normalize_host_picked_main() -> None:
+    from app.main import Skill, normalize_host_picked_names
+
+    a = Skill(name="a", title="A", description="", body="", source="bundled")
+    b = Skill(name="b", title="B", description="", body="", source="bundled")
+    by_name = {"a": a, "b": b}
+    assert normalize_host_picked_names(["b", "a", "b", "unknown"], by_name, 1) == ["b"]
+    assert normalize_host_picked_names([], by_name, 7) == []
+
+
 def test_parse_skill_triggers(tmp_path) -> None:
     md = tmp_path / "my-skill" / "SKILL.md"
     md.parent.mkdir(parents=True, exist_ok=True)