@heysalad/cheri-cli 1.3.0 → 1.3.1

package/CHANGELOG.md

@@ -2,6 +2,29 @@
 
 All notable changes to Cheri CLI will be documented in this file.
 
+## [1.3.1] - 2026-02-17
+
+### 🐛 Bug Fixes
+
+#### Permission System
+- **Fixed spinner blocking approval prompts**: Approval prompts now appear BEFORE spinners start, preventing terminal blocking
+- **Added upfront permission request**: Tasks with write operations now ask for permissions at the start
+- **Better user experience**: Users can approve entire session with [a]lways option
+
+#### How It Works
+1. Agent analyzes task for write operations (build, create, modify, etc.)
+2. Shows upfront permission request: `[Y]es, [n]o, [a]lways`
+3. If approved, proceeds with task
+4. Individual risky operations still prompt for confirmation (unless 'always' was chosen)
+
+#### Changes
+- Moved approval logic before `ToolPanel` creation to avoid spinner blocking input
+- Added `requestUpfrontPermissions()` function to analyze and request batch permissions
+- Added `skipApproval` parameter to `executeTool()` to avoid double prompting
+- Improved permission flow for better UX
+
+---
+
 ## [1.3.0] - 2026-02-17
 
 ### 🎯 Major Feature - Token-Tracked Sessions with Predictable Costs

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@heysalad/cheri-cli",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "Cheri CLI - AI-powered cloud IDE by HeySalad®. With token-tracked sessions, predictable AI costs, and automatic workspace management.",
   "type": "module",
   "bin": {

package/src/commands/agent.js

@@ -181,7 +181,7 @@ async function executeLocalToolEnhanced(name, args) {
 // ── Main tool execution with approval + hooks + permissions ───────────────────
 let sessionAutoApprove = false;
 
-async function executeTool(name, args, orchestrator, allTools, parseSSE, mcpManager) {
+async function executeTool(name, args, orchestrator, allTools, parseSSE, mcpManager, skipApproval = false) {
   // Permission rules check
   const permission = checkPermission(name, args);
   if (permission === "deny") return { error: `Tool ${name} is denied by permission rules` };
@@ -212,7 +212,9 @@ async function executeTool(name, args, orchestrator, allTools, parseSSE, mcpMana
   }
 
   // Local tools — enhanced approval system
-  if (!sessionAutoApprove) {
+  // Note: For tools executed via executeOne in agent loop, approval is handled
+  // BEFORE spinner creation to avoid blocking terminal. This is a fallback.
+  if (!sessionAutoApprove && !skipApproval) {
     const decision = shouldApprove(name, args);
     if (decision === "deny") return { error: "Denied by approval policy" };
     if (decision === "ask" || decision === "suggest") {
@@ -286,6 +288,51 @@ async function* parseSSEStream(response) {
   }
 }
 
+// ── Upfront permission request ────────────────────────────────────────────────
+async function requestUpfrontPermissions(userRequest) {
+  const approvalMode = getApprovalMode();
+
+  // Skip if in auto mode or already auto-approved this session
+  if (approvalMode === "auto" || sessionAutoApprove) {
+    return true;
+  }
+
+  // Check if request likely involves write operations
+  const writeKeywords = ['build', 'create', 'make', 'write', 'add', 'implement', 'generate', 'fix', 'update', 'modify', 'delete', 'install', 'setup'];
+  const hasWriteIntent = writeKeywords.some(kw => userRequest.toLowerCase().includes(kw));
+
+  if (!hasWriteIntent) {
+    return true; // No write operations expected, proceed
+  }
+
+  // Show upfront permission request
+  console.log("");
+  log.info("This task may require file modifications and command execution.");
+  console.log("");
+
+  return new Promise((resolve) => {
+    const rl = readline.createInterface({ input: process.stdin, output: process.stdout });
+    rl.question(
+      chalk.yellow(`  Grant permissions for this session? ${chalk.dim("[Y]es, [n]o, [a]lways")} `),
+      (answer) => {
+        rl.close();
+        const a = answer.trim().toLowerCase();
+        if (a === "a" || a === "always") {
+          sessionAutoApprove = true;
+          log.success("Auto-approve enabled for this session");
+          resolve(true);
+        } else if (a === "n" || a === "no") {
+          log.warn("Permissions denied");
+          resolve(false);
+        } else {
+          log.success("Permissions granted - will ask before risky operations");
+          resolve(true);
+        }
+      }
+    );
+  });
+}
+
 // ── Active session state ──────────────────────────────────────────────────────
 let currentSession = null;
 
@@ -297,6 +344,13 @@ export async function runAgent(userRequest, options = {}) {
   const memoryContext = getMemoryContext();
   const skillContext = getSkillContext(plugins.skills, userRequest);
 
+  // Request upfront permissions if needed
+  const hasPermission = await requestUpfrontPermissions(userRequest);
+  if (!hasPermission) {
+    log.error("Task cancelled - permissions denied");
+    return;
+  }
+
   // Create provider (defaults to Cheri cloud which uses AWS Bedrock)
   const providerName = getConfigValue("agent.provider") || getConfigValue("ai.provider") || "cheri";
   let provider;
@@ -567,7 +621,26 @@ export async function runAgent(userRequest, options = {}) {
         const isMcp = mcpManager.isMcpTool(tc.name);
         const isLocal = !CLOUD_TOOL_NAMES.has(tc.name) && !AGENT_TOOL_NAMES.has(tc.name) && !isMcp;
 
-        // Create animated panel for this tool execution
+        // Check if approval is needed BEFORE creating spinner
+        let needsApproval = false;
+        if (isLocal && !sessionAutoApprove) {
+          const decision = shouldApprove(tc.name, input);
+          if (decision === "ask" || decision === "suggest") {
+            needsApproval = true;
+
+            // Get approval WITHOUT spinner running
+            const approved = await promptApproval(tc.name, input, decision);
+            if (approved === "auto") {
+              sessionAutoApprove = true;
+            } else if (!approved) {
+              return { id: tc.id, result: { error: "User denied execution" } };
+            }
+          } else if (decision === "deny") {
+            return { id: tc.id, result: { error: "Denied by approval policy" } };
+          }
+        }
+
+        // Create animated panel for this tool execution (AFTER approval)
         const panel = new ToolPanel(tc.name, input);
 
         // Command safety label for run_command
@@ -577,7 +650,8 @@ export async function runAgent(userRequest, options = {}) {
           panel.update(`running ${safetyLabel}`);
         }
 
-        const result = await executeTool(tc.name, input, orchestrator, ALL_TOOLS, parseSSEStream, mcpManager);
+        // Skip approval in executeTool since we already handled it above
+        const result = await executeTool(tc.name, input, orchestrator, ALL_TOOLS, parseSSEStream, mcpManager, needsApproval);
 
         // Determine result message based on tool type
         let resultMsg = '';