@heyramzi/lint 1.33.0 → 2.0.0

package/README.md

@@ -6,7 +6,7 @@ Shared lint rules for Studio projects: one oxlint plugin, the oxlint base config
 
 - **Oxlint plugin**: the rules below, loaded through `jsPlugins`.
 - **Oxlint base config**: `@heyramzi/lint/oxlint`.
-- **Gates**: `heyramzi-commit-msg`, `heyramzi-comment-length`, `heyramzi-file-tokens`, `heyramzi-inline-path`, `heyramzi-jev-code`, `heyramzi-repo-rules`, `heyramzi-slop` and `heyramzi-svelte-markup`.
+- **Gates**: `heyramzi-commit-msg`, `heyramzi-comment-length`, `heyramzi-file-tokens`, `heyramzi-inline-path`, `heyramzi-jev-code`, `heyramzi-old-names`, `heyramzi-repo-rules`, `heyramzi-slop` and `heyramzi-svelte-markup`.
 
 There's no ESLint side. The Studio stack doesn't run ESLint, so the flat configs and the
 `heyramzi-lint` pre-commit CLI are gone.
@@ -31,7 +31,6 @@ deleted on 14 Sep 2026.
 | `no-class` | Prevents the use of classes in favor of functional composition. |
 | `no-default-export` | Enforces named exports for better discoverability and refactoring. |
 | `no-relative-imports` | Error in every preset. Blocks relative specifiers in `import`, `export … from`, `import()`, `require` and `vi.mock`; only `./$types` is exempt. `--fix` rewrites each to the most specific alias covering the target: package.json `imports` first, then tsconfig `paths` for files that tsconfig includes. `.mjs`, `.cjs` and `*.config.*` files get `imports` only, because they run before a bundler applies aliases. A target no alias covers is reported with no fix: add the alias. |
-| `no-relative-type-imports` | Deprecated and off: `no-relative-imports` covers type imports. |
 | `no-em-dash` | Error. Em and en dashes in comments, strings, template text and Svelte text. A spaced hyphen (` - `) fails there too, except where it isn't a dash: a string whose whole value is one em or en dash (an empty-value placeholder), a string or template that is code judged on content (SQL keywords like `SELECT … FROM` or `WHERE`, CSS `calc(` or `var(--`, GLSL `gl_` or `vec2`, JS `function x(`, `=>` or `const x =`), a markdown bullet at the start of a template line or comment line, `<style>`, and `sql`/`css`/`gql`/`html`/`raw` templates. Test and fixture files (`*.test.*`, `*.spec.*`, `__fixtures__/`, `fixtures/`) pass a spaced hyphen because their strings are inputs under test. A real em or en dash fails everywhere except a bare placeholder and a tagged template. |
 | `no-svelte4-syntax` | Error. `export let` and `$:` in a `.svelte` file. Svelte 4 markup is the markup gate's job. |
 | `no-app-stores` | Error. An import from `$app/stores`; read `page` from `$app/state`. |
@@ -42,7 +41,7 @@ deleted on 14 Sep 2026.
 | `no-redundant-prop-fallback` | Error. A `\|\|` or `??` fallback repeating the default a prop already has, in parameters, `$props()` and markup. |
 | `no-vitest-import-in-vite-plus` | Error. An import from `vitest` in a Vite+ package with no `vitest` dependency of its own; import from `vite-plus/test`. |
 | `no-skipped-or-focused-tests` | Error. `.only`, `.skip("title", fn)`, `xit`, `fit` and kin. A Playwright conditional skip, `test.skip(cond, "reason")`, passes. |
-| `convex-*` | 10 rules, an `overrides` entry on `**/convex/**` in the base config. Error: `require-args` (and the old function syntax), `no-deprecated-crons`, `internal-only` (crons, scheduler, HTTP actions), `no-get-metadata`, `runtime-imports`. Warn while old hits remain: `require-returns`, `no-filter`, `no-v-any`, `no-date-now-in-query`, `index-name`. `convex-react-client-module-scope` is error everywhere. Replaces the `@convex-dev/eslint-plugin` the skill claimed and no repo installed. |
+| `convex-*` | 10 rules, an `overrides` entry on `**/convex/**` in the base config. Error: `require-args` (and the old function syntax), `no-hourly-daily-crons`, `internal-only` (crons, scheduler, HTTP actions), `no-get-metadata`, `runtime-imports`. Warn while old hits remain: `require-returns`, `no-filter`, `no-v-any`, `no-date-now-in-query`, `index-name`. `convex-react-client-module-scope` is error everywhere. Replaces the `@convex-dev/eslint-plugin` the skill claimed and no repo installed. |
 
 ## The alias convention `no-relative-imports` enforces
 
@@ -143,7 +142,7 @@ Test and fixture files need no entry: `no-emoji` skips them already.
 
 ### Comment Length Gate
 
-The conduct core caps a comment at 30 words. `heyramzi-comment-length` enforces it over a
+`ai-doc/rules/comments.md` caps a comment at 30 words. `heyramzi-comment-length` enforces it over a
 whole repo: block comments, HTML comments and runs of consecutive line comments (`//`, `#`, `--`).
 
 ```bash
@@ -154,7 +153,7 @@ It's a hard cap. There's no allowlist, no baseline and no `--update`: a file ove
 until the comment is cut down, whether it's new or years old.
 
 The same gate fails a comment that marks a hack left in place: a `TODO`, `FIXME` or `HACK` tag,
-"for now", a temporary fix, backward compat, a legacy alias or path, or `@deprecated`. Agents
+"for now", a temporary fix, backward compat or `@deprecated`. Agents
 copy these along with the hack. Fix what the comment names, then delete it. A word inside
 backticks is a quote and passes. The list is `MARKERS` in `comment-length.js`.
 
@@ -195,12 +194,16 @@ Installed into every Studio repo's active pre-push hook by `bash ai-doc/scripts/
 
 ### File Token Gate
 
-No staged file may run past 5,000 tokens, counted as bytes / 4. `heyramzi-file-tokens` reads the
-staged blobs, not the working copy, so it judges exactly what the commit records.
+No staged file may run past its cap, counted as bytes / 4: 5,000 tokens for code, 8,000 for
+Markdown, because a reference reads top to bottom and splitting it at 5,000 scattered one topic over
+linked files. `heyramzi-file-tokens` reads the staged blobs, not the working copy, so it judges
+exactly what the commit records. `heyramzi-file-tokens --file <path>…` runs the same check on working
+copies; the `file-tokens-warn.sh` hook calls it after every write, so a file is split when it
+crosses the cap, not at someone else's commit.
 
 It skips pages, stylesheets and logs (`.html`, `.css`, `.log`), and what no person or agent
 writes by hand: lockfiles, `CHANGELOG.md`, `*.generated.*`, minified bundles, source maps, snapshots, SVGs, binaries, generated and vendored trees (`dist`,
-`_generated`, `vendor`, the `.claude/` projections, …), files whose first 2 KB carry a codegen
+`_generated`, `vendor`, `.obsidian` plugin bundles, the `.claude/` projections, …), files whose first 2 KB carry a codegen
 header (`@generated`, `Do not edit`, `Generated by`), and paths `.gitattributes` marks
 `linguist-generated`. A pure rename passes. There's no config and no allowlist: a hand-written
 file over the cap is split, and the refusal says how.
@@ -219,6 +222,23 @@ classes in Swift, zoom-blocking viewports, `user-select: none` on body, `outline
 `@heyramzi/ui/src`, `adapter-cloudflare` without `paths.relative: false`, and a `static/` file under a route.
 No allowlist and no config.
 
+Interface rules, from Jakub Krehel's checklist (in `ui-rules-css.js` and `ui-rules-markup.js`). They judge
+`.svelte`, `.css`, `.ts` and `.tsx`, never `.html` exports, and skip comments and `<code>`:
+
+- **CSS and Tailwind:** `will-change-all`, `will-change-layout` (anything but transform, opacity, filter),
+  `press-scale-floor` (an `active` scale under 0.95), `keyframe-toggle` (an `animation` on hover or open
+  state; the shared collapsible and accordion height keyframes pass), `light-small-text` (font-thin,
+  extralight or light with text-xs, sm or base), `line-height-unit` (px or rem), `tracking-px` (px or rem
+  letter-spacing), `raw-font-tags` (`wght`, `opsz`, `tnum`, `zero` in the font-*-settings properties),
+  `balance-paragraph` (`text-balance` on a `<p>`), `text-justify`. The `line-height: 24px`-style
+  declarations aren't read in plain `.ts`, where they're emails and OG images.
+- **Markup, `.svelte` only:** `div-onclick` (a `<div>` or `<span>` with `onclick` and no role),
+  `role-no-keys` (role button or tab with `onclick`, no key handler, no `use:` or spread),
+  `img-no-alt`, `aria-hidden-focusable`, `input-autocomplete` (email, password or tel), `block-paste`
+  (a handler that only cancels the paste).
+- **Any file:** `positive-tabindex`, `locale-less-date` (`toLocaleDateString()`, or `toLocaleTimeString()`,
+  with no locale).
+
 ### Svelte Markup Gate
 
 oxlint never reads a `.svelte` template, and skips a file with no `<script>`, so
@@ -234,6 +254,37 @@ pnpm exec heyramzi-svelte-markup --all  # every tracked .svelte file
 Generated and vendored trees are skipped (`DEFAULT_IGNORED` in `svelte-markup.js`). It runs in the
 managed `push gates` block. No allowlist and no config.
 
+### Old Names Gate
+
+"None of our repos should have legacy" (Ramzi, 22 Oct 2026). `heyramzi-old-names` fails a repo
+that keeps a name for how things used to work. The house rule it enforces: a refactor leaves no
+compat layer, so no alias export, no `oldField?` kept for a migration and no shim.
+
+```bash
+pnpm exec heyramzi-old-names        # the pushed files, or every tracked one outside a push
+pnpm exec heyramzi-old-names --all  # every tracked file, for an audit
+```
+
+- **The word `legacy`**, in any case and inside a longer word (`fromLegacy`, `LEGACY_KID`,
+  `monthlyValueLegacy`): in identifiers, comments, strings, template text and markup, and in file
+  and folder names.
+- **`compat`, `deprecated` and `shim`** (and `shims`), as a word part of a name only: an
+  identifier, a JSON, YAML or TOML key, a CSS or HTML name, a file or folder name. `toCompat`,
+  `deprecatedField` and `api-shim.ts` fail. `compatible`, `shimmer` and the word in a comment or
+  a string value pass, because they are different words or prose.
+- **Files read:** `ts tsx mts cts js jsx mjs cjs svelte swift py sql sh bash zsh css html json
+  jsonc yaml yml toml`. Prose (`md`, `mdx`, `txt`) is out of scope.
+- **Skipped:** what the file-token gate already treats as a tool's output (lockfiles,
+  `*.generated.*`, minified bundles, `dist`, `_generated`, `vendor`, `.svelte-kit`, `.obsidian`
+  plugin bundles, the `.claude` projections, …), a file whose first 2 KB carry a codegen header (`worker-configuration.d.ts`),
+  a path `.gitattributes` marks `linguist-generated`, and any `migrations/` or `drizzle/` folder,
+  because an applied migration is history the database already ran.
+
+Each hit prints the file, line and token, then says to delete the old path and move every caller,
+or rename the thing to what it is now. No allowlist, no baseline, no config, no ignore marker.
+Installed with the other push gates by `bash ai-doc/scripts/pre-push-hooks.sh`. The source spells
+the banned words in pieces, so it passes its own gate.
+
 ### Repo Rules Gate
 
 `heyramzi-repo-rules` judges staged files, and `--all` every tracked file for an audit. Each

package/bin/heyramzi-comment-length.js

@@ -109,9 +109,7 @@ function gate(files) {
     console.error(`${file}:${line}: ${label}`);
   }
   if (markers.length > 0) {
-    console.error(
-      "\nFix what the comment names, or delete it. No legacy name survives a refactor.",
-    );
+    console.error("\nFix what the comment names, or delete it. No old name survives a refactor.");
   }
   exit(1);
 }

package/bin/heyramzi-file-tokens.js

@@ -1,42 +1,72 @@
 #!/usr/bin/env node
 /**
- * The file-token gate over staged files. Usage: this package's README, "File Token Gate".
+ * The file-token gate. Usage: this package's README, "File Token Gate".
  *
- *   heyramzi-file-tokens  # non-zero when a staged file runs over 5,000 tokens
+ *   heyramzi-file-tokens               # staged files
+ *   heyramzi-file-tokens --file <p>…   # working copies, for the write-time hook
  */
 
 import { execFileSync } from "node:child_process";
-import { exit } from "node:process";
+import { readFileSync, statSync } from "node:fs";
+import { dirname, relative, resolve } from "node:path";
+import { argv, exit } from "node:process";
 
-import {
-  MAX_TOKENS,
-  check,
-  generatedContent,
-  ignoredPath,
-  report,
-} from "#lint/file-tokens.js";
+import { check, generatedContent, ignoredPath, report } from "#lint/file-tokens.js";
 
-const repoRoot = execFileSync("git", ["rev-parse", "--show-toplevel"], { encoding: "utf8" }).trim();
+const fileMode = argv[2] === "--file";
+// A hook passes a path from any repo, so the file's own folder names the repo, not the cwd.
+const repoRoot = gitRoot(fileMode && argv[3] ? dirname(resolve(argv[3])) : ".");
+if (!repoRoot) exit(0);
 const git = (args, input) =>
   execFileSync("git", args, { cwd: repoRoot, input, maxBuffer: 256 * 1024 * 1024 });
 
-const failures = check(stagedSizes(staged().filter((file) => !ignoredPath(file))));
+const failures = fileMode
+  ? check(workingSizes(argv.slice(3)))
+  : check(stagedSizes(staged().filter((file) => !ignoredPath(file))));
 const real = failures.filter(({ file }) => !generated(file));
 
 if (real.length === 0) {
-  console.log(`file-tokens: every staged file is under ${MAX_TOKENS.toLocaleString("en-US")} tokens`);
+  console.log(`file-tokens: every ${fileMode ? "" : "staged "}file is under its cap`);
 } else {
   console.error(report(real));
   exit(1);
 }
 
+function gitRoot(cwd) {
+  try {
+    return execFileSync("git", ["rev-parse", "--show-toplevel"], {
+      cwd,
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "ignore"],
+    }).trim();
+  } catch {
+    return "";
+  }
+}
+
+/** Working-copy sizes of the given paths, repo-relative, skipping what the gate never caps. */
+function workingSizes(paths) {
+  return Object.fromEntries(
+    paths
+      .map((path) => relative(repoRoot, resolve(path)))
+      .filter((file) => !file.startsWith("..") && !ignoredPath(file))
+      .flatMap((file) => {
+        try {
+          return [[file, statSync(resolve(repoRoot, file)).size]];
+        } catch {
+          return [];
+        }
+      }),
+  );
+}
+
 /** Added, copied, modified and renamed files. A pure move (R100) changes nothing, so it passes. */
 function staged() {
   const fields = git(["diff", "--cached", "--name-status", "-M", "-z", "--diff-filter=ACMR"])
     .toString("utf8")
     .split("\0");
   const files = [];
-  for (let index = 0; index < fields.length - 1; ) {
+  for (let index = 0; index < fields.length - 1;) {
     const status = fields[index];
     const paired = status.startsWith("R") || status.startsWith("C");
     const target = fields[index + (paired ? 2 : 1)];
@@ -49,18 +79,32 @@ function staged() {
 /** Byte size of each file's staged blob, which is what gets committed, not the working copy. */
 function stagedSizes(files) {
   if (files.length === 0) return {};
-  const lines = git(["cat-file", "--batch-check=%(objectsize)"], files.map((file) => `:${file}`).join("\n"))
+  const lines = git(
+    ["cat-file", "--batch-check=%(objectsize)"],
+    files.map((file) => `:${file}`).join("\n"),
+  )
     .toString("utf8")
     .trim()
     .split("\n");
   return Object.fromEntries(
-    files.flatMap((file, index) => (/^\d+$/.test(lines[index]) ? [[file, Number(lines[index])]] : [])),
+    files.flatMap((file, index) =>
+      /^\d+$/.test(lines[index]) ? [[file, Number(lines[index])]] : [],
+    ),
   );
 }
 
 /** Content markers or `.gitattributes` say a machine wrote this file. Checked only for files over the cap. */
 function generated(file) {
-  const attribute = git(["check-attr", "--cached", "linguist-generated", "--", file]).toString("utf8");
+  const attribute = git([
+    "check-attr",
+    ...(fileMode ? [] : ["--cached"]),
+    "linguist-generated",
+    "--",
+    file,
+  ]).toString("utf8");
   if (/: (set|true)\s*$/.test(attribute)) return true;
-  return generatedContent(git(["cat-file", "blob", `:${file}`]).subarray(0, 8000));
+  const head = fileMode
+    ? readFileSync(resolve(repoRoot, file))
+    : git(["cat-file", "blob", `:${file}`]);
+  return generatedContent(head.subarray(0, 8000));
 }

package/bin/heyramzi-old-names.js

@@ -0,0 +1,72 @@
+#!/usr/bin/env node
+/**
+ * The old-names gate over pushed files (every tracked one outside a push), `--all`, or named files.
+ * Usage: this package's README, "Old Names Gate".
+ */
+
+import { execFileSync } from "node:child_process";
+import { existsSync, readFileSync } from "node:fs";
+import path from "node:path";
+import { exit } from "node:process";
+
+import { gateFiles } from "#lint/gate-files.js";
+import { check, OLD_NAME_EXTENSIONS, report, selectFiles } from "#lint/old-names.js";
+
+const repoRoot = execFileSync("git", ["rev-parse", "--show-toplevel"], { encoding: "utf8" }).trim();
+// Run from a product inside a monorepo, the gate reads that product's files, not its siblings'.
+const scope = execFileSync("git", ["rev-parse", "--show-prefix"], { encoding: "utf8" })
+  .trim()
+  .replace(/\/$/, "");
+
+const args = process.argv.slice(2);
+if (args.includes("--all")) delete process.env.PUSH_FILES;
+const targets = args.filter((arg) => !arg.startsWith("-"));
+
+const candidates =
+  targets.length > 0
+    ? targets
+    : process.env.PUSH_FILES !== undefined
+      ? process.env.PUSH_FILES.split("\n").filter(Boolean)
+      : repoFiles();
+const files = notMarkedGenerated(gateFiles(repoRoot, selectFiles(candidates)));
+
+const hits = check(
+  Object.fromEntries(files.map((file) => [file, readFileSync(path.join(repoRoot, file), "utf8")])),
+);
+if (hits.length === 0) {
+  console.log(`old-names: ${files.length} file(s), no old name`);
+} else {
+  console.error(report(hits));
+  exit(1);
+}
+
+/** Tracked files plus new ones git hasn't seen yet, minus any deleted from the working tree. */
+function repoFiles() {
+  const patterns = OLD_NAME_EXTENSIONS.map((ext) => `*.${ext}`);
+  const args = ["ls-files", "--cached", "--others", "--exclude-standard", "--deduplicate"];
+  return execFileSync("git", [...args, "--full-name", "--", ...patterns], {
+    cwd: path.join(repoRoot, scope),
+    encoding: "utf8",
+    maxBuffer: 256 * 1024 * 1024,
+  })
+    .trim()
+    .split("\n")
+    .filter((file) => file && existsSync(path.join(repoRoot, file)));
+}
+
+/** Drops the files `.gitattributes` marks linguist-generated, the way the file-token gate does. */
+function notMarkedGenerated(list) {
+  if (list.length === 0) return list;
+  const out = execFileSync("git", ["check-attr", "-z", "--stdin", "linguist-generated"], {
+    cwd: repoRoot,
+    input: `${list.join("\0")}\0`,
+    maxBuffer: 256 * 1024 * 1024,
+  })
+    .toString("utf8")
+    .split("\0");
+  const generated = new Set();
+  for (let index = 0; index + 2 < out.length; index += 3) {
+    if (out[index + 2] === "set" || out[index + 2] === "true") generated.add(out[index]);
+  }
+  return list.filter((file) => !generated.has(file));
+}

package/bin/heyramzi-push-diff.js

@@ -59,11 +59,17 @@ function mergeBase() {
 
 /** New path to old path for every added, copied, modified or renamed file. A pure move is R100 and changes nothing. */
 function changedFiles() {
-  const fields = git(["diff", "--name-status", "-M", "-z", "--diff-filter=ACMR", base, "HEAD"]).split(
-    "\0",
-  );
+  const fields = git([
+    "diff",
+    "--name-status",
+    "-M",
+    "-z",
+    "--diff-filter=ACMR",
+    base,
+    "HEAD",
+  ]).split("\0");
   const map = new Map();
-  for (let index = 0; index < fields.length - 1; ) {
+  for (let index = 0; index < fields.length - 1;) {
     const status = fields[index];
     const paired = status.startsWith("R") || status.startsWith("C");
     const target = fields[index + (paired ? 2 : 1)];
@@ -87,7 +93,12 @@ function registryFiles(candidates) {
       "--",
       ...code.slice(index, index + 200),
     ]);
-    found.push(...out.split("\n").filter(Boolean).map((line) => line.replace(/^HEAD:/, "")));
+    found.push(
+      ...out
+        .split("\n")
+        .filter(Boolean)
+        .map((line) => line.replace(/^HEAD:/, "")),
+    );
   }
   return found.filter((file) => hasStorageKeys(tryGit(["show", `HEAD:${file}`])));
 }

package/bin/heyramzi-ui-rules.js

@@ -1,10 +1,7 @@
 #!/usr/bin/env node
 /**
- * The UI-rules gate over staged or pushed files. Usage: this package's README, "UI Rules Gate".
- *
- *   heyramzi-ui-rules          # staged files, or PUSH_FILES when the pre-push hook sets it
- *   heyramzi-ui-rules --all    # every tracked file
- *   heyramzi-ui-rules a.svelte # named files
+ * The UI-rules gate over staged or pushed files, `--all` for every tracked file, or named files.
+ * Usage: this package's README, "UI Rules Gate".
  */
 
 import { execFileSync } from "node:child_process";
@@ -13,10 +10,18 @@ import path from "node:path";
 import { exit } from "node:process";
 
 import { gateFiles } from "#lint/gate-files.js";
-import { checkFile, checkProject, durationNames, ignoredPath, report, resolvedDurations } from "#lint/ui-rules.js";
+import {
+  checkFile,
+  checkProject,
+  durationNames,
+  ignoredPath,
+  report,
+  resolvedDurations,
+} from "#lint/ui-rules.js";
 
 const repoRoot = execFileSync("git", ["rev-parse", "--show-toplevel"], { encoding: "utf8" }).trim();
-const git = (args) => execFileSync("git", args, { cwd: repoRoot, encoding: "utf8", maxBuffer: 256 * 1024 * 1024 });
+const git = (args) =>
+  execFileSync("git", args, { cwd: repoRoot, encoding: "utf8", maxBuffer: 256 * 1024 * 1024 });
 const lines = (text) => text.split("\n").filter(Boolean);
 
 const args = process.argv.slice(2);
@@ -33,7 +38,10 @@ const candidates = named.length
       ? lines(git(["diff", "--cached", "--name-only", "--diff-filter=ACMR"]))
       : lines(process.env.PUSH_FILES);
 
-const files = gateFiles(repoRoot, candidates.filter((file) => !ignoredPath(file)));
+const files = gateFiles(
+  repoRoot,
+  candidates.filter((file) => !ignoredPath(file)),
+);
 const read = (file) => {
   const full = path.join(repoRoot, file);
   return existsSync(full) ? readFileSync(full, "utf8") : null;
@@ -46,7 +54,8 @@ for (const file of files) {
   for (const hit of checkFile(file, source)) hits.push({ file, ...hit });
 }
 hits.push(...checkProject(files, tracked, read));
-if (hits.some((hit) => hit.rule === "duration-bare")) hits = resolvedDurations(hits, durationNames(tracked, read));
+if (hits.some((hit) => hit.rule === "duration-bare"))
+  hits = resolvedDurations(hits, durationNames(tracked, read));
 
 if (hits.length === 0) {
   console.log("ui-rules: no violations");

package/comment-length.js

@@ -1,6 +1,6 @@
 /**
  * The 30-word comment cap: a comment that outgrows its explanation stops being
- * read. The rule is `ai-doc/references/agents-core.md`.
+ * read. The rule is `ai-doc/rules/comments.md`.
  *
  * Pure here, git and process in `bin/heyramzi-comment-length.js`.
  */
@@ -150,10 +150,13 @@ function mergeRuns(src, spans) {
   return merged;
 }
 
-/** The comments of a file in `extension`'s language, as spans. */
-export function commentSpansFor(src, extension) {
+/**
+ * The comments of a file in `extension`'s language, as spans. Pass `strings` and the string and
+ * heredoc spans of Swift, Python, shell, CSS and SQL land in it.
+ */
+export function commentSpansFor(src, extension, strings) {
   const syntax = syntaxOf(extension);
-  return syntax ? simpleSpans(src, syntax) : commentSpans(src);
+  return syntax ? simpleSpans(src, syntax, strings) : commentSpans(src);
 }
 
 function skipString(src, i, syntax) {
@@ -202,14 +205,16 @@ function skipHeredocs(src, i, pending) {
   return j;
 }
 
-function simpleSpans(src, syntax) {
+function simpleSpans(src, syntax, strings) {
   const spans = [];
   const pending = [];
   let i = 0;
   while (i < src.length) {
     const c = src[i];
     if (c === "\n" && pending.length) {
+      const bodyStart = i;
       i = skipHeredocs(src, i, pending.splice(0));
+      strings?.push({ start: bodyStart, end: i });
     } else if (c === "\\" && syntax.escapes) {
       i += 2;
     } else if (
@@ -238,12 +243,21 @@ function simpleSpans(src, syntax) {
       spans.push({ kind: "block", start: i, end: j });
       i = j;
     } else if (syntax.raw && c === "#" && rawStringEnd(src, i) !== null) {
+      strings?.push({ start: i, end: rawStringEnd(src, i) });
       i = rawStringEnd(src, i);
-    } else if (syntax.url && src.startsWith("url(", i) && !/^url\(\s*["']/.test(src.slice(i, i + 12))) {
+    } else if (
+      syntax.url &&
+      src.startsWith("url(", i) &&
+      !/^url\(\s*["']/.test(src.slice(i, i + 12))
+    ) {
       const close = src.indexOf(")", i);
-      i = close === -1 ? src.length : close + 1;
+      const stop = close === -1 ? src.length : close + 1;
+      strings?.push({ start: i, end: stop });
+      i = stop;
     } else if (syntax.quotes.includes(c)) {
-      i = skipString(src, i, syntax);
+      const stop = skipString(src, i, syntax);
+      strings?.push({ start: i, end: stop });
+      i = stop;
     } else {
       // `<<<` is a here-string, and its 2nd and 3rd `<` must not read as a heredoc opener.
       const opener =
@@ -261,13 +275,13 @@ const REGEX_AFTER = new Set("(,=:[!&|?{};+-*%<>~^");
 const REGEX_KEYWORD = /\b(?:return|typeof|case|in|of|delete|void|throw|new|else|do|yield|await)$/;
 
 /** A `/` opens a regex after an operator or keyword, never after a value, so `a / b` stays division. */
-function regexStarts(src, i) {
+export function regexStarts(src, i) {
   const before = src.slice(0, i).trimEnd();
   return before === "" || REGEX_AFTER.has(before[before.length - 1]) || REGEX_KEYWORD.test(before);
 }
 
 /** Where a regex literal ends, flags included. A newline first means it was division after all. */
-function regexEnd(src, i) {
+export function regexEnd(src, i) {
   let j = i + 1;
   let inClass = false;
   while (j < src.length) {
@@ -318,10 +332,6 @@ export const MARKERS = [
     test: /\btemporar(?:y|ily)\s+(?:fix|workaround|hack|patch|solution)\b/i,
   },
   { label: "backward compatibility", test: /\bbackwards?[\s-]*compat/i },
-  {
-    label: "a legacy name or path",
-    test: /\blegacy\s+(?:alias|synonym|shim|wrapper|fallback|export|import|path|name|field|support|code|compat)\b/i,
-  },
   { label: "a @deprecated tag", test: /@deprecated\b/ },
 ];
 

package/config/oxlintrc.json

@@ -58,8 +58,7 @@
     "@heyramzi/lint/no-inline-svg": "error",
     "@heyramzi/lint/no-inline-path": "error",
     "@heyramzi/lint/no-relative-imports": "error",
-    "@heyramzi/lint/no-relative-type-imports": "off",
-    "@heyramzi/lint/no-legacy-compat": "error",
+    "@heyramzi/lint/no-underscore-reexport": "error",
     "@heyramzi/lint/convex-react-client-module-scope": "error",
     "@heyramzi/lint/no-chained-type-assertions": "warn",
     "@heyramzi/lint/no-conditional-empty-object-spread": "warn",
@@ -73,7 +72,7 @@
         "@heyramzi/lint/convex-index-name": "warn",
         "@heyramzi/lint/convex-internal-only": "error",
         "@heyramzi/lint/convex-no-date-now-in-query": "warn",
-        "@heyramzi/lint/convex-no-deprecated-crons": "error",
+        "@heyramzi/lint/convex-no-hourly-daily-crons": "error",
         "@heyramzi/lint/convex-no-filter": "warn",
         "@heyramzi/lint/convex-no-get-metadata": "error",
         "@heyramzi/lint/convex-no-v-any": "warn",

package/data/jev-code-bench.js

@@ -13,12 +13,12 @@ export const TRAIN = [
     code: `export async function load({ fetch }) {\n  const body = await (await fetch("/api/me")).json();\n  // @ts-ignore\n  return { name: body.profile.name as string };\n}`,
   },
   {
-    rule: "compat",
+    rule: "oldname",
     file: "src/lib/billing.ts",
     code: `export function chargeCustomer(id: string, cents: number) {\n  return stripe.charges.create({ customer: id, amount: cents });\n}\n\n/** @deprecated use chargeCustomer */\nexport const charge = chargeCustomer;`,
   },
   {
-    rule: "compat",
+    rule: "oldname",
     file: "src/lib/user.ts",
     code: `export function displayName(u: User) {\n  const first = u.firstName ?? u.first_name;\n  const last = u.lastName ?? u.last_name;\n  return \`\${first} \${last}\`;\n}`,
   },
@@ -95,7 +95,7 @@ export const TRAIN = [
   {
     rule: "leftover",
     file: "src/lib/checkout.ts",
-    code: `export function checkout(cart: Cart) {\n  console.log("cart here", cart);\n  // const old = legacyCheckout(cart);\n  // return old;\n  return submit(cart);\n}`,
+    code: `export function checkout(cart: Cart) {\n  console.log("cart here", cart);\n  // const old = oldCheckout(cart);\n  // return old;\n  return submit(cart);\n}`,
   },
   {
     rule: "leftover",
@@ -206,7 +206,7 @@ export const HELDOUT = [
     code: `export function handle(evt: Stripe.Event) {\n  const session = evt.data.object as unknown as CheckoutSession;\n  return session.customer_email!.toLowerCase();\n}`,
   },
   {
-    rule: "compat",
+    rule: "oldname",
     file: "src/lib/index.ts",
     code: `export { renderCard } from "./card";\n// kept so old imports keep working\nexport { renderCard as drawCard } from "./card";`,
   },
@@ -248,7 +248,7 @@ export const HELDOUT = [
   {
     rule: "leftover",
     file: "Sources/Feed.swift",
-    code: `func refresh() async {\n    print("DEBUG items", items.count)\n    // items = try await legacyFetch()\n    items = try await api.feed()\n}`,
+    code: `func refresh() async {\n    print("DEBUG items", items.count)\n    // items = try await oldFetch()\n    items = try await api.feed()\n}`,
   },
   {
     rule: "workaround",