@heyhuynhgiabuu/pi-pretty 0.4.0 → 0.4.1

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@heyhuynhgiabuu/pi-pretty",
-	"version": "0.4.0",
+	"version": "0.4.1",
 	"description": "Pretty terminal output for pi — syntax-highlighted file reads, colored bash output, tree-view directory listings, and more.",
 	"author": "huynhgiabuu",
 	"license": "MIT",

package/release-notes/v0.4.1.md

@@ -0,0 +1,28 @@
+# pi-pretty v0.4.1
+
+## Summary
+This patch release prevents `grep` from aborting Pi when FFF 0.5.2 indexes Unicode filenames and the grep call includes a `path` or `glob` constraint.
+
+## What changed
+- Constrained `grep` calls now bypass native FFF and use the SDK fallback path.
+- Unconstrained `grep` still uses FFF for the fast path.
+- Added regression tests for both `path` and `glob` constrained grep bypass behavior.
+
+## Why
+`@ff-labs/fff-node@0.5.2` can panic inside native Rust constraint matching when a byte-based slice lands inside a multi-byte UTF-8 character in an indexed filename, such as an en dash (`–`). Because that panic happens across FFI, JavaScript cannot catch it; the whole `pi` process aborts.
+
+This release avoids the crash-prone native constraint path until upstream FFF ships the Unicode boundary fix.
+
+## Files
+- `src/index.ts`
+- `test/fff-integration.test.ts`
+- `package.json`
+- `package-lock.json`
+
+## Verification
+- `npm run typecheck` ✅
+- `npm run lint` ✅
+- `npm test` ✅ (48 tests)
+
+## Upgrade notes
+No configuration changes required. After updating, file- or glob-scoped `grep` calls will prefer the SDK fallback for stability; broad unconstrained grep remains FFF-backed.

package/src/index.ts

@@ -1516,13 +1516,13 @@ export default function piPrettyExtension(pi: PiPrettyApi, deps?: PiPrettyDeps):
 				upd: unknown,
 				ctx: ExtensionContext,
 			) {
-				// Try FFF first (SIMD-accelerated, frecency-ranked)
-				if (_fffFinder && !_fffFinder.isDestroyed) {
+				// Try FFF first (SIMD-accelerated, frecency-ranked).
+				// FFF 0.5.2 can abort the process when path/glob constraints meet
+				// Unicode filenames, so constrained searches use the SDK fallback.
+				if (_fffFinder && !_fffFinder.isDestroyed && !params.path && !params.glob) {
 					try {
 						const effectiveLimit = Math.max(1, params.limit ?? 100);
-						let query = params.pattern;
-						if (params.glob) query = `${params.glob} ${query}`;
-						else if (params.path) query = `${params.path} ${query}`;
+						const query = params.pattern;
 
 						const grepResult = _fffFinder.grep(query, {
 							mode: params.literal ? "plain" : "regex",

package/test/fff-integration.test.ts

@@ -370,11 +370,20 @@ describe("piPrettyExtension integration", () => {
 			expect(grep).toHaveBeenCalledWith(expect.any(String), expect.objectContaining({ mode: "regex" }));
 		});
 
-		it("glob prepended to query", async () => {
+		it("glob constraints bypass FFF to avoid native Unicode path panic", async () => {
 			const grep = vi.fn().mockReturnValue({ ok: true, value: { items: [], totalMatched: 0, nextCursor: null } });
 			await loadWithFFF({ grep });
 			await tools.get("grep")!.execute("t1", { pattern: "TODO", glob: "*.ts" }, null, null, {});
-			expect(grep).toHaveBeenCalledWith("*.ts TODO", expect.any(Object));
+			expect(grep).not.toHaveBeenCalled();
+			expect(grepExec).toHaveBeenCalledOnce();
+		});
+
+		it("path constraints bypass FFF to avoid native Unicode path panic", async () => {
+			const grep = vi.fn().mockReturnValue({ ok: true, value: { items: [], totalMatched: 0, nextCursor: null } });
+			await loadWithFFF({ grep });
+			await tools.get("grep")!.execute("t1", { pattern: "TODO", path: "file_reviewapp/static/app.js" }, null, null, {});
+			expect(grep).not.toHaveBeenCalled();
+			expect(grepExec).toHaveBeenCalledOnce();
 		});
 
 		it("falls back to SDK on throw", async () => {