@heyhuynhgiabuu/pi-diff 0.8.2 → 0.9.0

package/dist/core/apply-patch.js

@@ -2,170 +2,534 @@
  * apply_patch — Multi-file patch engine.
  *
  * One call can add, update, delete, or move multiple files.
- * Uses replace.ts's conservative matcher for oldText → newText matching.
+ * Updates use a conservative matcher and are committed only after every
+ * change has been prepared successfully.
  */
+import { isUtf8 } from "node:buffer";
 import * as fs from "node:fs";
 import * as path from "node:path";
-import { replaceForPatch } from "./replace.js";
+import { structuredPatch } from "diff";
+import { findPatchReplacement } from "./replace.js";
+import { detectLineEnding, normalizeForLineEnding, restoreLineEndings, stripBom } from "./text-encoding.js";
+function isRecord(value) {
+    return typeof value === "object" && value !== null && !Array.isArray(value);
+}
+function requiredString(value, field, context) {
+    if (typeof value !== "string" || value.length === 0)
+        throw new Error(`${context}.${field} must be a non-empty string`);
+    return value;
+}
+function requiredText(value, field, context) {
+    if (typeof value !== "string")
+        throw new Error(`${context}.${field} must be a string`);
+    return value;
+}
+function rejectUnknownKeys(value, allowed, context) {
+    const allowedSet = new Set(allowed);
+    for (const key of Object.keys(value)) {
+        if (!allowedSet.has(key))
+            throw new Error(`${context}.${key} is not supported`);
+    }
+}
+function parseUpdateEdits(value, context) {
+    if (!Array.isArray(value) || value.length === 0)
+        throw new Error(`${context}.edits must contain at least one replacement`);
+    return value.map((entry, index) => {
+        const editContext = `${context}.edits[${index}]`;
+        if (!isRecord(entry))
+            throw new Error(`${editContext} must be an object`);
+        rejectUnknownKeys(entry, ["oldText", "newText"], editContext);
+        return {
+            oldText: requiredString(entry.oldText, "oldText", editContext),
+            newText: requiredText(entry.newText, "newText", editContext),
+        };
+    });
+}
+/** Decode the model-facing tool payload before it reaches the mutation core. */
+export function parseApplyPatchInput(input) {
+    if (!isRecord(input))
+        throw new Error("apply_patch input must be an object");
+    rejectUnknownKeys(input, ["changes"], "apply_patch");
+    if (!Array.isArray(input.changes) || input.changes.length === 0) {
+        throw new Error("apply_patch.changes must contain at least one change");
+    }
+    return input.changes.map((entry, index) => {
+        const context = `apply_patch.changes[${index}]`;
+        if (!isRecord(entry))
+            throw new Error(`${context} must be an object`);
+        const pathValue = requiredString(entry.path, "path", context);
+        const action = requiredString(entry.action, "action", context);
+        switch (action) {
+            case "add":
+                rejectUnknownKeys(entry, ["path", "action", "content"], context);
+                return { path: pathValue, action, content: requiredText(entry.content, "content", context) };
+            case "update": {
+                rejectUnknownKeys(entry, ["path", "action", "oldText", "newText", "edits"], context);
+                if (entry.edits !== undefined) {
+                    if (entry.oldText !== undefined || entry.newText !== undefined) {
+                        throw new Error(`${context} cannot combine edits with oldText/newText`);
+                    }
+                    return { path: pathValue, action, edits: parseUpdateEdits(entry.edits, context) };
+                }
+                return {
+                    path: pathValue,
+                    action,
+                    oldText: requiredString(entry.oldText, "oldText", context),
+                    newText: entry.newText === undefined ? undefined : requiredText(entry.newText, "newText", context),
+                };
+            }
+            case "delete":
+                rejectUnknownKeys(entry, ["path", "action"], context);
+                return { path: pathValue, action };
+            case "move":
+                rejectUnknownKeys(entry, ["path", "action", "movePath"], context);
+                return { path: pathValue, action, movePath: requiredString(entry.movePath, "movePath", context) };
+            default:
+                throw new Error(`${context}.action must be add, update, delete, or move`);
+        }
+    });
+}
+const pathLocks = new Map();
 // ---------------------------------------------------------------------------
-// Atomic file write
+// Path and filesystem safety
 // ---------------------------------------------------------------------------
-async function atomicWriteFile(filePath, content, mode) {
-    const dir = path.dirname(filePath);
-    const tmp = path.join(dir, `.${path.basename(filePath)}.pi-apply-patch.${process.pid}.tmp`);
-    await fs.promises.writeFile(tmp, content, { encoding: "utf8", mode });
-    await fs.promises.rename(tmp, filePath);
+function isMissingPathError(error) {
+    return (typeof error === "object" &&
+        error !== null &&
+        "code" in error &&
+        (error.code === "ENOENT" || error.code === "ENOTDIR"));
 }
-async function readRegularFile(filePath, label) {
-    let stats;
+function formatFilesystemError(error) {
+    if (error instanceof Error) {
+        const code = "code" in error && typeof error.code === "string" ? `${error.code}: ` : "";
+        return `${code}${error.message}`;
+    }
+    return String(error);
+}
+function isWithin(root, candidate) {
+    const relative = path.relative(root, candidate);
+    return relative === "" || (relative !== ".." && !relative.startsWith(`..${path.sep}`) && !path.isAbsolute(relative));
+}
+async function assertSafeAncestors(filePath, root, label) {
+    const relative = path.relative(root, filePath);
+    if (!isWithin(root, filePath))
+        throw new Error(`${label} must stay within workspace root: ${filePath}`);
+    if (relative === "")
+        return;
+    let current = root;
+    const segments = relative.split(path.sep).filter(Boolean);
+    for (let index = 0; index < segments.length; index++) {
+        current = path.join(current, segments[index]);
+        let stats;
+        try {
+            stats = await fs.promises.lstat(current);
+        }
+        catch (error) {
+            if (isMissingPathError(error))
+                return;
+            throw new Error(`${label} could not be inspected: ${formatFilesystemError(error)}`);
+        }
+        if (stats.isSymbolicLink())
+            throw new Error(`${label} must not traverse a symbolic link: ${filePath}`);
+        if (index < segments.length - 1 && !stats.isDirectory()) {
+            throw new Error(`${label} parent must be a directory: ${filePath}`);
+        }
+    }
+}
+async function createPathPolicy(options) {
+    const root = path.resolve(options.root ?? options.cwd ?? process.cwd());
+    const cwd = path.resolve(options.cwd ?? root);
     try {
-        stats = await fs.promises.lstat(filePath);
+        const rootStats = await fs.promises.stat(root);
+        const cwdStats = await fs.promises.stat(cwd);
+        if (!rootStats.isDirectory())
+            throw new Error(`${root} is not a directory`);
+        if (!cwdStats.isDirectory())
+            throw new Error(`${cwd} is not a directory`);
     }
-    catch {
-        throw new Error(`${label} not found: ${filePath}`);
+    catch (error) {
+        throw new Error(`workspace could not be resolved: ${formatFilesystemError(error)}`);
+    }
+    if (!isWithin(root, cwd))
+        throw new Error(`cwd must stay within workspace root: ${cwd}`);
+    return {
+        async resolve(filePath, label) {
+            if (typeof filePath !== "string" || filePath.length === 0)
+                throw new Error(`${label} path is required`);
+            const resolved = path.resolve(cwd, filePath);
+            if (!isWithin(root, resolved))
+                throw new Error(`${label} must stay within workspace root: ${filePath}`);
+            await assertSafeAncestors(resolved, root, label);
+            return resolved;
+        },
+    };
+}
+async function lstatIfExists(filePath) {
+    try {
+        return await fs.promises.lstat(filePath);
     }
-    if (stats.isSymbolicLink())
+    catch (error) {
+        if (isMissingPathError(error))
+            return undefined;
+        throw error;
+    }
+}
+async function readRegularFile(filePath, label) {
+    const initialStats = await lstatIfExists(filePath);
+    if (!initialStats)
+        throw new Error(`${label} not found: ${filePath}`);
+    if (initialStats.isSymbolicLink())
         throw new Error(`${label} must not be a symbolic link: ${filePath}`);
-    if (!stats.isFile())
+    if (!initialStats.isFile())
         throw new Error(`${label} must be a regular file: ${filePath}`);
-    return { content: await fs.promises.readFile(filePath, "utf8"), mode: stats.mode };
+    const noFollow = fs.constants.O_NOFOLLOW ?? 0;
+    let handle;
+    try {
+        handle = await fs.promises.open(filePath, fs.constants.O_RDONLY | noFollow);
+        const stats = await handle.stat();
+        if (!stats.isFile())
+            throw new Error(`${label} must be a regular file: ${filePath}`);
+        const bytes = await handle.readFile();
+        if (!isUtf8(bytes))
+            throw new Error(`${label} must contain valid UTF-8 text: ${filePath}`);
+        const rawContent = bytes.toString("utf8");
+        return {
+            bytes,
+            rawContent,
+            mode: stats.mode & 0o7777,
+            dev: stats.dev,
+            ino: stats.ino,
+            mtimeMs: stats.mtimeMs,
+            size: stats.size,
+        };
+    }
+    catch (error) {
+        if (error instanceof Error && error.message.includes("valid UTF-8"))
+            throw error;
+        throw new Error(`${label} could not be read: ${formatFilesystemError(error)}`);
+    }
+    finally {
+        await handle?.close();
+    }
+}
+async function assertUnchanged(filePath, original, label) {
+    const current = await readRegularFile(filePath, label);
+    if (current.dev !== original.dev ||
+        current.ino !== original.ino ||
+        current.size !== original.size ||
+        current.mtimeMs !== original.mtimeMs ||
+        !current.bytes.equals(original.bytes)) {
+        throw new Error(`${label} changed while patch was being prepared: ${filePath}`);
+    }
+}
+async function createParentDirectories(directory) {
+    const missing = [];
+    let current = directory;
+    while (true) {
+        const stats = await lstatIfExists(current);
+        if (stats) {
+            if (!stats.isDirectory())
+                throw new Error(`parent path is not a directory: ${current}`);
+            break;
+        }
+        missing.push(current);
+        const parent = path.dirname(current);
+        if (parent === current)
+            throw new Error(`could not find a directory for: ${directory}`);
+        current = parent;
+    }
+    try {
+        await fs.promises.mkdir(directory, { recursive: true });
+    }
+    catch (error) {
+        await removeCreatedDirectories(missing).catch(() => undefined);
+        throw error;
+    }
+    return missing;
 }
-async function pathExists(filePath) {
+async function removeCreatedDirectories(directories) {
+    for (const directory of directories) {
+        try {
+            await fs.promises.rmdir(directory);
+        }
+        catch (error) {
+            if (isMissingPathError(error) ||
+                (typeof error === "object" && error !== null && "code" in error && error.code === "ENOTEMPTY")) {
+                continue;
+            }
+            throw error;
+        }
+    }
+}
+async function atomicWriteFile(filePath, content, mode, replace = true) {
+    const directory = path.dirname(filePath);
+    const temporaryDirectory = await fs.promises.mkdtemp(path.join(directory, `.pi-apply-patch-${process.pid}-`));
+    const temporaryPath = path.join(temporaryDirectory, "content");
+    const desiredMode = mode ?? 0o666 & ~process.umask();
+    let handle;
     try {
-        await fs.promises.lstat(filePath);
-        return true;
+        handle = await fs.promises.open(temporaryPath, "wx", 0o600);
+        await handle.writeFile(content);
+        await handle.chmod(desiredMode);
+        await handle.sync();
+        await handle.close();
+        handle = undefined;
+        if (replace) {
+            await fs.promises.rename(temporaryPath, filePath);
+        }
+        else {
+            await fs.promises.link(temporaryPath, filePath);
+            await fs.promises.unlink(temporaryPath);
+        }
     }
-    catch {
-        return false;
+    finally {
+        await handle?.close().catch(() => undefined);
+        await fs.promises.rm(temporaryDirectory, { recursive: true, force: true });
     }
 }
-async function prepareAdd(change) {
-    if (await pathExists(change.path))
+async function withPathLocks(keys, operation) {
+    const locks = [];
+    for (const key of [...new Set(keys)].sort()) {
+        const previous = pathLocks.get(key) ?? Promise.resolve();
+        let release;
+        const gate = new Promise((resolve) => {
+            release = resolve;
+        });
+        const queued = previous.then(() => gate);
+        pathLocks.set(key, queued);
+        locks.push({ key, previous, queued, release });
+    }
+    await Promise.all(locks.map((lock) => lock.previous));
+    try {
+        return await operation();
+    }
+    finally {
+        for (const lock of locks)
+            lock.release();
+        for (const lock of locks) {
+            if (pathLocks.get(lock.key) === lock.queued)
+                pathLocks.delete(lock.key);
+        }
+    }
+}
+// ---------------------------------------------------------------------------
+// Preparation
+// ---------------------------------------------------------------------------
+async function prepareAdd(resolved) {
+    const { change, path: targetPath } = resolved;
+    if (await lstatIfExists(targetPath))
         throw new Error(`add target already exists: ${change.path}`);
     const content = change.content ?? "";
     const final = content.endsWith("\n") ? content : `${content}\n`;
+    let createdDirectories = [];
     return {
         change,
         applied: { path: change.path, action: "add", bytes: Buffer.byteLength(final, "utf8"), newContent: final },
         async commit() {
-            await fs.promises.mkdir(path.dirname(change.path), { recursive: true });
-            await atomicWriteFile(change.path, final);
+            createdDirectories = await createParentDirectories(path.dirname(targetPath));
+            try {
+                if (await lstatIfExists(targetPath))
+                    throw new Error(`add target appeared during patch: ${change.path}`);
+                await atomicWriteFile(targetPath, final, undefined, false);
+            }
+            catch (error) {
+                await removeCreatedDirectories(createdDirectories).catch(() => undefined);
+                throw error;
+            }
         },
         async rollback() {
-            await fs.promises.unlink(change.path);
+            await fs.promises.unlink(targetPath);
+            await removeCreatedDirectories(createdDirectories);
         },
     };
 }
-async function prepareUpdate(change) {
-    if (!change.oldText)
+function getUpdateEdits(change) {
+    if (change.edits !== undefined) {
+        if (change.oldText !== undefined || change.newText !== undefined) {
+            throw new Error("update cannot combine edits with oldText/newText");
+        }
+        if (!Array.isArray(change.edits) || change.edits.length === 0)
+            throw new Error("update requires edits");
+        return change.edits;
+    }
+    if (typeof change.oldText !== "string" || change.oldText.length === 0)
         throw new Error("update requires oldText");
-    if (change.oldText === change.newText)
-        throw new Error("oldText and newText are identical — no change");
-    const original = await readRegularFile(change.path, "update target");
-    const result = replaceForPatch(original.content, change.oldText, change.newText ?? "");
-    if (!result.changed)
-        throw new Error(`oldText not found in ${change.path}`);
-    const newContent = result.content;
+    return [{ oldText: change.oldText, newText: change.newText ?? "" }];
+}
+function applyUpdateEdits(content, edits, filePath) {
+    const replacements = edits.map((edit, index) => {
+        if (!edit || typeof edit.oldText !== "string" || typeof edit.newText !== "string") {
+            throw new Error(`edit ${index + 1} in ${filePath} is invalid`);
+        }
+        if (edit.oldText.length === 0)
+            throw new Error(`edit ${index + 1} in ${filePath} requires oldText`);
+        if (edit.oldText === edit.newText)
+            throw new Error("oldText and newText are identical — no change");
+        const match = findPatchReplacement(content, edit.oldText, edit.newText);
+        if (!match)
+            throw new Error(`oldText not found in ${filePath}`);
+        return match;
+    });
+    const ordered = [...replacements].sort((a, b) => a.start - b.start);
+    for (let index = 1; index < ordered.length; index++) {
+        if (ordered[index - 1].end > ordered[index].start)
+            throw new Error(`update edits overlap in ${filePath}`);
+    }
+    let result = content;
+    for (const replacement of [...ordered].reverse()) {
+        result = result.slice(0, replacement.start) + replacement.replacement + result.slice(replacement.end);
+    }
+    return result;
+}
+async function prepareUpdate(resolved) {
+    const { change, path: targetPath } = resolved;
+    const original = await readRegularFile(targetPath, "update target");
+    const { bom, text } = stripBom(original.rawContent);
+    const ending = detectLineEnding(text);
+    const normalizedContent = normalizeForLineEnding(text, ending);
+    const normalizedEdits = getUpdateEdits(change).map((edit) => ({
+        oldText: normalizeForLineEnding(edit.oldText, ending),
+        newText: normalizeForLineEnding(edit.newText, ending),
+    }));
+    const normalizedNewContent = applyUpdateEdits(normalizedContent, normalizedEdits, change.path);
+    const newContent = bom + restoreLineEndings(normalizedNewContent, ending);
     return {
         change,
         applied: {
             path: change.path,
             action: "update",
-            diff: generateDiff(change.path, original.content, newContent),
+            diff: generateDiff(change.path, original.rawContent, newContent),
             bytes: Buffer.byteLength(newContent, "utf8"),
-            oldContent: original.content,
+            oldContent: original.rawContent,
             newContent,
         },
         async commit() {
-            await atomicWriteFile(change.path, newContent, original.mode);
+            await assertUnchanged(targetPath, original, "update target");
+            await atomicWriteFile(targetPath, Buffer.from(newContent, "utf8"), original.mode);
         },
         async rollback() {
-            await atomicWriteFile(change.path, original.content, original.mode);
+            await atomicWriteFile(targetPath, original.bytes, original.mode);
         },
     };
 }
-async function prepareDelete(change) {
-    const original = await readRegularFile(change.path, "delete target");
+async function prepareDelete(resolved) {
+    const { change, path: targetPath } = resolved;
+    const original = await readRegularFile(targetPath, "delete target");
     return {
         change,
-        applied: { path: change.path, action: "delete", oldContent: original.content },
+        applied: { path: change.path, action: "delete", oldContent: original.rawContent },
         async commit() {
-            await fs.promises.unlink(change.path);
+            await assertUnchanged(targetPath, original, "delete target");
+            await fs.promises.unlink(targetPath);
         },
         async rollback() {
-            await atomicWriteFile(change.path, original.content, original.mode);
+            await atomicWriteFile(targetPath, original.bytes, original.mode, false);
         },
     };
 }
-async function prepareMove(change) {
-    const movePath = change.movePath;
-    if (!movePath)
+async function prepareMove(resolved) {
+    const { change, path: sourcePath, movePath: destinationPath } = resolved;
+    if (!destinationPath)
         throw new Error("move requires movePath");
-    await readRegularFile(change.path, "move source");
-    if (await pathExists(movePath))
-        throw new Error(`move destination already exists: ${movePath}`);
+    const original = await readRegularFile(sourcePath, "move source");
+    if (await lstatIfExists(destinationPath))
+        throw new Error(`move destination already exists: ${change.movePath}`);
+    let createdDirectories = [];
     return {
         change,
-        applied: { path: change.path, action: "move", movePath },
+        applied: { path: change.path, action: "move", movePath: change.movePath },
         async commit() {
-            await fs.promises.mkdir(path.dirname(movePath), { recursive: true });
-            await fs.promises.rename(change.path, movePath);
+            await assertUnchanged(sourcePath, original, "move source");
+            if (await lstatIfExists(destinationPath))
+                throw new Error(`move destination appeared during patch: ${change.movePath}`);
+            createdDirectories = await createParentDirectories(path.dirname(destinationPath));
+            try {
+                await fs.promises.rename(sourcePath, destinationPath);
+            }
+            catch (error) {
+                await removeCreatedDirectories(createdDirectories).catch(() => undefined);
+                throw error;
+            }
         },
         async rollback() {
-            await fs.promises.rename(movePath, change.path);
+            await fs.promises.rename(destinationPath, sourcePath);
+            await removeCreatedDirectories(createdDirectories);
         },
     };
 }
-async function prepareChange(change) {
-    switch (change.action) {
+async function prepareChange(resolved) {
+    switch (resolved.change.action) {
         case "add":
-            return prepareAdd(change);
+            return prepareAdd(resolved);
         case "update":
-            return prepareUpdate(change);
+            return prepareUpdate(resolved);
         case "delete":
-            return prepareDelete(change);
+            return prepareDelete(resolved);
         case "move":
-            return prepareMove(change);
+            return prepareMove(resolved);
         default:
-            throw new Error(`unknown action: ${change.action}`);
+            throw new Error(`unknown action: ${resolved.change.action}`);
     }
 }
 // ---------------------------------------------------------------------------
-// Diff generation (simple, for UI feedback)
+// Diff generation (for result/UI feedback)
 // ---------------------------------------------------------------------------
-function generateDiff(_filePath, oldContent, newContent) {
+function generateDiff(filePath, oldContent, newContent) {
     if (oldContent === newContent)
         return undefined;
-    const oldLines = oldContent.split("\n");
-    const newLines = newContent.split("\n");
-    const maxLen = Math.max(oldLines.length, newLines.length);
-    let diff = "";
-    let hasChanges = false;
-    for (let i = 0; i < maxLen; i++) {
-        const oldLine = oldLines[i] ?? "";
-        const newLine = newLines[i] ?? "";
-        if (oldLine !== newLine) {
-            if (oldLine)
-                diff += `- ${oldLine}\n`;
-            if (newLine)
-                diff += `+ ${newLine}\n`;
-            hasChanges = true;
-        }
-        else if (oldLine) {
-            diff += `  ${oldLine}\n`;
-        }
-    }
-    return hasChanges ? diff : undefined;
+    const patch = structuredPatch(filePath, filePath, oldContent, newContent, "", "", { context: 3 });
+    const lines = [];
+    for (const hunk of patch.hunks) {
+        const oldRange = `${hunk.oldStart},${hunk.oldLines}`;
+        const newRange = `${hunk.newStart},${hunk.newLines}`;
+        lines.push(`@@ -${oldRange} +${newRange} @@`);
+        lines.push(...hunk.lines);
+    }
+    return lines.length > 0 ? `${lines.join("\n")}\n` : undefined;
 }
 // ---------------------------------------------------------------------------
 // Main executor
 // ---------------------------------------------------------------------------
-export async function executeApplyPatch(changes) {
-    const prepared = [];
+export async function executeApplyPatch(changes, options = {}) {
+    if (!Array.isArray(changes) || changes.length === 0) {
+        return {
+            ok: false,
+            applied: [],
+            errors: [{ path: "", action: "patch", error: "patch must contain at least one change" }],
+        };
+    }
+    let policy;
+    try {
+        policy = await createPathPolicy(options);
+    }
+    catch (error) {
+        return {
+            ok: false,
+            applied: [],
+            errors: [{ path: "", action: "patch", error: formatFilesystemError(error) }],
+        };
+    }
+    const resolved = [];
     const errors = [];
     const claimedPaths = new Set();
     for (const change of changes) {
-        const paths = [change.path, ...(change.action === "move" && change.movePath ? [change.movePath] : [])].map((filePath) => path.resolve(filePath));
+        let sourcePath;
+        let destinationPath;
+        try {
+            sourcePath = await policy.resolve(change?.path, `${change?.action ?? "change"} target`);
+            if (change?.action === "move") {
+                destinationPath = await policy.resolve(change.movePath, "move destination");
+            }
+        }
+        catch (error) {
+            errors.push({
+                path: typeof change?.path === "string" ? change.path : "",
+                action: typeof change?.action === "string" ? change.action : "change",
+                error: formatFilesystemError(error),
+            });
+            continue;
+        }
+        const paths = [sourcePath, ...(destinationPath ? [destinationPath] : [])];
         if (paths.some((filePath) => claimedPaths.has(filePath))) {
             errors.push({
                 path: change.path,
@@ -176,47 +540,59 @@ export async function executeApplyPatch(changes) {
         }
         for (const filePath of paths)
             claimedPaths.add(filePath);
-        try {
-            prepared.push(await prepareChange(change));
-        }
-        catch (err) {
-            errors.push({
-                path: change.path,
-                action: change.action,
-                error: err instanceof Error ? err.message : String(err),
-            });
-        }
+        resolved.push({ change, path: sourcePath, movePath: destinationPath });
     }
     if (errors.length > 0)
         return { ok: false, applied: [], errors };
-    const committed = [];
-    try {
-        for (const change of prepared) {
-            await change.commit();
-            committed.push(change);
-        }
-    }
-    catch (err) {
-        for (const change of committed.reverse()) {
+    const lockPaths = resolved.flatMap(({ path: sourcePath, movePath: destinationPath }) => {
+        const paths = [sourcePath, ...(destinationPath ? [destinationPath] : [])];
+        return [...paths, ...paths.map((filePath) => path.dirname(filePath))];
+    });
+    return withPathLocks(lockPaths, async () => {
+        const prepared = [];
+        for (const change of resolved) {
             try {
-                await change.rollback();
+                prepared.push(await prepareChange(change));
             }
-            catch (rollbackError) {
+            catch (error) {
                 errors.push({
                     path: change.change.path,
                     action: change.change.action,
-                    error: `rollback failed: ${rollbackError instanceof Error ? rollbackError.message : String(rollbackError)}`,
+                    error: formatFilesystemError(error),
                 });
             }
         }
-        errors.unshift({
-            path: prepared[committed.length]?.change.path ?? "",
-            action: prepared[committed.length]?.change.action ?? "commit",
-            error: err instanceof Error ? err.message : String(err),
-        });
-        return { ok: false, applied: [], errors };
-    }
-    return { ok: true, applied: prepared.map((change) => change.applied), errors: [] };
+        if (errors.length > 0)
+            return { ok: false, applied: [], errors };
+        const committed = [];
+        try {
+            for (const change of prepared) {
+                await change.commit();
+                committed.push(change);
+            }
+        }
+        catch (error) {
+            for (const change of committed.reverse()) {
+                try {
+                    await change.rollback();
+                }
+                catch (rollbackError) {
+                    errors.push({
+                        path: change.change.path,
+                        action: change.change.action,
+                        error: `rollback failed: ${formatFilesystemError(rollbackError)}`,
+                    });
+                }
+            }
+            errors.unshift({
+                path: prepared[committed.length]?.change.path ?? "",
+                action: prepared[committed.length]?.change.action ?? "commit",
+                error: formatFilesystemError(error),
+            });
+            return { ok: false, applied: [], errors };
+        }
+        return { ok: true, applied: prepared.map((change) => change.applied), errors: [] };
+    });
 }
 // ---------------------------------------------------------------------------
 // Format result for tool output