@heyhuynhgiabuu/pi-diff 0.7.5 → 0.8.0

package/dist/index.js

@@ -20,20 +20,22 @@
  *   • Large-diff fallback (skip highlighting, still show diff)
  *   • Async rendering with invalidate() for non-blocking preview
  */
-import { existsSync, readFileSync, writeFileSync } from "node:fs";
+import { constants, existsSync, readFileSync } from "node:fs";
+import { access as accessFile, readFile, writeFile } from "node:fs/promises";
 import { extname, relative } from "node:path";
 import { codeToANSI } from "@shikijs/cli";
 import * as Diff from "diff";
 import { executeApplyPatch, formatApplyPatchResult } from "./core/apply-patch.js";
-import { configIndicatorStyle } from "./core/config.js";
+import { configIndicatorStyle, loadPiDiffConfig } from "./core/config.js";
 import { computeHunkBlocks, getSepStyle, parseDiff, parsePatchFiles, resolveSepStyle, sepLabelSplit, sepLabelUnified, } from "./core/diff.js";
-import { replace } from "./core/replace.js";
-import { registerEditGuard } from "./edit-guard.js";
 import { applyDiffPalette as applySharedDiffPalette, lang as detectDiffLanguage, renderSplit as renderSharedSplit, resolveDiffColors as resolveSharedDiffColors, themeCacheKey as sharedThemeCacheKey, } from "./review/hunk-preview.js";
 const ARROW_PREFIXED_TOOL_HEADERS = new Set(["write", "create", "edit", "apply_patch"]);
 function formatToolHeaderName(name) {
     return ARROW_PREFIXED_TOOL_HEADERS.has(name) ? `← ${name}` : name;
 }
+function isToolResultError(result, context) {
+    return result.isError === true || context.isError === true;
+}
 function formatToolHeaderPath(theme, filePath) {
     return theme.fg("toolTitle", filePath);
 }
@@ -1164,6 +1166,7 @@ export const __testing = {
     computeHunkBlocks,
     formatToolHeaderName,
     formatToolHeaderPath,
+    isToolResultError,
     normalizeShikiContrast,
     getSepStyle,
     parseDiff,
@@ -1173,10 +1176,6 @@ export const __testing = {
     renderUnified,
 };
 export default async function diffRendererExtension(pi) {
-    // pi-pretty sets toolOutputExpanded:false on session_start; write/edit default expanded.
-    pi.on("session_start", async (_event, ctx) => {
-        ctx.ui.setToolsExpanded(true);
-    });
     // Apply diff theme palette from settings/presets before rendering
     applySharedDiffPalette();
     // Resolve hunk separator style from env var
@@ -1210,6 +1209,11 @@ export default async function diffRendererExtension(pi) {
         writeHeaderStatsByCallId.set(toolCallId, { added, removed });
     }
     const cwd = process.cwd();
+    const disabledTools = new Set(loadPiDiffConfig().disabledTools ?? []);
+    const registerToolIfEnabled = (toolName, tool) => {
+        if (!disabledTools.has(toolName))
+            pi.registerTool(tool);
+    };
     const home = process.env.HOME ?? "";
     const sp = (p) => shortPath(cwd, home, p);
     const TOOL_RESULT_INDENT = " ";
@@ -1492,7 +1496,7 @@ export default async function diffRendererExtension(pi) {
     // write
     // =======================================================================
     const origWrite = createWriteTool(cwd);
-    pi.registerTool({
+    registerToolIfEnabled("write", {
         ...origWrite,
         name: "write",
         async execute(tid, params, sig, upd, ctx) {
@@ -1578,7 +1582,7 @@ export default async function diffRendererExtension(pi) {
         },
         renderResult(result, _opt, theme, ctx) {
             const text = getWidthAwareText(ctx.lastComponent);
-            if (ctx.isError) {
+            if (isToolResultError(result, ctx)) {
                 const e = result.content
                     ?.filter((c) => c.type === "text")
                     .map((c) => c.text || "")
@@ -1654,18 +1658,44 @@ export default async function diffRendererExtension(pi) {
         const newText = typeof input?.newText === "string" ? input.newText : typeof input?.new_text === "string" ? input.new_text : "";
         return oldText && oldText !== newText ? [{ oldText, newText }] : [];
     }
-    function summarizeEditOperations(operations) {
-        const diffs = operations.map((edit) => parseDiff(edit.oldText, edit.newText));
-        const totalAdded = diffs.reduce((sum, diff) => sum + diff.added, 0);
-        const totalRemoved = diffs.reduce((sum, diff) => sum + diff.removed, 0);
-        return {
-            diffs,
-            totalAdded,
-            totalRemoved,
-            summary: summarize(totalAdded, totalRemoved),
-        };
+    function normalizeEditMatchText(text) {
+        return text
+            .replace(/\r\n/g, "\n")
+            .replace(/\r/g, "\n")
+            .normalize("NFKC")
+            .split("\n")
+            .map((line) => line.trimEnd())
+            .join("\n")
+            .replace(/[\u2018\u2019\u201A\u201B]/g, "'")
+            .replace(/[\u201C\u201D\u201E\u201F]/g, '"')
+            .replace(/[\u2010\u2011\u2012\u2013\u2014\u2015\u2212]/g, "-")
+            .replace(/[\u00A0\u2002-\u200A\u202F\u205F\u3000]/g, " ");
     }
-    pi.registerTool({
+    function rejectOverlappingEditMatches(content, filePath, operations) {
+        if (!filePath || operations.length === 0)
+            return;
+        if (content.startsWith("\uFEFF"))
+            content = content.slice(1);
+        const normalizedContent = normalizeEditMatchText(content);
+        for (const [index, operation] of operations.entries()) {
+            const oldText = normalizeEditMatchText(operation.oldText);
+            if (!oldText)
+                continue;
+            let occurrences = 0;
+            let offset = 0;
+            while (true) {
+                const match = normalizedContent.indexOf(oldText, offset);
+                if (match === -1)
+                    break;
+                occurrences++;
+                if (occurrences > 1) {
+                    throw new Error(`Found ambiguous overlapping occurrences for edits[${index}] in ${filePath}. Provide more context to make oldText unique.`);
+                }
+                offset = match + 1;
+            }
+        }
+    }
+    registerToolIfEnabled("edit", {
         ...origEdit,
         name: "edit",
         parameters: {
@@ -1687,175 +1717,37 @@ export default async function diffRendererExtension(pi) {
         async execute(tid, params, sig, upd, ctx) {
             const fp = params.path ?? params.file_path ?? "";
             const operations = getEditOperations(params);
-            // Try cascading replace() first — smarter matching than SDK's exact-only edit
-            if (fp && operations.length > 0 && existsSync(fp)) {
-                try {
-                    let content = readFileSync(fp, "utf-8");
-                    let firstStrategy = "";
-                    let replaceOk = true;
-                    for (const op of operations) {
-                        const r = replace(content, op.oldText, op.newText);
-                        if (r.changed) {
-                            content = r.content;
-                            if (!firstStrategy)
-                                firstStrategy = r.strategy;
-                        }
-                        else {
-                            replaceOk = false;
-                            break;
-                        }
-                    }
-                    if (replaceOk) {
-                        writeFileSync(fp, content, "utf-8");
-                        const { diffs, summary } = summarizeEditOperations(operations);
-                        const lg = detectDiffLanguage(fp);
-                        if (operations.length === 1) {
-                            let editLine = 0;
-                            try {
-                                const idx = content.indexOf(operations[0].newText);
-                                if (idx >= 0)
-                                    editLine = content.slice(0, idx).split("\n").length;
-                            }
-                            catch {
-                                editLine = 0;
-                            }
-                            const useFull = !!params._expandGaps;
-                            const diffData = useFull ? parseDiff(operations[0].oldText, operations[0].newText, undefined) : diffs[0];
-                            return {
-                                content: [{ type: "text", text: `Edited ${sp(fp)}` }],
-                                details: {
-                                    _type: "editInfo",
-                                    summary: editLine > 0 ? `${summary} at line ${editLine}` : summary,
-                                    filePath: fp,
-                                    editLine,
-                                    diff: diffData,
-                                    language: lg,
-                                    oldContent: operations[0].oldText,
-                                    newContent: operations[0].newText,
-                                    _replaceStrategy: firstStrategy,
-                                },
-                            };
-                        }
-                        // Compute the line of the first edit for the title summary
-                        const firstEditLine = (() => {
-                            if (!operations[0]?.newText)
-                                return 0;
-                            const idx = content.indexOf(operations[0].newText);
-                            if (idx < 0)
-                                return 0;
-                            return content.slice(0, idx).split("\n").length;
-                        })();
-                        // Merge all diffs into one combined view for rendering
-                        const merged = {
-                            lines: diffs.flatMap((diff, i) => [
-                                ...(i > 0
-                                    ? [
-                                        {
-                                            type: "sep",
-                                            oldNum: null,
-                                            newNum: null,
-                                            content: `───── Edit ${i + 1} ─────`,
-                                        },
-                                    ]
-                                    : []),
-                                ...diff.lines,
-                            ]),
-                            added: diffs.reduce((sum, diff) => sum + diff.added, 0),
-                            removed: diffs.reduce((sum, diff) => sum + diff.removed, 0),
-                            chars: diffs.reduce((sum, diff) => sum + diff.chars, 0),
-                        };
-                        return {
-                            content: [{ type: "text", text: `Edited ${sp(fp)}` }],
-                            details: {
-                                _type: "multiEditInfo",
-                                summary: firstEditLine > 0 ? `${summary} at line ${firstEditLine}` : summary,
-                                filePath: fp,
-                                editCount: operations.length,
-                                diffLineCount: merged.lines.length,
-                                diff: merged,
-                                language: lg,
-                            },
-                        };
-                    }
-                }
-                catch (replaceError) {
-                    // replace() failed; fall through to SDK edit tool
-                    console.warn(`[pi-diff] replace() failed, falling back to SDK: ${replaceError instanceof Error ? replaceError.message : String(replaceError)}`);
-                }
-            }
-            const result = await origEdit.execute(tid, params, sig, upd, ctx);
-            if (operations.length === 0)
-                return result;
-            const { diffs, summary } = summarizeEditOperations(operations);
-            const lg = detectDiffLanguage(fp);
-            if (operations.length === 1) {
-                let editLine = 0;
-                try {
-                    if (fp && existsSync(fp)) {
-                        const f = readFileSync(fp, "utf-8");
-                        const idx = f.indexOf(operations[0].newText);
-                        if (idx >= 0)
-                            editLine = f.slice(0, idx).split("\n").length;
-                    }
-                }
-                catch {
-                    editLine = 0;
-                }
-                const useFull = !!params._expandGaps;
-                const diffData = useFull ? parseDiff(operations[0].oldText, operations[0].newText, undefined) : diffs[0];
-                result.details = {
-                    _type: "editInfo",
-                    summary: editLine > 0 ? `${summary} at line ${editLine}` : summary,
-                    filePath: fp,
-                    editLine,
-                    diff: diffData,
-                    language: lg,
-                    oldContent: operations[0].oldText,
-                    newContent: operations[0].newText,
-                };
+            const guardedEdit = createEditTool(cwd, {
+                operations: {
+                    access: (filePath) => accessFile(filePath, constants.R_OK | constants.W_OK),
+                    readFile: async (filePath) => {
+                        const content = await readFile(filePath);
+                        rejectOverlappingEditMatches(content.toString("utf8"), fp, operations);
+                        return content;
+                    },
+                    writeFile: (filePath, content) => writeFile(filePath, content, "utf8"),
+                },
+            });
+            const result = await guardedEdit.execute(tid, params, sig, upd, ctx);
+            const patch = result?.details?.patch;
+            const diff = typeof patch === "string" ? parsePatchFiles(patch)[0] : undefined;
+            if (!diff || (diff.added === 0 && diff.removed === 0))
                 return result;
-            }
-            // Merge all diffs into one combined view for rendering
-            const merged = {
-                lines: diffs.flatMap((diff, i) => [
-                    // Add separator between multiple edits
-                    ...(i > 0
-                        ? [
-                            {
-                                type: "sep",
-                                oldNum: null,
-                                newNum: null,
-                                content: `───── Edit ${i + 1} ─────`,
-                            },
-                        ]
-                        : []),
-                    ...diff.lines,
-                ]),
-                added: diffs.reduce((sum, diff) => sum + diff.added, 0),
-                removed: diffs.reduce((sum, diff) => sum + diff.removed, 0),
-                chars: diffs.reduce((sum, diff) => sum + diff.chars, 0),
-            };
-            let firstEditLine = 0;
-            try {
-                if (fp) {
-                    const f = readFileSync(fp, "utf8");
-                    const idx = f.indexOf(operations[0].newText);
-                    if (idx >= 0)
-                        firstEditLine = f.slice(0, idx).split("\n").length;
-                }
-            }
-            catch {
-                firstEditLine = 0;
-            }
-            result.details = {
-                _type: "multiEditInfo",
-                summary: firstEditLine > 0 ? `${summary} at line ${firstEditLine}` : summary,
+            const editCount = operations.length || (Array.isArray(params?.edits) ? params.edits.length : 1);
+            stashEditHeaderStats(tid, editCount, diff.lines.length, diff.added, diff.removed);
+            const details = {
+                ...result.details,
+                _type: editCount > 1 ? "multiEditInfo" : "editInfo",
                 filePath: fp,
-                editCount: operations.length,
-                diffLineCount: merged.lines.length,
-                diff: merged,
-                language: lg,
+                diff,
+                diffLineCount: diff.lines.length,
+                editCount,
+                linesAdded: diff.added,
+                linesRemoved: diff.removed,
+                language: detectDiffLanguage(fp),
+                summary: summarize(diff.added, diff.removed),
             };
+            result.details = details;
             return result;
         },
         renderCall(args, theme, ctx) {
@@ -1865,25 +1757,12 @@ export default async function diffRendererExtension(pi) {
             resolvePreviewDiffColors(theme);
             const stats = editCallStatsSuffix(ctx.toolCallId, theme);
             if (ctx.argsComplete && operations.length > 0) {
-                let previewLine = 0;
-                try {
-                    if (fp && existsSync(fp)) {
-                        const cur = readFileSync(fp, "utf-8");
-                        const idx = cur.indexOf(operations[0].oldText);
-                        if (idx >= 0)
-                            previewLine = cur.slice(0, idx).split("\n").length;
-                    }
-                }
-                catch {
-                    previewLine = 0;
-                }
-                const loc = previewLine > 0 ? `${TOOL_RESULT_INDENT}${theme.fg("muted", `at line ${previewLine}`)}` : "";
                 setToolHeaderBg(text);
                 text.setText(formatToolFrameHeaderText({
                     label: "edit",
                     filePath: fp,
                     theme,
-                    suffix: loc,
+                    suffix: stats,
                     topPad: EDIT_DIFF_RESULT_FRAME.topPad,
                     bottomPad: EDIT_DIFF_RESULT_FRAME.bottomPad,
                     headerLeftPad: EDIT_DIFF_RESULT_FRAME.headerLeftPad,
@@ -1946,7 +1825,7 @@ export default async function diffRendererExtension(pi) {
             return text;
         },
     });
-    pi.registerTool({
+    registerToolIfEnabled("apply_patch", {
         name: "apply_patch",
         label: "apply_patch",
         description: "Multi-file patch engine. One call can add, update, delete, or move multiple files. Uses structured JSON changes array.",
@@ -2032,6 +1911,5 @@ export default async function diffRendererExtension(pi) {
             return text;
         },
     });
-    registerEditGuard(pi);
 }
 //# sourceMappingURL=index.js.map