@hexar/biometric-identity-sdk-react-native 1.23.0 → 1.24.0

package/dist/components/VideoRecorder.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"VideoRecorder.d.ts","sourceRoot":"","sources":["../../src/components/VideoRecorder.tsx"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,KAAmD,MAAM,OAAO,CAAC;AAexE,OAAO,EAAE,WAAW,EAAE,mBAAmB,EAAE,iBAAiB,EAAmC,MAAM,oCAAoC,CAAC;AAE1I,MAAM,WAAW,eAAe;IAC9B,MAAM,EAAE,MAAM,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,WAAW,EAAE,MAAM,CAAC;IACpB,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;CACf;AAED,MAAM,WAAW,kBAAkB;IACjC,KAAK,CAAC,EAAE,WAAW,CAAC;IACpB,QAAQ,CAAC,EAAE,iBAAiB,CAAC;IAC7B,sEAAsE;IACtE,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,sCAAsC;IACtC,YAAY,CAAC,EAAE,mBAAmB,EAAE,CAAC;IACrC,0CAA0C;IAC1C,UAAU,CAAC,EAAE,eAAe,EAAE,CAAC;IAC/B,wCAAwC;IACxC,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,kDAAkD;IAClD,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB,wCAAwC;IACxC,UAAU,EAAE,CAAC,SAAS,EAAE,oBAAoB,KAAK,IAAI,CAAC;IACtD,iCAAiC;IACjC,QAAQ,EAAE,MAAM,IAAI,CAAC;IACrB,gDAAgD;IAChD,iBAAiB,CAAC,EAAE,MAAM,OAAO,CAAC,eAAe,EAAE,CAAC,CAAC;CACtD;AAED,MAAM,WAAW,oBAAoB;IACnC,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,QAAQ,EAAE,MAAM,CAAC;IACjB,oBAAoB,EAAE,OAAO,CAAC;IAC9B,YAAY,EAAE,MAAM,CAAC;IACrB,mBAAmB,EAAE,MAAM,EAAE,CAAC;IAC9B,SAAS,CAAC,EAAE,MAAM,CAAC;CACpB;AA2CD,eAAO,MAAM,aAAa,EAAE,KAAK,CAAC,EAAE,CAAC,kBAAkB,CAqiCtD,CAAC;AA4PF,eAAe,aAAa,CAAC"}
+{"version":3,"file":"VideoRecorder.d.ts","sourceRoot":"","sources":["../../src/components/VideoRecorder.tsx"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,KAAmD,MAAM,OAAO,CAAC;AAexE,OAAO,EAAE,WAAW,EAAE,mBAAmB,EAAE,iBAAiB,EAAmC,MAAM,oCAAoC,CAAC;AAE1I,MAAM,WAAW,eAAe;IAC9B,MAAM,EAAE,MAAM,CAAC;IACf,WAAW,EAAE,MAAM,CAAC;IACpB,WAAW,EAAE,MAAM,CAAC;IACpB,KAAK,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;CACf;AAED,MAAM,WAAW,kBAAkB;IACjC,KAAK,CAAC,EAAE,WAAW,CAAC;IACpB,QAAQ,CAAC,EAAE,iBAAiB,CAAC;IAC7B,sEAAsE;IACtE,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,sCAAsC;IACtC,YAAY,CAAC,EAAE,mBAAmB,EAAE,CAAC;IACrC,0CAA0C;IAC1C,UAAU,CAAC,EAAE,eAAe,EAAE,CAAC;IAC/B,wCAAwC;IACxC,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,kDAAkD;IAClD,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB,wCAAwC;IACxC,UAAU,EAAE,CAAC,SAAS,EAAE,oBAAoB,KAAK,IAAI,CAAC;IACtD,iCAAiC;IACjC,QAAQ,EAAE,MAAM,IAAI,CAAC;IACrB,gDAAgD;IAChD,iBAAiB,CAAC,EAAE,MAAM,OAAO,CAAC,eAAe,EAAE,CAAC,CAAC;CACtD;AAED,MAAM,WAAW,oBAAoB;IACnC,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,QAAQ,EAAE,MAAM,CAAC;IACjB,oBAAoB,EAAE,OAAO,CAAC;IAC9B,YAAY,EAAE,MAAM,CAAC;IACrB,mBAAmB,EAAE,MAAM,EAAE,CAAC;IAC9B,SAAS,CAAC,EAAE,MAAM,CAAC;CACpB;AA2CD,eAAO,MAAM,aAAa,EAAE,KAAK,CAAC,EAAE,CAAC,kBAAkB,CA2lCtD,CAAC;AA4PF,eAAe,aAAa,CAAC"}

package/dist/components/VideoRecorder.js

@@ -129,9 +129,19 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
     const videoRecordingRef = (0, react_1.useRef)(null);
     const isRecordingRef = (0, react_1.useRef)(false);
     const recordingTimeoutRef = (0, react_1.useRef)(null);
+    // Tracks whether a takePhoto() call is currently dispatched to the native
+    // bridge.  We must wait for it to resolve before unmounting the <Camera>
+    // view, otherwise CameraViewModule.findCameraView crashes on Android.
+    const captureInFlightRef = (0, react_1.useRef)(false);
+    const isMountedRef = (0, react_1.useRef)(true);
     // Trigger autofocus on center — some Android devices (e.g. Ulefone Armor)
     // don't auto-focus without an explicit programmatic trigger.
     const triggerFocus = (0, react_1.useCallback)(() => {
+        // Guard: focus() dispatches to native findCameraView which crashes
+        // if the view is gone.  The JS try/catch does NOT help — the exception
+        // happens on the Android UI thread Looper, not in the JS promise chain.
+        if (!isMountedRef.current)
+            return;
         try {
             const { width: w, height: h } = react_native_1.Dimensions.get('window');
             cameraRef.current?.focus({ x: w / 2, y: h / 2 });
@@ -140,6 +150,30 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
             // focus() not supported or camera not ready — safe to ignore
         }
     }, []);
+    // ── Unmount cleanup ──────────────────────────────────────────────────
+    // Prevents scenario 2: unexpected unmount (back button, navigation,
+    // phone call) while timers are still scheduled.  Without this, pending
+    // setTimeout callbacks fire after unmount, dispatch takePhoto() to the
+    // native bridge, and crash with IllegalViewOperationException.
+    (0, react_1.useEffect)(() => {
+        isMountedRef.current = true;
+        return () => {
+            isMountedRef.current = false;
+            isRecordingRef.current = false;
+            if (frameCaptureInterval.current) {
+                clearTimeout(frameCaptureInterval.current);
+                frameCaptureInterval.current = null;
+            }
+            if (recordingTimeoutRef.current) {
+                clearTimeout(recordingTimeoutRef.current);
+                recordingTimeoutRef.current = null;
+            }
+            if (frameInterval.current) {
+                clearTimeout(frameInterval.current);
+                frameInterval.current = null;
+            }
+        };
+    }, []);
     const minDurationMs = 8000;
     const totalDuration = duration || Math.max(minDurationMs, challenges.reduce((sum, c) => sum + c.duration_ms, 0) + 2000);
     (0, react_1.useEffect)(() => {
@@ -323,6 +357,30 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
         setPhase('loading');
         react_native_1.Alert.alert('Recording Error', 'Failed to record video. Please try again.', [{ text: 'OK', onPress: onCancel }]);
     }, [onCancel]);
+    // Wait for any in-flight takePhoto() to finish, then deactivate the camera
+    // and deliver the result.  This prevents the IllegalViewOperationException
+    // crash: the native view stays alive while the native bridge processes the
+    // last queued takePhoto(), and only THEN do we trigger the parent unmount
+    // via onComplete.
+    const safeComplete = (0, react_1.useCallback)((result) => {
+        const drain = () => {
+            if (captureInFlightRef.current) {
+                // A takePhoto() is still on the native bridge — check again shortly
+                setTimeout(drain, 30);
+                return;
+            }
+            // No in-flight capture — safe to tear down
+            setIsCameraActive(false);
+            // Small delay to let VisionCamera process the isActive=false prop change
+            // and release the native camera session before the parent unmounts the view.
+            setTimeout(() => {
+                if (isMountedRef.current) {
+                    onComplete(result);
+                }
+            }, 100);
+        };
+        drain();
+    }, [onComplete]);
     // Safety timeout: if the camera session never fires onInitialized within
     // 10 seconds, treat it as a hardware failure and send the user back.
     (0, react_1.useEffect)(() => {
@@ -389,12 +447,7 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
             };
             biometric_identity_sdk_core_1.logger.info('Video recording completed:', result.frames.length, 'frames,', (actualDuration / 1000).toFixed(1) + 's', 'challenges:', currentCompletedChallenges.length);
             isRecordingRef.current = false;
-            // Deactivate the camera first so VisionCamera tears down its native
-            // session. Any in-flight takePhoto() calls will then fail gracefully
-            // rather than crashing with IllegalViewOperationException when the
-            // parent unmounts the <Camera> view underneath them.
-            setIsCameraActive(false);
-            setTimeout(() => onComplete(result), 250);
+            safeComplete(result);
         }
         catch (error) {
             biometric_identity_sdk_core_1.logger.error('Error processing video:', error);
@@ -402,7 +455,7 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
             setOverallProgress(0);
             handleRecordingError(error);
         }
-    }, [frames, completedChallenges, challenges, sessionId, onComplete, resetAndRetry, handleRecordingError, strings, minDurationMs, phase]);
+    }, [frames, completedChallenges, challenges, sessionId, safeComplete, resetAndRetry, handleRecordingError, strings, minDurationMs, phase]);
     const startFrameCapture = (0, react_1.useCallback)(() => {
         if (cameraRef.current && device) {
             biometric_identity_sdk_core_1.logger.info('Starting serial frame capture');
@@ -450,9 +503,13 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
             // finishes, preventing overlapping takePhoto() calls that cause the
             // camera to throw "busy" errors and kill the capture loop.
             const captureNextFrame = async () => {
-                if (!isRecordingRef.current || framesRef.current.length >= MAX_FRAMES) {
+                // Bail if recording stopped, component unmounted, or we have enough frames.
+                // Checking isMountedRef prevents dispatching takePhoto() to a native view
+                // that is about to be removed from NativeViewHierarchyManager.
+                if (!isRecordingRef.current || !isMountedRef.current || framesRef.current.length >= MAX_FRAMES) {
                     return;
                 }
+                captureInFlightRef.current = true;
                 try {
                     const photo = await cameraRef.current?.takePhoto({
                         flash: 'off',
@@ -495,12 +552,14 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
                     biometric_identity_sdk_core_1.logger.warn('Frame capture error', consecutiveErrors, '/', maxConsecutiveErrors, error?.message);
                     if (consecutiveErrors >= maxConsecutiveErrors) {
                         biometric_identity_sdk_core_1.logger.error('Too many consecutive capture errors, stopping');
+                        captureInFlightRef.current = false;
                         return;
                     }
                 }
+                captureInFlightRef.current = false;
                 // Schedule next capture only after this one completes (serial chain).
                 // Small delay lets the camera hardware reset between captures.
-                if (isRecordingRef.current && framesRef.current.length < MAX_FRAMES) {
+                if (isRecordingRef.current && isMountedRef.current && framesRef.current.length < MAX_FRAMES) {
                     frameCaptureInterval.current = setTimeout(captureNextFrame, 66);
                 }
             };
@@ -545,8 +604,7 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
                         sessionId,
                     };
                     setPhase('processing');
-                    setIsCameraActive(false);
-                    setTimeout(() => onComplete(result), 250);
+                    safeComplete(result);
                 }
                 else {
                     biometric_identity_sdk_core_1.logger.info('Stopping recording with frames (fallback):', currentFrames.length);
@@ -559,8 +617,7 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
                         sessionId,
                     };
                     setPhase('processing');
-                    setIsCameraActive(false);
-                    setTimeout(() => onComplete(result), 250);
+                    safeComplete(result);
                 }
             }
         }
@@ -591,12 +648,9 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
                 challengesCompleted: currentCompletedChallenges,
                 sessionId,
             };
-            setIsCameraActive(false);
-            setTimeout(() => {
-                onComplete(result);
-            }, 250);
+            safeComplete(result);
         }
-    }, [frames, completedChallenges, challenges, sessionId, onComplete, minDurationMs, resetAndRetry, strings]);
+    }, [frames, completedChallenges, challenges, sessionId, onComplete, safeComplete, minDurationMs, resetAndRetry, strings]);
     const runChallenge = (0, react_1.useCallback)((index) => {
         const currentCompletedChallenges = completedChallengesRef.current.length > 0 ? completedChallengesRef.current : completedChallenges;
         biometric_identity_sdk_core_1.logger.info('VideoRecorder: runChallenge called', {
@@ -638,8 +692,7 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
                         sessionId,
                     };
                     setPhase('processing');
-                    setIsCameraActive(false);
-                    setTimeout(() => onComplete(result), 250);
+                    safeComplete(result);
                 }
             }
             return;
@@ -691,7 +744,7 @@ const VideoRecorder = ({ theme, language, duration, instructions, challenges: pr
                 runChallenge(index + 1);
             });
         }, challenge.duration_ms);
-    }, [challenges, fadeAnim, progressAnim, animateArrow, totalDuration, minDurationMs, stopRecording]);
+    }, [challenges, fadeAnim, progressAnim, animateArrow, totalDuration, minDurationMs, stopRecording, safeComplete]);
     const startRecording = (0, react_1.useCallback)(async () => {
         setPhase('recording');
         recordingStartTime.current = Date.now();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hexar/biometric-identity-sdk-react-native",
-  "version": "1.23.0",
+  "version": "1.24.0",
   "description": "React Native wrapper for Biometric Identity SDK",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/components/VideoRecorder.tsx

@@ -160,9 +160,18 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
   const videoRecordingRef = useRef<any>(null);
   const isRecordingRef = useRef<boolean>(false);
   const recordingTimeoutRef = useRef<NodeJS.Timeout | null>(null);
+  // Tracks whether a takePhoto() call is currently dispatched to the native
+  // bridge.  We must wait for it to resolve before unmounting the <Camera>
+  // view, otherwise CameraViewModule.findCameraView crashes on Android.
+  const captureInFlightRef = useRef<boolean>(false);
+  const isMountedRef = useRef<boolean>(true);
   // Trigger autofocus on center — some Android devices (e.g. Ulefone Armor)
   // don't auto-focus without an explicit programmatic trigger.
   const triggerFocus = useCallback(() => {
+    // Guard: focus() dispatches to native findCameraView which crashes
+    // if the view is gone.  The JS try/catch does NOT help — the exception
+    // happens on the Android UI thread Looper, not in the JS promise chain.
+    if (!isMountedRef.current) return;
     try {
       const { width: w, height: h } = Dimensions.get('window');
       cameraRef.current?.focus({ x: w / 2, y: h / 2 });
@@ -171,6 +180,31 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
     }
   }, []);
 
+  // ── Unmount cleanup ──────────────────────────────────────────────────
+  // Prevents scenario 2: unexpected unmount (back button, navigation,
+  // phone call) while timers are still scheduled.  Without this, pending
+  // setTimeout callbacks fire after unmount, dispatch takePhoto() to the
+  // native bridge, and crash with IllegalViewOperationException.
+  useEffect(() => {
+    isMountedRef.current = true;
+    return () => {
+      isMountedRef.current = false;
+      isRecordingRef.current = false;
+      if (frameCaptureInterval.current) {
+        clearTimeout(frameCaptureInterval.current);
+        frameCaptureInterval.current = null;
+      }
+      if (recordingTimeoutRef.current) {
+        clearTimeout(recordingTimeoutRef.current);
+        recordingTimeoutRef.current = null;
+      }
+      if (frameInterval.current) {
+        clearTimeout(frameInterval.current);
+        frameInterval.current = null;
+      }
+    };
+  }, []);
+
   const minDurationMs = 8000;
   const totalDuration = duration || Math.max(
     minDurationMs,
@@ -378,6 +412,31 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
     );
   }, [onCancel]);
 
+  // Wait for any in-flight takePhoto() to finish, then deactivate the camera
+  // and deliver the result.  This prevents the IllegalViewOperationException
+  // crash: the native view stays alive while the native bridge processes the
+  // last queued takePhoto(), and only THEN do we trigger the parent unmount
+  // via onComplete.
+  const safeComplete = useCallback((result: VideoRecordingResult) => {
+    const drain = () => {
+      if (captureInFlightRef.current) {
+        // A takePhoto() is still on the native bridge — check again shortly
+        setTimeout(drain, 30);
+        return;
+      }
+      // No in-flight capture — safe to tear down
+      setIsCameraActive(false);
+      // Small delay to let VisionCamera process the isActive=false prop change
+      // and release the native camera session before the parent unmounts the view.
+      setTimeout(() => {
+        if (isMountedRef.current) {
+          onComplete(result);
+        }
+      }, 100);
+    };
+    drain();
+  }, [onComplete]);
+
   // Safety timeout: if the camera session never fires onInitialized within
   // 10 seconds, treat it as a hardware failure and send the user back.
   useEffect(() => {
@@ -459,19 +518,14 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
       logger.info('Video recording completed:', result.frames.length, 'frames,', (actualDuration / 1000).toFixed(1) + 's', 'challenges:', currentCompletedChallenges.length);
 
       isRecordingRef.current = false;
-      // Deactivate the camera first so VisionCamera tears down its native
-      // session. Any in-flight takePhoto() calls will then fail gracefully
-      // rather than crashing with IllegalViewOperationException when the
-      // parent unmounts the <Camera> view underneath them.
-      setIsCameraActive(false);
-      setTimeout(() => onComplete(result), 250);
+      safeComplete(result);
     } catch (error) {
       logger.error('Error processing video:', error);
       setPhase('recording');
       setOverallProgress(0);
       handleRecordingError(error);
     }
-  }, [frames, completedChallenges, challenges, sessionId, onComplete, resetAndRetry, handleRecordingError, strings, minDurationMs, phase]);
+  }, [frames, completedChallenges, challenges, sessionId, safeComplete, resetAndRetry, handleRecordingError, strings, minDurationMs, phase]);
 
   const startFrameCapture = useCallback(() => {
     if (cameraRef.current && device) {
@@ -531,10 +585,14 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
       // finishes, preventing overlapping takePhoto() calls that cause the
       // camera to throw "busy" errors and kill the capture loop.
       const captureNextFrame = async () => {
-        if (!isRecordingRef.current || framesRef.current.length >= MAX_FRAMES) {
+        // Bail if recording stopped, component unmounted, or we have enough frames.
+        // Checking isMountedRef prevents dispatching takePhoto() to a native view
+        // that is about to be removed from NativeViewHierarchyManager.
+        if (!isRecordingRef.current || !isMountedRef.current || framesRef.current.length >= MAX_FRAMES) {
           return;
         }
 
+        captureInFlightRef.current = true;
         try {
           const photo = await cameraRef.current?.takePhoto({
             flash: 'off',
@@ -574,13 +632,15 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
           logger.warn('Frame capture error', consecutiveErrors, '/', maxConsecutiveErrors, error?.message);
           if (consecutiveErrors >= maxConsecutiveErrors) {
             logger.error('Too many consecutive capture errors, stopping');
+            captureInFlightRef.current = false;
             return;
           }
         }
+        captureInFlightRef.current = false;
 
         // Schedule next capture only after this one completes (serial chain).
         // Small delay lets the camera hardware reset between captures.
-        if (isRecordingRef.current && framesRef.current.length < MAX_FRAMES) {
+        if (isRecordingRef.current && isMountedRef.current && framesRef.current.length < MAX_FRAMES) {
           frameCaptureInterval.current = setTimeout(captureNextFrame, 66);
         }
       };
@@ -631,8 +691,7 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
             sessionId,
           };
           setPhase('processing');
-          setIsCameraActive(false);
-          setTimeout(() => onComplete(result), 250);
+          safeComplete(result);
         } else {
           logger.info('Stopping recording with frames (fallback):', currentFrames.length);
           const result: VideoRecordingResult = {
@@ -644,8 +703,7 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
             sessionId,
           };
           setPhase('processing');
-          setIsCameraActive(false);
-          setTimeout(() => onComplete(result), 250);
+          safeComplete(result);
         }
       }
     } else {
@@ -683,12 +741,9 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
         sessionId,
       };
       
-      setIsCameraActive(false);
-      setTimeout(() => {
-        onComplete(result);
-      }, 250);
+      safeComplete(result);
     }
-  }, [frames, completedChallenges, challenges, sessionId, onComplete, minDurationMs, resetAndRetry, strings]);
+  }, [frames, completedChallenges, challenges, sessionId, onComplete, safeComplete, minDurationMs, resetAndRetry, strings]);
 
   const runChallenge = useCallback((index: number) => {
     const currentCompletedChallenges = completedChallengesRef.current.length > 0 ? completedChallengesRef.current : completedChallenges;
@@ -735,8 +790,7 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
             sessionId,
           };
           setPhase('processing');
-          setIsCameraActive(false);
-          setTimeout(() => onComplete(result), 250);
+          safeComplete(result);
         }
       }
       return;
@@ -797,7 +851,7 @@ export const VideoRecorder: React.FC<VideoRecorderProps> = ({
         runChallenge(index + 1);
       });
     }, challenge.duration_ms);
-  }, [challenges, fadeAnim, progressAnim, animateArrow, totalDuration, minDurationMs, stopRecording]);
+  }, [challenges, fadeAnim, progressAnim, animateArrow, totalDuration, minDurationMs, stopRecording, safeComplete]);
 
   const startRecording = useCallback(async () => {
     setPhase('recording');